* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver @ 2015-12-14 8:28 MyungJoo Ham 2015-12-14 8:44 ` Chanwoo Choi 2015-12-15 3:32 ` Chanwoo Choi 0 siblings, 2 replies; 7+ messages in thread From: MyungJoo Ham @ 2015-12-14 8:28 UTC (permalink / raw) To: 최찬우, 크쉬시토프, kgene Cc: 박경민, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 5235 bytes --] > > This patch adds the generic exynos bus frequency driver for AMBA AXI bus > of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC > have the common architecture for bus between DRAM and sub-blocks in SoC. > This driver can support the generic bus frequency driver for Exynos SoCs. > > In devicetree, Each bus block has a bus clock, regulator, operation-point > and devfreq-event devices which measure the utilization of each bus block. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon <linux.amoon@gmail.com> > Chanwoo, could you please show me testing this set of patches in your site? Please let me know when is ok to visit you. (I do not have exynos machines right now.) > diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile > index 5134f9ee983d..375ebbb4fcfb 100644 > --- a/drivers/devfreq/Makefile > +++ b/drivers/devfreq/Makefile > @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o > obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o > > # DEVFREQ Drivers > +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ > obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ > obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ CONFIG_ARCH_EXYNOS is true if CONFIG_ARM_EXYNOS4_BUS_DEVFREQ is true or CONFIG_ARM_EXYNOS5_BUS_DEVFREQ is true Thus, the two lines after you've added have become useless. (dead code) Please delete them. [] > --- /dev/null > +++ b/drivers/devfreq/exynos/exynos-bus.c [] > +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) > +{ > + struct exynos_bus *bus = dev_get_drvdata(dev); > + struct dev_pm_opp *new_opp; > + unsigned long old_freq, new_freq, old_volt, new_volt; > + int ret = 0; > + > + /* Get new opp-bus instance according to new bus clock */ > + rcu_read_lock(); > + new_opp = devfreq_recommended_opp(dev, freq, flags); > + if (IS_ERR_OR_NULL(new_opp)) { > + dev_err(dev, "failed to get recommed opp instance\n"); > + rcu_read_unlock(); > + return PTR_ERR(new_opp); > + } > + > + new_freq = dev_pm_opp_get_freq(new_opp); > + new_volt = dev_pm_opp_get_voltage(new_opp); > + old_freq = dev_pm_opp_get_freq(bus->curr_opp); > + old_volt = dev_pm_opp_get_voltage(bus->curr_opp); > + rcu_read_unlock(); > + > + if (old_freq == new_freq) > + return 0; > + > + /* Change voltage and frequency according to new OPP level */ > + mutex_lock(&bus->lock); > + > + if (old_freq < new_freq) { > + ret = regulator_set_voltage(bus->regulator, new_volt, new_volt); Setting the maximum volt same as the minimum volt is not recommended. Especially for any DVFS mechanisms, I recommend to set values as: min_volt = minimum voltage that does not harm the stability max_volt = maximum voltage that does not break the circuit Please refer to /include/linux/regulator/driver.h "@set_voltage" comments. For the rest of regulator_set_voltage usages, I'd say the same. [] > +static int exynos_bus_get_dev_status(struct device *dev, > + struct devfreq_dev_status *stat) > +{ > + struct exynos_bus *bus = dev_get_drvdata(dev); > + struct devfreq_event_data edata; > + int ret; > + > + rcu_read_lock(); > + stat->current_frequency = dev_pm_opp_get_freq(bus->curr_opp); > + rcu_read_unlock(); > + > + ret = exynos_bus_get_event(bus, &edata); > + if (ret < 0) { > + stat->total_time = stat->busy_time = 0; > + goto err; > + } > + > + stat->busy_time = (edata.load_count * 100) / bus->ratio; > + stat->total_time = edata.total_count; > + > + dev_dbg(dev, "Usage of devfreq-event : %ld/%ld\n", stat->busy_time, > + stat->total_time); These two values are unsigned long. [] > +static int exynos_bus_parse_of(struct device_node *np, > + struct exynos_bus *bus) > +{ > + struct device *dev = bus->dev; > + unsigned long rate; > + int i, ret, count, size; > + > + /* Get the clock to provide each bus with source clock */ > + bus->clk = devm_clk_get(dev, "bus"); > + if (IS_ERR(bus->clk)) { > + dev_err(dev, "failed to get bus clock\n"); > + return PTR_ERR(bus->clk); > + } > + > + ret = clk_prepare_enable(bus->clk); > + if (ret < 0) { > + dev_err(dev, "failed to get enable clock\n"); > + return ret; > + } [] > +err_regulator: > + regulator_disable(bus->regulator); > +err_opp: > + dev_pm_opp_of_remove_table(dev); > + > + return ret; No clk_disable_unprepare() somewhere in the error handling routines? [] > +#ifdef CONFIG_PM_SLEEP > +static int exynos_bus_resume(struct device *dev) > +{ [] > + ret = regulator_enable(bus->regulator); [] > +} > + > +static int exynos_bus_suspend(struct device *dev) > +{ [] > + regulator_disable(bus->regulator); [] > +} > +#endif Isn't there any possibility that you should not disable at suspend callbacks? If I remember correctly, we should not disable VDD-INT/VDD-MIF of Exynos4412 for suspend-to-RAM although it is "mostly" ok to do so, but not "always" ok. In such cases, I guess it should be "selectively" disabled for suspend. (some regulators support special "low power if suspended" modes for such cases) [] ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-14 8:28 [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver MyungJoo Ham @ 2015-12-14 8:44 ` Chanwoo Choi 2015-12-15 3:32 ` Chanwoo Choi 1 sibling, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2015-12-14 8:44 UTC (permalink / raw) To: myungjoo.ham, 크쉬시토프, kgene Cc: 박경민, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree On 2015년 12월 14일 17:28, MyungJoo Ham wrote: >> >> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >> have the common architecture for bus between DRAM and sub-blocks in SoC. >> This driver can support the generic bus frequency driver for Exynos SoCs. >> >> In devicetree, Each bus block has a bus clock, regulator, operation-point >> and devfreq-event devices which measure the utilization of each bus block. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon <linux.amoon@gmail.com> >> > > Chanwoo, could you please show me testing this set of patches in your site? > Please let me know when is ok to visit you. > (I do not have exynos machines right now.) Sure. I can show it tomorrow whenever you want. Before visiting to me, just let me know. I'll prepare the demonstartion. Regards, Chanwo oChoi > >> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >> index 5134f9ee983d..375ebbb4fcfb 100644 >> --- a/drivers/devfreq/Makefile >> +++ b/drivers/devfreq/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >> >> # DEVFREQ Drivers >> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ >> obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ >> obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ > > CONFIG_ARCH_EXYNOS is true if > CONFIG_ARM_EXYNOS4_BUS_DEVFREQ is true > or > CONFIG_ARM_EXYNOS5_BUS_DEVFREQ is true > Thus, the two lines after you've added have become useless. (dead code) > > Please delete them. > > [] >> --- /dev/null >> +++ b/drivers/devfreq/exynos/exynos-bus.c > [] >> +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) >> +{ >> + struct exynos_bus *bus = dev_get_drvdata(dev); >> + struct dev_pm_opp *new_opp; >> + unsigned long old_freq, new_freq, old_volt, new_volt; >> + int ret = 0; >> + >> + /* Get new opp-bus instance according to new bus clock */ >> + rcu_read_lock(); >> + new_opp = devfreq_recommended_opp(dev, freq, flags); >> + if (IS_ERR_OR_NULL(new_opp)) { >> + dev_err(dev, "failed to get recommed opp instance\n"); >> + rcu_read_unlock(); >> + return PTR_ERR(new_opp); >> + } >> + >> + new_freq = dev_pm_opp_get_freq(new_opp); >> + new_volt = dev_pm_opp_get_voltage(new_opp); >> + old_freq = dev_pm_opp_get_freq(bus->curr_opp); >> + old_volt = dev_pm_opp_get_voltage(bus->curr_opp); >> + rcu_read_unlock(); >> + >> + if (old_freq == new_freq) >> + return 0; >> + >> + /* Change voltage and frequency according to new OPP level */ >> + mutex_lock(&bus->lock); >> + >> + if (old_freq < new_freq) { >> + ret = regulator_set_voltage(bus->regulator, new_volt, new_volt); > > Setting the maximum volt same as the minimum volt is not recommended. > Especially for any DVFS mechanisms, I recommend to set values as: > min_volt = minimum voltage that does not harm the stability > max_volt = maximum voltage that does not break the circuit > > Please refer to /include/linux/regulator/driver.h > "@set_voltage" comments. > > For the rest of regulator_set_voltage usages, I'd say the same. > > [] >> +static int exynos_bus_get_dev_status(struct device *dev, >> + struct devfreq_dev_status *stat) >> +{ >> + struct exynos_bus *bus = dev_get_drvdata(dev); >> + struct devfreq_event_data edata; >> + int ret; >> + >> + rcu_read_lock(); >> + stat->current_frequency = dev_pm_opp_get_freq(bus->curr_opp); >> + rcu_read_unlock(); >> + >> + ret = exynos_bus_get_event(bus, &edata); >> + if (ret < 0) { >> + stat->total_time = stat->busy_time = 0; >> + goto err; >> + } >> + >> + stat->busy_time = (edata.load_count * 100) / bus->ratio; >> + stat->total_time = edata.total_count; >> + >> + dev_dbg(dev, "Usage of devfreq-event : %ld/%ld\n", stat->busy_time, >> + stat->total_time); > > These two values are unsigned long. > > [] >> +static int exynos_bus_parse_of(struct device_node *np, >> + struct exynos_bus *bus) >> +{ >> + struct device *dev = bus->dev; >> + unsigned long rate; >> + int i, ret, count, size; >> + >> + /* Get the clock to provide each bus with source clock */ >> + bus->clk = devm_clk_get(dev, "bus"); >> + if (IS_ERR(bus->clk)) { >> + dev_err(dev, "failed to get bus clock\n"); >> + return PTR_ERR(bus->clk); >> + } >> + >> + ret = clk_prepare_enable(bus->clk); >> + if (ret < 0) { >> + dev_err(dev, "failed to get enable clock\n"); >> + return ret; >> + } > > [] > >> +err_regulator: >> + regulator_disable(bus->regulator); >> +err_opp: >> + dev_pm_opp_of_remove_table(dev); >> + >> + return ret; > > No clk_disable_unprepare() somewhere in the error handling routines? > > [] > >> +#ifdef CONFIG_PM_SLEEP >> +static int exynos_bus_resume(struct device *dev) >> +{ > [] >> + ret = regulator_enable(bus->regulator); > [] >> +} >> + >> +static int exynos_bus_suspend(struct device *dev) >> +{ > [] >> + regulator_disable(bus->regulator); > [] >> +} >> +#endif > > Isn't there any possibility that you should not disable at suspend callbacks? > If I remember correctly, we should not disable VDD-INT/VDD-MIF of Exynos4412 > for suspend-to-RAM although it is "mostly" ok to do so, but not "always" ok. > > In such cases, I guess it should be "selectively" disabled for suspend. > (some regulators support special "low power if suspended" modes for such cases) > > [] > N�����r��y���b�X��ǧv�^�){.n�+����{�����x,�ȧ�\x17��ܨ}���Ơz�&j:+v���\a����zZ+��+zf���h���~����i���z�\x1e�w���?����&�)ߢ^[fl=== > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-14 8:28 [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver MyungJoo Ham 2015-12-14 8:44 ` Chanwoo Choi @ 2015-12-15 3:32 ` Chanwoo Choi 1 sibling, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2015-12-15 3:32 UTC (permalink / raw) To: myungjoo.ham, 크쉬시토프, kgene Cc: 박경민, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree On 2015년 12월 14일 17:28, MyungJoo Ham wrote: >> >> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >> have the common architecture for bus between DRAM and sub-blocks in SoC. >> This driver can support the generic bus frequency driver for Exynos SoCs. >> >> In devicetree, Each bus block has a bus clock, regulator, operation-point >> and devfreq-event devices which measure the utilization of each bus block. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon <linux.amoon@gmail.com> >> > > Chanwoo, could you please show me testing this set of patches in your site? > Please let me know when is ok to visit you. > (I do not have exynos machines right now.) > >> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >> index 5134f9ee983d..375ebbb4fcfb 100644 >> --- a/drivers/devfreq/Makefile >> +++ b/drivers/devfreq/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >> >> # DEVFREQ Drivers >> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ >> obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ >> obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ > > CONFIG_ARCH_EXYNOS is true if > CONFIG_ARM_EXYNOS4_BUS_DEVFREQ is true > or > CONFIG_ARM_EXYNOS5_BUS_DEVFREQ is true > Thus, the two lines after you've added have become useless. (dead code) > > Please delete them. In this series, patch11 deletes all of both exynos4_bus.c and exynos5_bus.c. > > [] >> --- /dev/null >> +++ b/drivers/devfreq/exynos/exynos-bus.c > [] >> +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) >> +{ >> + struct exynos_bus *bus = dev_get_drvdata(dev); >> + struct dev_pm_opp *new_opp; >> + unsigned long old_freq, new_freq, old_volt, new_volt; >> + int ret = 0; >> + >> + /* Get new opp-bus instance according to new bus clock */ >> + rcu_read_lock(); >> + new_opp = devfreq_recommended_opp(dev, freq, flags); >> + if (IS_ERR_OR_NULL(new_opp)) { >> + dev_err(dev, "failed to get recommed opp instance\n"); >> + rcu_read_unlock(); >> + return PTR_ERR(new_opp); >> + } >> + >> + new_freq = dev_pm_opp_get_freq(new_opp); >> + new_volt = dev_pm_opp_get_voltage(new_opp); >> + old_freq = dev_pm_opp_get_freq(bus->curr_opp); >> + old_volt = dev_pm_opp_get_voltage(bus->curr_opp); >> + rcu_read_unlock(); >> + >> + if (old_freq == new_freq) >> + return 0; >> + >> + /* Change voltage and frequency according to new OPP level */ >> + mutex_lock(&bus->lock); >> + >> + if (old_freq < new_freq) { >> + ret = regulator_set_voltage(bus->regulator, new_volt, new_volt); > > Setting the maximum volt same as the minimum volt is not recommended. > Especially for any DVFS mechanisms, I recommend to set values as: > min_volt = minimum voltage that does not harm the stability > max_volt = maximum voltage that does not break the circuit > > Please refer to /include/linux/regulator/driver.h > "@set_voltage" comments. > > For the rest of regulator_set_voltage usages, I'd say the same. OK. I'll add the 'voltage-tolerance' property as cpufreq-dt.c driver. The cpufreq-dt.c get the percentage value by using 'voltage-tolerance' devicetree property. For example, if (of_property_read_u32(np, "exynos,voltage-tolerance", &bus->voltage_tolerance)) bus->voltage_tolerance = DEFAULT_VOLTAGE_TOLERANCE; tol = new_volt * bus->voltage_tolerance / 100; regulator_set_voltage_tol(regulator, new_volt, tol); > > [] >> +static int exynos_bus_get_dev_status(struct device *dev, >> + struct devfreq_dev_status *stat) >> +{ >> + struct exynos_bus *bus = dev_get_drvdata(dev); >> + struct devfreq_event_data edata; >> + int ret; >> + >> + rcu_read_lock(); >> + stat->current_frequency = dev_pm_opp_get_freq(bus->curr_opp); >> + rcu_read_unlock(); >> + >> + ret = exynos_bus_get_event(bus, &edata); >> + if (ret < 0) { >> + stat->total_time = stat->busy_time = 0; >> + goto err; >> + } >> + >> + stat->busy_time = (edata.load_count * 100) / bus->ratio; >> + stat->total_time = edata.total_count; >> + >> + dev_dbg(dev, "Usage of devfreq-event : %ld/%ld\n", stat->busy_time, >> + stat->total_time); > > These two values are unsigned long. OK. I'll modify it (%ld -> %lu) > > [] >> +static int exynos_bus_parse_of(struct device_node *np, >> + struct exynos_bus *bus) >> +{ >> + struct device *dev = bus->dev; >> + unsigned long rate; >> + int i, ret, count, size; >> + >> + /* Get the clock to provide each bus with source clock */ >> + bus->clk = devm_clk_get(dev, "bus"); >> + if (IS_ERR(bus->clk)) { >> + dev_err(dev, "failed to get bus clock\n"); >> + return PTR_ERR(bus->clk); >> + } >> + >> + ret = clk_prepare_enable(bus->clk); >> + if (ret < 0) { >> + dev_err(dev, "failed to get enable clock\n"); >> + return ret; >> + } > > [] > >> +err_regulator: >> + regulator_disable(bus->regulator); >> +err_opp: >> + dev_pm_opp_of_remove_table(dev); >> + >> + return ret; > > No clk_disable_unprepare() somewhere in the error handling routines? OK. I'll handle the error of clock control. > > [] > >> +#ifdef CONFIG_PM_SLEEP >> +static int exynos_bus_resume(struct device *dev) >> +{ > [] >> + ret = regulator_enable(bus->regulator); > [] >> +} >> + >> +static int exynos_bus_suspend(struct device *dev) >> +{ > [] >> + regulator_disable(bus->regulator); > [] >> +} >> +#endif > > Isn't there any possibility that you should not disable at suspend callbacks? > If I remember correctly, we should not disable VDD-INT/VDD-MIF of Exynos4412 > for suspend-to-RAM although it is "mostly" ok to do so, but not "always" ok. Yes. It is not always same. I'll pass the role of handling the VDD_INT/VDD_MIF regulator to regulator framework. The regulator framework handles the state in suspend state by using 'regulator-off-in-suspend' property as following: For example, in arch/arm/boot/dts/exynos4412-trats.dts: buck1_reg: BUCK1 { regulator-name = "vdd_mif"; regulator-min-microvolt = <850000>; regulator-max-microvolt = <1100000>; regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-off-in-suspend; }; }; buck3_reg: BUCK3 { regulator-name = "vdd_int"; regulator-min-microvolt = <850000>; regulator-max-microvolt = <1150000>; regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-off-in-suspend; }; }; > > In such cases, I guess it should be "selectively" disabled for suspend. > (some regulators support special "low power if suspended" modes for such cases) Thanks, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 00/20] PM / devferq: Add generic exynos bus frequency driver and new passive governor @ 2015-12-14 6:38 Chanwoo Choi 2015-12-14 6:38 ` [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2015-12-14 6:38 UTC (permalink / raw) To: myungjoo.ham, k.kozlowski, kgene Cc: kyungmin.park, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, cw00.choi, linux-kernel, linux-pm, linux-samsung-soc, devicetree This patch-set includes the two features as following. The generic exynos bus frequency driver is able to support almost Exynos SoCs for bus frequency scaling. And the new passive governor is able to make the dependency on between devices for frequency/voltage scaling. I had posted the patch-set[2] with the similiar concept. This is is revised version for exynos bus frequency. - Generic exynos bus frequency driver - New passive governor of DEVFREQ framework Depend on: - next-20151210 tag of linux-next (master branch). - Merge the latest devfreq patches on devfreq.git[2] (for-rafael branch). [1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/ (branch: for-rafael) [2] https://lkml.org/lkml/2015/1/7/872 : [PATCHv3 0/8] devfreq: Add generic exynos memory-bus frequency driver Changes from v3: (https://lkml.org/lkml/2015/12/11/75) - Add the reviewed-by tag from Krzysztof Kozlowski (patch2/3/13/14/15/16/17) - Fix typo of the description on patch14 - Modify the subject and description of patch17 - Reorder the 'bus_xxx' device tree node alphabetically in both exynos3250-rinato/monk.dts and exynos4412-trats/odroidu3 Changes from v2: (https://lkml.org/lkml/2015/12/8/869) - Fix typo on documentation - Modify the more appropriate sentence on patch description - Add the detailed description about both parent and passive bus device - Modify the DMC frequency for Exynos4x12 DMC bus (200MHz -> 267MHz) - Modify the voltage of 200MHz was included in Exynos3250 DMC bus (800mV -> 825mV) - Rename OPP nodes as 'opp@<opp-hz>' - Delete the duplicate 'opp-microvolt' property of passive devfreq device - Reorder the 'bus_xxx' device tree node alphabetically in exynos3250-rinato/monk.dts - Reorder the 'bus_xxx' device tree node alphabetically in exynos4412-trats/odroidu3 - Add new exynos4412-ppmu-common.dtsi to remove the duplicate PPMU dt node on rinato/monk/trats2/odroid-u3 board - Add the log message if bus device is registered to devfreq framework successfully - Add the reviewed-by tag from Krzysztof Kozlowski - Add the tested-by tag from Anand Moon on Odroid U3 - Add 'SAMSUNG BUS FREQUENCY DRIVER' entry to MAINTAINERS Changes from v1: (https://lkml.org/lkml/2015/11/26/260) - Check whether the instance of regulator is NULL or not when executing regulator_disable() because of only parent devfreq device has the regulator instance. After fixing it, the wake-up from suspend state is well working. (patch1) - Fix bug which checks 'bus-clk' instead of 'bus->regulator' after calling devm_clk_get() (on patch1) - Update the documentation to remove the description about DEVFREQ-EVENT subsystem (on patch2) - Add the full name of DMC (Dynamic Memory Controller) (on patch2) - Modify the detailed correlation of buses for Exynos3250 on documentation (patch2) - Add the MFC bus node for Exynos3250 (on patch11, patch12) - Fix the duplicate frequency of bus_display on Exynos4x12.dtsi - Add the PPMU node for exynos4412-odroidu3 - Add the support of bus frequency for exynos4412-odroidu3 Detailed descirption for patch-set: 1. Add generic exynos bus frequency driver : This patch-set adds the generic exynos bus frequency driver for AXI bus of sub-blocks in exynos SoC. The Samsung Exynos SoC have the common architecture for bus between DRAM and sub-blocks in SoC. There are the different buses according to Exynos SoC because Exynos SoC has the differnt sub-blocks and bus speed. In spite of this difference among Exynos SoCs, this driver is able to support almost Exynos SoC by adding unique data of each bus in the devicetree file. In devicetree, each bus node has a bus clock, regulator, operation-point and devfreq-event devices which measure the utilization of each bus block. For example, - The bus of DMC block in exynos3250.dtsi are listed below: bus_dmc: bus_dmc { compatible = "samsung,exynos-bus"; clocks = <&cmu_dmc CLK_DIV_DMC>; clock-names = "bus"; operating-points-v2 = <&bus_dmc_opp_table>; status = "disabled"; }; bus_dmc_opp_table: opp_table1 { compatible = "operating-points-v2"; opp-shared; opp@50000000 { opp-hz = /bits/ 64 <50000000>; opp-microvolt = <800000>; }; opp@100000000 { opp-hz = /bits/ 64 <100000000>; opp-microvolt = <800000>; }; opp@134000000 { opp-hz = /bits/ 64 <134000000>; opp-microvolt = <800000>; }; opp@200000000 { opp-hz = /bits/ 64 <200000000>; opp-microvolt = <825000>; }; opp@400000000 { opp-hz = /bits/ 64 <400000000>; opp-microvolt = <875000>; }; }; - Usage case to handle the frequency and voltage of bus on runtime in exynos3250-rinato.dts are listed below: &bus_dmc { devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; vdd-supply = <&buck1_reg>; /* VDD_MIF */ status = "okay"; }; 2. Add new passive governor of DEVFREQ framework (patch5-patch7) : This patch-set add the new passive governor for DEVFREQ framework. The existing governors (ondemand, performance and so on) are used for DVFS (Dynamic Voltage and Frequency Scaling) drivers. The existing governors are independently used for specific device driver which don't give the influence to other device drviers and also don't receive the effect from other device drivers. The passive governor depends on operation of parent driver with existing governors(ondemand, performance and so on) extremely and is not able to decide the new frequency by oneself. According to the decided new frequency of parent driver with governor, the passive governor uses it to decide the appropriate frequency for own device driver. The passive governor must need the following information from device tree: For exameple, There are one more bus device drivers in Exynos3250 which need to change their source clock according to their utilization on runtime. But, they share the same power line (e.g., regulator). So, LEFTBUS bus driver is operated as parent with ondemand governor and then the rest device driver with passive governor. The buses of Internal block in exynos3250.dtsi are listed below: When LEFTBUS bus driver (parent) changes the bus frequency with ondemand governor on runtime, the rest bus devices which sharing the same power line (VDD_INT) will change the each bus frequency according to the decision of LEFTBUS bus driver (parent). - INT (Internal) block : VDD_INT |--- LEFTBUS |--- PERIL |--- MFC |--- G3D |--- RIGHTBUS |--- FSYS |--- LCD0 |--- PERIR |--- ISP |--- CAM - The buss of INT block in exynos3250.dtsi are listed below: bus_leftbus: bus_leftbus { compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_GDL>; clock-names = "bus"; operating-points-v2 = <&bus_leftbus_opp_table>; status = "disabled"; }; bus_rightbus: bus_rightbus { compatible = "samsung,exynos-bus"; clocks = <&cmu CLK_DIV_GDR>; clock-names = "bus"; operating-points-v2 = <&bus_leftbus_opp_table>; status = "disabled"; }; (Omit the rest bus dt node) - Usage case to handle the frequency and voltage of bus on runtime in exynos3250-rinato.dts are listed below: /* Parent bus device of VDD_INT */ &bus_leftbus { devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>; vdd-supply = <&buck3_reg>; status = "okay"; }; /* Passive bus device depend on LEFTBUS bus. */ &bus_rightbus { devfreq = <&bus_leftbus>; /* 'devfreq' property indicates the phandle of parent device. */ status = "okay"; }; (Omit the rest bus dt node) Chanwoo Choi (20): PM / devfreq: exynos: Add generic exynos bus frequency driver PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver ARM: dts: Add DMC bus node for Exynos3250 ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk PM / devfreq: Add new passive governor PM / devfreq: Add devfreq_get_devfreq_by_phandle() PM / devfreq: Show the related information according to governor type PM / devfreq: exynos: Add support of bus frequency of sub-blocks using passive governor PM / devfreq: exynos: Update documentation for bus devices using passive governor PM / devfreq: exynos: Add the detailed correlation between sub-blocks and power line PM / devfreq: exynos: Remove unused exynos4/5 busfreq driver MAINTAINERS: Add samsung bus frequency driver entry ARM: dts: Add bus nodes using VDD_INT for Exynos3250 ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12 ARM: dts: Add bus nodes using VDD_INT for Exynos4x12 ARM: dts: Add bus nodes using VDD_MIF for Exynos4210 ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU nodes ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3 ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3 .../devicetree/bindings/devfreq/exynos-bus.txt | 388 +++++++ MAINTAINERS | 9 + arch/arm/boot/dts/exynos3250-monk.dts | 47 +- arch/arm/boot/dts/exynos3250-rinato.dts | 88 +- arch/arm/boot/dts/exynos3250.dtsi | 181 ++++ arch/arm/boot/dts/exynos4210.dtsi | 159 +++ arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 54 +- arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 50 + arch/arm/boot/dts/exynos4412-trats2.dts | 88 +- arch/arm/boot/dts/exynos4x12.dtsi | 174 ++++ drivers/devfreq/Kconfig | 37 +- drivers/devfreq/Makefile | 2 + drivers/devfreq/devfreq.c | 120 ++- drivers/devfreq/exynos/Makefile | 3 +- drivers/devfreq/exynos/exynos-bus.c | 556 +++++++++++ drivers/devfreq/exynos/exynos4_bus.c | 1055 -------------------- drivers/devfreq/exynos/exynos4_bus.h | 110 -- drivers/devfreq/exynos/exynos5_bus.c | 431 -------- drivers/devfreq/exynos/exynos_ppmu.c | 119 --- drivers/devfreq/exynos/exynos_ppmu.h | 86 -- drivers/devfreq/governor.h | 7 + drivers/devfreq/governor_passive.c | 109 ++ drivers/devfreq/governor_performance.c | 1 + drivers/devfreq/governor_powersave.c | 1 + drivers/devfreq/governor_simpleondemand.c | 1 + drivers/devfreq/governor_userspace.c | 1 + include/linux/devfreq.h | 26 + 27 files changed, 1955 insertions(+), 1948 deletions(-) create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi create mode 100644 drivers/devfreq/exynos/exynos-bus.c delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h create mode 100644 drivers/devfreq/governor_passive.c -- 1.9.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-14 6:38 [PATCH v4 00/20] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi @ 2015-12-14 6:38 ` Chanwoo Choi 2015-12-15 3:41 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2015-12-14 6:38 UTC (permalink / raw) To: myungjoo.ham, k.kozlowski, kgene Cc: kyungmin.park, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, cw00.choi, linux-kernel, linux-pm, linux-samsung-soc, devicetree This patch adds the generic exynos bus frequency driver for AMBA AXI bus of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC have the common architecture for bus between DRAM and sub-blocks in SoC. This driver can support the generic bus frequency driver for Exynos SoCs. In devicetree, Each bus block has a bus clock, regulator, operation-point and devfreq-event devices which measure the utilization of each bus block. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> [linux.amoon: Tested on Odroid U3] Tested-by: Anand Moon <linux.amoon@gmail.com> --- drivers/devfreq/Kconfig | 15 ++ drivers/devfreq/Makefile | 1 + drivers/devfreq/exynos/Makefile | 1 + drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ 4 files changed, 466 insertions(+) create mode 100644 drivers/devfreq/exynos/exynos-bus.c diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 64281bb2f650..55ec774f794c 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE comment "DEVFREQ Drivers" +config ARM_EXYNOS_BUS_DEVFREQ + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" + depends on ARCH_EXYNOS + select DEVFREQ_GOV_SIMPLE_ONDEMAND + select DEVFREQ_EVENT_EXYNOS_PPMU + select PM_DEVFREQ_EVENT + select PM_OPP + help + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos + Memory bus has one more group of memory bus (e.g, MIF and INT block). + Each memory bus group could contain many memoby bus block. It reads + PPMU counters of memory controllers by using DEVFREQ-event device + and adjusts the operating frequencies and voltages with OPP support. + This does not yet operate with optimal voltages. + config ARM_EXYNOS4_BUS_DEVFREQ bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile index 5134f9ee983d..375ebbb4fcfb 100644 --- a/drivers/devfreq/Makefile +++ b/drivers/devfreq/Makefile @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o # DEVFREQ Drivers +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ obj-$(CONFIG_ARM_TEGRA_DEVFREQ) += tegra-devfreq.o diff --git a/drivers/devfreq/exynos/Makefile b/drivers/devfreq/exynos/Makefile index 49bc9175f923..4ec06d322996 100644 --- a/drivers/devfreq/exynos/Makefile +++ b/drivers/devfreq/exynos/Makefile @@ -1,3 +1,4 @@ # Exynos DEVFREQ Drivers +obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos_ppmu.o exynos4_bus.o obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos_ppmu.o exynos5_bus.o diff --git a/drivers/devfreq/exynos/exynos-bus.c b/drivers/devfreq/exynos/exynos-bus.c new file mode 100644 index 000000000000..f1bc20839650 --- /dev/null +++ b/drivers/devfreq/exynos/exynos-bus.c @@ -0,0 +1,449 @@ +/* + * Generic Exynos Bus frequency driver with DEVFREQ Framework + * + * Copyright (c) 2015 Samsung Electronics Co., Ltd. + * Author : Chanwoo Choi <cw00.choi@samsung.com> + * + * This driver support Exynos Bus frequency feature by using + * DEVFREQ framework and is based on drivers/devfreq/exynos/exynos4_bus.c. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/clk.h> +#include <linux/devfreq.h> +#include <linux/devfreq-event.h> +#include <linux/device.h> +#include <linux/export.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/pm_opp.h> +#include <linux/platform_device.h> +#include <linux/regulator/consumer.h> +#include <linux/slab.h> + +#define DEFAULT_SATURATION_RATIO 40 + +struct exynos_bus { + struct device *dev; + + struct devfreq *devfreq; + struct devfreq_event_dev **edev; + unsigned int edev_count; + struct mutex lock; + + struct dev_pm_opp *curr_opp; + + struct regulator *regulator; + struct clk *clk; + int ratio; +}; + +/* + * Control the devfreq-event device to get the current state of bus + */ +#define exynos_bus_ops_edev(ops) \ +static int exynos_bus_##ops(struct exynos_bus *bus) \ +{ \ + int i, ret; \ + \ + for (i = 0; i < bus->edev_count; i++) { \ + if (!bus->edev[i]) \ + continue; \ + ret = devfreq_event_##ops(bus->edev[i]); \ + if (ret < 0) \ + return ret; \ + } \ + \ + return 0; \ +} +exynos_bus_ops_edev(enable_edev); +exynos_bus_ops_edev(disable_edev); +exynos_bus_ops_edev(set_event); + +static int exynos_bus_get_event(struct exynos_bus *bus, + struct devfreq_event_data *edata) +{ + struct devfreq_event_data event_data; + unsigned long load_count = 0, total_count = 0; + int i, ret = 0; + + for (i = 0; i < bus->edev_count; i++) { + if (!bus->edev[i]) + continue; + + ret = devfreq_event_get_event(bus->edev[i], &event_data); + if (ret < 0) + return ret; + + if (i == 0 || event_data.load_count > load_count) { + load_count = event_data.load_count; + total_count = event_data.total_count; + } + } + + edata->load_count = load_count; + edata->total_count = total_count; + + return ret; +} + +/* + * Must necessary function for devfreq governor + */ +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 flags) +{ + struct exynos_bus *bus = dev_get_drvdata(dev); + struct dev_pm_opp *new_opp; + unsigned long old_freq, new_freq, old_volt, new_volt; + int ret = 0; + + /* Get new opp-bus instance according to new bus clock */ + rcu_read_lock(); + new_opp = devfreq_recommended_opp(dev, freq, flags); + if (IS_ERR_OR_NULL(new_opp)) { + dev_err(dev, "failed to get recommed opp instance\n"); + rcu_read_unlock(); + return PTR_ERR(new_opp); + } + + new_freq = dev_pm_opp_get_freq(new_opp); + new_volt = dev_pm_opp_get_voltage(new_opp); + old_freq = dev_pm_opp_get_freq(bus->curr_opp); + old_volt = dev_pm_opp_get_voltage(bus->curr_opp); + rcu_read_unlock(); + + if (old_freq == new_freq) + return 0; + + /* Change voltage and frequency according to new OPP level */ + mutex_lock(&bus->lock); + + if (old_freq < new_freq) { + ret = regulator_set_voltage(bus->regulator, new_volt, new_volt); + if (ret < 0) { + dev_err(bus->dev, "failed to set voltage\n"); + regulator_set_voltage(bus->regulator, old_volt, + old_volt); + goto out; + } + } + + ret = clk_set_rate(bus->clk, new_freq); + if (ret < 0) { + dev_err(dev, "failed to change clock of bus\n"); + clk_set_rate(bus->clk, old_freq); + goto out; + } + + if (old_freq > new_freq) { + ret = regulator_set_voltage(bus->regulator, new_volt, new_volt); + if (ret < 0) { + dev_err(bus->dev, "failed to set voltage\n"); + regulator_set_voltage(bus->regulator, old_volt, + old_volt); + goto out; + } + } + bus->curr_opp = new_opp; + + dev_dbg(dev, "Set the frequency of bus (%ldkHz -> %ldkHz)\n", + old_freq/1000, new_freq/1000); +out: + mutex_unlock(&bus->lock); + + return ret; +} + +static int exynos_bus_get_dev_status(struct device *dev, + struct devfreq_dev_status *stat) +{ + struct exynos_bus *bus = dev_get_drvdata(dev); + struct devfreq_event_data edata; + int ret; + + rcu_read_lock(); + stat->current_frequency = dev_pm_opp_get_freq(bus->curr_opp); + rcu_read_unlock(); + + ret = exynos_bus_get_event(bus, &edata); + if (ret < 0) { + stat->total_time = stat->busy_time = 0; + goto err; + } + + stat->busy_time = (edata.load_count * 100) / bus->ratio; + stat->total_time = edata.total_count; + + dev_dbg(dev, "Usage of devfreq-event : %ld/%ld\n", stat->busy_time, + stat->total_time); + +err: + ret = exynos_bus_set_event(bus); + if (ret < 0) { + dev_err(dev, "failed to set event to devfreq-event devices\n"); + return ret; + } + + return ret; +} + +static void exynos_bus_exit(struct device *dev) +{ + struct exynos_bus *bus = dev_get_drvdata(dev); + int ret; + + ret = exynos_bus_disable_edev(bus); + if (ret < 0) + dev_warn(dev, "failed to disable the devfreq-event devices\n"); + + if (bus->regulator) + regulator_disable(bus->regulator); + + dev_pm_opp_of_remove_table(dev); +} + +static int exynos_bus_parse_of(struct device_node *np, + struct exynos_bus *bus) +{ + struct device *dev = bus->dev; + unsigned long rate; + int i, ret, count, size; + + /* Get the clock to provide each bus with source clock */ + bus->clk = devm_clk_get(dev, "bus"); + if (IS_ERR(bus->clk)) { + dev_err(dev, "failed to get bus clock\n"); + return PTR_ERR(bus->clk); + } + + ret = clk_prepare_enable(bus->clk); + if (ret < 0) { + dev_err(dev, "failed to get enable clock\n"); + return ret; + } + + /* Get the freq/voltage OPP table to scale the bus frequency */ + rcu_read_lock(); + ret = dev_pm_opp_of_add_table(dev); + if (ret < 0) { + dev_err(dev, "failed to get OPP table\n"); + rcu_read_unlock(); + return ret; + } + + rate = clk_get_rate(bus->clk); + bus->curr_opp = dev_pm_opp_find_freq_ceil(dev, &rate); + if (IS_ERR(bus->curr_opp)) { + dev_err(dev, "failed to find dev_pm_opp\n"); + rcu_read_unlock(); + ret = PTR_ERR(bus->curr_opp); + goto err_opp; + } + rcu_read_unlock(); + + /* Get the regulator to provide each bus with the power */ + bus->regulator = devm_regulator_get(dev, "vdd"); + if (IS_ERR(bus->regulator)) { + dev_err(dev, "failed to get VDD regulator\n"); + ret = PTR_ERR(bus->regulator); + goto err_opp; + } + + ret = regulator_enable(bus->regulator); + if (ret < 0) { + dev_err(dev, "failed to enable VDD regulator\n"); + goto err_opp; + } + + /* + * Get the devfreq-event devices to get the current utilization of + * buses. This raw data will be used in devfreq ondemand governor. + */ + count = devfreq_event_get_edev_count(dev); + if (count < 0) { + dev_err(dev, "failed to get the count of devfreq-event dev\n"); + ret = count; + goto err_regulator; + } + bus->edev_count = count; + + size = sizeof(*bus->edev) * count; + bus->edev = devm_kzalloc(dev, size, GFP_KERNEL); + if (!bus->edev) { + ret = -ENOMEM; + goto err_regulator; + } + + for (i = 0; i < count; i++) { + bus->edev[i] = devfreq_event_get_edev_by_phandle(dev, i); + if (IS_ERR(bus->edev[i])) { + ret = -EPROBE_DEFER; + goto err_regulator; + } + } + + /* + * Optionally, Get the saturation ratio according to Exynos SoC + * When measuring the utilization of each AXI bus with devfreq-event + * devices, the measured real cycle might be much lower than the + * total cycle of bus during sampling rate. In result, the devfreq + * simple-ondemand governor might not decide to change the current + * frequency due to too utilization (= real cycle/total cycle). + * So, this property is used to adjust the utilization when calculating + * the busy_time in exynos_bus_get_dev_status(). + */ + if (of_property_read_u32(np, "exynos,saturation-ratio", &bus->ratio)) + bus->ratio = DEFAULT_SATURATION_RATIO; + + return 0; + +err_regulator: + regulator_disable(bus->regulator); +err_opp: + dev_pm_opp_of_remove_table(dev); + + return ret; +} + +static int exynos_bus_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev->of_node; + struct devfreq_dev_profile *profile; + struct devfreq_simple_ondemand_data *ondemand_data; + struct exynos_bus *bus; + int ret; + + if (!np) { + dev_err(dev, "failed to find devicetree node\n"); + return -EINVAL; + } + + bus = devm_kzalloc(&pdev->dev, sizeof(*bus), GFP_KERNEL); + if (!bus) + return -ENOMEM; + mutex_init(&bus->lock); + bus->dev = &pdev->dev; + platform_set_drvdata(pdev, bus); + + /* Parse the device-tree to get the resource information */ + ret = exynos_bus_parse_of(np, bus); + if (ret < 0) + return ret; + + /* Initalize the struct profile and governor data */ + profile = devm_kzalloc(dev, sizeof(*profile), GFP_KERNEL); + if (!profile) + return -ENOMEM; + profile->polling_ms = 50; + profile->target = exynos_bus_target; + profile->get_dev_status = exynos_bus_get_dev_status; + profile->exit = exynos_bus_exit; + + ondemand_data = devm_kzalloc(dev, sizeof(*ondemand_data), GFP_KERNEL); + if (!ondemand_data) + return -ENOMEM; + ondemand_data->upthreshold = 40; + ondemand_data->downdifferential = 5; + + /* Add devfreq device to monitor and handle the exynos bus */ + bus->devfreq = devm_devfreq_add_device(dev, profile, "simple_ondemand", + ondemand_data); + if (IS_ERR_OR_NULL(bus->devfreq)) { + dev_err(dev, "failed to add devfreq device\n"); + return PTR_ERR(bus->devfreq); + } + + /* Register opp_notifier to catch the change of OPP */ + ret = devm_devfreq_register_opp_notifier(dev, bus->devfreq); + if (ret < 0) { + dev_err(dev, "failed to register opp notifier\n"); + return ret; + } + + /* + * Enable devfreq-event to get raw data which is used to determine + * current bus load. + */ + ret = exynos_bus_enable_edev(bus); + if (ret < 0) { + dev_err(dev, "failed to enable devfreq-event devices\n"); + return ret; + } + + ret = exynos_bus_set_event(bus); + if (ret < 0) { + dev_err(dev, "failed to set event to devfreq-event devices\n"); + return ret; + } + + return 0; +} + +#ifdef CONFIG_PM_SLEEP +static int exynos_bus_resume(struct device *dev) +{ + struct exynos_bus *bus = dev_get_drvdata(dev); + int ret; + + if (bus->regulator) { + ret = regulator_enable(bus->regulator); + if (ret < 0) { + dev_err(dev, "failed to enable VDD regulator\n"); + return ret; + } + } + + ret = exynos_bus_enable_edev(bus); + if (ret < 0) { + dev_err(dev, "failed to enable the devfreq-event devices\n"); + return ret; + } + + return 0; +} + +static int exynos_bus_suspend(struct device *dev) +{ + struct exynos_bus *bus = dev_get_drvdata(dev); + int ret; + + ret = exynos_bus_disable_edev(bus); + if (ret < 0) { + dev_err(dev, "failed to disable the devfreq-event devices\n"); + return ret; + } + + if (bus->regulator) + regulator_disable(bus->regulator); + + return 0; +} +#endif + +static const struct dev_pm_ops exynos_bus_pm = { + SET_SYSTEM_SLEEP_PM_OPS(exynos_bus_suspend, exynos_bus_resume) +}; + +static const struct of_device_id exynos_bus_of_match[] = { + { .compatible = "samsung,exynos-bus", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, exynos_bus_of_match); + +static struct platform_driver exynos_bus_platdrv = { + .probe = exynos_bus_probe, + .driver = { + .name = "exynos-bus", + .pm = &exynos_bus_pm, + .of_match_table = of_match_ptr(exynos_bus_of_match), + }, +}; +module_platform_driver(exynos_bus_platdrv); + +MODULE_DESCRIPTION("Generic Exynos Bus frequency driver"); +MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>"); +MODULE_LICENSE("GPL v2"); -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-14 6:38 ` [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver Chanwoo Choi @ 2015-12-15 3:41 ` Krzysztof Kozlowski 2015-12-18 0:34 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2015-12-15 3:41 UTC (permalink / raw) To: Chanwoo Choi, myungjoo.ham, kgene Cc: kyungmin.park, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree On 14.12.2015 15:38, Chanwoo Choi wrote: > This patch adds the generic exynos bus frequency driver for AMBA AXI bus > of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC > have the common architecture for bus between DRAM and sub-blocks in SoC. > This driver can support the generic bus frequency driver for Exynos SoCs. > > In devicetree, Each bus block has a bus clock, regulator, operation-point > and devfreq-event devices which measure the utilization of each bus block. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon <linux.amoon@gmail.com> > --- > drivers/devfreq/Kconfig | 15 ++ > drivers/devfreq/Makefile | 1 + > drivers/devfreq/exynos/Makefile | 1 + > drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 466 insertions(+) > create mode 100644 drivers/devfreq/exynos/exynos-bus.c > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 64281bb2f650..55ec774f794c 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE > > comment "DEVFREQ Drivers" > > +config ARM_EXYNOS_BUS_DEVFREQ > + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" > + depends on ARCH_EXYNOS > + select DEVFREQ_GOV_SIMPLE_ONDEMAND > + select DEVFREQ_EVENT_EXYNOS_PPMU > + select PM_DEVFREQ_EVENT > + select PM_OPP > + help > + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos > + Memory bus has one more group of memory bus (e.g, MIF and INT block). > + Each memory bus group could contain many memoby bus block. It reads > + PPMU counters of memory controllers by using DEVFREQ-event device > + and adjusts the operating frequencies and voltages with OPP support. > + This does not yet operate with optimal voltages. > + > config ARM_EXYNOS4_BUS_DEVFREQ > bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" > depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM > diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile > index 5134f9ee983d..375ebbb4fcfb 100644 > --- a/drivers/devfreq/Makefile > +++ b/drivers/devfreq/Makefile > @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o > obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o > > # DEVFREQ Drivers > +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos mach code? Or on ARM code? If not, then this probably should be obj-y to allow compile testing. Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-15 3:41 ` Krzysztof Kozlowski @ 2015-12-18 0:34 ` Chanwoo Choi 2015-12-18 0:43 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2015-12-18 0:34 UTC (permalink / raw) To: Krzysztof Kozlowski, myungjoo.ham, kgene Cc: kyungmin.park, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree Hi, On 2015년 12월 15일 12:41, Krzysztof Kozlowski wrote: > On 14.12.2015 15:38, Chanwoo Choi wrote: >> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >> have the common architecture for bus between DRAM and sub-blocks in SoC. >> This driver can support the generic bus frequency driver for Exynos SoCs. >> >> In devicetree, Each bus block has a bus clock, regulator, operation-point >> and devfreq-event devices which measure the utilization of each bus block. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon <linux.amoon@gmail.com> >> --- >> drivers/devfreq/Kconfig | 15 ++ >> drivers/devfreq/Makefile | 1 + >> drivers/devfreq/exynos/Makefile | 1 + >> drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ >> 4 files changed, 466 insertions(+) >> create mode 100644 drivers/devfreq/exynos/exynos-bus.c >> >> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >> index 64281bb2f650..55ec774f794c 100644 >> --- a/drivers/devfreq/Kconfig >> +++ b/drivers/devfreq/Kconfig >> @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE >> >> comment "DEVFREQ Drivers" >> >> +config ARM_EXYNOS_BUS_DEVFREQ >> + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" >> + depends on ARCH_EXYNOS >> + select DEVFREQ_GOV_SIMPLE_ONDEMAND >> + select DEVFREQ_EVENT_EXYNOS_PPMU >> + select PM_DEVFREQ_EVENT >> + select PM_OPP >> + help >> + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos >> + Memory bus has one more group of memory bus (e.g, MIF and INT block). >> + Each memory bus group could contain many memoby bus block. It reads >> + PPMU counters of memory controllers by using DEVFREQ-event device >> + and adjusts the operating frequencies and voltages with OPP support. >> + This does not yet operate with optimal voltages. >> + >> config ARM_EXYNOS4_BUS_DEVFREQ >> bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" >> depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM >> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >> index 5134f9ee983d..375ebbb4fcfb 100644 >> --- a/drivers/devfreq/Makefile >> +++ b/drivers/devfreq/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >> >> # DEVFREQ Drivers >> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ > > Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos > mach code? Or on ARM code? There is no dependency. > > If not, then this probably should be obj-y to allow compile testing. > Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. OK. I'll alter it as obj-y. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver 2015-12-18 0:34 ` Chanwoo Choi @ 2015-12-18 0:43 ` Chanwoo Choi 0 siblings, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2015-12-18 0:43 UTC (permalink / raw) To: Krzysztof Kozlowski, myungjoo.ham, kgene Cc: kyungmin.park, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, tjakobi, linux.amoon, linux-kernel, linux-pm, linux-samsung-soc, devicetree On 2015년 12월 18일 09:34, Chanwoo Choi wrote: > Hi, > > On 2015년 12월 15일 12:41, Krzysztof Kozlowski wrote: >> On 14.12.2015 15:38, Chanwoo Choi wrote: >>> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >>> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >>> have the common architecture for bus between DRAM and sub-blocks in SoC. >>> This driver can support the generic bus frequency driver for Exynos SoCs. >>> >>> In devicetree, Each bus block has a bus clock, regulator, operation-point >>> and devfreq-event devices which measure the utilization of each bus block. >>> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> [linux.amoon: Tested on Odroid U3] >>> Tested-by: Anand Moon <linux.amoon@gmail.com> >>> --- >>> drivers/devfreq/Kconfig | 15 ++ >>> drivers/devfreq/Makefile | 1 + >>> drivers/devfreq/exynos/Makefile | 1 + >>> drivers/devfreq/exynos/exynos-bus.c | 449 ++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 466 insertions(+) >>> create mode 100644 drivers/devfreq/exynos/exynos-bus.c >>> >>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>> index 64281bb2f650..55ec774f794c 100644 >>> --- a/drivers/devfreq/Kconfig >>> +++ b/drivers/devfreq/Kconfig >>> @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE >>> >>> comment "DEVFREQ Drivers" >>> >>> +config ARM_EXYNOS_BUS_DEVFREQ >>> + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" >>> + depends on ARCH_EXYNOS >>> + select DEVFREQ_GOV_SIMPLE_ONDEMAND >>> + select DEVFREQ_EVENT_EXYNOS_PPMU >>> + select PM_DEVFREQ_EVENT >>> + select PM_OPP >>> + help >>> + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos >>> + Memory bus has one more group of memory bus (e.g, MIF and INT block). >>> + Each memory bus group could contain many memoby bus block. It reads >>> + PPMU counters of memory controllers by using DEVFREQ-event device >>> + and adjusts the operating frequencies and voltages with OPP support. >>> + This does not yet operate with optimal voltages. >>> + >>> config ARM_EXYNOS4_BUS_DEVFREQ >>> bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" >>> depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && !ARCH_MULTIPLATFORM >>> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >>> index 5134f9ee983d..375ebbb4fcfb 100644 >>> --- a/drivers/devfreq/Makefile >>> +++ b/drivers/devfreq/Makefile >>> @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >>> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >>> >>> # DEVFREQ Drivers >>> +obj-$(CONFIG_ARCH_EXYNOS) += exynos/ >> >> Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos >> mach code? Or on ARM code? > > There is no dependency. > >> >> If not, then this probably should be obj-y to allow compile testing. >> Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. > > OK. I'll alter it as obj-y. As you commented, CONFIG_ARM_EXYNOS_BUS_DEVFREQ is more appropriate without exynos/ directory as following: +obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-18 0:43 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-12-14 8:28 [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver MyungJoo Ham 2015-12-14 8:44 ` Chanwoo Choi 2015-12-15 3:32 ` Chanwoo Choi -- strict thread matches above, loose matches on Subject: below -- 2015-12-14 6:38 [PATCH v4 00/20] PM / devferq: Add generic exynos bus frequency driver and new passive governor Chanwoo Choi 2015-12-14 6:38 ` [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver Chanwoo Choi 2015-12-15 3:41 ` Krzysztof Kozlowski 2015-12-18 0:34 ` Chanwoo Choi 2015-12-18 0:43 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).