Linux 2.4.5-ac9

Linux 2.4.5-ac9

[Alan Cox]

	ftp://ftp.kernel.org/pub/linux/kernel/people/alan/2.4/

		 Intermediate diffs are available from
			http://www.bzimage.org

In terms of going through the code audit almost all the sound drivers still 
need fixing to lock against format changes during a read/write. Poll creating 
and starting a buffer as write does and also mmap during write, write during
an mmap.

2.4.5-ac9
o	Fix gameport link problems			(Vojtech Pavlik)
o	Fix an oops in the sg driver			(Tachino Nobuhiro)
o	Fix brlock indexing bug				(Takanori Kawano)
o	Add parport_pc_unregister_port			(Tim Waugh)
o	Configure.help updates				(Eric Raymond)
o	Fix xircom_cb problems with some cisco kit	(Ion Badulescu)
o	Fix tdfxfb cursor rendering bug			(Franz Melchior)
o	Add driver for the sony vaio i/o controller	(Stelian Pop, 
				Junchi Morita, Takaya Kinjo, Andrew Tridgell)
o	Orinoco updates for symbol, intel, 3com cards	(Jean Tourrihles)
o	Use list_del_init in uhci driver		(Herbert Xu)
o	Fix a uhci SMP deadlock				(Herbert Xu)
o	Allow faster freeing of reisefs metadata	(Chris Mason)
o	Fix error path leaks in reiserfs		(Chris Mason,
							 Vladimir Saveliev)
o	Fix NFS problems triggered by 2.4.5 mmap change	(Trond Myklebust)
o	Resynchronize with m68k tree			(Jes Sorensen)
o	Add es1371 sound driver locking			(Frank Davis)
o	Fix a small error in the trident locking	(Frank Davis)

2.4.5-ac8
o	Fix sign handling bug in random sysctl		(me)
	| From Stanford tools
o	Add more idents to the NS558 driver		(Vojtech Pavlik)
o	Fix oops on some HID descriptor sets		(Vojtech Pavlik)
o	Fix reuse bug in UML net code + clean up	(Jeff Dike)
o	ES1370 driver locking				(Frank Davis)
o	Update init/main.c patch for umask		(Andrew Tridgell)
o	Fix uml fault race, and looping fault on 	(Jeff Dike)
	protection error
o	Update devices.txt				(H Peter Anvin)
o	Update the airo driver (fix pci pm oops.	(Jeff Garzik)
	spinlock abuse, delete after kfree, unchecked
	copies)
o	Remove old UML umn driver			(Jeff Dike)
o	Fix resource leaks and printk levels in isapnp	(Mike Borrelli)
o	Add new procfs programming documentation	(Erik Mouw)
o	Fix usb xconfig breakage		(Andrzej Krzysztofowicz)
o	Replace accidentaly lost UP_APIC help		(Mikael Pettersson)
o	Olypmic driver update				(Mike Phillips)
o	Clean up LVM spelling, debug macros		(Andreas Dilger)
o	Make various bits of LVM static			(Andreas Dilger)
o	Make lvm_snapshot_use_rate its own function	(Andreas Dilger)
o	Make lvm_do_lv_create loop the right amount
o	Fix lvm stamping on a semaphore causing an oops
o	Fix lvm hardware block size handling		(Andrea Arcangeli)

2.4.5-ac7
o	UML cleanups					(Jeff Dike)
o	Trap invalid addresses in UML ethernet driver	(Jeff Dike)
o	Reimplment UML user space access		(Jeff Dike)
o	Add device node support to hostfs		(Jorgen Cederlof)
o	Fix hang if the UML net helper fails to run	(Jeff Dike)
o	Support setting time in UML kernels		(Livio Baldini Soares)
o	Move more non portable code out of UML core	(Jeff Dike)
o	Merge most of remaining UML ppc changes		(Chris Emerson)
o	Printk cleanups, remove one non portable	(James Stevenson)
o	Add speaker mixer support to the cmpci mixer	(Carlos Gorges)
o	Fix inittdata ordering in i2c docs	     (Andrzej Krzysztofowicz)
o	Add usb skeleton driver				(Greg Kroah-Hartmann)
o	Fix ns558 unload 				(Marcus Meissner)
o	Further cs46xx fixing				(Frank Davies)
o	S/390 updates from the IBM folks		(Martin Schwidefsky)
o	CS46xx pop/crackle fixes on IBM T20		(Thomas Woller)
o	Make USB require PCI				(me)
o	Tulip driver update				(Jeff Garzik)
o	Fix slip/slhc missing symbols problem		(Michael Guntsche)
o	IRDA updates					(Dag Brattli)
o	Add cs4232 isapnp probing			(Marcus Meissner)
o	Merge airo_cs driver		(Benjamin Reed, Javier Achirica,
							Jean Tourrilhes)
o	VIA workarounds for APIC IRQ routing		(Jeff Garzik)
o	Fix bootmem.c comment cut&paste accident	(Richard Urena)
o	Update LVM with new VG_CREATE ioctl (and 	(Joe Thornber)
	VG_CREATE_OLD for back compatibility)
o	Fix pv_t/lv_t confusion in lv_status_bydev_req	(Joe Thornber)
o	Lots of update/fixes for _lv_status_by* code	(Joe Thornber)
o	Add support for I2O IOP's requiring private	(me)
	resource spaces
o	Hopefully fix hid jerkiness			(Michael)

2.4.5-ac6
o	Fix the cs46xx right this time			(me)
o	Further FATfs cleanup				(OGAWA Hirofumi)
o	ISDN PPP code cleanup, cvs tag update		(Kai Germaschewski)
o	Large amount of UFS file system cleanup		(Al Viro)
o	Fix endianness problems in FATfs		(Petr Vandrovec)
o	Fix -ac quota crashes				(Jan Kara)
o	Fix bluetooth out of memory handling		(Greg Kroah-Hartmann)
o	Fix freevxfs readdir				(Christoph Hellwig)
o	Fix freevxfs sign/unsigned issues		(Christoph Hellwig)
o	Fix doctypos, other freevxfs cleanup		(Christoph Hellwig)
o	Fix flush_dirty_buffers warning			(J A Magallon)
o	Add Carlos Gorges to credits			(Carlos Gorges)
o	Further atm cleanup fixes (kmalloc/signedness)	(Mitchell Blank)
o	Fix hotplug variable in matroxfb		(Petr Vandrovec)
o	Fix ns558 crash					(Vojtech Pavlik)
o	Revert to Pete Zaitcev's khub locking		(Pete Zaitcev)
	| It works for me, Johannes changes don't seem to
o	Fix usb Config.in breakage for input devices	(Vojtech Pavlik)
o	Add another 3c509 ISAPnP id			(Marcus Meissner)
o	Fix oopses and null checks on iphase		(Mitchell Blank)
o	CS46xx update					(Thomas Woller)
o	Fix mmap cornercase				(Maciej Rozycki)
o	Tidy up aironet and saa9730 delay abuse	   (Andrzej Krzysztofowicz)
o	Force initial umask to be sane for broken	(Andrew Tridgell)
	init programs
o	Teach CML1 to strip out <file: > from the	(Eric Raymond)
	Configure.help
o	Resync with Eric's master Configure.help	(Eric Raymond)
o	Revert FIOQSIZE	
o	Fix missing copy_*_user in cosa driver		(me)
	| From Stanford tools
o	Fix missing copy_*_user in eicon		(me)
	+ clean up ioctls a bit more
	| From Stanford tools
o	Fix use after free in lpbether			(me)
	| From Stanford tools
o	Fix missing return in rose_dev			(me)
	| From Stanford tools
o	Fix use after free in bpqether			(me)
	| From Stanford tools

2.4.5-ac5
o	Fix bug introduced in cs46xx/trident locking	(me)
o	Fix reiserfs unload/exit locking race		(Paul Mundt)
o	Miscellaneous small UML updates			(Jeff Dike)
o	Further FAT cleanups				(OGAWA Hirofumi)
o	Fix ext2fs oops following disk error		(Andreas Dilger)
o	Optimise segment reloads, syscall path		(Andi Kleen)
o	Clean up .byte abuse where asm is now known	(Brian Gerst)
	by required tools
o	Fix eepro100 on 64bit machine bitops bug	(Andrea Arcangeli)
o	Move the pagecache and pagemap_lru_lock to	(Andrea Arcangeli)
	different cache lines
o	Clean up .byte abuse where asm is now known	(Brian Gerst)
	by required tools
o	Fix user space dereference in bluetooth		(me)
	| From Stanford tools
o	Fix user space dereference in sbc60wdt		(me)
	| From Stanford tools
o	Fix user space dereference in mdc800		(me)
	| From Stanford tools
o	Fix a rather wrong memset in nubus.c		(Chris Peterson)
o	Remove fpu references from dmfe			(Arjan van de Ven)
o	Fix spelling of Portuguese			(Nerijus Baliunas)

2.4.5-ac4
o	APIC parsing updates				(Ingo Molnar)
o	Retry rather than losing I/O on an IDE DMA	(Jens Axboe)
	timeout.
o	Add missing locking to cs46xx			(Frank Davis)
o	Clean up sym53c416 and add PnP support		(me)
o	Tidy up changelog in apm.c			(Stephen Rothwell)
o	Update jffs2, remove abuse of kdev_t		(David Woodhouse)
o	Fix oops on unplugging bluetooth		(Greg Kroah-Hartmann)
o	Move stuff into bss on aironet4500		(Rasmus Andersen)
o	Fix up alpha oops output			(George France)
o	Update SysKonnect PCI id list			(Mirko Lindner)
o	Update SysKonnect GigE driver			(Mirko Lindner)
o	Add ATM DS3/OC12 definitions to atmdev.h	(Mitchell Blank)
o	Clean up atm drivers, fixed up user space	(Mitchell Blank,
	access with irqs off, kmalloc and use after	 John Levon)
	free.
o	Update input device/joystick/gameport drivers	(Vojtech Pavlik)
o	Update USB hid drivers				(Vojtech Pavlik)
o	Fix out of memory oops in hysdn			(Rasmus Andersen)
o	Belarussian should be Belarusian according to	(Nerijus Baliunas)
	the standards
o	Support booting off old 720K floppies		(Niels Jensen, 
							 Chris Noe)

2.4.5-ac3
o	Ignore console writes from an IRQ handler	(me)
o	Make SIGBUS/SIGILL visible to UML debugger	(Jeff Dike)
o	Clean up UML syscalls add missing items		(Jeff Dike)
o	Clean up non portable UML code			(Jeff Dike)
o	Fix off by one and other oddments in hostfs	(Henrik Nordstrom)
o	Update UML to use CONFIG_SMP not __SMP__	(Jeff Dike)
o	Fix UML crash if console is typed at too early	(Jeff Dike)
o	Clean up UML host transports			(Lennert Buytenhek,
							 Jim Leu)
o	Resynchronize UML/ppc				(Chris Emerson)
o	Fix UML crash if it had an address space hole	(Jeff Dike)
	between text and data
o	Fix rd_ioctl crash with initrd			(Go Taniguchi)
o	Fix IRQ ack path on Alpha rawhide		(Richard Henderson)
o	Drop back to older 8139too driver from 2.4.3
	| Seems the new one causes lockups
o 	Experimental promise fastrak raid driver	(Arjan van de Ven)

2.4.5-ac2
o	Restore lock_kernel on umount			(Al Viro)
	| Should cure Reiserfs crash in 2.4.5
o	Fix additional scsi_ioctl leak			(John Martin)
o	Clean up scsi_ioctl error handling		(me)
o	Configure.help typo fixes			(Nerijus Baliunas)
o	Fix hgafb problems with logos			(Ferenc Bakonyi)
o	Fix lock problems in the rio driver		(Rasmus Andersen)
o	Make new cmpci SMP safe				(Carlos E Gorges)
o	Fix missing restore flags in soundmodem		(Rasmus Andersen)
o	Set max sectors in ps2esdi			(Paul Gortmaker)
o	Fix interrupt restore problems in mixcom	(Rasmus Andersen)
o	Fix alpha compile on dp264/generic		(Andrea Arcangeli)
o	Fix irda irport locking restores		(Rasmus Andersen)
o	Fix failed kmalloc handling in hisax		(Kai Germaschewski)
o	Add missing memory barrier in qlogicisp		(?)
o	Fix missing restore_flags in eata_dma		(Rasmus Andersen)
o	Fix procfs locking in irttp			(Rasmus Andersen)
o	Winbond updates					(Manfred Spraul)
o	Stop network eating PF_MEMALLOC ram		(Manfred Spraul)
o	Drop fs/buffer.c low mem flush changes		(me)
o	Drop changes to mm/highmem.c			(me)
	| I don't think the Linus one is quite right but its easier
	| for everyone to be working off one base
o	Revert GFP_FAIL and some other alloc bits	(me)
o	Hopefully fix initrd problem			(me)
o	Fix kmalloc check in ide-tape			(Rasmus Andersen)
o	Fix irda irtty locking				(Rasmus Andersen)
o	Fix missing irq restore in qla1280		(Rasmus Andersen)
o	Fix proc/pid/mem cross exec behaviour		(Arjan van de Ven)
o	Fix direct user space derefs in eicon		(me)
	| From Stanford checker
o	Fix direct user space derefs in ipddp		(me)
	| From Stanford checker
o	Fix direct user space derefs in ixj		(me)
	| From Stanford checker
o	Fix direct user space derefs in decnet		(me)
	| From Stanford checker

2.4.5-ac1
o	Merge Linus 2.4.5 tree

Summary of changes for Linux 2.4.5-ac versus Linus 2.4.5

o	Fix memory leak in wanrouter
o	Fix memory leak in wanmain
o	Use non atomic memory for linearising NFS buffers as they are 
	done in task context
o	Fix dereference of freed memory in NetROM drivers
o	Fix writing to freed memory in ax25_ip
o	Support debugging of slab pools
o	NinjaSCSI pcmcia scsi driver
o	Raw HID device for USB peripheral buttons/controllers
o	Updated NTFS
o	RAMfs with resource limits
o	NMI watchdog available on uniprocessor x86
o	Update CMPCI drivers (not yet SMP safe)
o	Configurable max_map_count
o	Dynamic sysctl key registration
o	SE401 USB camera driver
o	Updated Zoran ZR3606x driver (replaces buz)
o	w9966 parallel port camera driver (partially merged with Linus)
o	Include headers in etags
o	Don't delete empty directories on make distclean
o	Fix halt/reboot handling on Alcor Alpha
o	IDE driver support for Etrax E100
o	IDE infrastructure support for IDE using non standard data transfers
o	Run ~/bin/installkernel if present
o	Support for out of order stores on x86 with this mode (IDT Winchip)
	- worth 20% performance on them
o	Configure level debugging menu
o	Make BUG() default to an oops only - saves 70K
o	Power management help for UP-APIC
o	Work around 440BX APIC hang (eg the ne2000 SMP hang)
o	Run time configurable APM behaviour (interrupts, psr etc)
o	Smarter DMI parser - handles multiple use of names
o	DMI layer has blacklist tables fixing Dell Inspiron 5000e crashes,
	PowerEdge reboot problems , and IBM laptop APM problems
o	PNPBios support
o	Fix atomicity of IRQ error count
o	Handle PCI/ISA boxes that don't list edge levels but have an ELCR
o	Don't erroneously mangle settings on all VIA bridges - cures the 
	horrible performance problem in 2.4.5 vanilla with VIA
o	Fix bootmem corruption on x86 boot
o	Scan and retrieve multipliers for processors (not yet used to handle
	the SMP cases where we need to disable tsc use)
o	Support machine check on Athlon and Pentium
o	Fix SUS violation with signal stacks
o	Handle boxes where firmware resets the timer to 18Hz (this should
	now not show false positives)
o	Better OOPS formatting on x86
o	Fix nasty problems with interrupts being disabled for long periods
	in frame buffer drivers
o	PAE mode alignment assumption fixes
o	32bit UID clean quota
o	Fix quota deadlocks
o	Fix TLB shootdown races
o	Experimental merge of usermode Linux
o	Fix memory leaks and othe rproblems with the iphase driver
o	IBM AS/400 iSeries virtual drivers
o	DAC960 null pointer checks
o	CCISS driver leak fixes
o	MPT fusion drivers for scsi and networking
o	Handle out of memory allocating request queue entries and avoid oops
o	Free the initial ramdisk correctly
o	Small CD-ROM layer updates
o	AGP power management hooks
o	First basic applicom driver fixes
o	Fix copy_from_user with interrupts off in cyclades driver
o	Fix out of memory handling in DRM
o	Clean up dsp56K driver
o	Update generic serial driver with break support
o	Clean up h8 driver namespace
o	Fix keymap changing problems in console drivers
o	Fix locking in machzwd
o	Updated rio serial driver
o	A2232 driver
o	Fix serial driver mangling of some clone uarts
o	Handle xircom serial port setup delay bug
o	Updated sx driver for newer generic_serial
o	W83877F watchdog driver
o	ITE8172 IDE driver support
o	Q40/Q60 IDE support
o	Fix nodma handling bug in alim15x3
o	hpt366 DMA blacklist
o	IDE-CD updates
o	Updated IDE DMA blacklist
o	OOPS catch for sg reuse in IDE driver
o	Support formatting of IDE floppies
o	Support PIIX4U4 (851EM)
o	Enable second port on promise pseudo raid
o	Support nodma on pmac
o	Support more PCI irq sharing on IDE
o	IDE tape updates - DI-50 support, 
o	Much updated VIA IDE support
o	video1394 updated to newer module API
o	Support write on the input event driver
o	Quieten mouse and keyboard input drivers
o	Fix compile problem with pc110pad
o	Fix memory leak in isdnppp
o	LVM updates
o	Fix plan b locking
o	Fix saa5249 locking
o	Fix stradis locking
o	Acenic driver updates
o	aironet4500 cleanups, probe tables
o	Ariadne updated to newer API
o	Don't limit mtu to 68+ in arlan drivers
o	Updated eepro100 driver
o	Fix potential crash on downing a bpqether port
o	Updated nsc-ircc driver
o	Updated toshoboe driver
o	Intel Panther LP486e ethernet driver
o	Remove erroneous check in eth_change_mtu
o	Alternative xircom_cb driver
o	Avoid ibm tr being rebuilt each make
o	Updated ibm token ring drivers
o	Add 'static' to bits of ppp code
o	Add pci probe table to roadrunner
o	Fix memory leak in sk_ge
o	sk_g16 updates
o	sk_mca updates
o	Add tools to generate starfire firmware
o	Synclink driver can be compiled in
o	Fix possible oops in lapbether
o	Fix memory leak in lanmedia driver
o	Fix SDLA_X25 warnings
o	Fix syncppp negotiation loop bug
o	GSC parallel port support
o	PCMCIA parallel port support
o	Support PnPBIOS probing for PC parallel ports
o	Fix leak in PCMCIA bulkmem driver
o	Fix leak in PCMCIA ds driver
o	Add more cards to the ti list for the yenta pcmcia
o	Updated 3ware scsi driver
o	NCR 53c700 and 53c700/66 driver core
o	Fix pci_enable/resource read order on buslogic
o	Updated NCR53c8xx driver
o	Updated SYM53c8xx driver
o	Fix NCR53c406 warnings
o	NCR dual MCA driver
o	AIC7xxx pci probe table for hotplug
o	Updated aic7xxx_old
o	Fix resource leaks in dec esp driver
o	Fix printk levels in dmx3191 driver
o	Allow per device max sector counts. (2.4 workaround until 2.5 does
	this in the block layer per device)
o	Support SCSI2/SCSI3 extended LUN numbering
o	Limit qlogicisp and qlogicpti to 64 sectors/write
o	Fix missing EFAULT return in scsi proc
o	Fix locking of scsi_unregister_host
o	Fix leaks in scsi_ioctl
o	Fix potential lost requests in scsi merges
o	Fix leak on write when scsi driver has no proc write op
o	Extend the scsi black/whitelist
o	Fix locking/eject/rescan on removable scsi disk media
o	Updated scsi generic driver
o	Updated scsi cdrom driver
o	Correct ac97 handling on sparc
o	Fix use after kfree in cs4281
o	Update ess solo to new PCI style and PM
o	Update maestro to new PCI style and PM
o	Add docking station support to maestro
o	Update sonicvies to new PCI api
o	Fix trident locking problems
o	Fix buzzing on ymfpci
o	Power management for ymfpci
o	Fix leak/missized copy on xjack driver
o	CDCEther driver
o	ACM driver with fixed CLOCAL
o	Updated USB audio drivers
o	Fix locking/reporting in USB device list
o	Allow dsbr100 to take a radio_nr option
o	HP5300 series USB scanner driver
o	Updated IBM cam driver
o	Fix USB inode locking
o	Driver for Kawasaki based USB ethernet
o	Small ov511 fixes
o	Updated USB storage drivers
o	Entries for Sony MSC-U01N memory stick, Fujifilm FinePix 1400Zoom,
	Casio QV Digial Camera
o	USB Ultracam driver
o	Fix derefence of freed memory in the USB code
o	Generic USB host->host drivers for anchorchip 2270, ipaq, netchip
	1080, and Prolific PL-2301/2
o	Updated ATI frame buffer drivers
o	Updated clgen and control frame buffer drivers
o	Updated cyber2000 driver
o	Documentation for fbcon driver
o	Additional modes for titanium powerbook (1152x768)
o	Updated matrxofb drivers
o	Support __setup in mdacon
o	Radeon console driver
o	Handle out of memory on sun3 fb
o	Updated tga/vesa fb
o	CMS file system (basic R/O)
o	JFFS journalling flash file system with compression
o	Updated AFFS file system
o	Threaded core dumps
o	Fix security holes in binfmt_misc
o	Allow flushing of low buffers only when we need bounce buffers
o	Use brelse in cramfs
o	Fix memory leaks in freevxfs
o	Updated isofs
o	Small lockd updates (experimental)
o	Fix nfs alignment funnies
o	Report correct SuS errors on some opens
o	Add generic_file_open to get 64bit stuff right
o	Locking on make_inode_number for procfs
o	Report shmem size in shared memory proc field
o	Fail lseek outside of allowed range for filesystem
o	Fix select race with fdset growth
o	Kernel message levels and handle oom on superblock/mount ops
o	Updated frame buffer logos
o	Prefetch support for AMD Athlon
o	Support out of order stores in spinlocks on x86
o	m68k bitop compile fixes
o	Add truncatepage op to address operations
o	shmem filesystem cleanups and updates
o	Fix off by one on real time pre-emption in scheduler
o	Use prefetches in scheduler and wakeups
o	Support GFP_FAIL to avoid highmem deadlocks
 
---
Alan Cox <alan@lxorguk.ukuu.org.uk>
Red Hat Kernel Hacker
& Linux 2.2 Maintainer                        Brainbench MVP for TCP/IP
http://www.linux.org.uk/diary                 http://www.brainbench.com

Re: Linux 2.4.5-ac9

[Keith Owens]

On Tue, 5 Jun 2001 23:49:29 +0100, 
Alan Cox <laughing@shared-source.org> wrote:
>o	Fix gameport link problems			(Vojtech Pavlik)

Adds CONFIG_INPUT_GAMEPORT and CONFIG_INPUT_SERIO with no Configure.help.

Re: Linux 2.4.5-ac9

[David Ford]

2.4.5-ac8 has a brokenness about it.

sshd stalled in [down] with the following, subsequent sshd attempts 
which needed a tty resulted in D state the same as the first:

invalid operand: 0000
CPU:    0
EIP:    0010:[<c01269f9>]
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010086
eax: 0000001b   ebx: c13bf768   ecx: c0345060   edx: 00002c76
esi: c0a54000   edi: c0a549aa   ebp: c0a549aa   esp: c57afe54
ds: 0018   es: 0018   ss: 0018
Process sshd (pid: 3627, stackpage=c57af000)
Stack: c02cab45 000004dc 00000000 0000800a c03dc900 c03dc900 00001000 
00000246
       c01b1021 00000c3c 00000007 c03dc900 c01b1c43 0000000a c03dc900 
c03dc900
       00000000 c13c9e50 0000000a 00000000 00000000 00000000 00000000 
c13c9e50
Call Trace: [<c01b1021>] [<c01b1c43>] [<c01b2643>] [<c0137fc0>] 
[<c0138871>]
   [<c0167ccb>] [<c012e389>] [<c012e2c2>] [<c012e5b0>] [<c0106a93>]
Code: 0f 0b 83 c4 08 89 f6 f6 43 11 04 74 51 b8 a5 c2 0f 17 87 06

 >>EIP; c01269f9 <proc_getdata+4d/154>   <=====
Trace; c01b1021 <read_eeprom+131/1a8>
Trace; c01b1c43 <rtl8139_tx_timeout+143/148>
Trace; c01b2643 <rtl8139_interrupt+5f/170>
Trace; c0137fc0 <__emul_lookup_dentry+a4/fc>
Trace; c0138871 <open_namei+4d1/560>
Trace; c0167ccb <leaf_define_dest_src_infos+1a7/1ac>
Trace; c012e389 <do_readv_writev+15d/228>
Trace; c012e2c2 <do_readv_writev+96/228>
Trace; c012e5b0 <sys_pread+bc/d0>
Trace; c0106a93 <system_call+23/40>
Code;  c01269f9 <proc_getdata+4d/154>
00000000 <_EIP>:
Code;  c01269f9 <proc_getdata+4d/154>   <=====
   0:   0f 0b                     ud2a      <=====
Code;  c01269fb <proc_getdata+4f/154>
   2:   83 c4 08                  add    $0x8,%esp
Code;  c01269fe <proc_getdata+52/154>
   5:   89 f6                     mov    %esi,%esi
Code;  c0126a00 <proc_getdata+54/154>
   7:   f6 43 11 04               testb  $0x4,0x11(%ebx)
Code;  c0126a04 <proc_getdata+58/154>
   b:   74 51                     je     5e <_EIP+0x5e> c0126a57 
<proc_getdata+ab/154>
Code;  c0126a06 <proc_getdata+5a/154>
   d:   b8 a5 c2 0f 17            mov    $0x170fc2a5,%eax
Code;  c0126a0b <proc_getdata+5f/154>
  12:   87 06                     xchg   %eax,(%esi)


Alan Cox wrote:

>	ftp://ftp.kernel.org/pub/linux/kernel/people/alan/2.4/
>
>		 Intermediate diffs are available from
>			http://www.bzimage.org
>
>In terms of going through the code audit almost all the sound drivers still 
>need fixing to lock against format changes during a read/write. Poll creating 
>and starting a buffer as write does and also mmap during write, write during
>an mmap.
>
>2.4.5-ac9
>

Re: Linux 2.4.5-ac9

[Jeff Garzik]

David Ford wrote:
>  >>EIP; c01269f9 <proc_getdata+4d/154>   <=====
> Trace; c01b1021 <read_eeprom+131/1a8>
> Trace; c01b1c43 <rtl8139_tx_timeout+143/148>
> Trace; c01b2643 <rtl8139_interrupt+5f/170>
> Trace; c0137fc0 <__emul_lookup_dentry+a4/fc>
> Trace; c0138871 <open_namei+4d1/560>
> Trace; c0167ccb <leaf_define_dest_src_infos+1a7/1ac>
> Trace; c012e389 <do_readv_writev+15d/228>
> Trace; c012e2c2 <do_readv_writev+96/228>

This trace looks corrupted to me... are you sure that System.map for the
crashed kernel matches -exactly- with the one ksymoops used to decode
this?  It uses /proc/ksyms by default, which is incorrect for most
postmortem ksymoops runs...

rtl8139_interrupt doesn't call tx_timeout, which doesn't call
read_eeprom, which doesn't call proc_getdata.

-- 
Jeff Garzik      | An expert is one who knows more and more about
Building 1024    | less and less until he knows absolutely everything
MandrakeSoft     | about nothing.

Re: Linux 2.4.5-ac9

[David Ford]

Quite positive it's the right map file.  I used -m and specified the 
exact file.

David

Jeff Garzik wrote:

>David Ford wrote:
>
>> >>EIP; c01269f9 <proc_getdata+4d/154>   <=====
>>Trace; c01b1021 <read_eeprom+131/1a8>
>>Trace; c01b1c43 <rtl8139_tx_timeout+143/148>
>>Trace; c01b2643 <rtl8139_interrupt+5f/170>
>>Trace; c0137fc0 <__emul_lookup_dentry+a4/fc>
>>Trace; c0138871 <open_namei+4d1/560>
>>Trace; c0167ccb <leaf_define_dest_src_infos+1a7/1ac>
>>Trace; c012e389 <do_readv_writev+15d/228>
>>Trace; c012e2c2 <do_readv_writev+96/228>
>>
>
>This trace looks corrupted to me... are you sure that System.map for the
>crashed kernel matches -exactly- with the one ksymoops used to decode
>this?  It uses /proc/ksyms by default, which is incorrect for most
>postmortem ksymoops runs...
>
>rtl8139_interrupt doesn't call tx_timeout, which doesn't call
>read_eeprom, which doesn't call proc_getdata.
>

Re: Linux 2.4.5-ac9

[Keith Owens]

On Tue, 05 Jun 2001 21:55:39 -0700, 
David Ford <david@blue-labs.org> wrote:
>Quite positive it's the right map file.  I used -m and specified the 
>exact file.
>
>Jeff Garzik wrote:
>
>>David Ford wrote:
>>
>>> >>EIP; c01269f9 <proc_getdata+4d/154>   <=====
>>>Trace; c01b1021 <read_eeprom+131/1a8>
>>
>>This trace looks corrupted to me... are you sure that System.map for the
>>crashed kernel matches -exactly- with the one ksymoops used to decode
>>this?

The trace definitely looks suspect, I cannot see any BUG() calls in
proc_getdata(), even looking at the object code.

Does
  objdump --start-address=0xc01269f9 --stop-address=0xc0126a10 vmlinux
show the same code bytes, starting with ud2a?  I will be surprised if
it does.  If it does not then you definitely have the wrong System.map
for the oops.

Re: SCSI is as SCSI don't...

[Greg KH]

On Tue, Jun 05, 2001 at 11:08:04PM -0700, Alan Olsen wrote:
> The basic effect is that the kernel will not load.  Something breaks hard
> in it.

Any clue on what the last thing printed to the kernel log is?
Hardware you have?
.config for the kernel?

Come on Alan, I know you can give better bug reports than that :)

greg k-h

SCSI is as SCSI don't...

[Alan Olsen]

I am trying to get 2.4.5 and/or 2.4.5-ac9 working.  Both are choking on
compile with an odd error message or four...

In file included from /usr/src/linux-2.4.5-ac9/include/linux/raid/md.h:50,
                 from ll_rw_blk.c:30:
/usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h: In function
`pers_to_level':/usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h:41:
warning: control reaches end of non-void function

I am seeing similar messages in the AIC7xxx code.

The basic effect is that the kernel will not load.  Something breaks hard
in it.

My C is pretty rusty. (Too much IS work as of late...)  Does anyone know
what this message is and why it is occuring?

I am currently using 2.4.4-ac11 and it does not have this problem.  

My reason for upgrading is that cdrecord gave me the following error, and
I was hoping that 2.4.5 would have fixed it...

Starting new track at sector: 0
CDB:  2A 00 00 00 9E FF 00 00 1F 80
cdrecord: Input/output error. write_teac_g1: scsi sendcmd: retryable error
Sense Bytes: 70 00 0B 00 00 00 00 0A 00 00 00 01 BA 00 00 00
status: 0x2 (CHECK CONDITION)
Sense Key: 0xB Aborted Command, Segment 0
Sense Code: 0xBA Qual 0x00 (no write data - buffer empty) Fru 0x0
Sense flags: Blk 0 (not valid)

cdrecord: Input/output error. write_teac_g1: scsi sendcmd: retryable error
write track data: error after 83359744 bytes
status: 0x2 (CHECK CONDITION)
Sense Bytes: 70 00 00 00 00 00 00 0A 00 00 00 00 00 00 00 00 00 00
WARNING: adding dummy block to close track.
CDB:  2A 00 00 00 9E FF 00 00 01 00
Sense Bytes: 70 00 0B 00 00 00 00 0A 00 00 00 01 BA 00 00 00
Sense Key: 0xB Aborted Command, Segment 0
Sense Code: 0xBA Qual 0x00 (no write data - buffer empty) Fru 0x0
Sense flags: Blk 0 (not valid)

Ideas...?  (At least it give me time to finish Linus's autobiography while
I am rebuilding things, but I am quickly running out of book. ]:> )

alan@ctrl-alt-del.com | Note to AOL users: for a quick shortcut to reply
Alan Olsen            | to my mail, just hit the ctrl, alt and del keys.
    "In the future, everything will have its 15 minutes of blame."

Re: SCSI is as SCSI don't...

[Alan Olsen]

Forgot to list my working environment...

Redhat 7.1 patched to pretty close to the latest. (As of a week ago or
so.) P-III 600 with 256 megs of ram and lots of disk, so resource
starvation is not an issue.  (Unless something got REALLY big in the last
few patches.)

On Tue, 5 Jun 2001, Alan Olsen wrote:

> I am trying to get 2.4.5 and/or 2.4.5-ac9 working.  Both are choking on
> compile with an odd error message or four...
> 
> In file included from /usr/src/linux-2.4.5-ac9/include/linux/raid/md.h:50,
>                  from ll_rw_blk.c:30:
> /usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h: In function
> `pers_to_level':/usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h:41:
> warning: control reaches end of non-void function
> 
> I am seeing similar messages in the AIC7xxx code.
> 
> The basic effect is that the kernel will not load.  Something breaks hard
> in it.
> 
> My C is pretty rusty. (Too much IS work as of late...)  Does anyone know
> what this message is and why it is occuring?
> 
> I am currently using 2.4.4-ac11 and it does not have this problem.  
> 
> My reason for upgrading is that cdrecord gave me the following error, and
> I was hoping that 2.4.5 would have fixed it...
> 
> Starting new track at sector: 0
> CDB:  2A 00 00 00 9E FF 00 00 1F 80
> cdrecord: Input/output error. write_teac_g1: scsi sendcmd: retryable error
> Sense Bytes: 70 00 0B 00 00 00 00 0A 00 00 00 01 BA 00 00 00
> status: 0x2 (CHECK CONDITION)
> Sense Key: 0xB Aborted Command, Segment 0
> Sense Code: 0xBA Qual 0x00 (no write data - buffer empty) Fru 0x0
> Sense flags: Blk 0 (not valid)
> 
> cdrecord: Input/output error. write_teac_g1: scsi sendcmd: retryable error
> write track data: error after 83359744 bytes
> status: 0x2 (CHECK CONDITION)
> Sense Bytes: 70 00 00 00 00 00 00 0A 00 00 00 00 00 00 00 00 00 00
> WARNING: adding dummy block to close track.
> CDB:  2A 00 00 00 9E FF 00 00 01 00
> Sense Bytes: 70 00 0B 00 00 00 00 0A 00 00 00 01 BA 00 00 00
> Sense Key: 0xB Aborted Command, Segment 0
> Sense Code: 0xBA Qual 0x00 (no write data - buffer empty) Fru 0x0
> Sense flags: Blk 0 (not valid)
> 
> Ideas...?  (At least it give me time to finish Linus's autobiography while
> I am rebuilding things, but I am quickly running out of book. ]:> )
> 
> alan@ctrl-alt-del.com | Note to AOL users: for a quick shortcut to reply
> Alan Olsen            | to my mail, just hit the ctrl, alt and del keys.
>     "In the future, everything will have its 15 minutes of blame."
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

alan@ctrl-alt-del.com | Note to AOL users: for a quick shortcut to reply
Alan Olsen            | to my mail, just hit the ctrl, alt and del keys.
    "In the future, everything will have its 15 minutes of blame."

Re: SCSI is as SCSI don't...

[Alan Cox]

> I am trying to get 2.4.5 and/or 2.4.5-ac9 working.  Both are choking on
> compile with an odd error message or four...
> 
> In file included from /usr/src/linux-2.4.5-ac9/include/linux/raid/md.h:50,
>                  from ll_rw_blk.c:30:
> /usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h: In function
> `pers_to_level':/usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h:41:
> warning: control reaches end of non-void function

That is just a warning caused by a C compiler bug and harmless. The sg case
you report I've seen random variants of caused by burner bugs, software bugs
and scsi layer bugs - I dont know what it would be and you didnt give enough
info

Re: SCSI is as SCSI don't...

[Alan Olsen]

On Tue, 5 Jun 2001, Greg KH wrote:

> On Tue, Jun 05, 2001 at 11:08:04PM -0700, Alan Olsen wrote:
> > The basic effect is that the kernel will not load.  Something breaks hard
> > in it.
> 
> Any clue on what the last thing printed to the kernel log is?
> Hardware you have?
> .config for the kernel?
> 
> Come on Alan, I know you can give better bug reports than that :)

it has been a long day...

Actually it did not get much past the lilo prompt.

I will add more debugging options and try again after I get more sleep.

alan@ctrl-alt-del.com | Note to AOL users: for a quick shortcut to reply
Alan Olsen            | to my mail, just hit the ctrl, alt and del keys.
    "In the future, everything will have its 15 minutes of blame."

Re: Linux 2.4.5-ac9

[Thomas Sailer]

Alan Cox schrieb:

> 2.4.5-ac9
> o       Add es1371 sound driver locking                 (Frank Davis)

Looks bogus. Independent processes can open the same device
once for reading and once for writing, now you are serializing
needlessly these processes. Please revert.

Tom

Re: Linux 2.4.5-ac9

[Christoph Hellwig]

In article <20010605234928.A28971@lightning.swansea.linux.org.uk> you wrote:
> 2.4.5-ac9

> o	Add es1371 sound driver locking			(Frank Davis)

It's buggy.  The locking in ->read and ->write will give
double ups when a signal is pending and remove a not added waitq
when programming the dmabuf fails.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.

Re: Linux 2.4.5-ac9

[Thomas Sailer]

Christoph Hellwig schrieb:
> 
> In article <20010605234928.A28971@lightning.swansea.linux.org.uk> you wrote:
> > 2.4.5-ac9
> 
> > o     Add es1371 sound driver locking                 (Frank Davis)
> 
> It's buggy.  The locking in ->read and ->write will give
> double ups when a signal is pending and remove a not added waitq
> when programming the dmabuf fails.

But Alan added a different patch than yours, that doesn't
seem to have poll in the guard.

Also, both your and Frank Davis' patch don't care about dac, which
seems bogus to me.

Tom

Re: Linux 2.4.5-ac9

[Christoph Hellwig]

On Wed, Jun 06, 2001 at 01:41:31PM +0200, Thomas Sailer wrote:
> Christoph Hellwig schrieb:
> > 
> > In article <20010605234928.A28971@lightning.swansea.linux.org.uk> you wrote:
> > > 2.4.5-ac9
> > 
> > > o     Add es1371 sound driver locking                 (Frank Davis)
> > 
> > It's buggy.  The locking in ->read and ->write will give
> > double ups when a signal is pending and remove a not added waitq
> > when programming the dmabuf fails.
> 
> But Alan added a different patch than yours,

Mine got _that_ right.

> that doesn't seem to have poll in the guard.
> 
> Also, both your and Frank Davis' patch don't care about dac, which
> seems bogus to me.

Yepp.

-- 
Of course it doesn't work. We've performed a software upgrade.

RE: Linux 2.4.5-ac9

[Chris Liebman]

I've just tried the orinoco_cs driver with my "Orinoco Gold" pcmcia card in
hopes that I could use this instead of having to rebuild the pcmcia-cs
package everytime I try a new kernel...  I am seeing the following messages:

NETDEV WATCHDOG: eth1: transmit timed out
eth1: Tx timeout! Resetting card.

and:

hermes_read_ltv(): rid  (0xfc28) does not match type (0xfc27)
hermes_read_ltv(): rid  (0xfd10) does not match type (0xfc28)
hermes_read_ltv(): rid  (0xfd20) does not match type (0xfd10)
hermes_read_ltv(): rid  (0xfd41) does not match type (0xfd20)
hermes_read_ltv(): rid  (0xfd42) does not match type (0xfd41)
hermes_read_ltv(): rid  (0xfd43) does not match type (0xfd42)
hermes_read_ltv(): rid  (0xfd44) does not match type (0xfd43)
hermes_read_ltv(): rid  (0xfd4f) does not match type (0xfd44)
hermes_read_ltv(): rid  (0xfdc1) does not match type (0xfd4f)
hermes_read_ltv(): rid  (0xfdc6) does not match type (0xfdc1)

any ideas?

[liebman@xyzzy kernel]$ cat /proc/hermes/eth1/recs
PORTTYPE        (0xfc00): length=2 (2 bytes)    value=0001
MACADDR         (0xfc01): length=4 (6 bytes)    value=00:02:2D:1B:5C:7E
DESIRED_SSID    (0xfc02): length=18 (34 bytes)  value="xyzzy"
CHANNEL         (0xfc03): length=2 (2 bytes)    value=0000
OWN_SSID        (0xfc04): length=18 (34 bytes)  value="non-specified SSID
!!"
SYSTEM_SCALE    (0xfc06): length=2 (2 bytes)    value=0001
MAX_DATA_LEN    (0xfc07): length=2 (2 bytes)    value=0900
PM_ENABLE       (0xfc09): length=2 (2 bytes)    value=0000
PM_MCAST_RX     (0xfc0b): length=2 (2 bytes)    value=0001
PM_PERIOD       (0xfc0c): length=2 (2 bytes)    value=0064
NICKNAME        (0xfc0e): length=18 (34 bytes)  value="xyzzy.zod.com"
WEP_ON          (0xfc20): length=2 (2 bytes)    value=0001
MWO_ROBUST      (0xfc25): length=2 (2 bytes)    value=0000
MULTICAST_LIST  (0xfc80): length=4 (6 bytes)    value=01:00:5E:00:00:01
CREATEIBSS      (0xfc81): length=2 (2 bytes)    value=0001
FRAG_THRESH     (0xfc82): length=0 (-2 bytes)   value
RTS_THRESH      (0xfc83): length=2 (2 bytes)    value=092B
TX_RATE_CTRL    (0xfc84): length=2 (2 bytes)    value=0003
PROMISCUOUS     (0xfc85): length=2 (2 bytes)    value=0000
KEYS            (0xfcb0): length=0 (-2 bytes)   value
TX_KEY          (0xfcb1): length=2 (2 bytes)    value=0000
TICKTIME        (0xfce0): length=2 (2 bytes)    value=000A
PRISM2_TX_KEY   (0xfc23): length=2 (2 bytes)    value=0002
PRISM2_KEY0     (0xfc24): length=0 (-2 bytes)   value
PRISM2_KEY1     (0xfc25): length=2 (2 bytes)    value=00:00
PRISM2_KEY2     (0xfc26): length=0 (-2 bytes)   value
PRISM2_KEY3     (0xfc27): length=0 (-2 bytes)   value
PRISM2_WEP_ON   (0xfc28): length=0 (-2 bytes)   value
CHANNEL_LIST    (0xfd10): length=2 (2 bytes)    value=07FF
STAIDENTITY     (0xfd20): length=5 (8 bytes)    value=001F-0001-0006-0010
CURRENT_SSID    (0xfd41): length=18 (34 bytes)  value="xyzzy"
CURRENT_BSSID   (0xfd42): length=4 (6 bytes)    value=02:02:2D:06:30:06
COMMSQUALITY    (0xfd43): length=4 (6 bytes)    value=0000-001B-001B
CURRENT_TX_RATE (0xfd44): length=2 (2 bytes)    value=0002
WEP_AVAIL       (0xfd4f): length=2 (2 bytes)    value=0001
CURRENT_CHANNEL (0xfdc1): length=2 (2 bytes)    value=0003
DATARATES       (0xfdc6): length=6 (10 bytes)
value=04:00:02:04:0B:16:00:00:00:00

	-- Chris

Re: Linux 2.4.5-ac9

[Tom Sightler]

> 2.4.5-ac9

> o Fix xircom_cb problems with some cisco kit (Ion Badulescu)

I'm not sure what this is supposed to fix, but it makes my Xircom
RBEM56G-100 almost useless on my network at the office.  Actually, I can't
quite blame just this patch, it only makes the problem worse, the driver
from 2.4.5-ac3 worked, but with 1 second ping times, the new driver barely
works at all, it seems to think the link is not there, at least not enough
to pull an IP address.

The last driver that worked moderately well for me was the one from
2.4.4-ac11, it still had a few issues, mostly when resuming, but everything
worked at home on my 10Mb hub, and at the office on my 10/100Mb FD Cisco
6509.  I must admist that I haven't tested every version in between.

One other note, the version in 2.4.4-ac11 is listed as 1.33 while the
version in 2.4.5-ac9 is 1.11, why did we go backwards?  Were there
significant problems with the newer version?  The 1.33 sure seems to work
better for me.

Later,
Tom

Re: Linux 2.4.5-ac9

[Alan Cox]

> Looks bogus. Independent processes can open the same device
> once for reading and once for writing, now you are serializing
> needlessly these processes. Please revert.

Some of the serializing is not a bug but I agree that patch is not yet
right. Think for example about


		thread1			thread2

	write
		blocks			 mmap

Also parallel buffer allocations 

Alan

Re: Linux 2.4.5-ac9

[Ion Badulescu]

On Wed, 6 Jun 2001 13:20:41 -0400, Tom Sightler <ttsig@tuxyturvy.com> wrote:
>> 2.4.5-ac9
> 
>> o Fix xircom_cb problems with some cisco kit (Ion Badulescu)
> 
> I'm not sure what this is supposed to fix, but it makes my Xircom
> RBEM56G-100 almost useless on my network at the office.  Actually, I can't
> quite blame just this patch, it only makes the problem worse, the driver
> from 2.4.5-ac3 worked, but with 1 second ping times, the new driver barely
> works at all, it seems to think the link is not there, at least not enough
> to pull an IP address.

The patch does only one thing: it instructs the card not to negotiate
full-duplex modes, because (for undocumented and yet unexplained reasons)
full-duplex modes don't work well on this card.

If you had problems before, then their cause is most likely elsewhere.
1-second ping time is definitely wrong.

> The last driver that worked moderately well for me was the one from
> 2.4.4-ac11, it still had a few issues, mostly when resuming, but everything
> worked at home on my 10Mb hub, and at the office on my 10/100Mb FD Cisco
> 6509.  I must admist that I haven't tested every version in between.

The thing is, I don't really see any significant differences between the
2.4.4-ac11 driver and the 2.4.5-ac9 driver. I see lots of clean-ups, some
power management stuff, and the half-duplex stuff. None of them should
affect the core functionality directly..

Please do me a favor: comment out the call to set_half_duplex() (in
xircom_up), recompile and see if it makes a difference.

> One other note, the version in 2.4.4-ac11 is listed as 1.33 while the
> version in 2.4.5-ac9 is 1.11, why did we go backwards?  Were there
> significant problems with the newer version?  The 1.33 sure seems to work
> better for me.

The CVS version is almost irrelevant, I guess Arjan simply rebuild his
repository.

Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.

Re: Linux 2.4.5-ac9

[arjan]

In article <002e01c0eead$03c6d890$26040a0a@zeusinc.com> you wrote:
>> 2.4.5-ac9

>> o Fix xircom_cb problems with some cisco kit (Ion Badulescu)

> One other note, the version in 2.4.4-ac11 is listed as 1.33 while the
> version in 2.4.5-ac9 is 1.11, why did we go backwards?  Were there
> significant problems with the newer version?  The 1.33 sure seems to work
> better for me.

It went backwards because I switched from my local CVS repository to the
tulip driver one.

I appologize for the driver not working as well as expected, and will try to
find a way to make it work for everyone .

Greetings,
   Arjan van de Ven

Re: SCSI is as SCSI don't...

[Alan Olsen]

On Wed, 6 Jun 2001, Alan Cox wrote:

> > I am trying to get 2.4.5 and/or 2.4.5-ac9 working.  Both are choking on
> > compile with an odd error message or four...
> > 
> > In file included from /usr/src/linux-2.4.5-ac9/include/linux/raid/md.h:50,
> >                  from ll_rw_blk.c:30:
> > /usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h: In function
> > `pers_to_level':/usr/src/linux-2.4.5-ac9/include/linux/raid/md_k.h:41:
> > warning: control reaches end of non-void function
> 
> That is just a warning caused by a C compiler bug and harmless. The sg case
> you report I've seen random variants of caused by burner bugs, software bugs
> and scsi layer bugs - I dont know what it would be and you didnt give enough
> info

Sorry.

The boot problems I believe were caused by "kernel building under the
influence of sleep deprivation".  I rebuilt and things are working fine.

I have added extra SCSI and kernel debugging to try and track down the
issues with the burner software.  (It has been pretty stable up until now.
At least it is not burning weird hallucinatory things to disc, like one of
the previous version did.  Just glad I found out before burning backups.)

Sorry for the non-error and even more worthless bug report. (I need more
caffiene...)

However, the compile problem with 2.4.5-ac9 seems real enough.  The link
problems do not go away until I build in the joystick drivers into the
kernel. (Building them as modules did not work, but may have been a
mismatch between the joystick support built in to the kernel and the
drivers built as modules.)

Thanks for the quick reply.

alan@ctrl-alt-del.com | Note to AOL users: for a quick shortcut to reply
Alan Olsen            | to my mail, just hit the ctrl, alt and del keys.
 "All power is derived from the barrel of a gnu." - Mao Tse Stallman

xircom_cb problems

[Tom Sightler]

> The patch does only one thing: it instructs the card not to negotiate
> full-duplex modes, because (for undocumented and yet unexplained
> reasons)
> full-duplex modes don't work well on this card.
> 
> If you had problems before, then their cause is most likely elsewhere.
> 1-second ping time is definitely wrong.

Well, I compiled the driver from 2.4.4-ac11, 2.4.5-ac3, and 2.4.5-ac9 all with
the exact same source from 2.4.5-ac9, and my problems are 100% repeatable on my
hardware.

At home where I have a 10Mb half-duplex hub connection all of the drivers work
properly.

At work where I have a 10/100Mb full-duplex switch connection the drivers work
exactly as I described before:

2.4.4-ac11 -- mostly works fine -- minor problems awaking from sleep

2.4.5-ac3 -- seems to work but pings are >1 second (yes really a full second)

2.4.5-ac9 -- keeps logging "Link is absent" then "Linux is 100 mbit" over and
over when trying to pull an IP address via dhcp using pump or dhcpcd. 
Interestingly manually setting an IP address seems to work fine with this driver.

> The thing is, I don't really see any significant differences between
> the
> 2.4.4-ac11 driver and the 2.4.5-ac9 driver. I see lots of clean-ups,
> some
> power management stuff, and the half-duplex stuff. None of them should
> affect the core functionality directly..

I looked at this before posting, and generally agree, but the results are 100%
reproducable on my machine as listed above, so they must be having some affect.
 My current working system is 2.4.5-ac9 with the driver source from 2.4.4-ac11
recomiled for it and it's working great (minor resume problems aside).

> Please do me a favor: comment out the call to set_half_duplex() (in
> xircom_up), recompile and see if it makes a difference.

I'll do this tomorrow morning when I get in and report back.  Thanks for the
help, I'd really like to see this card get stable as we have it in a lot of our
laptops here at work.

> > One other note, the version in 2.4.4-ac11 is listed as 1.33 while
> the
> > version in 2.4.5-ac9 is 1.11, why did we go backwards?  Were there
> > significant problems with the newer version?  The 1.33 sure seems to
> work
> > better for me.
> 
> The CVS version is almost irrelevant, I guess Arjan simply rebuild his
> repository.

And you would be correct as Arjan confirmed in a follow up messages, sorry about
that, it just looked strange.

Thanks for the help,
Tom

Re: xircom_cb problems

[Ion Badulescu]

On Wed, 6 Jun 2001, Tom Sightler wrote:

> At home where I have a 10Mb half-duplex hub connection all of the drivers work
> properly.

All right, that's expected.

> At work where I have a 10/100Mb full-duplex switch connection the drivers work
> exactly as I described before:
> 
> 2.4.4-ac11 -- mostly works fine -- minor problems awaking from sleep

Can you run some performance testing with this driver, though? The speed
of ftp transfers in both directions would be a good measure. The reason
I'm asking is because we saw really poor performance on 100Mb full-duplex,
something like 200-300KB/s when receiving.

> 2.4.5-ac9 -- keeps logging "Link is absent" then "Linux is 100 mbit" over and
> over when trying to pull an IP address via dhcp using pump or dhcpcd. 

pump likes to bring the interface up and down and up and down, so those 
messages are not necessarily unusual.

Hmm. I have an idea though. In set_half_duplex, we shouldn't touch the MII 
if the new autoneg value is the same as the old one. It should certainly 
help with things like pump. Arjan, what do you think?

> Interestingly manually setting an IP address seems to work fine with
> this driver.

That's very good to know. So most likely the repeated up/down that pump's 
doing is upsetting the card.

> I'll do this tomorrow morning when I get in and report back.  Thanks
> for the help, I'd really like to see this card get stable as we have
> it in a lot of our laptops here at work.

And we'd like to thank you for your patience and for your help diagnosing 
the problem. Let's hope we can solve it quickly..

I'm attaching a small patch that does what I proposed above -- can you 
give it a try as well?

Thanks,
Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.
------------------------
--- linux-2.4-ac/drivers/net/pcmcia/xircom_cb.c.old	Thu Jun  7 01:27:07 2001
+++ linux-2.4-ac/drivers/net/pcmcia/xircom_cb.c	Thu Jun  7 01:28:13 2001
@@ -1092,13 +1092,15 @@
 
 	/* tell the MII not to advertise 10/100FDX */
 	tmp = mdio_read(card, 0, 4);
-	printk("xircom_cb: capabilities changed from %#x to %#x\n",
-	       tmp, tmp & ~0x140);
-	tmp &= ~0x140;
-	mdio_write(card, 0, 4, tmp);
-	/* restart autonegotiation */
-	tmp = mdio_read(card, 0, 0);
-	mdio_write(card, 0, 0, tmp | 0x1200);
+	if (tmp != tmp & ~0x140) {
+		printk("xircom_cb: capabilities changed from %#x to %#x\n",
+		       tmp, tmp & ~0x140);
+		tmp &= ~0x140;
+		mdio_write(card, 0, 4, tmp);
+		/* restart autonegotiation */
+		tmp = mdio_read(card, 0, 0);
+		mdio_write(card, 0, 0, tmp | 0x1200);
+	}
 
 	if (rx)
 		activate_receiver(card);

Re: xircom_cb problems

[Tom Sightler]

Quoting Ion Badulescu <ionut@cs.columbia.edu>:

> > 2.4.4-ac11 -- mostly works fine -- minor problems awaking from sleep
> 
> Can you run some performance testing with this driver, though? The
> speed
> of ftp transfers in both directions would be a good measure. The
> reason
> I'm asking is because we saw really poor performance on 100Mb
> full-duplex,
> something like 200-300KB/s when receiving.

OK, I did some simple FTP benchmarking, transferring a 100MB to and from my 
laptop connected to a Cisco Catalyst 6509.  The other systems were a PIII 
700Mhz UP with eepro100 NIC running 2.4.2-ac11, and a PIII 1Ghz SMP (2 proc) 
with Alteon Gigabit NIC running 2.2.19.

Transferring files between the eepro100 machine running 2.4.2-ac11 and my 
laptop produced a result of 2.24MB/s for sending and 2.13MB/s recieving the 
file.

Transfering files between the Alteon Gigabit machine running 2.2.19 and my 
laptop resulted in the dismal numbers of 249KB/s sending and 185KB/s recieving, 
close to the numbers you quoted above, but actually slightly worse.

I'm not sure what would explain the 2.2.19 1GB conencted box being 10x slower 
than the 2.4.2-ac11 100MB machine.

Transferring the same file between the two other boxes gives 9.81MB/s which is 
near the theoretical maximum for 100Mb.

> > 2.4.5-ac9 -- keeps logging "Link is absent" then "Linux is 100 mbit"
> over and
> > over when trying to pull an IP address via dhcp using pump or dhcpcd.
> 
> 
> pump likes to bring the interface up and down and up and down, so those
> 
> messages are not necessarily unusual.

Yea, I've actually complained of this before, the interface up/down things that 
pump does makes it very tough to use on a large network with full spanning tree 
as pump brings the interface down and up again right about the time spanning 
tree puts the port into forwarding mode.  I can get around this by setting 
Cisco's portfast feature, but doing that on all ports somewhat defeats the 
purpose of spanning tree and I move my laptop a lot.
 
> Hmm. I have an idea though. In set_half_duplex, we shouldn't touch the
> MII 
> if the new autoneg value is the same as the old one. It should certainly
> 
> help with things like pump. Arjan, what do you think?
> 
> > Interestingly manually setting an IP address seems to work fine with
> > this driver.
> 
> That's very good to know. So most likely the repeated up/down that
> pump's 
> doing is upsetting the card.

Commenting out the set_half_duplex made the driver in 2.4.5-ac9 work with DHCP 
again so your probably right.
 
I'll apply your patch with the change to MII handling and rerun some simple 
file transfers and report the results soon.

Thanks,
Tom

Re: xircom_cb problems

[Ion Badulescu]

On Thu, 7 Jun 2001, Tom Sightler wrote:

> Transferring files between the eepro100 machine running 2.4.2-ac11 and my 
> laptop produced a result of 2.24MB/s for sending and 2.13MB/s recieving the 
> file.
> 
> Transfering files between the Alteon Gigabit machine running 2.2.19 and my 
> laptop resulted in the dismal numbers of 249KB/s sending and 185KB/s recieving, 
> close to the numbers you quoted above, but actually slightly worse.
> 
> I'm not sure what would explain the 2.2.19 1GB conencted box being 10x slower 
> than the 2.4.2-ac11 100MB machine.

Both of these are slow, actually. I'm getting 7.5-8MB/s when receiving 
from a 100Mbit box (tulip or starfire, doesn't seem to matter). 
Transmitting is still slow for me, but that is most likely a different 
problem -- and I'm looking into it.

Moreover, I'm getting 9+MB/s in both directions when using the other 
driver (xircom_tulip_cb), patched to do half-duplex only. So the card can 
definitely transfer at network speeds.

> I'll apply your patch with the change to MII handling and rerun some simple 
> file transfers and report the results soon.

Looking forward to seeing them...

Thanks,
Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.

Re: xircom_cb problems

[Tom Sightler]

> Both of these are slow, actually. I'm getting 7.5-8MB/s when receiving
> from a 100Mbit box (tulip or starfire, doesn't seem to matter). 
> Transmitting is still slow for me, but that is most likely a different 
> problem -- and I'm looking into it.

Yeah, I knew they were both slow, but at least one is acceptable, the <200KB/s
is below usable when doing any network based work.

> Moreover, I'm getting 9+MB/s in both directions when using the other 
> driver (xircom_tulip_cb), patched to do half-duplex only. So the card
> can definitely transfer at network speeds.

I'm not doing nearly as well with the other driver, but I don't have it patched
for half-duplex only.  I tried setting the remote end to force half-duplex but
this didn't seem to work quite right.


> Looking forward to seeing them...

OK, I tried your patch, it did fix the problem where pump wouldn't pull an IP
address, but I'm still having the problem where my ping times go nuts.  I've
attached an example, it's 100% repeatable on my network at work.  It was so bad
I couldn't get any benchmark numbers.

Later,
Tom

Re: xircom_cb problems

[Ion Badulescu]

On Fri, 8 Jun 2001, Tom Sightler wrote:

> OK, I tried your patch, it did fix the problem where pump wouldn't
> pull an IP address, but I'm still having the problem where my ping
> times go nuts.  I've attached an example, it's 100% repeatable on my
> network at work.  It was so bad I couldn't get any benchmark numbers.

Just one more question: do you see the same bad ping times if you
completely comment out the call to set_half_duplex?

Thanks,
Ion

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.

Re: xircom_cb problems

[Tom Sightler]

Quoting Ion Badulescu <ionut@cs.columbia.edu>:

> On Fri, 8 Jun 2001, Tom Sightler wrote:
> 
> > OK, I tried your patch, it did fix the problem where pump wouldn't
> > pull an IP address, but I'm still having the problem where my ping
> > times go nuts.  I've attached an example, it's 100% repeatable on my
> > network at work.  It was so bad I couldn't get any benchmark
> numbers.
> 
> Just one more question: do you see the same bad ping times if you
> completely comment out the call to set_half_duplex?

No, the problem goes away if I do this, although then I hae the performance
problems as before.  I also noticed that even when the call to set_half_duplex
is left in, the switch reports that the link is still in full duplex, 100Mb
mode.  I tried forcing half duplex on the switch but this didn't help.  It
actually looks like half duplex is not really being set correctly.

I plugged in a desktop with an eepro100 based card and forced the duplex to half
with the command line options and the switch properly reported a half-duplex
link had been negotiated, with the xircom card the switch reports full-duplex
with or without the set_half_duplex line, which certainly implies it's not
really working right.

Hope the helps.  I won't be back at the office until Monday so that's the
earliest I'll be able to test again, but I'll be glad to test any combination
that I can.

Later,
Tom

Re: xircom_cb problems

[Arjan van de Ven]

Tom Sightler wrote:
> 
> Whoops!! Sorry, forgot the attachment.
> 
>   ------------------------------------------------------------------------
> 
> [root@iso-2146-l1 ttsig]# ping 10.10.4.254
> PING 10.10.4.254 (10.10.4.254) from 10.10.4.33 : 56(84) bytes of data.
> 64 bytes from 10.10.4.254: icmp_seq=3 ttl=255 time=590 usec
> 64 bytes from 10.10.4.254: icmp_seq=0 ttl=255 time=2.996 sec
> 64 bytes from 10.10.4.254: icmp_seq=1 ttl=255 time=2.000 sec
> 64 bytes from 10.10.4.254: icmp_seq=2 ttl=255 time=1.000 sec
> 64 bytes from 10.10.4.254: icmp_seq=7 ttl=255 time=575 usec
> 64 bytes from 10.10.4.254: icmp_seq=4 ttl=255 time=3.000 sec
> 64 bytes from 10.10.4.254: icmp_seq=5 ttl=255 time=2.000 sec
> 64 bytes from 10.10.4.254: icmp_seq=6 ttl=255 time=1.000 sec
> 

This matches exactly with what I think is the problem; now to find the
code
that causes it...

Re: xircom_cb problems

[Tom Sightler]

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Whoops!! Sorry, forgot the attachment.

Thanks,
Tom


> Both of these are slow, actually. I'm getting 7.5-8MB/s when receiving
> from a 100Mbit box (tulip or starfire, doesn't seem to matter). 
> Transmitting is still slow for me, but that is most likely a different 
> problem -- and I'm looking into it.

Yeah, I knew they were both slow, but at least one is acceptable, the <200KB/s
is below usable when doing any network based work.

> Moreover, I'm getting 9+MB/s in both directions when using the other 
> driver (xircom_tulip_cb), patched to do half-duplex only. So the card
> can definitely transfer at network speeds.

I'm not doing nearly as well with the other driver, but I don't have it patched
for half-duplex only.  I tried setting the remote end to force half-duplex but
this didn't seem to work quite right.


> Looking forward to seeing them...

OK, I tried your patch, it did fix the problem where pump wouldn't pull an IP
address, but I'm still having the problem where my ping times go nuts.  I've
attached an example, it's 100% repeatable on my network at work.  It was so bad
I couldn't get any benchmark numbers.

Later,
Tom


[-- Attachment #2: /root/xircom-slow-pings.txt --]
[-- Type: text/plain, Size: 1975 bytes --]


[root@iso-2146-l1 ttsig]# ping 10.10.4.254
PING 10.10.4.254 (10.10.4.254) from 10.10.4.33 : 56(84) bytes of data.
64 bytes from 10.10.4.254: icmp_seq=3 ttl=255 time=590 usec
64 bytes from 10.10.4.254: icmp_seq=0 ttl=255 time=2.996 sec
64 bytes from 10.10.4.254: icmp_seq=1 ttl=255 time=2.000 sec
64 bytes from 10.10.4.254: icmp_seq=2 ttl=255 time=1.000 sec
64 bytes from 10.10.4.254: icmp_seq=7 ttl=255 time=575 usec
64 bytes from 10.10.4.254: icmp_seq=4 ttl=255 time=3.000 sec
64 bytes from 10.10.4.254: icmp_seq=5 ttl=255 time=2.000 sec
64 bytes from 10.10.4.254: icmp_seq=6 ttl=255 time=1.000 sec

--- 10.10.4.254 ping statistics ---
10 packets transmitted, 8 packets received, 20% packet loss
round-trip min/avg/max/mdev = 0.575/1500.228/3000.710/1117.327 ms
[root@iso-2146-l1 ttsig]# rmmod xircom_cb
rmmod: module xircom_cb is not loaded
[root@iso-2146-l1 ttsig]# lsmod
Module                  Size  Used by
appletalk              18352   0  (autoclean)
serial                 44864   0 
vmnet                  16448   1 
vmmon                  18352   0 
r128                  145392   1 
agpgart                13568   3  (autoclean)
usb-uhci               20864   0  (unused)
usbcore                48176   1  [usb-uhci]
[root@iso-2146-l1 ttsig]# ping 10.10.4.254
PING 10.10.4.254 (10.10.4.254) from 10.10.4.33 : 56(84) bytes of data.
64 bytes from 10.10.4.254: icmp_seq=0 ttl=255 time=955 usec
64 bytes from 10.10.4.254: icmp_seq=1 ttl=255 time=492 usec
64 bytes from 10.10.4.254: icmp_seq=2 ttl=255 time=453 usec
64 bytes from 10.10.4.254: icmp_seq=3 ttl=255 time=465 usec
64 bytes from 10.10.4.254: icmp_seq=4 ttl=255 time=451 usec
64 bytes from 10.10.4.254: icmp_seq=5 ttl=255 time=455 usec
64 bytes from 10.10.4.254: icmp_seq=6 ttl=255 time=450 usec
64 bytes from 10.10.4.254: icmp_seq=7 ttl=255 time=453 usec

--- 10.10.4.254 ping statistics ---
8 packets transmitted, 8 packets received, 0% packet loss
round-trip min/avg/max/mdev = 0.450/0.521/0.955/0.166 ms