From: "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Saha, Tamal" <tamal.saha@intel.com>
Subject: RE: [PATCH v3 2/2] pinctrl: Add Intel Keem Bay pinctrl driver
Date: Fri, 30 Jul 2021 11:06:08 +0000 [thread overview]
Message-ID: <BL3PR11MB56995CA61A5C6AF043A37B11C4EC9@BL3PR11MB5699.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdZ2_Hd66FoB5W_p0WCy8Hvx7ypz5K9iVAv22mnjE+jCQ@mail.gmail.com>
Thank you Linus Walleij and Andy Shevchenko,
I will fix the warning and post the next version with 'Reviewed-by: Linus Walleij <linus.walleij@linaro.org>' tag.
Thanks and Regards,
Lakshmi Sowjanya
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Friday, July 30, 2021 3:02 PM
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: D, Lakshmi Sowjanya <lakshmi.sowjanya.d@intel.com>; open list:GPIO
> SUBSYSTEM <linux-gpio@vger.kernel.org>; linux-kernel <linux-
> kernel@vger.kernel.org>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@intel.com>; Saha, Tamal
> <tamal.saha@intel.com>
> Subject: Re: [PATCH v3 2/2] pinctrl: Add Intel Keem Bay pinctrl driver
>
> On Fri, Jul 30, 2021 at 12:14 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Fri, Jul 16, 2021 at 6:27 PM <lakshmi.sowjanya.d@intel.com> wrote:
> >
> > > + /*
> > > + * Each Interrupt line can be shared by up to 4 GPIO pins. Enable bit
> > > + * and input values were checked to identify the source of the
> > > + * Interrupt. The checked enable bit positions are 7, 15, 23 and 31.
> > > + */
> > > + for_each_set_clump8(bit, clump, ®,
> BITS_PER_TYPE(typeof(reg))) {
> > > + pin = clump & ~KEEMBAY_GPIO_IRQ_ENABLE;
> > > + val = keembay_read_pin(kpc->base0 +
> KEEMBAY_GPIO_DATA_IN, pin);
> > > + kmb_irq = irq_linear_revmap(gc->irq.domain, pin);
> > > +
> > > + /* Checks if the interrupt is enabled */
> > > + if (val && (clump & KEEMBAY_GPIO_IRQ_ENABLE))
> > > + generic_handle_irq(kmb_irq);
> > > + }
> >
> > Aha there it is. "Half-hierarchical" with one IRQ handling 4 lines.
> >
> > OK we can't do any better than this so this and the bindings look
> > fine.
> >
> > I need to know how Andy think about merging,
>
> Linus, unfortunately I can fulfil a detailed review (busy with a critical task not
> related to this platform anyway), but this version is more or less okay to
> merge. We may adjust it with follow up fixes if needed.
>
> > and then there is
> > an uninitialized ret in the mail from Dan Carpenter look into that
> > too.
> >
> > In any case with minor nits fixed:
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2021-07-30 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 16:27 [PATCH v3 0/2] Add pinctrl support for Intel Keem Bay SoC lakshmi.sowjanya.d
2021-07-16 16:27 ` [PATCH v3 1/2] dt-bindings: pinctrl: Add bindings for Intel Keembay pinctrl driver lakshmi.sowjanya.d
2021-07-30 9:05 ` Linus Walleij
2021-07-30 11:29 ` Andy Shevchenko
2021-07-30 11:58 ` Linus Walleij
2021-07-30 9:15 ` Linus Walleij
2021-07-30 11:06 ` D, Lakshmi Sowjanya
2021-07-16 16:27 ` [PATCH v3 2/2] pinctrl: Add Intel Keem Bay " lakshmi.sowjanya.d
2021-07-28 19:16 ` [kbuild] " Dan Carpenter
2021-07-30 11:05 ` D, Lakshmi Sowjanya
2021-07-30 9:13 ` Linus Walleij
2021-07-30 9:32 ` Andy Shevchenko
2021-07-30 11:06 ` D, Lakshmi Sowjanya [this message]
2021-07-30 11:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL3PR11MB56995CA61A5C6AF043A37B11C4EC9@BL3PR11MB5699.namprd11.prod.outlook.com \
--to=lakshmi.sowjanya.d@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tamal.saha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).