linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices"
@ 2017-05-19 18:46 Pascal Wichmann
  2017-05-19 19:08 ` Dmitry Torokhov
  0 siblings, 1 reply; 10+ messages in thread
From: Pascal Wichmann @ 2017-05-19 18:46 UTC (permalink / raw)
  To: Dmitry Torokhov, Benjamin Tissoires; +Cc: linux-input, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1346 bytes --]

Hello,

using the latest 4.12-rc1 kernel, the trackpoint and touchpad of my
Thinkpad X250 are not recognized.

This is caused by commit
e839ffa  Input: synaptics - add support for Intertouch devices


The specific problem seems to be the detection of whether to use
synaptics_intertouch for the psmouse module or not. That parameter
is set to -1 by default, in which case synaptics_intertouch is
enabled on my device.

When I explicitly set that parameter to 0, the trackpoint and touchpad
are recognized and work as expected.

Removing my device from smbus_pnp_ids in 4.12 rc1 fixes the issue
without need to manually disable synaptics_intertouch in the psmouse
module:

diff -ruN a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
--- a/drivers/input/mouse/synaptics.c	2017-05-19 19:31:48.930734395 +0200
+++ b/drivers/input/mouse/synaptics.c	2017-05-19 19:32:00.490782484 +0200
@@ -170,7 +170,6 @@
 static const char * const smbus_pnp_ids[] = {
 	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
 	"LEN0048", /* X1 Carbon 3 */
-	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
 	"LEN200f", /* T450s */
 	NULL


Is the ThinkPad X250 not supporting intertouch or is there another
problem causing the input devices not to work with it enabled?


Regards,
Pascal



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-05-23  8:33 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 18:46 [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" Pascal Wichmann
2017-05-19 19:08 ` Dmitry Torokhov
2017-05-19 19:37   ` Pascal Wichmann
2017-05-19 20:23     ` Dmitry Torokhov
2017-05-19 20:35       ` Pascal Wichmann
2017-05-19 20:49         ` Dmitry Torokhov
2017-05-20  5:47           ` Pascal Wichmann
2017-05-20  9:59             ` Benjamin Tissoires
2017-05-20 17:35               ` Dmitry Torokhov
2017-05-23  8:33                 ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).