[PATCH] signal: annotate implicit fall through

[PATCH] signal: annotate implicit fall through

[Mathieu Malaterre]

There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).

This commit remove the following warning:

  kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/signal.c b/kernel/signal.c
index e1d7ad8e6ab1..aa7a507757d7 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
 			 */
 			if (!sid || sid == task_session(current))
 				break;
+			/* fall through */
 		default:
 			return -EPERM;
 		}
-- 
2.19.2

Re: [PATCH] signal: annotate implicit fall through

[Mathieu Malaterre]

ping ?

On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
>   kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  kernel/signal.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index e1d7ad8e6ab1..aa7a507757d7 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>                          */
>                         if (!sid || sid == task_session(current))
>                                 break;
> +                       /* fall through */
>                 default:
>                         return -EPERM;
>                 }
> --
> 2.19.2
>

Re: [PATCH] signal: annotate implicit fall through

[Gustavo A. R. Silva]

[+cc Andrew]

On 3/13/19 3:27 PM, Mathieu Malaterre wrote:
> ping ?
> 

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Maybe Andrew can take this?

Thanks
--
Gustavo

> On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>>
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> this place in the code produced a warning (W=1).
>>
>> This commit remove the following warning:
>>
>>   kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>>  kernel/signal.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index e1d7ad8e6ab1..aa7a507757d7 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>>                          */
>>                         if (!sid || sid == task_session(current))
>>                                 break;
>> +                       /* fall through */
>>                 default:
>>                         return -EPERM;
>>                 }
>> --
>> 2.19.2
>>