linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: jme: fix suspend/resume on JMC260
@ 2016-02-23  0:32 Diego Viola
  2016-02-23  1:46 ` Fabio Estevam
  0 siblings, 1 reply; 7+ messages in thread
From: Diego Viola @ 2016-02-23  0:32 UTC (permalink / raw)
  To: cooldavid
  Cc: netdev, linux-kernel, richard.weinberger, pavel, rjw, davem, Diego Viola

Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
 drivers/net/ethernet/jme.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index b1de7af..8adbe8f 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
 		jme_reset_phy_processor(jme);
 	jme_phy_calibration(jme);
 	jme_phy_setEA(jme);
-	jme_start_irq(jme);
 	netif_device_attach(netdev);
 
 	atomic_inc(&jme->link_changing);
 
 	jme_reset_link(jme);
 
+	jme_start_irq(jme);
+
 	return 0;
 }
 
-- 
2.7.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  0:32 [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola
@ 2016-02-23  1:46 ` Fabio Estevam
  2016-02-23  1:58   ` Diego Viola
  0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2016-02-23  1:46 UTC (permalink / raw)
  To: Diego Viola
  Cc: cooldavid, netdev, linux-kernel, Richard Weinberger,
	Pavel Machek, rjw, David S. Miller

On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
> Signed-off-by: Diego Viola <diego.viola@gmail.com>

You should write a commit log.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  1:46 ` Fabio Estevam
@ 2016-02-23  1:58   ` Diego Viola
  2016-02-23  2:35     ` Diego Viola
  2016-02-23  4:42     ` David Miller
  0 siblings, 2 replies; 7+ messages in thread
From: Diego Viola @ 2016-02-23  1:58 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: cooldavid, netdev, linux-kernel, Richard Weinberger,
	Pavel Machek, rjw, David S. Miller

On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>
> You should write a commit log.

I thought about including the link to my bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=112351

What else would you suggest I add to the commit message?

Diego

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  1:58   ` Diego Viola
@ 2016-02-23  2:35     ` Diego Viola
  2016-02-23  4:42     ` David Miller
  1 sibling, 0 replies; 7+ messages in thread
From: Diego Viola @ 2016-02-23  2:35 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: cooldavid, netdev, linux-kernel, Richard Weinberger,
	Pavel Machek, rjw, David S. Miller

On Mon, Feb 22, 2016 at 10:58 PM, Diego Viola <diego.viola@gmail.com> wrote:
> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>
>> You should write a commit log.
>
> I thought about including the link to my bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>
> What else would you suggest I add to the commit message?
>
> Diego

I probably should have explained also that this patch fixes my
suspend/resume problem even when /sys/power/pm_async is set to 1,
because before that, suspend/resume only worked when pm_async was 0.

I had a chat with Guo a few minutes ago on Hangouts and he said he
will look into this problem. :)

Diego

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  1:58   ` Diego Viola
  2016-02-23  2:35     ` Diego Viola
@ 2016-02-23  4:42     ` David Miller
  2016-02-23  5:11       ` Diego Viola
  1 sibling, 1 reply; 7+ messages in thread
From: David Miller @ 2016-02-23  4:42 UTC (permalink / raw)
  To: diego.viola
  Cc: festevam, cooldavid, netdev, linux-kernel, richard.weinberger,
	pavel, rjw

From: Diego Viola <diego.viola@gmail.com>
Date: Mon, 22 Feb 2016 22:58:48 -0300

> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>
>> You should write a commit log.
> 
> I thought about including the link to my bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=112351
> 
> What else would you suggest I add to the commit message?

The commit message is where you describe the change you are making.

This includes exactly what you are fixing, how you are doing it, and why
you are doing it that way.

Empty commit log messages are %99.99999 of the time completely
inappropriate.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  4:42     ` David Miller
@ 2016-02-23  5:11       ` Diego Viola
  2016-02-23  5:36         ` Diego Viola
  0 siblings, 1 reply; 7+ messages in thread
From: Diego Viola @ 2016-02-23  5:11 UTC (permalink / raw)
  To: David Miller
  Cc: festevam, cooldavid, netdev, linux-kernel, richard.weinberger,
	pavel, rjw

On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@davemloft.net> wrote:
> From: Diego Viola <diego.viola@gmail.com>
> Date: Mon, 22 Feb 2016 22:58:48 -0300
>
>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>>
>>> You should write a commit log.
>>
>> I thought about including the link to my bug report:
>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>
>> What else would you suggest I add to the commit message?
>
> The commit message is where you describe the change you are making.
>
> This includes exactly what you are fixing, how you are doing it, and why
> you are doing it that way.
>
> Empty commit log messages are %99.99999 of the time completely
> inappropriate.

David,

I understand and appreciate your advice, thanks.

However, please consider that I'm not a kernel developer, so I don't
understand much or anything about how this driver works internally,
this is why I came here to report about problem in the first place.

All I can tell you for certain is that this change makes my
suspend/resume work and it doesn't hang anymore while resuming from
suspend.

I apologize for the empty commit message and for not being able to
explain things deeper, but Pavel Machek is the person who suggested I
make this change in the code, so maybe he can provide some help?

Diego

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] net: jme: fix suspend/resume on JMC260
  2016-02-23  5:11       ` Diego Viola
@ 2016-02-23  5:36         ` Diego Viola
  0 siblings, 0 replies; 7+ messages in thread
From: Diego Viola @ 2016-02-23  5:36 UTC (permalink / raw)
  To: David Miller
  Cc: festevam, cooldavid, netdev, linux-kernel, richard.weinberger,
	pavel, rjw

On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola <diego.viola@gmail.com> wrote:
> On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@davemloft.net> wrote:
>> From: Diego Viola <diego.viola@gmail.com>
>> Date: Mon, 22 Feb 2016 22:58:48 -0300
>>
>>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>>>
>>>> You should write a commit log.
>>>
>>> I thought about including the link to my bug report:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>>
>>> What else would you suggest I add to the commit message?
>>
>> The commit message is where you describe the change you are making.
>>
>> This includes exactly what you are fixing, how you are doing it, and why
>> you are doing it that way.
>>
>> Empty commit log messages are %99.99999 of the time completely
>> inappropriate.
>
> David,
>
> I understand and appreciate your advice, thanks.
>
> However, please consider that I'm not a kernel developer, so I don't
> understand much or anything about how this driver works internally,
> this is why I came here to report about problem in the first place.
>
> All I can tell you for certain is that this change makes my
> suspend/resume work and it doesn't hang anymore while resuming from
> suspend.
>
> I apologize for the empty commit message and for not being able to
> explain things deeper, but Pavel Machek is the person who suggested I
> make this change in the code, so maybe he can provide some help?
>
> Diego

I will try sending a V2 patch again with a proper commit message, sorry.

Diego

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-23  5:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-23  0:32 [PATCH] net: jme: fix suspend/resume on JMC260 Diego Viola
2016-02-23  1:46 ` Fabio Estevam
2016-02-23  1:58   ` Diego Viola
2016-02-23  2:35     ` Diego Viola
2016-02-23  4:42     ` David Miller
2016-02-23  5:11       ` Diego Viola
2016-02-23  5:36         ` Diego Viola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).