From: Linus Walleij <linus.walleij@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
stwiss.opensource@diasemi.com,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v2 4/5] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation
Date: Fri, 29 Nov 2019 09:33:04 +0100 [thread overview]
Message-ID: <CACRpkdZHmbgaHHbsXuAg4GD_cWWSx33WQ71Sk11HySoeorfUbA@mail.gmail.com> (raw)
In-Reply-To: <20191127135932.7223-5-m.felsch@pengutronix.de>
On Wed, Nov 27, 2019 at 2:59 PM Marco Felsch <m.felsch@pengutronix.de> wrote:
> At the gpio-based regulator enable/disable documentation. This property
> can be applied to each subnode within the 'regulators' node so each
> regulator can be configured differently.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
(...)
> + - dlg,ena-sense-gpios : The GPIO reference which should be used by the
> + regulator to enable/disable the output. If the signal is active the
> + regulator is on else it is off. Attention: Sharing the same gpio for other
> + purposes or across multiple regulators is possible but the gpio settings
> + must be the same. Also the gpio phandle must refer to the mfd root node
> + other gpios are not allowed and make no sense.
- Point out that this concerns references to the GPI general purpose
input on the DA9062 itself, and not just "any" GPIO. The last sentence
tries to say this but it should be stated more clearly.
- Clarify which "gpio settings" must be the same, e.g. polarity I guess.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-11-29 8:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:59 [PATCH v2 0/5] DA9062 PMIC features Marco Felsch
2019-11-27 13:59 ` [PATCH v2 1/5] gpio: add support to get local gpio number Marco Felsch
2019-11-28 10:46 ` Bartosz Golaszewski
2019-11-28 12:49 ` Marco Felsch
2019-11-29 7:45 ` Uwe Kleine-König
2019-11-29 7:50 ` Marco Felsch
2019-11-29 9:32 ` Linus Walleij
2019-11-29 10:15 ` Marco Felsch
2019-11-29 10:19 ` Linus Walleij
2019-11-29 11:36 ` Marco Felsch
2019-11-29 12:46 ` Linus Walleij
2019-11-27 13:59 ` [PATCH v2 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch
2019-11-27 13:59 ` [PATCH v2 3/5] regulator: da9062: add voltage selection gpio support Marco Felsch
2019-11-29 8:29 ` Linus Walleij
2019-11-27 13:59 ` [PATCH v2 4/5] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch
2019-11-29 8:33 ` Linus Walleij [this message]
2019-11-27 13:59 ` [PATCH v2 5/5] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch
2019-11-29 8:25 ` Linus Walleij
2019-11-29 9:11 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZHmbgaHHbsXuAg4GD_cWWSx33WQ71Sk11HySoeorfUbA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).