From: Linus Walleij <linus.walleij@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
stwiss.opensource@diasemi.com,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v2 5/5] regulator: da9062: add gpio based regulator dis-/enable support
Date: Fri, 29 Nov 2019 09:25:45 +0100 [thread overview]
Message-ID: <CACRpkdb9iXneW3BUj6RfODYnL7DwMwbGbPwXgQ4Z5YTj7MgGcw@mail.gmail.com> (raw)
In-Reply-To: <20191127135932.7223-6-m.felsch@pengutronix.de>
On Wed, Nov 27, 2019 at 2:59 PM Marco Felsch <m.felsch@pengutronix.de> wrote:
> Each regulator can be enabeld/disabled by the internal pmic state
> machine or by a gpio input signal. Typically the OTP configures the
> regulators to be enabled/disabled on a specific sequence number which is
> most the time fine. Sometimes we need to reconfigure that due to a PCB
> bug. This patch adds the support to disable/enable the regulator based
> on a gpio input signal.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Overall I think this is fine, it's a solid use case that need to be
supported.
> + struct reg_field ena_gpi;
Maybe just add some doc comment to this struct member?
IIUC it is a general purpose input that can be configured
such that it will enable one of the DA9062 regulators when
asserted. (Correct?)
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-11-29 8:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:59 [PATCH v2 0/5] DA9062 PMIC features Marco Felsch
2019-11-27 13:59 ` [PATCH v2 1/5] gpio: add support to get local gpio number Marco Felsch
2019-11-28 10:46 ` Bartosz Golaszewski
2019-11-28 12:49 ` Marco Felsch
2019-11-29 7:45 ` Uwe Kleine-König
2019-11-29 7:50 ` Marco Felsch
2019-11-29 9:32 ` Linus Walleij
2019-11-29 10:15 ` Marco Felsch
2019-11-29 10:19 ` Linus Walleij
2019-11-29 11:36 ` Marco Felsch
2019-11-29 12:46 ` Linus Walleij
2019-11-27 13:59 ` [PATCH v2 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch
2019-11-27 13:59 ` [PATCH v2 3/5] regulator: da9062: add voltage selection gpio support Marco Felsch
2019-11-29 8:29 ` Linus Walleij
2019-11-27 13:59 ` [PATCH v2 4/5] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch
2019-11-29 8:33 ` Linus Walleij
2019-11-27 13:59 ` [PATCH v2 5/5] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch
2019-11-29 8:25 ` Linus Walleij [this message]
2019-11-29 9:11 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb9iXneW3BUj6RfODYnL7DwMwbGbPwXgQ4Z5YTj7MgGcw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).