* Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
[not found] <20210624064913.41788-1-wangborong@cdjrlc.com>
@ 2021-06-24 16:22 ` Florian Fainelli
2021-07-23 15:47 ` Linus Walleij
1 sibling, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2021-06-24 16:22 UTC (permalink / raw)
To: Jason Wang, linus.walleij
Cc: nsaenz, rjui, sbranden, bcm-kernel-feedback-list, phil, iivanov,
linux-gpio, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 6/23/21 11:49 PM, Jason Wang wrote:
> The if condition followed by BUG can be replaced to BUG_ON which is
> more compact and formal in linux source.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Although I would rather completely remove this BUG_ON() and replace it
with a WARN_ON() instead, no need to kill the machine for such a
problem, however unlikely it is to appear.
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON
[not found] <20210624064913.41788-1-wangborong@cdjrlc.com>
2021-06-24 16:22 ` [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON Florian Fainelli
@ 2021-07-23 15:47 ` Linus Walleij
1 sibling, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-07-23 15:47 UTC (permalink / raw)
To: wangborong
Cc: Nicolas Saenz Julienne, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Phil Elwell, Ivan T. Ivanov,
open list:GPIO SUBSYSTEM, linux-rpi-kernel, Linux ARM,
linux-kernel
On Thu, Jun 24, 2021 at 8:50 AM Jason Wang <wangborong@cdjrlc.com> wrote:
> The if condition followed by BUG can be replaced to BUG_ON which is
> more compact and formal in linux source.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-23 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210624064913.41788-1-wangborong@cdjrlc.com>
2021-06-24 16:22 ` [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON Florian Fainelli
2021-07-23 15:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).