From: Tim Kryger <tim.kryger@gmail.com>
To: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Arun Ramamurthy <arunrama@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] pwm: kona: Remove setting default smooth type and polarity for all channels
Date: Fri, 28 Nov 2014 19:19:51 -0800 [thread overview]
Message-ID: <CAD7vxxJFuA8V0TiPLQo1LOnRQPbM-QOYDTLkg7Ty0N=Nr7frGQ@mail.gmail.com> (raw)
In-Reply-To: <54791F30.3050306@broadcom.com>
On Fri, Nov 28, 2014 at 5:19 PM, Arun Ramamurthy
<arun.ramamurthy@broadcom.com> wrote:
>
>
> On 14-11-28 05:08 PM, Tim Kryger wrote:
>>
>> On Fri, Nov 28, 2014 at 3:47 PM, Arun Ramamurthy
>> <arun.ramamurthy@broadcom.com> wrote:
>>>
>>>
>>>
>>> On 14-11-25 09:51 PM, Tim Kryger wrote:
>>>>
>>>>
>>>> On Tue, Nov 25, 2014 at 11:40 AM, Scott Branden <sbranden@broadcom.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> From: Arun Ramamurthy <arunrama@broadcom.com>
>>>>>
>>>>> The probe routine unnecessarily sets the smooth type and polarity for
>>>>> all channels. This causes the channel for the speaker to click at the
>>>>> same
>>>>> time the backlight turns on. The smooth type and polarity should be set
>>>>> individually
>>>>> for each channel as required and no defaults need to be set.
>>>>
>>>>
>>>>
>>>> I am guessing you are talking about a PWM controlled beeper/buzzer.
>>>>
>>> This change is more so to remove setting smooth type and polarity for all
>>> channels during probe and to leave them as their default values. Infact,
>>> setting the PWM_CONTROL_TYPE_SHIT is also redundant cause the default
>>> value
>>> is already 1 for all channels. We can remove that loop entirely and this
>>> will be done in the next patch set. The smooth type and polarity are only
>>> changed when the particular pwm channel is enabled or polarity is
>>> changed.
>>>
>>>> Can you mention what board you are observing this issue on?
>>>>
>>>> Also please explain why setting these bits result in an audible click.
>>>>
>>> We observe this on the bcm958300K board where one of the
>>> PWM channels is connected to the buzzer and changing the
>>> smooth type and polarity from its default values causes a click
>>>
>>
>> Which of these two bits is causing the click?
>>
>> I've already said that I'm open to removing the smooth bit here if that
>> helps.
>>
> Thank you for your quick reply Tim. It is setting the polarity bit that
> causes the click. I am planning on removing this entire loop in the next
> patch set, are you okay with that?
Does it cause a click at this moment or at a later point in time?
Is the click your sole motivation for this series? If so, can you
propose a more targeted fix?
I would be amenable to deferring polarity changes until subsequent
enable operations:
- kona_pwmc_probe doesn't do any hardware writes
- kona_pwmc_set_polarity only updates a polarity variable
- kona_pwmc_enable sets hardware polarity according to the variable
Would this be sufficient to satisfy your needs?
I am still worried that deferring polarity changes may negatively
impact some PWM users who set polarity but don't immediately enable
the PWM.
>>>>>
>>>>> Signed-off-by: Arun Ramamurthy <arunrama@broadcom.com>
>>>>> Reviewed-by: Ray Jui <rjui@broadcom.com>
>>>>> Signed-off-by: Scott Branden <sbranden@broadcom.com>
>>>>> ---
>>>>> drivers/pwm/pwm-bcm-kona.c | 7 ++-----
>>>>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
>>>>> index 02bc048..29eef9e 100644
>>>>> --- a/drivers/pwm/pwm-bcm-kona.c
>>>>> +++ b/drivers/pwm/pwm-bcm-kona.c
>>>>> @@ -266,12 +266,9 @@ static int kona_pwmc_probe(struct platform_device
>>>>> *pdev)
>>>>> return ret;
>>>>> }
>>>>>
>>>>> - /* Set smooth mode, push/pull, and normal polarity for all
>>>>> channels */
>>>>> - for (chan = 0; chan < kp->chip.npwm; chan++) {
>>>>> - value |= (1 << PWM_CONTROL_SMOOTH_SHIFT(chan));
>>>>> + /* Set push/pull for all channels */
>>>>> + for (chan = 0; chan < kp->chip.npwm; chan++)
>>>>> value |= (1 << PWM_CONTROL_TYPE_SHIFT(chan));
>>>>> - value |= (1 << PWM_CONTROL_POLARITY_SHIFT(chan));
>>>>> - }
>>>>>
>>>>> writel(value, kp->base + PWM_CONTROL_OFFSET);
>>>>
>>>>
>>>>
>>>> While the smooth bit need not be set here, it is important that the
>>>> polarity bit be set.
>>>>
>>> The default value for polarity is 0 which is normal polarity, so setting
>>> it
>>> to 1 here in the probe function without a sysfs call is
>>> when the software will report the polarity as normal when it is actually
>>> inversed.
>>
>>
>> Please double check the meaning of the polarity bits for the revision
>> of PWM IP in your chip. I suspect you are mistaken here.
>>
>> This driver is for PWM blocks compatible those found in bcm28145,
>> bcm28155, bcm21664, and other mobile chips of that generation.
>>
>> Apparently in contrast to the chip you are using, a set polarity bit
>> in the control register means normal polarity for the chips I
>> mentioned.
>>
>> A default of zero for these bits means they must be set to meet the
>> PWM framework's expectation that channels begin with normal polarity.
>>
> Tim, this is from the RDB of our new chip which is supposed to have the same
> IP as the mobile chip sets you mentioned:
>
> When set to 1 the output polarity for the PWM Output signal will be active
> hight; When set to 0, the output polarity for the PWM Output signal will be
> active low. Default State is 0.
>
> My understanding is that the frameworks normal polarity means active low, am
> I mistaken in that?
That is not how I would interpret things.
Perhaps this paragraph from Documentation/pwm.txt will help you:
When implementing polarity support in a PWM driver, make sure to respect the
signal conventions in the PWM framework. By definition, normal polarity
characterizes a signal starts high for the duration of the duty cycle and
goes low for the remainder of the period. Conversely, a signal with inversed
polarity starts low for the duration of the duty cycle and goes high for the
remainder of the period.
>
>>>>
>>>> Otherwise software will report the polarity as normal when it it is
>>>> actually inversed.
>>>>
>>>> Consider the case where a userspace process is controlling the PWM via
>>>> sysfs.
>>>>
>>> I agree with you about the sysfs case Tim, but since this is the probe
>>> function and not a sysfs callback, should we not leave it as the default
>>> value?
next prev parent reply other threads:[~2014-11-29 3:19 UTC|newest]
Thread overview: 265+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Scott Branden <sbranden@broadcom.com>
2014-10-08 5:26 ` [PATCH V3 0/6] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-08 5:27 ` [PATCH 1/6] ARM: cygnus: Initial " Scott Branden
2014-10-08 7:54 ` Arnd Bergmann
2014-10-08 12:27 ` Scott Branden
2014-10-08 13:28 ` Arnd Bergmann
2014-10-08 16:27 ` Scott Branden
2014-10-08 18:12 ` Arnd Bergmann
2014-10-08 18:45 ` Scott Branden
2014-10-08 22:16 ` Scott Branden
2014-10-09 7:32 ` Arnd Bergmann
2014-10-08 8:11 ` Russell King - ARM Linux
2014-10-08 11:17 ` Scott Branden
2014-10-08 11:41 ` Russell King - ARM Linux
2014-10-08 13:10 ` Rob Herring
2014-10-08 16:34 ` Scott Branden
2014-10-08 5:27 ` [PATCH 2/6] clk: Clock driver " Scott Branden
2014-10-08 5:27 ` [PATCH 3/6] dt-bindings: Document Broadcom Cygnus SoC and clock driver Scott Branden
2014-10-08 7:57 ` Arnd Bergmann
2014-10-08 10:58 ` Scott Branden
2014-10-08 13:35 ` Arnd Bergmann
2014-10-08 5:27 ` [PATCH 4/6] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-08 7:58 ` Arnd Bergmann
2014-10-08 11:01 ` Scott Branden
2014-10-08 5:27 ` [PATCH 5/6] ARM: dts: Enable " Scott Branden
2014-10-08 5:27 ` [PATCH 6/6] MAINTAINERS: Entry for Cygnus/iproc arm architecture and clock drivers Scott Branden
2014-10-09 22:44 ` [PATCH V4 0/7] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-09 22:44 ` [PATCH V4 1/7] ARM: cygnus: Initial " Scott Branden
2014-10-10 9:50 ` Arnd Bergmann
2014-10-10 19:08 ` Scott Branden
2014-10-09 22:44 ` [PATCH V4 2/7] clk: Clock driver " Scott Branden
2014-10-09 22:44 ` [PATCH V4 3/7] dt-bindings: Document Broadcom Cygnus SoC and clock driver Scott Branden
2014-10-09 22:44 ` [PATCH V4 4/7] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-09 22:44 ` [PATCH V4 5/7] ARM: dts: Enable " Scott Branden
2014-10-10 10:08 ` Arnd Bergmann
2014-10-10 19:11 ` Scott Branden
2014-10-09 22:44 ` [PATCH V4 6/7] MAINTAINERS: Entry for Cygnus/iproc arm architecture and clock drivers Scott Branden
2014-10-09 23:00 ` Joe Perches
2014-10-09 23:18 ` Scott Branden
2014-10-09 22:44 ` [PATCH V4 7/7] ARM: multi_v7_defconfig: Enable ARCH_BCM_CYGNUS config Scott Branden
2014-10-10 9:59 ` Arnd Bergmann
2014-10-10 19:12 ` Scott Branden
2014-10-15 2:01 ` [PATCH 0/1] sdhci-bcm2835: added quirk and removed udelay in write ops Scott Branden
2014-10-15 2:01 ` [PATCH 1/1] mmc: " Scott Branden
2014-10-17 2:50 ` Stephen Warren
2014-10-15 2:58 ` [PATCH v5 0/6] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-15 2:58 ` [PATCH v5 1/6] ARM: cygnus: Initial " Scott Branden
2014-10-20 19:55 ` Arnd Bergmann
2014-10-20 22:59 ` Scott Branden
2014-10-21 5:48 ` Arnd Bergmann
2014-10-22 0:11 ` Scott Branden
2014-10-22 8:22 ` Arnd Bergmann
2014-10-22 17:12 ` Scott Branden
2014-10-15 2:58 ` [PATCH v5 2/6] dt-bindings: Document Broadcom Cygnus SoC and clocks Scott Branden
2014-10-15 2:58 ` [PATCH v5 3/6] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-15 2:58 ` [PATCH v5 4/6] ARM: dts: Enable " Scott Branden
2014-10-15 2:58 ` [PATCH v5 5/6] MAINTAINERS: Entry for Cygnus/iproc arm architecture Scott Branden
2014-10-15 2:58 ` [PATCH v5 6/6] ARM: mach-bcm: Consolidate currently supported IPROC SoCs Scott Branden
2014-10-15 15:54 ` [PATCH 1/1] MAINTAINERS: corrected bcm2835 search Scott Branden
2014-10-15 18:12 ` Stephen Warren
2014-10-15 16:43 ` [PATCH 1/1] mmc: sdhci-bcm2835: added quirk and removed udelay in write ops Scott Branden
2014-10-18 2:37 ` Stephen Warren
2014-10-18 6:40 ` Scott Branden
2014-10-22 2:09 ` [PATCH v6 0/6] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-22 2:09 ` [PATCH v6 1/6] ARM: cygnus: Initial " Scott Branden
2014-10-22 2:09 ` [PATCH v6 2/6] dt-bindings: Document Broadcom Cygnus SoC and clocks Scott Branden
2014-10-22 2:09 ` [PATCH v6 3/6] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-22 2:09 ` [PATCH v6 4/6] ARM: dts: Enable " Scott Branden
2014-10-22 2:09 ` [PATCH v6 5/6] MAINTAINERS: Entry for Cygnus/iproc arm architecture Scott Branden
2014-10-22 2:09 ` [PATCH v6 6/6] ARM: mach-bcm: Consolidate currently supported IPROC SoCs Scott Branden
2014-10-22 20:57 ` [PATCH v7 0/7] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-22 20:57 ` [PATCH v7 1/7] ARM: cygnus: Initial " Scott Branden
2014-10-22 20:57 ` [PATCH v7 2/7] dt-bindings: Document Broadcom Cygnus SoC and clocks Scott Branden
2014-10-22 20:57 ` [PATCH v7 3/7] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-22 20:57 ` [PATCH v7 4/7] ARM: dts: Enable " Scott Branden
2014-10-28 16:10 ` Arnd Bergmann
2014-10-28 19:41 ` Scott Branden
2014-10-22 20:57 ` [PATCH v7 5/7] MAINTAINERS: Entry for Cygnus/iproc arm architecture Scott Branden
2014-10-22 20:57 ` [PATCH v7 6/7] ARM: mach-bcm: Consolidate currently supported IPROC SoCs Scott Branden
2014-10-22 20:57 ` [PATCH v7 7/7] ARM: mach-bcm: ARCH_BCM_MOBILE: remove one level of menu from Kconfig Scott Branden
2014-10-28 19:53 ` [PATCH v8 0/8] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-28 19:53 ` [PATCH v8 1/8] ARM: cygnus: Initial " Scott Branden
2014-10-28 19:53 ` [PATCH v8 2/8] dt-bindings: Document Broadcom Cygnus SoC and clocks Scott Branden
2014-10-28 19:53 ` [PATCH v8 3/8] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-28 19:53 ` [PATCH v8 4/8] ARM: dts: Enable " Scott Branden
2014-11-09 0:22 ` Olof Johansson
2014-11-09 6:13 ` Scott Branden
2014-11-09 6:49 ` Olof Johansson
2014-11-09 17:23 ` Greg Kroah-Hartman
2014-11-09 20:38 ` Arnd Bergmann
2014-11-10 5:17 ` Scott Branden
2014-11-10 8:11 ` Arnd Bergmann
2014-11-10 18:28 ` Scott Branden
2014-10-28 19:53 ` [PATCH v8 5/8] MAINTAINERS: Entry for Cygnus/iproc arm architecture Scott Branden
2014-10-28 19:53 ` [PATCH v8 6/8] ARM: mach-bcm: Consolidate currently supported IPROC SoCs Scott Branden
2014-10-28 19:53 ` [PATCH v8 7/8] ARM: mach-bcm: ARCH_BCM_MOBILE: remove one level of menu from Kconfig Scott Branden
2014-10-28 19:53 ` [PATCH v8 8/8] ARM: multi_v7_defconfig: Enable Broadcom Cygnus Scott Branden
2014-10-28 20:01 ` Arnd Bergmann
2014-10-28 20:06 ` Scott Branden
2014-10-28 20:13 ` Arnd Bergmann
2014-10-28 23:15 ` [PATCH v9 0/8] Add initial support for Broadcom Cygnus SoC Scott Branden
2014-10-28 23:15 ` [PATCH v9 1/8] ARM: cygnus: Initial " Scott Branden
2014-10-28 23:15 ` [PATCH v9 2/8] dt-bindings: Document Broadcom Cygnus SoC and clocks Scott Branden
2014-11-20 1:05 ` Mike Turquette
2014-10-28 23:15 ` [PATCH v9 3/8] ARM: cygnus defconfig : Initial defconfig for Broadcom Cygnus SoC Scott Branden
2014-10-28 23:15 ` [PATCH v9 4/8] ARM: dts: Enable " Scott Branden
2014-11-10 10:50 ` Paul Bolle
2014-11-10 18:35 ` Olof Johansson
2014-11-10 19:23 ` Paul Bolle
2014-10-28 23:15 ` [PATCH v9 5/8] MAINTAINERS: Entry for Cygnus/iproc arm architecture Scott Branden
2014-10-28 23:15 ` [PATCH v9 6/8] ARM: mach-bcm: Consolidate currently supported IPROC SoCs Scott Branden
2014-10-28 23:15 ` [PATCH v9 7/8] ARM: mach-bcm: ARCH_BCM_MOBILE: remove one level of menu from Kconfig Scott Branden
2014-10-28 23:15 ` [PATCH v9 8/8] ARM: multi_v7_defconfig: Enable Broadcom Cygnus Scott Branden
2014-10-30 6:36 ` [PATCHv2 0/5] sdhci-bcm2835: added quirk and removed udelay in write ops Scott Branden
2014-10-30 6:36 ` [PATCHv2 1/5] mmc: sdhci-bcm2835: group read and write functions to improve readability Scott Branden
2014-10-30 6:36 ` [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent Scott Branden
2014-11-05 4:48 ` Stephen Warren
2014-11-05 5:19 ` Scott Branden
2014-10-30 6:36 ` [PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround Scott Branden
2014-11-05 4:57 ` Stephen Warren
2014-11-05 6:55 ` Scott Branden
2014-11-06 4:48 ` Stephen Warren
2014-11-07 18:29 ` Scott Branden
2014-10-30 6:36 ` [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround Scott Branden
2014-11-05 4:44 ` Stephen Warren
2014-11-05 5:26 ` Scott Branden
2014-11-05 4:59 ` Stephen Warren
2014-11-05 7:00 ` Scott Branden
2014-11-06 5:01 ` Stephen Warren
2014-11-07 18:31 ` Scott Branden
2015-12-22 15:55 ` Stefan Wahren
2015-12-22 19:23 ` Scott Branden
2015-12-22 20:13 ` Stefan Wahren
2014-10-30 6:36 ` [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 Scott Branden
2014-11-05 5:00 ` Stephen Warren
2014-11-05 7:02 ` Scott Branden
2014-11-06 4:50 ` Stephen Warren
2014-11-07 18:30 ` Scott Branden
2014-11-10 5:55 ` [PATCH 1/2] ARM: multi_v7_defconfig: remove one level of menu from Kconfig Scott Branden
2014-11-10 5:55 ` [PATCH 2/2] ARM: multi_v7_defconfig: Enable Broadcom Cygnus Scott Branden
2014-11-14 18:29 ` [PATCH 0/4] pwm: kona: Drivers fixes Scott Branden
2014-11-14 18:29 ` [PATCH 1/4] pwm: kona: Remove setting default smooth type and polarity for all channels Scott Branden
2014-11-14 18:29 ` [PATCH 2/4] pwm: kona: Fix incorrect enable after channel polarity change Scott Branden
2014-11-14 18:29 ` [PATCH 3/4] pwm: kona: Fix enable, disable and config procedures Scott Branden
2014-11-14 18:30 ` [PATCH 4/4] pwm: kona: Update dependency to ARCH_BCM Scott Branden
2014-11-17 12:52 ` Thierry Reding
2014-11-17 17:33 ` Scott Branden
2014-11-17 12:41 ` [PATCH 0/4] pwm: kona: Drivers fixes Thierry Reding
2014-11-20 19:18 ` [PATCH] mtd: nand: added nand_shutdown Scott Branden
2014-11-26 9:10 ` Brian Norris
2014-11-27 18:28 ` Scott Branden
2014-11-28 0:30 ` Scott Branden
2014-12-04 22:38 ` Scott Branden
2014-11-25 19:40 ` [PATCH v2 0/4] pwm: kona: Drivers fixes Scott Branden
2014-11-25 19:40 ` [PATCH v2 1/4] pwm: kona: Remove setting default smooth type and polarity for all channels Scott Branden
2014-11-26 5:51 ` Tim Kryger
2014-11-28 23:47 ` Arun Ramamurthy
2014-11-29 1:08 ` Tim Kryger
2014-11-29 1:19 ` Arun Ramamurthy
2014-11-29 3:19 ` Tim Kryger [this message]
2014-12-01 19:37 ` Arun Ramamurthy
2014-12-04 20:22 ` Jonathan Richardson
2014-12-06 23:13 ` Tim Kryger
2014-12-10 19:57 ` Jonathan Richardson
2014-11-25 19:40 ` [PATCH v2 2/4] pwm: kona: Fix incorrect enable after channel polarity change Scott Branden
2014-11-26 6:22 ` Tim Kryger
2014-11-28 23:48 ` Arun Ramamurthy
2014-11-29 2:02 ` Tim Kryger
2014-12-04 20:33 ` Jonathan Richardson
2014-11-25 19:40 ` [PATCH v2 3/4] pwm: kona: Fix enable, disable and config procedures Scott Branden
2014-11-26 7:29 ` Tim Kryger
2014-11-27 23:30 ` Scott Branden
2014-11-28 23:49 ` Arun Ramamurthy
2014-11-29 2:30 ` Tim Kryger
2014-12-01 19:37 ` Arun Ramamurthy
2014-12-02 4:29 ` Tim Kryger
2014-12-04 20:26 ` Jonathan Richardson
2014-11-25 19:40 ` [PATCH v2 4/4] pwm: kona: Update dependency to ARCH_BCM Scott Branden
2014-12-04 22:37 ` [PATCH] mtd: add reboot notifier to mtdcore and register nand_shutdown with notifier Scott Branden
2014-12-05 0:13 ` Scott Branden
2014-12-05 2:31 ` Brian Norris
2014-12-05 0:11 ` [PATCH] mmc: sdhci: add quirk for ACMD23 broken Scott Branden
2014-12-05 0:16 ` [PATCH v2] " Scott Branden
2014-12-17 18:36 ` Scott Branden
2014-12-17 19:48 ` Chris Ball
2014-12-17 20:42 ` Scott Branden
2015-02-10 0:06 ` [PATCH 0/4] Add support for IPROC SDHCI controller Scott Branden
2015-02-10 0:06 ` [PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken Scott Branden
2015-02-10 0:06 ` [PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden
2015-02-10 0:06 ` [PATCH 3/4] mmc: sdhci-iproc: add IPROC SDHCI driver Scott Branden
2015-02-10 0:06 ` [PATCH 4/4] mmc: sdhci-iproc: add device tree bindings Scott Branden
2015-03-02 23:50 ` Florian Fainelli
2015-03-04 23:14 ` Scott Branden
2015-02-26 17:28 ` [PATCH 0/4] Add support for IPROC SDHCI controller Scott Branden
2015-02-10 0:07 ` [PATCH 0/2] Add support for Broadcom RNG200 Scott Branden
2015-02-10 0:07 ` [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver Scott Branden
2015-02-10 0:27 ` Joe Perches
2015-02-14 16:36 ` Scott Branden
2015-02-14 17:02 ` Scott Branden
2015-02-10 0:07 ` [PATCH 2/2] hwrng: iproc-rng200 - Add device tree bindings Scott Branden
2015-02-10 0:07 ` [PATCH 0/2] Add support for Broadcom keypad controller Scott Branden
2015-02-10 0:07 ` [PATCH 1/2] Input: bcm-keypad: add device tree bindings Scott Branden
2015-02-10 0:51 ` Dmitry Torokhov
2015-02-14 16:49 ` Scott Branden
2015-02-16 5:17 ` Dmitry Torokhov
2015-02-23 17:49 ` Dmitry Torokhov
2015-02-26 16:13 ` Scott Branden
2015-02-10 0:07 ` [PATCH 2/2] Input: bcm-keypad: Add Broadcom keypad controller Scott Branden
2015-02-10 1:02 ` Dmitry Torokhov
2015-02-14 17:12 ` Scott Branden
2015-02-25 18:16 ` [PATCH v2 0/2] Add support for Broadcom RNG200 Scott Branden
2015-02-25 18:16 ` [PATCH v2 1/2] hwrng: iproc-rng200 - Add device tree bindings Scott Branden
2015-03-02 23:47 ` Florian Fainelli
2015-02-25 18:16 ` [PATCH v2 2/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver Scott Branden
2015-02-25 18:43 ` Dmitry Torokhov
2015-03-03 0:50 ` Scott Branden
2015-02-25 19:17 ` Arnd Bergmann
2015-02-26 19:37 ` Scott Branden
2015-02-26 20:15 ` Arnd Bergmann
2015-02-26 22:26 ` Scott Branden
2015-02-27 9:14 ` Arnd Bergmann
2015-02-28 16:01 ` Scott Branden
2015-02-28 19:31 ` Arnd Bergmann
2015-03-02 19:41 ` Scott Branden
2015-03-02 10:23 ` [PATCH v2 0/2] Add support for Broadcom RNG200 Herbert Xu
2015-02-26 16:08 ` [PATCH v2 0/2] Add support for Broadcom keypad controller Scott Branden
2015-02-26 16:08 ` [PATCH v2 1/2] Input: bcm-keypad: add device tree bindings Scott Branden
2015-02-27 23:39 ` Dmitry Torokhov
2015-02-28 15:41 ` Scott Branden
2015-02-26 16:08 ` [PATCH v2 2/2] Input: bcm-keypad: Add Broadcom keypad controller Scott Branden
2015-02-27 23:44 ` Dmitry Torokhov
2015-02-28 15:52 ` Scott Branden
2015-02-28 14:16 ` Paul Bolle
2015-02-28 15:36 ` Scott Branden
2015-02-28 16:03 ` [PATCH v3 0/2] Add support for " Scott Branden
2015-02-28 16:03 ` [PATCH v3 1/2] Input: bcm-keypad: add device tree bindings Scott Branden
2015-02-28 16:03 ` [PATCH v3 2/2] Input: bcm-keypad: Add Broadcom keypad controller Scott Branden
2015-02-28 16:35 ` [PATCH v4 0/2] Add support for " Scott Branden
2015-02-28 16:35 ` [PATCH v4 1/2] Input: bcm-keypad: add device tree bindings Scott Branden
2015-03-03 0:04 ` Dmitry Torokhov
2015-02-28 16:35 ` [PATCH v4 2/2] Input: bcm-keypad: Add Broadcom keypad controller Scott Branden
2015-02-28 22:10 ` Dmitry Torokhov
2015-02-28 22:15 ` Dmitry Torokhov
2015-03-02 19:37 ` Scott Branden
2015-03-02 20:23 ` Dmitry Torokhov
2015-03-02 21:59 ` Scott Branden
2015-03-02 19:38 ` Scott Branden
2015-03-04 20:42 ` [PATCH v3 0/2] Add support for Broadcom RNG200 Scott Branden
2015-03-04 20:42 ` [PATCH v3 1/2] hwrng: iproc-rng200 - Add device tree bindings Scott Branden
2015-03-04 20:42 ` [PATCH v3 2/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver Scott Branden
2015-03-06 11:53 ` [PATCH v3 0/2] Add support for Broadcom RNG200 Herbert Xu
2015-03-05 15:59 ` [PATCH RESEND 0/4] Add support for IPROC SDHCI controller Scott Branden
2015-03-05 15:59 ` [PATCH 1/4] mmc: sdhci: add quirk for ACMD23 broken Scott Branden
2015-03-05 15:59 ` [PATCH 2/4] mmc: sdhci: do not set AUTO_CMD12 for multi-block CMD53 Scott Branden
2015-03-05 15:59 ` [PATCH 3/4] mmc: sdhci-iproc: add IPROC SDHCI driver Scott Branden
2015-03-05 15:59 ` [PATCH 4/4] mmc: sdhci-iproc: add device tree bindings Scott Branden
2015-03-05 16:16 ` [PATCH RESEND 0/4] Add support for IPROC SDHCI controller Ulf Hansson
2015-03-05 19:57 ` Florian Fainelli
2015-03-10 18:35 ` [PATCH] mmc: sdhci: fix card presence logic in sdhci_request function Scott Branden
2015-03-13 10:14 ` Ulf Hansson
2015-03-16 17:59 ` [PATCH] wireless: rt2x00: add new rt2800usb device DWA 130 Scott Branden
2015-03-20 6:45 ` Kalle Valo
2015-03-16 18:19 ` [PATCH] ARM: amba: Increase number of IRQs Scott Branden
2015-03-16 21:08 ` Russell King - ARM Linux
2015-03-16 21:18 ` Scott Branden
2015-03-16 21:16 ` [PATCH v2 1/1] " Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD7vxxJFuA8V0TiPLQo1LOnRQPbM-QOYDTLkg7Ty0N=Nr7frGQ@mail.gmail.com' \
--to=tim.kryger@gmail.com \
--cc=arun.ramamurthy@broadcom.com \
--cc=arunrama@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).