From: Saravana Kannan <saravanak@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Kevin Hilman" <khilman@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Len Brown" <len.brown@intel.com>, "Pavel Machek" <pavel@ucw.cz>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"David Ahern" <dsahern@kernel.org>,
"Android Kernel Team" <kernel-team@android.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux PM list" <linux-pm@vger.kernel.org>,
"Linux IOMMU" <iommu@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Thomas Bogendoerfer" <tbogendoerfer@suse.de>
Subject: Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up
Date: Wed, 8 Jun 2022 16:15:07 -0700 [thread overview]
Message-ID: <CAGETcx_ZPB2ce-7Zf-bVy4hHe8Nvk62_7HVeO1dhQvg1iuHQDw@mail.gmail.com> (raw)
In-Reply-To: <20220608154908.4ddb9795@kernel.org>
On Wed, Jun 8, 2022 at 3:49 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 8 Jun 2022 14:07:44 -0700 Saravana Kannan wrote:
> > David/Jakub,
> >
> > Do the IP4 autoconfig changes look reasonable to you?
>
> I'm no expert in this area, I'd trust the opinion of the embedded folks
> (adding Florian as well) more than myself.
Thanks.
> It's unclear to me why we'd
> wait_for_init_devices_probe() after the first failed iteration,
wait_for_init_devices_probe() relaxes ordering rules for all devices
and it's not something we want to do unless we really need it. That's
why we are doing that only if we can't find any network device in the
first iteration.
> sleep,
> and then allow 11 more iterations with wait_for_device_probe().
> Let me also add Thomas since he wrote e2ffe3ff6f5e ("net: ipconfig:
> Wait for deferred device probes").
Even without this change, I'm not sure the wait_for_device_probe()
needs to be within the loop. It's probably sufficient to just do it
once in the beginning, but it's already there and I'm not sure if I'm
missing some scenarios, so I left that part as is.
-Saravana
prev parent reply other threads:[~2022-06-08 23:16 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-06-09 11:44 ` Ulf Hansson
2022-06-09 19:29 ` Saravana Kannan
2022-06-21 7:28 ` Tony Lindgren
2022-06-21 19:34 ` Saravana Kannan
2022-06-22 4:58 ` Tony Lindgren
2022-06-22 19:09 ` Saravana Kannan
2022-06-23 7:01 ` Tony Lindgren
2022-06-23 8:21 ` Saravana Kannan
2022-06-27 9:10 ` Tony Lindgren
2022-06-30 23:10 ` Saravana Kannan
2022-06-30 23:26 ` Rob Herring
2022-06-30 23:30 ` Saravana Kannan
2022-07-01 5:33 ` Tony Lindgren
2022-07-01 6:12 ` Tony Lindgren
2022-07-01 8:10 ` Saravana Kannan
2022-07-01 8:26 ` Saravana Kannan
2022-07-01 13:00 ` Tony Lindgren
2022-07-12 7:12 ` Tony Lindgren
2022-07-13 0:49 ` Saravana Kannan
2022-07-13 8:06 ` Tony Lindgren
2022-07-01 15:08 ` Sudeep Holla
2022-07-01 19:13 ` Saravana Kannan
2022-07-05 8:44 ` Saravana Kannan
2022-07-01 7:38 ` Geert Uytterhoeven
2022-06-23 12:08 ` Alexander Stein
2022-07-01 0:37 ` Saravana Kannan
2022-07-01 6:01 ` (EXT) " Alexander Stein
2022-07-01 7:02 ` Saravana Kannan
2022-07-04 7:07 ` (EXT) " Alexander Stein
2022-07-05 1:24 ` Saravana Kannan
2022-07-06 13:02 ` Re: " Alexander Stein
2022-07-13 0:45 ` Saravana Kannan
2022-07-14 6:41 ` Alexander Stein
2022-07-15 22:08 ` Saravana Kannan
2022-07-01 7:30 ` Geert Uytterhoeven
2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan
2022-07-05 9:11 ` Geert Uytterhoeven
2022-07-13 1:40 ` Saravana Kannan
2022-07-13 11:39 ` Geert Uytterhoeven
2022-08-15 8:38 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan
2022-07-20 17:31 ` Geert Uytterhoeven
2022-07-20 19:01 ` Saravana Kannan
2022-07-21 8:40 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan
2022-06-22 7:47 ` Sascha Hauer
2022-06-22 8:44 ` Linus Walleij
2022-06-22 10:52 ` Andy Shevchenko
2022-06-22 11:18 ` Sascha Hauer
2022-06-22 19:40 ` Saravana Kannan
2022-06-22 20:35 ` Saravana Kannan
2022-06-22 22:30 ` Saravana Kannan
2022-06-28 13:09 ` Linus Walleij
2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-08-19 14:26 ` Jean-Philippe Brucker
2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan
2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven
2022-06-08 0:55 ` Saravana Kannan
2022-06-08 4:17 ` Saravana Kannan
2022-06-08 10:25 ` Geert Uytterhoeven
2022-06-08 18:12 ` Saravana Kannan
2022-06-08 18:47 ` Geert Uytterhoeven
2022-06-08 21:07 ` Saravana Kannan
2022-06-08 22:49 ` Jakub Kicinski
2022-06-08 23:15 ` Saravana Kannan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGETcx_ZPB2ce-7Zf-bVy4hHe8Nvk62_7HVeO1dhQvg1iuHQDw@mail.gmail.com \
--to=saravanak@google.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=khilman@kernel.org \
--cc=kuba@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tbogendoerfer@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).