From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] net: mdio: Delete usage of driver_deferred_probe_check_state()
Date: Wed, 13 Jul 2022 13:39:05 +0200 [thread overview]
Message-ID: <CAMuHMdUrpnsvc_G33FQA6GtqNowidMrjjYBEZW-_biBMYvqjgQ@mail.gmail.com> (raw)
In-Reply-To: <CAGETcx-jU5+Tc0Qkt1e4QY0YprYSp-4A+MoaSRjpdPp_8tZm5g@mail.gmail.com>
Hi Saravana,
On Wed, Jul 13, 2022 at 3:40 AM Saravana Kannan <saravanak@google.com> wrote:
> On Tue, Jul 5, 2022 at 2:11 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Jun 1, 2022 at 2:44 PM Saravana Kannan <saravanak@google.com> wrote:
> > > Now that fw_devlink=on by default and fw_devlink supports interrupt
> > > properties, the execution will never get to the point where
> > > driver_deferred_probe_check_state() is called before the supplier has
> > > probed successfully or before deferred probe timeout has expired.
> > >
> > > So, delete the call and replace it with -ENODEV.
> > >
> > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> >
> > Thanks for your patch, which is now commit f8217275b57aa48d ("net:
> > mdio: Delete usage of driver_deferred_probe_check_state()") in
> > driver-core/driver-core-next.
> >
> > Seems like I missed something when providing my T-b for this series,
> > sorry for that.
>
> > arch/arm/boot/dts/r8a7791-koelsch.dts has:
> >
> > ðer {
> > pinctrl-0 = <ðer_pins>, <&phy1_pins>;
> > pinctrl-names = "default";
> >
> > phy-handle = <&phy1>;
> > renesas,ether-link-active-low;
> > status = "okay";
> >
> > phy1: ethernet-phy@1 {
> > compatible = "ethernet-phy-id0022.1537",
> > "ethernet-phy-ieee802.3-c22";
> > reg = <1>;
> > interrupt-parent = <&irqc0>;
> > interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > micrel,led-mode = <1>;
> > reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
> > };
> > };
> >
> > Despite the interrupts property, ðer is now probed before irqc0
> > (interrupt-controller@e61c0000 in arch/arm/boot/dts/r8a7791.dtsi),
> > causing the PHY not finding its interrupt, and resorting to polling:
>
> I'd still expect the device link to have been created properly for
> this phy device. Could you enable the logging in device_link_add() to
> check the link is created between the phy and the IRQ?
>
> My guess is that this probably has something to do with phys being
> attached to drivers differently.
Comparison of dmesg before/after enabling debugging, for
related nodes:
+interrupt-controller@e61c0000 Linked as a fwnode consumer to
clock-controller@e6150000
+pmic@58 Linked as a fwnode consumer to interrupt-controller@e61c0000
+regulator@68 Linked as a fwnode consumer to interrupt-controller@e61c0000
Other user of irqc
+ethernet@ee700000 Linked as a fwnode consumer to clock-controller@e6150000
+ethernet@ee700000 Linked as a fwnode consumer to pinctrl@e6060000
+ethernet-phy@1 Linked as a fwnode consumer to interrupt-controller@e61c0000
+ethernet-phy@1 Linked as a fwnode consumer to gpio@e6055000
PHY linked correctly to consumers
+device: 'e61c0000.interrupt-controller': device_add
+device: 'platform:e6150000.clock-controller--platform:e61c0000.interrupt-controller':
device_add
+devices_kset: Moving e61c0000.interrupt-controller to end of list
+platform e61c0000.interrupt-controller: Linked as a consumer to
e6150000.clock-controller
+interrupt-controller@e61c0000 Dropping the fwnode link to
clock-controller@e6150000
+platform e61c0000.interrupt-controller: error -EPROBE_DEFER:
supplier e6150000.clock-controller not ready
Tried to probe irqc (why? consumer not ready), deferred.
+device: 'platform:e61c0000.interrupt-controller--platform:e60b0000.i2c':
device_add
+platform e60b0000.i2c: Linked as a sync state only consumer to
e61c0000.interrupt-controller
I guess sync state means through other (child) consumers (pmic,
regulator) above?
+device: 'ee700000.ethernet': device_add
+device: 'platform:e6060000.pinctrl--platform:ee700000.ethernet': device_add
+devices_kset: Moving ee700000.ethernet to end of list
+platform ee700000.ethernet: Linked as a consumer to e6060000.pinctrl
+ethernet@ee700000 Dropping the fwnode link to pinctrl@e6060000
+device: 'platform:e6150000.clock-controller--platform:ee700000.ethernet':
device_add
+devices_kset: Moving ee700000.ethernet to end of list
+platform ee700000.ethernet: Linked as a consumer to
e6150000.clock-controller
+ethernet@ee700000 Dropping the fwnode link to clock-controller@e6150000
+device: 'platform:e6055000.gpio--platform:ee700000.ethernet': device_add
+platform ee700000.ethernet: Linked as a sync state only consumer
to e6055000.gpio
+device: 'platform:e61c0000.interrupt-controller--platform:ee700000.ethernet':
device_add
+platform ee700000.ethernet: Linked as a sync state only consumer
to e61c0000.interrupt-controller
Hence linking ethernet to child (phy) consumers.
+device: 'ee700000.ethernet-ffffffff': device_add
Probing ethernet...
libphy: fwnode_get_phy_id: fwnode
/soc/ethernet@ee700000/ethernet-phy@1 phy_id = 0x00221537
libphy: fwnode_get_phy_id: fwnode
/soc/ethernet@ee700000/ethernet-phy@1 phy_id = 0x00221537
+fwnode_mdiobus_phy_device_register: fwnode_irq_get() returned -517
+fwnode_mdiobus_phy_device_register: ignoring -EPROBE_DEFER
This is the part that got changed by this patch.
+device: 'ee700000.ethernet-ffffffff:01': device_add
+device: 'platform:e6055000.gpio--mdio_bus:ee700000.ethernet-ffffffff:01':
device_add
+devices_kset: Moving ee700000.ethernet-ffffffff:01 to end of list
+mdio_bus ee700000.ethernet-ffffffff:01: Linked as a consumer to
e6055000.gpio
+ethernet-phy@1 Dropping the fwnode link to gpio@e6055000
+device: 'platform:e61c0000.interrupt-controller--mdio_bus:ee700000.ethernet-ffffffff:01':
device_add
+devices_kset: Moving ee700000.ethernet-ffffffff:01 to end of list
+mdio_bus ee700000.ethernet-ffffffff:01: Linked as a consumer to
e61c0000.interrupt-controller
+ethernet-phy@1 Dropping the fwnode link to interrupt-controller@e61c0000
+mdio_bus ee700000.ethernet-ffffffff:01: error -EPROBE_DEFER:
supplier e61c0000.interrupt-controller not ready
Why was ethernet probed this early?
We knew the supplier of the phy was still missing?
+device: 'eth1': device_add
sh-eth ee700000.ethernet eth1: Base address at 0xee700000,
2e:09:0a:00:6d:85, IRQ 104.
+sh-eth ee700000.ethernet: Dropping the link to e6055000.gpio
+device: 'platform:e6055000.gpio--platform:ee700000.ethernet':
device_unregister
+sh-eth ee700000.ethernet: Dropping the link to
e61c0000.interrupt-controller
+device: 'platform:e61c0000.interrupt-controller--platform:ee700000.ethernet':
device_unregister
+devices_kset: Moving e61c0000.interrupt-controller to end of list
+devices_kset: Moving ee700000.ethernet-ffffffff:01 to end of list
renesas_irqc e61c0000.interrupt-controller: driving 10 irqs
Finally, irqc is probed.
+device: '6-0058': device_add
+device: 'platform:e61c0000.interrupt-controller--i2c:6-0058': device_add
+devices_kset: Moving 6-0058 to end of list
+i2c 6-0058: Linked as a consumer to e61c0000.interrupt-controller
+pmic@58 Dropping the fwnode link to interrupt-controller@e61c0000
+device: '6-0068': device_add
+device: 'platform:e61c0000.interrupt-controller--i2c:6-0068': device_add
+devices_kset: Moving 6-0068 to end of list
+i2c 6-0068: Linked as a consumer to e61c0000.interrupt-controller
+regulator@68 Dropping the fwnode link to interrupt-controller@e61c0000
Propagating other irqc suppliers to the parent of their consumers
+i2c-sh_mobile e60b0000.i2c: Dropping the link to
e61c0000.interrupt-controller
+device: 'platform:e61c0000.interrupt-controller--platform:e60b0000.i2c':
device_unregister
+devices_kset: Moving ee700000.ethernet-ffffffff:01 to end of list
Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: attached PHY
driver (mii_bus:phy_addr=ee700000.ethernet-ffffffff:01, irq=POLL)
sh-eth ee700000.ethernet eth1: Link is Up - 100Mbps/Full - flow control off
Sending DHCP requests ., OK
> > -Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: attached PHY
> > driver (mii_bus:phy_addr=ee700000.ethernet-ffffffff:01, irq=185)
> > +Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: attached PHY
> > driver (mii_bus:phy_addr=ee700000.ethernet-ffffffff:01, irq=POLL)
>
> Can you drop a WARN() where this is printed to get the stack trace to
> check my hypothesis?
That didn't help much, as this is the messenger, not the cause.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-07-13 11:45 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-06-09 11:44 ` Ulf Hansson
2022-06-09 19:29 ` Saravana Kannan
2022-06-21 7:28 ` Tony Lindgren
2022-06-21 19:34 ` Saravana Kannan
2022-06-22 4:58 ` Tony Lindgren
2022-06-22 19:09 ` Saravana Kannan
2022-06-23 7:01 ` Tony Lindgren
2022-06-23 8:21 ` Saravana Kannan
2022-06-27 9:10 ` Tony Lindgren
2022-06-30 23:10 ` Saravana Kannan
2022-06-30 23:26 ` Rob Herring
2022-06-30 23:30 ` Saravana Kannan
2022-07-01 5:33 ` Tony Lindgren
2022-07-01 6:12 ` Tony Lindgren
2022-07-01 8:10 ` Saravana Kannan
2022-07-01 8:26 ` Saravana Kannan
2022-07-01 13:00 ` Tony Lindgren
2022-07-12 7:12 ` Tony Lindgren
2022-07-13 0:49 ` Saravana Kannan
2022-07-13 8:06 ` Tony Lindgren
2022-07-01 15:08 ` Sudeep Holla
2022-07-01 19:13 ` Saravana Kannan
2022-07-05 8:44 ` Saravana Kannan
2022-07-01 7:38 ` Geert Uytterhoeven
2022-06-23 12:08 ` Alexander Stein
2022-07-01 0:37 ` Saravana Kannan
2022-07-01 6:01 ` (EXT) " Alexander Stein
2022-07-01 7:02 ` Saravana Kannan
2022-07-04 7:07 ` (EXT) " Alexander Stein
2022-07-05 1:24 ` Saravana Kannan
2022-07-06 13:02 ` Re: " Alexander Stein
2022-07-13 0:45 ` Saravana Kannan
2022-07-14 6:41 ` Alexander Stein
2022-07-15 22:08 ` Saravana Kannan
2022-07-01 7:30 ` Geert Uytterhoeven
2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan
2022-07-05 9:11 ` Geert Uytterhoeven
2022-07-13 1:40 ` Saravana Kannan
2022-07-13 11:39 ` Geert Uytterhoeven [this message]
2022-08-15 8:38 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan
2022-07-20 17:31 ` Geert Uytterhoeven
2022-07-20 19:01 ` Saravana Kannan
2022-07-21 8:40 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan
2022-06-22 7:47 ` Sascha Hauer
2022-06-22 8:44 ` Linus Walleij
2022-06-22 10:52 ` Andy Shevchenko
2022-06-22 11:18 ` Sascha Hauer
2022-06-22 19:40 ` Saravana Kannan
2022-06-22 20:35 ` Saravana Kannan
2022-06-22 22:30 ` Saravana Kannan
2022-06-28 13:09 ` Linus Walleij
2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-08-19 14:26 ` Jean-Philippe Brucker
2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan
2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven
2022-06-08 0:55 ` Saravana Kannan
2022-06-08 4:17 ` Saravana Kannan
2022-06-08 10:25 ` Geert Uytterhoeven
2022-06-08 18:12 ` Saravana Kannan
2022-06-08 18:47 ` Geert Uytterhoeven
2022-06-08 21:07 ` Saravana Kannan
2022-06-08 22:49 ` Jakub Kicinski
2022-06-08 23:15 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUrpnsvc_G33FQA6GtqNowidMrjjYBEZW-_biBMYvqjgQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=khilman@kernel.org \
--cc=kuba@kernel.org \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).