From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Saravana Kannan <saravanak@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Kevin Hilman" <khilman@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Len Brown" <len.brown@intel.com>, "Pavel Machek" <pavel@ucw.cz>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"David Ahern" <dsahern@kernel.org>,
"Android Kernel Team" <kernel-team@android.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux PM list" <linux-pm@vger.kernel.org>,
"Linux IOMMU" <iommu@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up
Date: Wed, 8 Jun 2022 20:47:36 +0200 [thread overview]
Message-ID: <CAMuHMdXQCwMQj_ZiOBAzusdCxd8w6NbTqD_7nzykhVs+UWx8Gw@mail.gmail.com> (raw)
In-Reply-To: <CAGETcx_Nqo4ju7cWwO3dP3YM2wpCb0jx23OHOReexOjpT5pATA@mail.gmail.com>
Hi Saravana,
On Wed, Jun 8, 2022 at 8:13 PM Saravana Kannan <saravanak@google.com> wrote:
> On Wed, Jun 8, 2022 at 3:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Jun 8, 2022 at 6:17 AM Saravana Kannan <saravanak@google.com> wrote:
> > > On Tue, Jun 7, 2022 at 5:55 PM Saravana Kannan <saravanak@google.com> wrote:
> > > > On Tue, Jun 7, 2022 at 11:13 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > On Wed, Jun 1, 2022 at 12:46 PM Saravana Kannan <saravanak@google.com> wrote:
> > > > > > This series is based on linux-next + these 2 small patches applies on top:
> > > > > > https://lore.kernel.org/lkml/20220526034609.480766-1-saravanak@google.com/
> > > > > >
> > > > > > A lot of the deferred_probe_timeout logic is redundant with
> > > > > > fw_devlink=on. Also, enabling deferred_probe_timeout by default breaks
> > > > > > a few cases.
> > > > > >
> > > > > > This series tries to delete the redundant logic, simplify the frameworks
> > > > > > that use driver_deferred_probe_check_state(), enable
> > > > > > deferred_probe_timeout=10 by default, and fixes the nfsroot failure
> > > > > > case.
> > > > > >
> > > > > > The overall idea of this series is to replace the global behavior of
> > > > > > driver_deferred_probe_check_state() where all devices give up waiting on
> > > > > > supplier at the same time with a more granular behavior:
> > > > > >
> > > > > > 1. Devices with all their suppliers successfully probed by late_initcall
> > > > > > probe as usual and avoid unnecessary deferred probe attempts.
> > > > > >
> > > > > > 2. At or after late_initcall, in cases where boot would break because of
> > > > > > fw_devlink=on being strict about the ordering, we
> > > > > >
> > > > > > a. Temporarily relax the enforcement to probe any unprobed devices
> > > > > > that can probe successfully in the current state of the system.
> > > > > > For example, when we boot with a NFS rootfs and no network device
> > > > > > has probed.
> > > > > > b. Go back to enforcing the ordering for any devices that haven't
> > > > > > probed.
> > > > > >
> > > > > > 3. After deferred probe timeout expires, we permanently give up waiting
> > > > > > on supplier devices without drivers. At this point, whatever devices
> > > > > > can probe without some of their optional suppliers end up probing.
> > > > > >
> > > > > > In the case where module support is disabled, it's fairly
> > > > > > straightforward and all device probes are completed before the initcalls
> > > > > > are done.
> > > > > >
> > > > > > Patches 1 to 3 are fairly straightforward and can probably be applied
> > > > > > right away.
> > > > > >
> > > > > > Patches 4 to 6 are for fixing the NFS rootfs issue and setting the
> > > > > > default deferred_probe_timeout back to 10 seconds when modules are
> > > > > > enabled.
> > > > > >
> > > > > > Patches 7 to 9 are further clean up of the deferred_probe_timeout logic
> > > > > > so that no framework has to know/care about deferred_probe_timeout.
> > > > > >
> > > > > > Yoshihiro/Geert,
> > > > > >
> > > > > > If you can test this patch series and confirm that the NFS root case
> > > > > > works, I'd really appreciate that.
> > > > >
> > > > > Thanks, I gave this a try on various boards I have access to.
> > > > > The results were quite positive. E.g. the compile error I saw on v1
> > > > > (implicit declation of fw_devlink_unblock_may_probe(), which is no longer
> > > > > used in v2) is gone.
> > > >
> > > > Thanks a lot for testing these.
> > > >
> > > > > However, I'm seeing a weird error when userspace (Debian9 nfsroot) is
> > > > > starting:
> > Setting fw_devlink_strict to true vs. false seems to influence which of
> > two different failures will happen:
> > - rcar-csi2: probe of feaa0000.csi2 failed with error -22
> > - rcar-vin: probe of e6ef5000.video failed with error -22
> > The former causes the NULL pointer dereference later.
> > The latter existed before, but I hadn't noticed it, and bisection
> > led to the real culprit (commit 3e52419ec04f9769 ("media: rcar-{csi2,vin}:
> > Move to full Virtual Channel routing per CSI-2 IP").
>
> If you revert that patch, does this series work fine? If yes, are you
> happy with giving this a Tested-by?
Sure, sorry for forgetting that ;-)
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-06-08 18:47 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-06-09 11:44 ` Ulf Hansson
2022-06-09 19:29 ` Saravana Kannan
2022-06-21 7:28 ` Tony Lindgren
2022-06-21 19:34 ` Saravana Kannan
2022-06-22 4:58 ` Tony Lindgren
2022-06-22 19:09 ` Saravana Kannan
2022-06-23 7:01 ` Tony Lindgren
2022-06-23 8:21 ` Saravana Kannan
2022-06-27 9:10 ` Tony Lindgren
2022-06-30 23:10 ` Saravana Kannan
2022-06-30 23:26 ` Rob Herring
2022-06-30 23:30 ` Saravana Kannan
2022-07-01 5:33 ` Tony Lindgren
2022-07-01 6:12 ` Tony Lindgren
2022-07-01 8:10 ` Saravana Kannan
2022-07-01 8:26 ` Saravana Kannan
2022-07-01 13:00 ` Tony Lindgren
2022-07-12 7:12 ` Tony Lindgren
2022-07-13 0:49 ` Saravana Kannan
2022-07-13 8:06 ` Tony Lindgren
2022-07-01 15:08 ` Sudeep Holla
2022-07-01 19:13 ` Saravana Kannan
2022-07-05 8:44 ` Saravana Kannan
2022-07-01 7:38 ` Geert Uytterhoeven
2022-06-23 12:08 ` Alexander Stein
2022-07-01 0:37 ` Saravana Kannan
2022-07-01 6:01 ` (EXT) " Alexander Stein
2022-07-01 7:02 ` Saravana Kannan
2022-07-04 7:07 ` (EXT) " Alexander Stein
2022-07-05 1:24 ` Saravana Kannan
2022-07-06 13:02 ` Re: " Alexander Stein
2022-07-13 0:45 ` Saravana Kannan
2022-07-14 6:41 ` Alexander Stein
2022-07-15 22:08 ` Saravana Kannan
2022-07-01 7:30 ` Geert Uytterhoeven
2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan
2022-07-05 9:11 ` Geert Uytterhoeven
2022-07-13 1:40 ` Saravana Kannan
2022-07-13 11:39 ` Geert Uytterhoeven
2022-08-15 8:38 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan
2022-07-20 17:31 ` Geert Uytterhoeven
2022-07-20 19:01 ` Saravana Kannan
2022-07-21 8:40 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan
2022-06-22 7:47 ` Sascha Hauer
2022-06-22 8:44 ` Linus Walleij
2022-06-22 10:52 ` Andy Shevchenko
2022-06-22 11:18 ` Sascha Hauer
2022-06-22 19:40 ` Saravana Kannan
2022-06-22 20:35 ` Saravana Kannan
2022-06-22 22:30 ` Saravana Kannan
2022-06-28 13:09 ` Linus Walleij
2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-08-19 14:26 ` Jean-Philippe Brucker
2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan
2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven
2022-06-08 0:55 ` Saravana Kannan
2022-06-08 4:17 ` Saravana Kannan
2022-06-08 10:25 ` Geert Uytterhoeven
2022-06-08 18:12 ` Saravana Kannan
2022-06-08 18:47 ` Geert Uytterhoeven [this message]
2022-06-08 21:07 ` Saravana Kannan
2022-06-08 22:49 ` Jakub Kicinski
2022-06-08 23:15 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXQCwMQj_ZiOBAzusdCxd8w6NbTqD_7nzykhVs+UWx8Gw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=khilman@kernel.org \
--cc=kuba@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).