From: Jean-Philippe Brucker <jpb@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
eric.auger@redhat.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, kernel-team@android.com
Subject: Re: [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state()
Date: Fri, 19 Aug 2022 15:26:45 +0100 [thread overview]
Message-ID: <Yv+dpeIPvde7oDHi@myrica> (raw)
In-Reply-To: <20220601070707.3946847-9-saravanak@google.com>
Hi Saravana,
On Wed, Jun 01, 2022 at 12:07:04AM -0700, Saravana Kannan via iommu wrote:
> Now that fw_devlink=on and fw_devlink.strict=1 by default and fw_devlink
> supports iommu DT properties, the execution will never get to the point
> where driver_deferred_probe_check_state() is called before the supplier
> has probed successfully or before deferred probe timeout has expired.
>
> So, delete the call and replace it with -ENODEV.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/iommu/of_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
> index 5696314ae69e..41f4eb005219 100644
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -40,7 +40,7 @@ static int of_iommu_xlate(struct device *dev,
> * a proper probe-ordering dependency mechanism in future.
> */
> if (!ops)
> - return driver_deferred_probe_check_state(dev);
> + return -ENODEV;
Unfortunately this breaks virtio-iommu on v6.0-rc1. Could you add it to
your revert series [1]?
Eventually I'd really like to use fw_devlink in order to enable module
support, so I'm looking for a proper fix. Our DT description is peculiar
because the virtio-iommu, when it uses the virtio-pci transport, can
appear on the same PCI bus than the endpoints it manages. So the PCI node
looks like this:
pcie@10000000 {
compatible = "pci-host-ecam-generic";
...
iommu-map = <0x00 &viommu 0x00 0x20>
<0x21 &viommu 0x21 0xffdf>;
viommu: virtio_iommu@32 {
#iommu-cells = <0x01>;
reg = <0x2000 0x00 0x00 0x00 0x00>;
compatible = "virtio,pci-iommu";
};
};
The iommu-map property points to the IOMMU sub-node for all endpoints
except the IOMMU itself (device 0x20 - 00:04.0). fw_devlink currently
rejects this:
[ 0.270150] OF: Not linking pcie@10000000 to virtio_iommu@32 - is descendant
[ 0.270324] OF: Not linking pcie@10000000 to virtio_iommu@32 - is descendant
I don't know yet if this kind of topology could ever work with fw_devlink,
but I thought I'd notify you before digging further.
Thanks,
Jean
[1] https://lore.kernel.org/all/20220727185012.3255200-1-saravanak@google.com/#t
>
> if (!try_module_get(ops->owner))
> return -ENODEV;
> --
> 2.36.1.255.ge46751e96f-goog
>
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-08-19 14:27 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-06-09 11:44 ` Ulf Hansson
2022-06-09 19:29 ` Saravana Kannan
2022-06-21 7:28 ` Tony Lindgren
2022-06-21 19:34 ` Saravana Kannan
2022-06-22 4:58 ` Tony Lindgren
2022-06-22 19:09 ` Saravana Kannan
2022-06-23 7:01 ` Tony Lindgren
2022-06-23 8:21 ` Saravana Kannan
2022-06-27 9:10 ` Tony Lindgren
2022-06-30 23:10 ` Saravana Kannan
2022-06-30 23:26 ` Rob Herring
2022-06-30 23:30 ` Saravana Kannan
2022-07-01 5:33 ` Tony Lindgren
2022-07-01 6:12 ` Tony Lindgren
2022-07-01 8:10 ` Saravana Kannan
2022-07-01 8:26 ` Saravana Kannan
2022-07-01 13:00 ` Tony Lindgren
2022-07-12 7:12 ` Tony Lindgren
2022-07-13 0:49 ` Saravana Kannan
2022-07-13 8:06 ` Tony Lindgren
2022-07-01 15:08 ` Sudeep Holla
2022-07-01 19:13 ` Saravana Kannan
2022-07-05 8:44 ` Saravana Kannan
2022-07-01 7:38 ` Geert Uytterhoeven
2022-06-23 12:08 ` Alexander Stein
2022-07-01 0:37 ` Saravana Kannan
2022-07-01 6:01 ` (EXT) " Alexander Stein
2022-07-01 7:02 ` Saravana Kannan
2022-07-04 7:07 ` (EXT) " Alexander Stein
2022-07-05 1:24 ` Saravana Kannan
2022-07-06 13:02 ` Re: " Alexander Stein
2022-07-13 0:45 ` Saravana Kannan
2022-07-14 6:41 ` Alexander Stein
2022-07-15 22:08 ` Saravana Kannan
2022-07-01 7:30 ` Geert Uytterhoeven
2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan
2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan
2022-07-05 9:11 ` Geert Uytterhoeven
2022-07-13 1:40 ` Saravana Kannan
2022-07-13 11:39 ` Geert Uytterhoeven
2022-08-15 8:38 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan
2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan
2022-07-20 17:31 ` Geert Uytterhoeven
2022-07-20 19:01 ` Saravana Kannan
2022-07-21 8:40 ` Geert Uytterhoeven
2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan
2022-06-22 7:47 ` Sascha Hauer
2022-06-22 8:44 ` Linus Walleij
2022-06-22 10:52 ` Andy Shevchenko
2022-06-22 11:18 ` Sascha Hauer
2022-06-22 19:40 ` Saravana Kannan
2022-06-22 20:35 ` Saravana Kannan
2022-06-22 22:30 ` Saravana Kannan
2022-06-28 13:09 ` Linus Walleij
2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-08-19 14:26 ` Jean-Philippe Brucker [this message]
2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan
2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven
2022-06-08 0:55 ` Saravana Kannan
2022-06-08 4:17 ` Saravana Kannan
2022-06-08 10:25 ` Geert Uytterhoeven
2022-06-08 18:12 ` Saravana Kannan
2022-06-08 18:47 ` Geert Uytterhoeven
2022-06-08 21:07 ` Saravana Kannan
2022-06-08 22:49 ` Jakub Kicinski
2022-06-08 23:15 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv+dpeIPvde7oDHi@myrica \
--to=jpb@kernel.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).