* [PATCHv1] NVMe: nvme_queue made cache friendly. @ 2015-05-20 20:43 Parav Pandit 2015-05-21 20:45 ` J Freyensee 0 siblings, 1 reply; 4+ messages in thread From: Parav Pandit @ 2015-05-20 20:43 UTC (permalink / raw) To: linux-nvme, willy; +Cc: parav.pandit, axboe, linux-kernel nvme_queue structure made 64B cache friendly so that majority of the data elements of the structure during IO and completion path can be found in typical single 64B cache line size which was previously spanning beyond single 64B cache line size. By aligning most of the fields are found at start of the structure. Elements which are not used in frequent IO path are moved at the end of structure. Signed-off-by: Parav Pandit <parav.pandit@avagotech.com> --- drivers/block/nvme-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index b9ba36f..58041c7 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme-core.c @@ -98,23 +98,23 @@ struct async_cmd_info { struct nvme_queue { struct device *q_dmadev; struct nvme_dev *dev; - char irqname[24]; /* nvme4294967295-65535\0 */ - spinlock_t q_lock; struct nvme_command *sq_cmds; + struct blk_mq_hw_ctx *hctx; volatile struct nvme_completion *cqes; - dma_addr_t sq_dma_addr; - dma_addr_t cq_dma_addr; u32 __iomem *q_db; + spinlock_t q_lock; u16 q_depth; - s16 cq_vector; u16 sq_head; u16 sq_tail; u16 cq_head; u16 qid; + s16 cq_vector; u8 cq_phase; u8 cqe_seen; struct async_cmd_info cmdinfo; - struct blk_mq_hw_ctx *hctx; + char irqname[24]; /* nvme4294967295-65535\0 */ + dma_addr_t sq_dma_addr; + dma_addr_t cq_dma_addr; }; /* -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv1] NVMe: nvme_queue made cache friendly. 2015-05-20 20:43 [PATCHv1] NVMe: nvme_queue made cache friendly Parav Pandit @ 2015-05-21 20:45 ` J Freyensee 2015-05-22 4:52 ` Parav Pandit 0 siblings, 1 reply; 4+ messages in thread From: J Freyensee @ 2015-05-21 20:45 UTC (permalink / raw) To: Parav Pandit; +Cc: linux-nvme, willy, axboe, linux-kernel On Wed, 2015-05-20 at 16:43 -0400, Parav Pandit wrote: > nvme_queue structure made 64B cache friendly so that majority of the > data elements of the structure during IO and completion path can be > found in typical single 64B cache line size which was previously spanning > beyond single 64B cache line size. > > By aligning most of the fields are found at start of the structure. > Elements which are not used in frequent IO path are moved at the > end of structure. I'll repeat the same question Matthew said last time: "Have you done any performance measurements on this?" If the answer is no, then I'm not sure why the patch is even being sent to apply to the code base if the main reason is performance-related. >From the comments from the last patch attempt, it did not even sound like there was a good understanding where the q_lock should go for best performance. I think it would be better to have some results to go along with the patch request. At least it would be known for sure where the q_lock should go. And that would be good knowledge to know for future programming projects. > > Signed-off-by: Parav Pandit <parav.pandit@avagotech.com> > --- > drivers/block/nvme-core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c > index b9ba36f..58041c7 100644 > --- a/drivers/block/nvme-core.c > +++ b/drivers/block/nvme-core.c > @@ -98,23 +98,23 @@ struct async_cmd_info { > struct nvme_queue { > struct device *q_dmadev; > struct nvme_dev *dev; > - char irqname[24]; /* nvme4294967295-65535\0 */ > - spinlock_t q_lock; > struct nvme_command *sq_cmds; > + struct blk_mq_hw_ctx *hctx; > volatile struct nvme_completion *cqes; > - dma_addr_t sq_dma_addr; > - dma_addr_t cq_dma_addr; > u32 __iomem *q_db; > + spinlock_t q_lock; > u16 q_depth; > - s16 cq_vector; > u16 sq_head; > u16 sq_tail; > u16 cq_head; > u16 qid; > + s16 cq_vector; > u8 cq_phase; > u8 cqe_seen; > struct async_cmd_info cmdinfo; > - struct blk_mq_hw_ctx *hctx; > + char irqname[24]; /* nvme4294967295-65535\0 */ > + dma_addr_t sq_dma_addr; > + dma_addr_t cq_dma_addr; > }; > > /* ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv1] NVMe: nvme_queue made cache friendly. 2015-05-21 20:45 ` J Freyensee @ 2015-05-22 4:52 ` Parav Pandit 2015-06-02 7:08 ` Parav Pandit 0 siblings, 1 reply; 4+ messages in thread From: Parav Pandit @ 2015-05-22 4:52 UTC (permalink / raw) To: J Freyensee; +Cc: linux-nvme, Matthew Wilcox, Jens Axboe, linux-kernel On Fri, May 22, 2015 at 2:15 AM, J Freyensee <james_p_freyensee@linux.intel.com> wrote: > On Wed, 2015-05-20 at 16:43 -0400, Parav Pandit wrote: >> nvme_queue structure made 64B cache friendly so that majority of the >> data elements of the structure during IO and completion path can be >> found in typical single 64B cache line size which was previously spanning >> beyond single 64B cache line size. >> >> By aligning most of the fields are found at start of the structure. >> Elements which are not used in frequent IO path are moved at the >> end of structure. > > I'll repeat the same question Matthew said last time: > > "Have you done any performance measurements on this?" > > If the answer is no, then I'm not sure why the patch is even being sent > to apply to the code base if the main reason is performance-related. > From the comments from the last patch attempt, it did not even sound > like there was a good understanding where the q_lock should go for best > performance. > I should be able to do performance test for cache accesses in few days. However its pretty clear from the nvme_queue structure that, spinlock sitting between irq_name array and other data path specific elements is not a best way because irq_name array is not needed along with q_lock. so other related elements should be close to it, instead of name. On x86 in non paravirtualized mode, without any padding spinlock_t is 16-bit. There is auto padding done to align to 32/64-bit boundary for spinlock. spinlock placed along with other u16 elements further makes it naturally aligned without need of padding. Similarly DMA addresses at in middle of other data path structure is not good idea as they are not needed in same cache line either. With existing structure, IO path elements of nvme_queue are clearly residing in two cache lines. So moving irq_name and dma address at end is fairly simple change. > I think it would be better to have some results to go along with the > patch request. At least it would be known for sure where the q_lock > should go. And that would be good knowledge to know for future > programming projects. > >> >> Signed-off-by: Parav Pandit <parav.pandit@avagotech.com> >> --- >> drivers/block/nvme-core.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c >> index b9ba36f..58041c7 100644 >> --- a/drivers/block/nvme-core.c >> +++ b/drivers/block/nvme-core.c >> @@ -98,23 +98,23 @@ struct async_cmd_info { >> struct nvme_queue { >> struct device *q_dmadev; >> struct nvme_dev *dev; >> - char irqname[24]; /* nvme4294967295-65535\0 */ >> - spinlock_t q_lock; >> struct nvme_command *sq_cmds; >> + struct blk_mq_hw_ctx *hctx; >> volatile struct nvme_completion *cqes; >> - dma_addr_t sq_dma_addr; >> - dma_addr_t cq_dma_addr; >> u32 __iomem *q_db; >> + spinlock_t q_lock; >> u16 q_depth; >> - s16 cq_vector; >> u16 sq_head; >> u16 sq_tail; >> u16 cq_head; >> u16 qid; >> + s16 cq_vector; >> u8 cq_phase; >> u8 cqe_seen; >> struct async_cmd_info cmdinfo; >> - struct blk_mq_hw_ctx *hctx; >> + char irqname[24]; /* nvme4294967295-65535\0 */ >> + dma_addr_t sq_dma_addr; >> + dma_addr_t cq_dma_addr; >> }; >> >> /* > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv1] NVMe: nvme_queue made cache friendly. 2015-05-22 4:52 ` Parav Pandit @ 2015-06-02 7:08 ` Parav Pandit 0 siblings, 0 replies; 4+ messages in thread From: Parav Pandit @ 2015-06-02 7:08 UTC (permalink / raw) To: J Freyensee; +Cc: linux-nvme, Matthew Wilcox, Jens Axboe, linux-kernel On Fri, May 22, 2015 at 10:22 AM, Parav Pandit <parav.pandit@avagotech.com> wrote: > On Fri, May 22, 2015 at 2:15 AM, J Freyensee > <james_p_freyensee@linux.intel.com> wrote: >> On Wed, 2015-05-20 at 16:43 -0400, Parav Pandit wrote: >>> nvme_queue structure made 64B cache friendly so that majority of the >>> data elements of the structure during IO and completion path can be >>> found in typical single 64B cache line size which was previously spanning >>> beyond single 64B cache line size. >>> >>> By aligning most of the fields are found at start of the structure. >>> Elements which are not used in frequent IO path are moved at the >>> end of structure. >> >> I'll repeat the same question Matthew said last time: >> >> "Have you done any performance measurements on this?" >> >> If the answer is no, then I'm not sure why the patch is even being sent >> to apply to the code base if the main reason is performance-related. >> From the comments from the last patch attempt, it did not even sound >> like there was a good understanding where the q_lock should go for best >> performance. >> > > I should be able to do performance test for cache accesses in few days. > I am finally able to do the performance tests with Patch v1 changes using perf tool on Intel 750 Series Gen3 NVMe card. Summary: In a performance test run of 512 bytes IO for IO count of 10000000, with packed structure, L1-dcache-loads are higher from 9,146,849,853 to 9,147,300,101. overall cache misses is lower by 20,000 roughly. In the test, dd and irq both affinity were set to same CPU using cpuset cgroup and /proc/irq/31/smp_affinity respectively. Network load etc were left to run on other CPUs. IO size: 512 bytes IO type: read from NVMe count: 10000000 IRQ and dd application affinity: CPU_2. Test ran for 10 iterations. Tool used to see hardware cache events: perf stat -e cache-misses Command: dd if=/dev/nvme0n1 of=/dev/null bs=512 count=10000000 cache results were not always consistent but there were in same range with new code. Tested with 20 iterations with existing and new structure. IO count and iteration are picked up empirically to avoid the effect of page cache pressure, instead of using O_DIRECT. (Meaning page cache was available in both the tests). > However its pretty clear from the nvme_queue structure that, > spinlock sitting between irq_name array and other data path specific > elements is not a best way because irq_name array is not needed along > with q_lock. > so other related elements should be close to it, instead of name. > > On x86 in non paravirtualized mode, without any padding spinlock_t is 16-bit. > There is auto padding done to align to 32/64-bit boundary for spinlock. > spinlock placed along with other u16 elements further makes it > naturally aligned without need of padding. > > Similarly DMA addresses at in middle of other data path structure is > not good idea as they are not needed in same cache line either. > With existing structure, IO path elements of nvme_queue are clearly > residing in two cache lines. > So moving irq_name and dma address at end is fairly simple change. > >> I think it would be better to have some results to go along with the >> patch request. At least it would be known for sure where the q_lock >> should go. And that would be good knowledge to know for future >> programming projects. > >> >>> >>> Signed-off-by: Parav Pandit <parav.pandit@avagotech.com> >>> --- >>> drivers/block/nvme-core.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c >>> index b9ba36f..58041c7 100644 >>> --- a/drivers/block/nvme-core.c >>> +++ b/drivers/block/nvme-core.c >>> @@ -98,23 +98,23 @@ struct async_cmd_info { >>> struct nvme_queue { >>> struct device *q_dmadev; >>> struct nvme_dev *dev; >>> - char irqname[24]; /* nvme4294967295-65535\0 */ >>> - spinlock_t q_lock; >>> struct nvme_command *sq_cmds; >>> + struct blk_mq_hw_ctx *hctx; >>> volatile struct nvme_completion *cqes; >>> - dma_addr_t sq_dma_addr; >>> - dma_addr_t cq_dma_addr; >>> u32 __iomem *q_db; >>> + spinlock_t q_lock; >>> u16 q_depth; >>> - s16 cq_vector; >>> u16 sq_head; >>> u16 sq_tail; >>> u16 cq_head; >>> u16 qid; >>> + s16 cq_vector; >>> u8 cq_phase; >>> u8 cqe_seen; >>> struct async_cmd_info cmdinfo; >>> - struct blk_mq_hw_ctx *hctx; >>> + char irqname[24]; /* nvme4294967295-65535\0 */ >>> + dma_addr_t sq_dma_addr; >>> + dma_addr_t cq_dma_addr; >>> }; >>> >>> /* >> >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-02 7:08 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-05-20 20:43 [PATCHv1] NVMe: nvme_queue made cache friendly Parav Pandit 2015-05-21 20:45 ` J Freyensee 2015-05-22 4:52 ` Parav Pandit 2015-06-02 7:08 ` Parav Pandit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).