* [RESEND PATCH v4 0/2] Add a property in at24.c
@ 2018-07-02 9:12 alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: alanx.chiang @ 2018-07-02 9:12 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
This RESEND PATCH only adds the Acked-by and Reviewed-by,
no other patch for the codes.
In at24.c, it uses 8-bit addressing by default. In this patch,
add a property address-width that provides a flexible method to
pass the information to the driver.
Alan Chiang (2):
dt-bindings: at24: Add address-width property
eeprom: at24: Add support for address-width property
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 13+ messages in thread* [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
@ 2018-07-02 9:12 ` alanx.chiang
2018-07-05 21:22 ` Rob Herring
2018-07-02 9:12 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
2018-07-02 11:59 ` [RESEND PATCH v4 0/2] Add a property in at24.c Bartosz Golaszewski
2 siblings, 1 reply; 13+ messages in thread
From: alanx.chiang @ 2018-07-02 9:12 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
The AT24 series chips use 8-bit address by default. If some
chips would like to support more than 8 bits, the at24 driver
should be added the compatible field for specfic chips.
Provide a flexible way to determine the addressing bits through
address-width in this patch.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1:
-- Remove the address-width field in the example.
since v2:
-- Remove redundant space.
since v3:
-- Add Acked-by.
---
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 61d833a..aededdb 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -72,6 +72,8 @@ Optional properties:
- wp-gpios: GPIO to which the write-protect pin of the chip is connected.
+ - address-width: number of address bits (one of 8, 16).
+
Example:
eeprom@52 {
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
@ 2018-07-05 21:22 ` Rob Herring
2018-07-05 20:24 ` Robert P. J. Day
0 siblings, 1 reply; 13+ messages in thread
From: Rob Herring @ 2018-07-05 21:22 UTC (permalink / raw)
To: alanx.chiang
Cc: linux-i2c, andy.yeh, sakari.ailus, andriy.shevchenko,
andriy.shevchenko, rajmohan.mani, andy.shevchenko, tfiga,
jcliang, brgl, mark.rutland, arnd, gregkh, linux-kernel,
devicetree
On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
> From: Alan Chiang <alanx.chiang@intel.com>
>
> The AT24 series chips use 8-bit address by default. If some
> chips would like to support more than 8 bits, the at24 driver
> should be added the compatible field for specfic chips.
>
> Provide a flexible way to determine the addressing bits through
> address-width in this patch.
>
> Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> ---
> since v1:
> -- Remove the address-width field in the example.
> since v2:
> -- Remove redundant space.
> since v3:
> -- Add Acked-by.
>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-05 21:22 ` Rob Herring
@ 2018-07-05 20:24 ` Robert P. J. Day
2018-07-09 3:12 ` Chiang, AlanX
0 siblings, 1 reply; 13+ messages in thread
From: Robert P. J. Day @ 2018-07-05 20:24 UTC (permalink / raw)
To: Rob Herring
Cc: alanx.chiang, linux-i2c, andy.yeh, sakari.ailus,
andriy.shevchenko, andriy.shevchenko, rajmohan.mani,
andy.shevchenko, tfiga, jcliang, brgl, mark.rutland, arnd,
gregkh, linux-kernel, devicetree
On Thu, 5 Jul 2018, Rob Herring wrote:
> On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
> > From: Alan Chiang <alanx.chiang@intel.com>
> >
> > The AT24 series chips use 8-bit address by default. If some
> > chips would like to support more than 8 bits, the at24 driver
> > should be added the compatible field for specfic chips.
> >
> > Provide a flexible way to determine the addressing bits through
> > address-width in this patch.
> >
> > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > ---
> > since v1:
> > -- Remove the address-width field in the example.
> > since v2:
> > -- Remove redundant space.
> > since v3:
> > -- Add Acked-by.
> >
> > ---
> > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
"... should be added the compatible field ..."??
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca/dokuwiki
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 13+ messages in thread* RE: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-05 20:24 ` Robert P. J. Day
@ 2018-07-09 3:12 ` Chiang, AlanX
2018-07-09 8:52 ` Bartosz Golaszewski
0 siblings, 1 reply; 13+ messages in thread
From: Chiang, AlanX @ 2018-07-09 3:12 UTC (permalink / raw)
To: Robert P. J. Day, Rob Herring
Cc: linux-i2c, Yeh, Andy, sakari.ailus, andriy.shevchenko,
Shevchenko, Andriy, Mani, Rajmohan, andy.shevchenko, tfiga,
jcliang, brgl, mark.rutland, arnd, gregkh, linux-kernel,
devicetree
Hi Robert,
> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
> Sent: Friday, July 6, 2018 4:24 AM
> To: Rob Herring <robh@kernel.org>
> Cc: Chiang, AlanX <alanx.chiang@intel.com>; linux-i2c@vger.kernel.org; Yeh,
> Andy <andy.yeh@intel.com>; sakari.ailus@linux.intel.com;
> andriy.shevchenko@linux.intel.com; Shevchenko, Andriy
> <andriy.shevchenko@intel.com>; Mani, Rajmohan
> <rajmohan.mani@intel.com>; andy.shevchenko@gmail.com;
> tfiga@chromium.org; jcliang@chromium.org; brgl@bgdev.pl;
> mark.rutland@arm.com; arnd@arndb.de; gregkh@linuxfoundation.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
> property
>
> On Thu, 5 Jul 2018, Rob Herring wrote:
>
> > On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
> > > From: Alan Chiang <alanx.chiang@intel.com>
> > >
> > > The AT24 series chips use 8-bit address by default. If some chips
> > > would like to support more than 8 bits, the at24 driver should be
> > > added the compatible field for specfic chips.
> > >
> > > Provide a flexible way to determine the addressing bits through
> > > address-width in this patch.
> > >
> > > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> > > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > >
> > > ---
> > > since v1:
> > > -- Remove the address-width field in the example.
> > > since v2:
> > > -- Remove redundant space.
> > > since v3:
> > > -- Add Acked-by.
> > >
> > > ---
> > > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> "... should be added the compatible field ..."??
>
> rday
Maybe I should modify the sentence as below that makes it clear.
"The compatible field should be added in the at24.c for specific chips.".
I quote Andy's words in patch v2:
"The current at24 driver has no address width support, thus, reusing same
(allocated) IDs (non-DT case) is hard."
This is the reason that I submitted the patch.
Thanks
>
> --
>
> ==========================================================
> ==============
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca/dokuwiki
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ==========================================================
> ==============
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-09 3:12 ` Chiang, AlanX
@ 2018-07-09 8:52 ` Bartosz Golaszewski
2018-07-17 8:01 ` Bartosz Golaszewski
0 siblings, 1 reply; 13+ messages in thread
From: Bartosz Golaszewski @ 2018-07-09 8:52 UTC (permalink / raw)
To: Chiang, AlanX
Cc: Robert P. J. Day, Rob Herring, linux-i2c, Yeh, Andy,
sakari.ailus, andriy.shevchenko, Shevchenko, Andriy, Mani,
Rajmohan, andy.shevchenko, tfiga, jcliang, mark.rutland, arnd,
gregkh, linux-kernel, devicetree
2018-07-09 5:12 GMT+02:00 Chiang, AlanX <alanx.chiang@intel.com>:
> Hi Robert,
>
>> -----Original Message-----
>> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
>> Sent: Friday, July 6, 2018 4:24 AM
>> To: Rob Herring <robh@kernel.org>
>> Cc: Chiang, AlanX <alanx.chiang@intel.com>; linux-i2c@vger.kernel.org; Yeh,
>> Andy <andy.yeh@intel.com>; sakari.ailus@linux.intel.com;
>> andriy.shevchenko@linux.intel.com; Shevchenko, Andriy
>> <andriy.shevchenko@intel.com>; Mani, Rajmohan
>> <rajmohan.mani@intel.com>; andy.shevchenko@gmail.com;
>> tfiga@chromium.org; jcliang@chromium.org; brgl@bgdev.pl;
>> mark.rutland@arm.com; arnd@arndb.de; gregkh@linuxfoundation.org;
>> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
>> Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
>> property
>>
>> On Thu, 5 Jul 2018, Rob Herring wrote:
>>
>> > On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
>> > > From: Alan Chiang <alanx.chiang@intel.com>
>> > >
>> > > The AT24 series chips use 8-bit address by default. If some chips
>> > > would like to support more than 8 bits, the at24 driver should be
>> > > added the compatible field for specfic chips.
>> > >
>> > > Provide a flexible way to determine the addressing bits through
>> > > address-width in this patch.
>> > >
>> > > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
>> > > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
>> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> > >
>> > > ---
>> > > since v1:
>> > > -- Remove the address-width field in the example.
>> > > since v2:
>> > > -- Remove redundant space.
>> > > since v3:
>> > > -- Add Acked-by.
>> > >
>> > > ---
>> > > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>> > > 1 file changed, 2 insertions(+)
>> >
>> > Reviewed-by: Rob Herring <robh@kernel.org>
>>
>> "... should be added the compatible field ..."??
>>
>> rday
>
> Maybe I should modify the sentence as below that makes it clear.
> "The compatible field should be added in the at24.c for specific chips.".
>
> I quote Andy's words in patch v2:
> "The current at24 driver has no address width support, thus, reusing same
> (allocated) IDs (non-DT case) is hard."
>
> This is the reason that I submitted the patch.
>
> Thanks
>
Make it something like:
Currently the only way to use a variant of a supported model with
a different address width is to define a new compatible string and the
corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer by
defining a new property: address-width.
Best regards,
Bartosz Golaszewski
>>
>> --
>>
>> ==========================================================
>> ==============
>> Robert P. J. Day Ottawa, Ontario, CANADA
>> http://crashcourse.ca/dokuwiki
>>
>> Twitter: http://twitter.com/rpjday
>> LinkedIn: http://ca.linkedin.com/in/rpjday
>> ==========================================================
>> ==============
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-09 8:52 ` Bartosz Golaszewski
@ 2018-07-17 8:01 ` Bartosz Golaszewski
2018-07-24 11:07 ` sakari.ailus
0 siblings, 1 reply; 13+ messages in thread
From: Bartosz Golaszewski @ 2018-07-17 8:01 UTC (permalink / raw)
To: Chiang, AlanX
Cc: Robert P. J. Day, Rob Herring, linux-i2c, Yeh, Andy,
sakari.ailus, andriy.shevchenko, Shevchenko, Andriy, Mani,
Rajmohan, andy.shevchenko, tfiga, jcliang, mark.rutland, arnd,
gregkh, linux-kernel, devicetree
2018-07-09 10:52 GMT+02:00 Bartosz Golaszewski <brgl@bgdev.pl>:
> 2018-07-09 5:12 GMT+02:00 Chiang, AlanX <alanx.chiang@intel.com>:
>> Hi Robert,
>>
>>> -----Original Message-----
>>> From: Robert P. J. Day [mailto:rpjday@crashcourse.ca]
>>> Sent: Friday, July 6, 2018 4:24 AM
>>> To: Rob Herring <robh@kernel.org>
>>> Cc: Chiang, AlanX <alanx.chiang@intel.com>; linux-i2c@vger.kernel.org; Yeh,
>>> Andy <andy.yeh@intel.com>; sakari.ailus@linux.intel.com;
>>> andriy.shevchenko@linux.intel.com; Shevchenko, Andriy
>>> <andriy.shevchenko@intel.com>; Mani, Rajmohan
>>> <rajmohan.mani@intel.com>; andy.shevchenko@gmail.com;
>>> tfiga@chromium.org; jcliang@chromium.org; brgl@bgdev.pl;
>>> mark.rutland@arm.com; arnd@arndb.de; gregkh@linuxfoundation.org;
>>> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
>>> Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width
>>> property
>>>
>>> On Thu, 5 Jul 2018, Rob Herring wrote:
>>>
>>> > On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@intel.com wrote:
>>> > > From: Alan Chiang <alanx.chiang@intel.com>
>>> > >
>>> > > The AT24 series chips use 8-bit address by default. If some chips
>>> > > would like to support more than 8 bits, the at24 driver should be
>>> > > added the compatible field for specfic chips.
>>> > >
>>> > > Provide a flexible way to determine the addressing bits through
>>> > > address-width in this patch.
>>> > >
>>> > > Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
>>> > > Signed-off-by: Andy Yeh <andy.yeh@intel.com>
>>> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>>> > >
>>> > > ---
>>> > > since v1:
>>> > > -- Remove the address-width field in the example.
>>> > > since v2:
>>> > > -- Remove redundant space.
>>> > > since v3:
>>> > > -- Add Acked-by.
>>> > >
>>> > > ---
>>> > > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>>> > > 1 file changed, 2 insertions(+)
>>> >
>>> > Reviewed-by: Rob Herring <robh@kernel.org>
>>>
>>> "... should be added the compatible field ..."??
>>>
>>> rday
>>
>> Maybe I should modify the sentence as below that makes it clear.
>> "The compatible field should be added in the at24.c for specific chips.".
>>
>> I quote Andy's words in patch v2:
>> "The current at24 driver has no address width support, thus, reusing same
>> (allocated) IDs (non-DT case) is hard."
>>
>> This is the reason that I submitted the patch.
>>
>> Thanks
>>
>
> Make it something like:
>
> Currently the only way to use a variant of a supported model with
> a different address width is to define a new compatible string and the
> corresponding chip data structure.
>
> Provide a flexible way to specify the size of the address pointer by
> defining a new property: address-width.
>
> Best regards,
> Bartosz Golaszewski
>
>>>
>>> --
>>>
>>> ==========================================================
>>> ==============
>>> Robert P. J. Day Ottawa, Ontario, CANADA
>>> http://crashcourse.ca/dokuwiki
>>>
>>> Twitter: http://twitter.com/rpjday
>>> LinkedIn: http://ca.linkedin.com/in/rpjday
>>> ==========================================================
>>> ==============
Hi,
I will soon be sending my pull request to Wolfram, so if you still
want that applied for 4.19 - please resend with the commit message
fixed.
Thanks,
Bart
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-17 8:01 ` Bartosz Golaszewski
@ 2018-07-24 11:07 ` sakari.ailus
2018-07-24 14:10 ` Bartosz Golaszewski
0 siblings, 1 reply; 13+ messages in thread
From: sakari.ailus @ 2018-07-24 11:07 UTC (permalink / raw)
To: Chiang, AlanX
Cc: Bartosz Golaszewski, Robert P. J. Day, Rob Herring, linux-i2c,
Yeh, Andy, andriy.shevchenko, Shevchenko, Andriy, Mani, Rajmohan,
andy.shevchenko, tfiga, jcliang, mark.rutland, arnd, gregkh,
linux-kernel, devicetree
On Tue, Jul 17, 2018 at 10:01:17AM +0200, Bartosz Golaszewski wrote:
> I will soon be sending my pull request to Wolfram, so if you still
> want that applied for 4.19 - please resend with the commit message
> fixed.
Alan?
Not sure whether it's too late for 4.19 now though.
--
Sakari Ailus
sakari.ailus@linux.intel.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-24 11:07 ` sakari.ailus
@ 2018-07-24 14:10 ` Bartosz Golaszewski
0 siblings, 0 replies; 13+ messages in thread
From: Bartosz Golaszewski @ 2018-07-24 14:10 UTC (permalink / raw)
To: sakari.ailus
Cc: Chiang, AlanX, Robert P. J. Day, Rob Herring, linux-i2c, Yeh,
Andy, andriy.shevchenko, Shevchenko, Andriy, Mani, Rajmohan,
andy.shevchenko, tfiga, jcliang, mark.rutland, arnd, gregkh,
linux-kernel, devicetree
2018-07-24 13:07 GMT+02:00 sakari.ailus@linux.intel.com
<sakari.ailus@linux.intel.com>:
> On Tue, Jul 17, 2018 at 10:01:17AM +0200, Bartosz Golaszewski wrote:
>> I will soon be sending my pull request to Wolfram, so if you still
>> want that applied for 4.19 - please resend with the commit message
>> fixed.
>
> Alan?
>
> Not sure whether it's too late for 4.19 now though.
>
> --
> Sakari Ailus
> sakari.ailus@linux.intel.com
I may still be ok until tomorrow if Alan resend it.
Bart
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
@ 2018-07-02 9:12 ` alanx.chiang
2018-07-02 11:59 ` [RESEND PATCH v4 0/2] Add a property in at24.c Bartosz Golaszewski
2 siblings, 0 replies; 13+ messages in thread
From: alanx.chiang @ 2018-07-02 9:12 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1
-- Add a warn message for 8-bit addressing.
since v2
-- Modify the warning message for clear.
-- Move the clearing bit operation outside of a statement.
since v3
-- Merge the warning message into one line.
---
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..7ea640b 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct device *dev,
if (device_property_present(dev, "no-read-rollover"))
chip->flags |= AT24_FLAG_NO_RDROL;
+ err = device_property_read_u32(dev, "address-width", &val);
+ if (!err) {
+ switch (val) {
+ case 8:
+ if (chip->flags & AT24_FLAG_ADDR16)
+ dev_warn(dev, "Override address width to be 8, while default is 16\n");
+ chip->flags &= ~AT24_FLAG_ADDR16;
+ break;
+ case 16:
+ chip->flags |= AT24_FLAG_ADDR16;
+ break;
+ default:
+ dev_warn(dev, "Bad \"address-width\" property: %u\n",
+ val);
+ }
+ }
+
err = device_property_read_u32(dev, "size", &val);
if (!err)
chip->byte_len = val;
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [RESEND PATCH v4 0/2] Add a property in at24.c
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
@ 2018-07-02 11:59 ` Bartosz Golaszewski
2 siblings, 0 replies; 13+ messages in thread
From: Bartosz Golaszewski @ 2018-07-02 11:59 UTC (permalink / raw)
To: alanx.chiang
Cc: linux-i2c, andy.yeh, Sakari Ailus, Andy Shevchenko,
andriy.shevchenko, Rajmohan Mani, Andy Shevchenko, tfiga,
jcliang, Rob Herring, Mark Rutland, Arnd Bergmann,
Greg Kroah-Hartman, Linux Kernel Mailing List, devicetree
2018-07-02 11:12 GMT+02:00 <alanx.chiang@intel.com>:
> From: Alan Chiang <alanx.chiang@intel.com>
>
> This RESEND PATCH only adds the Acked-by and Reviewed-by,
> no other patch for the codes.
>
Please don't do this. We're waiting for Rob's Acked-by and I will
collect all the tags anyway. Don't resend unless there are changes to
patches.
Best regards,
Bartosz Golaszewski
> In at24.c, it uses 8-bit addressing by default. In this patch,
> add a property address-width that provides a flexible method to
> pass the information to the driver.
>
> Alan Chiang (2):
> dt-bindings: at24: Add address-width property
> eeprom: at24: Add support for address-width property
>
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
> 2 files changed, 19 insertions(+)
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RESEND PATCH v4 0/2] Add aproperty in at24.c
@ 2018-07-25 3:20 alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
0 siblings, 1 reply; 13+ messages in thread
From: alanx.chiang @ 2018-07-25 3:20 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, rpjday, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
The RESEND PATCH modifies the commit message and adds the Reviewed-by.
In at24.c, it uses 8-bit addressing by default. In this patch add a
property address-width that provides a flexible method to pass the
information to the driver.
Alan Chiang (2):
dt-bindings: at24: Add address-width property
eeprom: at24: Add support for address-width property
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty " alanx.chiang
@ 2018-07-25 3:20 ` alanx.chiang
2018-07-25 7:35 ` Bartosz Golaszewski
0 siblings, 1 reply; 13+ messages in thread
From: alanx.chiang @ 2018-07-25 3:20 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, rpjday, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
Currently the only way to use a variant of a supported model with
a different address with a different address width is to define a
new compatible string and the corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer
by defining a new property: address-width.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 61d833a..aededdb 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -72,6 +72,8 @@ Optional properties:
- wp-gpios: GPIO to which the write-protect pin of the chip is connected.
+ - address-width: number of address bits (one of 8, 16).
+
Example:
eeprom@52 {
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
@ 2018-07-25 7:35 ` Bartosz Golaszewski
0 siblings, 0 replies; 13+ messages in thread
From: Bartosz Golaszewski @ 2018-07-25 7:35 UTC (permalink / raw)
To: Chiang, AlanX
Cc: linux-i2c, Yeh, Andy, Sakari Ailus, Andy Shevchenko, Shevchenko,
Andriy, Rajmohan Mani, Andy Shevchenko, tfiga, jcliang,
Rob Herring, Mark Rutland, Arnd Bergmann, Robert P. J. Day,
Greg Kroah-Hartman, Linux Kernel Mailing List, devicetree
2018-07-25 5:20 GMT+02:00 <alanx.chiang@intel.com>:
> From: Alan Chiang <alanx.chiang@intel.com>
>
> Currently the only way to use a variant of a supported model with
> a different address with a different address width is to define a
There's some copy-paste problem here. I fixed it.
> new compatible string and the corresponding chip data structure.
>
> Provide a flexible way to specify the size of the address pointer
> by defining a new property: address-width.
>
> Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 61d833a..aededdb 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -72,6 +72,8 @@ Optional properties:
>
> - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
>
> + - address-width: number of address bits (one of 8, 16).
> +
> Example:
>
> eeprom@52 {
> --
> 2.7.4
>
Applied both to for-next.
Bart
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-07-25 7:35 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-05 21:22 ` Rob Herring
2018-07-05 20:24 ` Robert P. J. Day
2018-07-09 3:12 ` Chiang, AlanX
2018-07-09 8:52 ` Bartosz Golaszewski
2018-07-17 8:01 ` Bartosz Golaszewski
2018-07-24 11:07 ` sakari.ailus
2018-07-24 14:10 ` Bartosz Golaszewski
2018-07-02 9:12 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
2018-07-02 11:59 ` [RESEND PATCH v4 0/2] Add a property in at24.c Bartosz Golaszewski
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty " alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-25 7:35 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).