* [PATCH 01/11] fsl/qe: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
` (9 subsequent siblings)
10 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: linuxppc-dev; +Cc: kernel-janitors, linux-kernel, qiang.zhao, davem
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/soc/fsl/qe/qe_tdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c
index 5e48b14..0ac98e6 100644
--- a/drivers/soc/fsl/qe/qe_tdm.c
+++ b/drivers/soc/fsl/qe/qe_tdm.c
@@ -99,7 +99,7 @@ int ucc_of_parse_tdm(struct device_node *np, struct ucc_tdm *utdm,
utdm->tdm_port = val;
ut_info->uf_info.tdm_num = utdm->tdm_port;
- if (of_get_property(np, "fsl,tdm-internal-loopback", NULL))
+ if (of_property_read_bool(np, "fsl,tdm-internal-loopback"))
utdm->tdm_mode = TDM_INTERNAL_LOOPBACK;
else
utdm->tdm_mode = TDM_NORMAL;
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 02/11] usb: host: fsl-mph-dr-of: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:26 ` [PATCH 02/11 v2] " Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
` (8 subsequent siblings)
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel-janitors, linux-usb, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/usb/host/fsl-mph-dr-of.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 1044b0f..8bbca74 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -222,11 +222,11 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
pdata->controller_ver = usb_get_ver_info(np);
/* Activate Erratum by reading property in device tree */
- if (of_get_property(np, "fsl,usb-erratum-a007792", NULL))
+ if (of_property_read_bool(np, "fsl,usb-erratum-a007792"))
pdata->has_fsl_erratum_a007792 = 1;
else
pdata->has_fsl_erratum_a007792 = 0;
- if (of_get_property(np, "fsl,usb-erratum-a005275", NULL))
+ if (of_property_read_bool(np, "fsl,usb-erratum-a005275"))
pdata->has_fsl_erratum_a005275 = 1;
else
pdata->has_fsl_erratum_a005275 = 0;
@@ -235,7 +235,7 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
* Determine whether phy_clk_valid needs to be checked
* by reading property in device tree
*/
- if (of_get_property(np, "phy-clk-valid", NULL))
+ if (of_property_read_bool(np, "phy-clk-valid"))
pdata->check_phy_clk_valid = 1;
else
pdata->check_phy_clk_valid = 0;
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 02/11 v2] usb: host: fsl-mph-dr-of: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
@ 2016-08-05 11:26 ` Julia Lawall
0 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 11:26 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel-janitors, linux-usb, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/usb/host/fsl-mph-dr-of.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 1044b0f..f07ccb2 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -222,23 +222,17 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
pdata->controller_ver = usb_get_ver_info(np);
/* Activate Erratum by reading property in device tree */
- if (of_get_property(np, "fsl,usb-erratum-a007792", NULL))
- pdata->has_fsl_erratum_a007792 = 1;
- else
- pdata->has_fsl_erratum_a007792 = 0;
- if (of_get_property(np, "fsl,usb-erratum-a005275", NULL))
- pdata->has_fsl_erratum_a005275 = 1;
- else
- pdata->has_fsl_erratum_a005275 = 0;
+ pdata->has_fsl_erratum_a007792 =
+ of_property_read_bool(np, "fsl,usb-erratum-a007792");
+ pdata->has_fsl_erratum_a005275 =
+ of_property_read_bool(np, "fsl,usb-erratum-a005275");
/*
* Determine whether phy_clk_valid needs to be checked
* by reading property in device tree
*/
- if (of_get_property(np, "phy-clk-valid", NULL))
- pdata->check_phy_clk_valid = 1;
- else
- pdata->check_phy_clk_valid = 0;
+ pdata->check_phy_clk_valid =
+ of_property_read_bool(np, "phy-clk-valid");
if (pdata->have_sysif_regs) {
if (pdata->controller_ver == FSL_USB_VER_NONE) {
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 03/11] pinctrl: nomadik: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
` (7 subsequent siblings)
10 siblings, 2 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Linus Walleij
Cc: kernel-janitors, Alessandro Rubini, linux-arm-kernel, linux-gpio,
linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 35f6218..d8dc3fe 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1110,7 +1110,7 @@ static int nmk_gpio_probe(struct platform_device *dev)
return PTR_ERR(nmk_chip);
}
- if (of_get_property(np, "st,supports-sleepmode", NULL))
+ if (of_property_read_bool(np, "st,supports-sleepmode"))
supports_sleepmode = true;
else
supports_sleepmode = false;
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 03/11 v2] pinctrl: nomadik: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
@ 2016-08-05 11:26 ` Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
1 sibling, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 11:26 UTC (permalink / raw)
To: Linus Walleij
Cc: kernel-janitors, Alessandro Rubini, linux-arm-kernel, linux-gpio,
linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 35f6218..6f2e1da 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1110,10 +1110,8 @@ static int nmk_gpio_probe(struct platform_device *dev)
return PTR_ERR(nmk_chip);
}
- if (of_get_property(np, "st,supports-sleepmode", NULL))
- supports_sleepmode = true;
- else
- supports_sleepmode = false;
+ supports_sleepmode =
+ of_property_read_bool(np, "st,supports-sleepmode");
/* Correct platform device ID */
dev->id = nmk_chip->bank;
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 03/11] pinctrl: nomadik: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
@ 2016-08-11 11:52 ` Linus Walleij
1 sibling, 0 replies; 33+ messages in thread
From: Linus Walleij @ 2016-08-11 11:52 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Alessandro Rubini, linux-arm-kernel, linux-gpio,
linux-kernel
On Fri, Aug 5, 2016 at 10:56 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 04/11] i2c: mpc: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (2 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2017-10-27 20:15 ` [04/11] " Wolfram Sang
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
` (6 subsequent siblings)
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Wolfram Sang; +Cc: kernel-janitors, linux-i2c, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/i2c/busses/i2c-mpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 48ecffe..4b5707b 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -700,7 +700,7 @@ static int fsl_i2c_probe(struct platform_device *op)
}
}
- if (of_get_property(op->dev.of_node, "fsl,preserve-clocking", NULL)) {
+ if (of_property_read_bool(op->dev.of_node, "fsl,preserve-clocking")) {
clock = MPC_I2C_CLOCK_PRESERVE;
} else {
prop = of_get_property(op->dev.of_node, "clock-frequency",
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [04/11] i2c: mpc: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
@ 2017-10-27 20:15 ` Wolfram Sang
0 siblings, 0 replies; 33+ messages in thread
From: Wolfram Sang @ 2017-10-27 20:15 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Fri, Aug 05, 2016 at 10:56:44AM +0200, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Shortened commit message and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 05/11] tty/serial: at91: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (3 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
` (5 subsequent siblings)
10 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Nicolas Ferre
Cc: kernel-janitors, Greg Kroah-Hartman, Jiri Slaby, linux-serial,
linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/tty/serial/atmel_serial.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 2eaa18d..c57a51d 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1634,8 +1634,8 @@ static void atmel_init_property(struct atmel_uart_port *atmel_port,
if (np) {
/* DMA/PDC usage specification */
- if (of_get_property(np, "atmel,use-dma-rx", NULL)) {
- if (of_get_property(np, "dmas", NULL)) {
+ if (of_property_read_bool(np, "atmel,use-dma-rx")) {
+ if (of_property_read_bool(np, "dmas")) {
atmel_port->use_dma_rx = true;
atmel_port->use_pdc_rx = false;
} else {
@@ -1647,8 +1647,8 @@ static void atmel_init_property(struct atmel_uart_port *atmel_port,
atmel_port->use_pdc_rx = false;
}
- if (of_get_property(np, "atmel,use-dma-tx", NULL)) {
- if (of_get_property(np, "dmas", NULL)) {
+ if (of_property_read_bool(np, "atmel,use-dma-tx")) {
+ if (of_property_read_bool(np, "dmas")) {
atmel_port->use_dma_tx = true;
atmel_port->use_pdc_tx = false;
} else {
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 06/11] mmc: sdhci-of-esdhc: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (4 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-18 7:36 ` Adrian Hunter
2016-08-22 13:39 ` Ulf Hansson
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
` (4 subsequent siblings)
10 siblings, 2 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Adrian Hunter; +Cc: kernel-janitors, Ulf Hansson, linux-mmc, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index 239be2f..fb71c86 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -583,7 +583,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
np = pdev->dev.of_node;
- if (of_get_property(np, "little-endian", NULL))
+ if (of_property_read_bool(np, "little-endian"))
host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata,
sizeof(struct sdhci_esdhc));
else
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 06/11] mmc: sdhci-of-esdhc: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
@ 2016-08-18 7:36 ` Adrian Hunter
2016-08-22 13:39 ` Ulf Hansson
1 sibling, 0 replies; 33+ messages in thread
From: Adrian Hunter @ 2016-08-18 7:36 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Julia Lawall, kernel-janitors, linux-mmc, linux-kernel
On 05/08/16 11:56, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 239be2f..fb71c86 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -583,7 +583,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
>
> np = pdev->dev.of_node;
>
> - if (of_get_property(np, "little-endian", NULL))
> + if (of_property_read_bool(np, "little-endian"))
> host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata,
> sizeof(struct sdhci_esdhc));
> else
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 06/11] mmc: sdhci-of-esdhc: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
2016-08-18 7:36 ` Adrian Hunter
@ 2016-08-22 13:39 ` Ulf Hansson
1 sibling, 0 replies; 33+ messages in thread
From: Ulf Hansson @ 2016-08-22 13:39 UTC (permalink / raw)
To: Julia Lawall; +Cc: Adrian Hunter, kernel-janitors, linux-mmc, linux-kernel
On 5 August 2016 at 10:56, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied for next!
Kind regards
Uffe
>
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 239be2f..fb71c86 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -583,7 +583,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
>
> np = pdev->dev.of_node;
>
> - if (of_get_property(np, "little-endian", NULL))
> + if (of_property_read_bool(np, "little-endian"))
> host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata,
> sizeof(struct sdhci_esdhc));
> else
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 07/11] phy: qcom-ufs: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (5 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:25 ` [PATCH 07/11 v2] " Julia Lawall
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
` (3 subsequent siblings)
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/phy/phy-qcom-ufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 107cb57..8eaf60a 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -283,7 +283,7 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
err = 0;
}
snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name);
- if (of_get_property(dev->of_node, prop_name, NULL))
+ if (of_property_read_bool(dev->of_node, prop_name))
vreg->is_always_on = true;
else
vreg->is_always_on = false;
^ permalink raw reply related [flat|nested] 33+ messages in thread* [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
@ 2016-08-05 11:25 ` Julia Lawall
2016-08-12 10:02 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 11:25 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/phy/phy-qcom-ufs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 107cb57..18a5b49 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
err = 0;
}
snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name);
- if (of_get_property(dev->of_node, prop_name, NULL))
- vreg->is_always_on = true;
- else
- vreg->is_always_on = false;
+ vreg->is_always_on = of_property_read_bool(dev->of_node,
+ prop_name);
}
if (!strcmp(name, "vdda-pll")) {
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool
2016-08-05 11:25 ` [PATCH 07/11 v2] " Julia Lawall
@ 2016-08-12 10:02 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 33+ messages in thread
From: Kishon Vijay Abraham I @ 2016-08-12 10:02 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-kernel
On Friday 05 August 2016 04:55 PM, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2,x;
> @@
> - if (of_get_property(e1,e2,NULL))
> - x = true;
> - else
> - x = false;
> + x = of_property_read_bool(e1,e2);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
merged, thanks.
-Kishon
>
> ---
> v2: special case for propagating true and false
>
> drivers/phy/phy-qcom-ufs.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index 107cb57..18a5b49 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
> err = 0;
> }
> snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name);
> - if (of_get_property(dev->of_node, prop_name, NULL))
> - vreg->is_always_on = true;
> - else
> - vreg->is_always_on = false;
> + vreg->is_always_on = of_property_read_bool(dev->of_node,
> + prop_name);
> }
>
> if (!strcmp(name, "vdda-pll")) {
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (6 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 9:30 ` Johannes Berg
` (2 more replies)
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
` (2 subsequent siblings)
10 siblings, 3 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..a77ba98 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
+ if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
priv->is_little_endian = true;
else
priv->is_little_endian = false;
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
@ 2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2 siblings, 2 replies; 33+ messages in thread
From: Johannes Berg @ 2016-08-05 9:30 UTC (permalink / raw)
To: Julia Lawall, netdev; +Cc: kernel-janitors, linux-kernel
> - if (of_get_property(pdev->dev.of_node,
> - "little-endian", NULL))
> + if (of_property_read_bool(pdev->dev.of_node, "little-
> endian"))
> priv->is_little_endian = true;
> else
> priv->is_little_endian = false;
>
Perhaps, while changing this, that'd be better as
priv->is_little_endian = of_property_read_bool(...);
Obviously that would've worked before, but now it'd be even easier to
understand, it seems.
johannes
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 9:30 ` Johannes Berg
@ 2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
1 sibling, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 9:47 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 564 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
>
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.
Thanks for the suggestion. Will send shortly.
julia
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
@ 2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg
1 sibling, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 10:08 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 800 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
>
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.
Can I do the same for:
if (of_property_read_bool(np, "phy-clk-valid"))
pdata->check_phy_clk_valid = 1;
else
pdata->check_phy_clk_valid = 0;
The type is not bool, but:
include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
thanks,
julia
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 10:08 ` Julia Lawall
@ 2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
0 siblings, 1 reply; 33+ messages in thread
From: Johannes Berg @ 2016-08-05 10:12 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, kernel-janitors, linux-kernel
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>
> Can I do the same for:
>
> if (of_property_read_bool(np, "phy-clk-valid"))
> pdata->check_phy_clk_valid = 1;
> else
> pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
>
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.
johannes
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 10:12 ` Johannes Berg
@ 2016-08-05 10:14 ` Julia Lawall
0 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 10:14 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, kernel-janitors, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 614 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
> On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> >
> > Can I do the same for:
> >
> > if (of_property_read_bool(np, "phy-clk-valid"))
> > pdata->check_phy_clk_valid = 1;
> > else
> > pdata->check_phy_clk_valid = 0;
> >
> > The type is not bool, but:
> >
> > include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
> >
> The type doesn't even matter, does it? Any bool->int conversion should
> result in 0/1.
Just paranoid. Thanks.
julia
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 08/11 v2] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
@ 2016-08-05 11:24 ` Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 11:24 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 7b8fe86..e03b30c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
goto err_ioremap;
}
- if (of_get_property(pdev->dev.of_node,
- "little-endian", NULL))
- priv->is_little_endian = true;
- else
- priv->is_little_endian = false;
+ priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
+ "little-endian");
ret = of_mdiobus_register(bus, np);
if (ret) {
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
@ 2016-08-05 11:35 ` Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2 siblings, 1 reply; 33+ messages in thread
From: Sergei Shtylyov @ 2016-08-05 11:35 UTC (permalink / raw)
To: Julia Lawall, netdev; +Cc: kernel-janitors, linux-kernel
Hello.
On 8/5/2016 11:56 AM, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
> index 7b8fe86..a77ba98 100644
> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
> goto err_ioremap;
> }
>
> - if (of_get_property(pdev->dev.of_node,
> - "little-endian", NULL))
> + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
> priv->is_little_endian = true;
> else
> priv->is_little_endian = false;
priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
"little-endian"));
MBR, Sergei
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
@ 2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
0 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 11:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, kernel-janitors, linux-kernel
On Fri, 5 Aug 2016, Sergei Shtylyov wrote:
> Hello.
>
> On 8/5/2016 11:56 AM, Julia Lawall wrote:
>
> > Use of_property_read_bool to check for the existence of a property.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e1,e2;
> > statement S2,S1;
> > @@
> > - if (of_get_property(e1,e2,NULL))
> > + if (of_property_read_bool(e1,e2))
> > S1 else S2
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> > drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > index 7b8fe86..a77ba98 100644
> > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> > @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
> > *pdev)
> > goto err_ioremap;
> > }
> >
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
>
> priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
> "little-endian"));
Thanks,
I just sent a v2 with this change.
julia
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 08/11] net/fsl: use of_property_read_bool
2016-08-05 11:38 ` Julia Lawall
@ 2016-08-05 11:40 ` Sergei Shtylyov
0 siblings, 0 replies; 33+ messages in thread
From: Sergei Shtylyov @ 2016-08-05 11:40 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, kernel-janitors, linux-kernel
On 8/5/2016 2:38 PM, Julia Lawall wrote:
>>> Use of_property_read_bool to check for the existence of a property.
>>>
>>> The semantic patch that makes this change is as follows:
>>> (http://coccinelle.lip6.fr/)
>>>
>>> // <smpl>
>>> @@
>>> expression e1,e2;
>>> statement S2,S1;
>>> @@
>>> - if (of_get_property(e1,e2,NULL))
>>> + if (of_property_read_bool(e1,e2))
>>> S1 else S2
>>> // </smpl>
>>>
>>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>>
>>> ---
>>> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> index 7b8fe86..a77ba98 100644
>>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device
>>> *pdev)
>>> goto err_ioremap;
>>> }
>>>
>>> - if (of_get_property(pdev->dev.of_node,
>>> - "little-endian", NULL))
>>> + if (of_property_read_bool(pdev->dev.of_node, "little-endian"))
>>> priv->is_little_endian = true;
>>> else
>>> priv->is_little_endian = false;
>>
>> priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
>> "little-endian"));
>
> Thanks,
>
> I just sent a v2 with this change.
I've seen. Sorry, forgot to look at the followups before commenting...
> julia
MBR, Sergei
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 09/11] powerpc/mpic: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (7 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-08 6:37 ` Michael Ellerman
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kernel-janitors, Paul Mackerras, Michael Ellerman, linuxppc-dev,
linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/powerpc/sysdev/mpic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index 7de45b2..26d9c3f 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -1249,7 +1249,7 @@ struct mpic * __init mpic_alloc(struct device_node *node,
/* Pick the physical address from the device tree if unspecified */
if (!phys_addr) {
/* Check if it is DCR-based */
- if (of_get_property(node, "dcr-reg", NULL)) {
+ if (of_property_read_bool(node, "dcr-reg")) {
flags |= MPIC_USES_DCR;
} else {
struct resource r;
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 09/11] powerpc/mpic: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
@ 2016-08-08 6:37 ` Michael Ellerman
0 siblings, 0 replies; 33+ messages in thread
From: Michael Ellerman @ 2016-08-08 6:37 UTC (permalink / raw)
To: Julia Lawall, Benjamin Herrenschmidt
Cc: kernel-janitors, Paul Mackerras, linuxppc-dev, linux-kernel
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> arch/powerpc/sysdev/mpic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 10/11] soc: ti: knav_qmss_queue: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (8 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 12:47 ` Robin Murphy
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Santosh Shilimkar; +Cc: kernel-janitors, linux-kernel, linux-arm-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/soc/ti/knav_qmss_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index b73e353..56b5d7c 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1240,7 +1240,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
if (of_get_property(node, "qalloc-by-id", NULL))
range->flags |= RANGE_RESERVED;
- if (of_get_property(node, "accumulator", NULL)) {
+ if (of_property_read_bool(node, "accumulator")) {
ret = knav_init_acc_range(kdev, node, range);
if (ret < 0) {
devm_kfree(dev, range);
^ permalink raw reply related [flat|nested] 33+ messages in thread* Re: [PATCH 10/11] soc: ti: knav_qmss_queue: use of_property_read_bool
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
@ 2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:59 ` Julia Lawall
0 siblings, 1 reply; 33+ messages in thread
From: Robin Murphy @ 2016-08-05 12:47 UTC (permalink / raw)
To: Julia Lawall, Santosh Shilimkar
Cc: kernel-janitors, linux-kernel, linux-arm-kernel, devicetree, robh+dt
Hi Julia,
On 05/08/16 09:56, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
This caught my eye since Rob told me off for doing the same recently[1].
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..56b5d7c 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1240,7 +1240,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
> if (of_get_property(node, "qalloc-by-id", NULL))
According to the binding, "qalloc-by-id" _is_ a boolean property, so
this one really does deserve to be of_property_read_bool()...
> range->flags |= RANGE_RESERVED;
>
> - if (of_get_property(node, "accumulator", NULL)) {
> + if (of_property_read_bool(node, "accumulator")) {
...whereas "accumulator" must have a value, so this isn't technically
appropriate. In general, most of these "if the property exists, read the
property and do stuff" checks are probably a sign of code that could be
simplified by refactoring the "do stuff" step to just specifically
handle the "read the property" step returning -EINVAL when it's not present.
Robin.
[1]:https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg13375.html
> ret = knav_init_acc_range(kdev, node, range);
> if (ret < 0) {
> devm_kfree(dev, range);
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [PATCH 10/11] soc: ti: knav_qmss_queue: use of_property_read_bool
2016-08-05 12:47 ` Robin Murphy
@ 2016-08-05 12:59 ` Julia Lawall
0 siblings, 0 replies; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 12:59 UTC (permalink / raw)
To: Robin Murphy
Cc: Santosh Shilimkar, kernel-janitors, linux-kernel,
linux-arm-kernel, devicetree, robh+dt, linux-mmc, linux-i2c,
linux-usb, linuxppc-dev, linux-gpio, linux-serial, alsa-devel
On Fri, 5 Aug 2016, Robin Murphy wrote:
> Hi Julia,
>
> On 05/08/16 09:56, Julia Lawall wrote:
> > Use of_property_read_bool to check for the existence of a property.
>
> This caught my eye since Rob told me off for doing the same recently[1].
>
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > expression e1,e2;
> > statement S2,S1;
> > @@
> > - if (of_get_property(e1,e2,NULL))
> > + if (of_property_read_bool(e1,e2))
> > S1 else S2
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> > drivers/soc/ti/knav_qmss_queue.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> > index b73e353..56b5d7c 100644
> > --- a/drivers/soc/ti/knav_qmss_queue.c
> > +++ b/drivers/soc/ti/knav_qmss_queue.c
> > @@ -1240,7 +1240,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
> > if (of_get_property(node, "qalloc-by-id", NULL))
>
> According to the binding, "qalloc-by-id" _is_ a boolean property, so
> this one really does deserve to be of_property_read_bool()...
>
> > range->flags |= RANGE_RESERVED;
> >
> > - if (of_get_property(node, "accumulator", NULL)) {
> > + if (of_property_read_bool(node, "accumulator")) {
>
> ...whereas "accumulator" must have a value, so this isn't technically
> appropriate. In general, most of these "if the property exists, read the
> property and do stuff" checks are probably a sign of code that could be
> simplified by refactoring the "do stuff" step to just specifically
> handle the "read the property" step returning -EINVAL when it's not present.
Thanks for the very helpful feedback. I will rethink the patch set in
light of this information.
julia
> Robin.
>
> [1]:https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg13375.html
>
> > ret = knav_init_acc_range(kdev, node, range);
> > if (ret < 0) {
> > devm_kfree(dev, range);
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 11/11] ASoC: use of_property_read_bool
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
` (9 preceding siblings ...)
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
@ 2016-08-05 8:56 ` Julia Lawall
2016-08-05 12:09 ` Applied "ASoC: use of_property_read_bool" to the asoc tree Mark Brown
10 siblings, 1 reply; 33+ messages in thread
From: Julia Lawall @ 2016-08-05 8:56 UTC (permalink / raw)
To: Liam Girdwood
Cc: kernel-janitors, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/soc/codecs/ab8500-codec.c | 10 +++++-----
sound/soc/sh/rcar/ssi.c | 2 +-
sound/soc/soc-core.c | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 2fc8915..1d4059c 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2408,28 +2408,28 @@ static void ab8500_codec_of_probe(struct device *dev, struct device_node *np,
{
u32 value;
- if (of_get_property(np, "stericsson,amic1-type-single-ended", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1-type-single-ended"))
codec->amics.mic1_type = AMIC_TYPE_SINGLE_ENDED;
else
codec->amics.mic1_type = AMIC_TYPE_DIFFERENTIAL;
- if (of_get_property(np, "stericsson,amic2-type-single-ended", NULL))
+ if (of_property_read_bool(np, "stericsson,amic2-type-single-ended"))
codec->amics.mic2_type = AMIC_TYPE_SINGLE_ENDED;
else
codec->amics.mic2_type = AMIC_TYPE_DIFFERENTIAL;
/* Has a non-standard Vamic been requested? */
- if (of_get_property(np, "stericsson,amic1a-bias-vamic2", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1a-bias-vamic2"))
codec->amics.mic1a_micbias = AMIC_MICBIAS_VAMIC2;
else
codec->amics.mic1a_micbias = AMIC_MICBIAS_VAMIC1;
- if (of_get_property(np, "stericsson,amic1b-bias-vamic2", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1b-bias-vamic2"))
codec->amics.mic1b_micbias = AMIC_MICBIAS_VAMIC2;
else
codec->amics.mic1b_micbias = AMIC_MICBIAS_VAMIC1;
- if (of_get_property(np, "stericsson,amic2-bias-vamic1", NULL))
+ if (of_property_read_bool(np, "stericsson,amic2-bias-vamic1"))
codec->amics.mic2_micbias = AMIC_MICBIAS_VAMIC1;
else
codec->amics.mic2_micbias = AMIC_MICBIAS_VAMIC2;
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index 5f848f0..6cb6db0 100644
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -928,7 +928,7 @@ int rsnd_ssi_probe(struct rsnd_priv *priv)
}
ops = &rsnd_ssi_non_ops;
- if (of_get_property(np, "pio-transfer", NULL))
+ if (of_property_read_bool(np, "pio-transfer"))
ops = &rsnd_ssi_pio_ops;
else
ops = &rsnd_ssi_dma_ops;
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 16369ca..ead49d0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3733,7 +3733,7 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
* SND_SOC_DAIFMT_CLOCK_MASK area
*/
snprintf(prop, sizeof(prop), "%scontinuous-clock", prefix);
- if (of_get_property(np, prop, NULL))
+ if (of_property_read_bool(np, prop))
format |= SND_SOC_DAIFMT_CONT;
else
format |= SND_SOC_DAIFMT_GATED;
^ permalink raw reply related [flat|nested] 33+ messages in thread* Applied "ASoC: use of_property_read_bool" to the asoc tree
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
@ 2016-08-05 12:09 ` Mark Brown
0 siblings, 0 replies; 33+ messages in thread
From: Mark Brown @ 2016-08-05 12:09 UTC (permalink / raw)
To: Julia Lawall
Cc: Mark Brown, Liam Girdwood, alsa-devel, kernel-janitors,
linux-kernel, Takashi Iwai, Mark Brown
The patch
ASoC: use of_property_read_bool
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 7ac2a2432bbba0c3a5cf9848c768ff3c6c8a976c Mon Sep 17 00:00:00 2001
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Fri, 5 Aug 2016 10:56:51 +0200
Subject: [PATCH] ASoC: use of_property_read_bool
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/ab8500-codec.c | 10 +++++-----
sound/soc/sh/rcar/ssi.c | 2 +-
sound/soc/soc-core.c | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 8b1d0c1a7839..f2dd86ede075 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2408,28 +2408,28 @@ static void ab8500_codec_of_probe(struct device *dev, struct device_node *np,
{
u32 value;
- if (of_get_property(np, "stericsson,amic1-type-single-ended", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1-type-single-ended"))
codec->amics.mic1_type = AMIC_TYPE_SINGLE_ENDED;
else
codec->amics.mic1_type = AMIC_TYPE_DIFFERENTIAL;
- if (of_get_property(np, "stericsson,amic2-type-single-ended", NULL))
+ if (of_property_read_bool(np, "stericsson,amic2-type-single-ended"))
codec->amics.mic2_type = AMIC_TYPE_SINGLE_ENDED;
else
codec->amics.mic2_type = AMIC_TYPE_DIFFERENTIAL;
/* Has a non-standard Vamic been requested? */
- if (of_get_property(np, "stericsson,amic1a-bias-vamic2", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1a-bias-vamic2"))
codec->amics.mic1a_micbias = AMIC_MICBIAS_VAMIC2;
else
codec->amics.mic1a_micbias = AMIC_MICBIAS_VAMIC1;
- if (of_get_property(np, "stericsson,amic1b-bias-vamic2", NULL))
+ if (of_property_read_bool(np, "stericsson,amic1b-bias-vamic2"))
codec->amics.mic1b_micbias = AMIC_MICBIAS_VAMIC2;
else
codec->amics.mic1b_micbias = AMIC_MICBIAS_VAMIC1;
- if (of_get_property(np, "stericsson,amic2-bias-vamic1", NULL))
+ if (of_property_read_bool(np, "stericsson,amic2-bias-vamic1"))
codec->amics.mic2_micbias = AMIC_MICBIAS_VAMIC1;
else
codec->amics.mic2_micbias = AMIC_MICBIAS_VAMIC2;
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index 5f848f054745..6cb6db005fc4 100644
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -928,7 +928,7 @@ int rsnd_ssi_probe(struct rsnd_priv *priv)
}
ops = &rsnd_ssi_non_ops;
- if (of_get_property(np, "pio-transfer", NULL))
+ if (of_property_read_bool(np, "pio-transfer"))
ops = &rsnd_ssi_pio_ops;
else
ops = &rsnd_ssi_dma_ops;
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 16369cad4803..ead49d032e4c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3733,7 +3733,7 @@ unsigned int snd_soc_of_parse_daifmt(struct device_node *np,
* SND_SOC_DAIFMT_CLOCK_MASK area
*/
snprintf(prop, sizeof(prop), "%scontinuous-clock", prefix);
- if (of_get_property(np, prop, NULL))
+ if (of_property_read_bool(np, prop))
format |= SND_SOC_DAIFMT_CONT;
else
format |= SND_SOC_DAIFMT_GATED;
--
2.8.1
^ permalink raw reply related [flat|nested] 33+ messages in thread