* 2.4.14 doesn't compile: deactivate_page not defined in loop.c @ 2001-11-06 0:57 David Dyck 2001-11-06 1:30 ` Erik Andersen 2001-11-06 1:35 ` Chris Wright 0 siblings, 2 replies; 5+ messages in thread From: David Dyck @ 2001-11-06 0:57 UTC (permalink / raw) To: linux-kernel; +Cc: Jens Axboe drivers/block/block.o: In function `lo_send': drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page' drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page' a grep from deactivate_page only shows up in linux/drivers/block/loop.c ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c 2001-11-06 0:57 2.4.14 doesn't compile: deactivate_page not defined in loop.c David Dyck @ 2001-11-06 1:30 ` Erik Andersen 2001-11-06 1:35 ` Chris Wright 1 sibling, 0 replies; 5+ messages in thread From: Erik Andersen @ 2001-11-06 1:30 UTC (permalink / raw) To: David Dyck; +Cc: linux-kernel On Mon Nov 05, 2001 at 04:57:18PM -0800, David Dyck wrote: > > > drivers/block/block.o: In function `lo_send': > drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page' > drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page' > > > a grep from deactivate_page only shows up in linux/drivers/block/loop.c It used to be in mm/swap.c but it no longer is.... Looks like the loop device needs some surgery, -Erik -- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c 2001-11-06 0:57 2.4.14 doesn't compile: deactivate_page not defined in loop.c David Dyck 2001-11-06 1:30 ` Erik Andersen @ 2001-11-06 1:35 ` Chris Wright 2001-11-06 1:50 ` Andrea Arcangeli 1 sibling, 1 reply; 5+ messages in thread From: Chris Wright @ 2001-11-06 1:35 UTC (permalink / raw) To: David Dyck; +Cc: linux-kernel, Jens Axboe, Linus Torvalds * David Dyck (dcd@tc.fluke.com) wrote: > > > drivers/block/block.o: In function `lo_send': > drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page' > drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page' > > > a grep from deactivate_page only shows up in linux/drivers/block/loop.c appears that deactivate_page was removed (see patch-2.4.14). the patch below Works For Me with limited testing (mount loop back, write, unmount, remount, stuff i wrote is still there ;-). YMMV. cheers, -chris diff -X /home/chris/dontdiff -Naur linux-2.4.14/drivers/block/loop.c linux-2.4.14-loop/drivers/block/loop.c --- linux-2.4.14/drivers/block/loop.c Thu Oct 25 13:58:34 2001 +++ linux-2.4.14-loop/drivers/block/loop.c Mon Nov 5 17:06:08 2001 @@ -207,7 +207,6 @@ index++; pos += size; UnlockPage(page); - deactivate_page(page); page_cache_release(page); } return 0; @@ -218,7 +217,6 @@ kunmap(page); unlock: UnlockPage(page); - deactivate_page(page); page_cache_release(page); fail: return -1; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c 2001-11-06 1:35 ` Chris Wright @ 2001-11-06 1:50 ` Andrea Arcangeli 2001-11-06 2:14 ` Linus Torvalds 0 siblings, 1 reply; 5+ messages in thread From: Andrea Arcangeli @ 2001-11-06 1:50 UTC (permalink / raw) To: David Dyck, linux-kernel, Jens Axboe, Linus Torvalds On Mon, Nov 05, 2001 at 05:35:17PM -0800, Chris Wright wrote: > * David Dyck (dcd@tc.fluke.com) wrote: > > > > > > drivers/block/block.o: In function `lo_send': > > drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page' > > drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page' > > > > > > a grep from deactivate_page only shows up in linux/drivers/block/loop.c > > appears that deactivate_page was removed (see patch-2.4.14). the patch > below Works For Me with limited testing (mount loop back, write, > unmount, remount, stuff i wrote is still there ;-). YMMV. no idea why deactivate_page disappeared, it made sense to deactivate the lower level cache, it doesn't worth to keep two caches with duplicate information, the higher level cache is faster so we'd better get rid of the lowlevel cache ASAP, hence the deactivate_page in loop.c. Andrea ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c 2001-11-06 1:50 ` Andrea Arcangeli @ 2001-11-06 2:14 ` Linus Torvalds 0 siblings, 0 replies; 5+ messages in thread From: Linus Torvalds @ 2001-11-06 2:14 UTC (permalink / raw) To: Andrea Arcangeli; +Cc: David Dyck, linux-kernel, Jens Axboe On Tue, 6 Nov 2001, Andrea Arcangeli wrote: > > no idea why deactivate_page disappeared, it made sense to deactivate the > lower level cache Answer me this: How would it get activated in the first place? Right. By being accessed multiple times, that's how. Which you claim it won't be - in which case de-activating it is a no-op, and unnecessary. Now, there's another possibility: that it _does_ get accessed multiple times, _despite_ being the lower-level cache. In which case de-activating it is the wrong thing to do. So we basically have two cases. And in neither case does it make sense to de-activate the page. Eh? Linus ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-11-06 2:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2001-11-06 0:57 2.4.14 doesn't compile: deactivate_page not defined in loop.c David Dyck 2001-11-06 1:30 ` Erik Andersen 2001-11-06 1:35 ` Chris Wright 2001-11-06 1:50 ` Andrea Arcangeli 2001-11-06 2:14 ` Linus Torvalds
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).