RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support

[Vabhav Sharma <vabhav.sharma@nxp.com>]

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, October 8, 2018 11:15 AM
> To: Vabhav Sharma <vabhav.sharma@nxp.com>
> Cc: sudeep.holla@arm.com; oss@buserror.net; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> mturquette@baylibre.com; sboyd@kernel.org; rjw@rjwysocki.net;
> viresh.kumar@linaro.org; linux-clk@vger.kernel.org; linux-pm@vger.kernel.org;
> linux-kernel-owner@vger.kernel.org; catalin.marinas@arm.com;
> will.deacon@arm.com; gregkh@linuxfoundation.org; arnd@arndb.de;
> kstewart@linuxfoundation.org; yamada.masahiro@socionext.com; Leo Li
> <leoyang.li@nxp.com>; linux@armlinux.org.uk; Varun Sethi <V.Sethi@nxp.com>;
> Udit Kumar <udit.kumar@nxp.com>; Pankaj Bansal <pankaj.bansal@nxp.com>;
> Ramneek Mehresh <ramneek.mehresh@nxp.com>; Ying Zhang
> <ying.zhang22455@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Priyanka
> Jain <priyanka.jain@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>; Sriram Dash <sriram.dash@nxp.com>
> Subject: Re: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support
> 
> On Thu, Oct 04, 2018 at 06:33:50AM +0530, Vabhav Sharma wrote:
> > LX2160A SoC is based on Layerscape Chassis Generation 3.2 Architecture.
> >
> > LX2160A features an advanced 16 64-bit ARM v8 CortexA72 processor
> > cores in 8 cluster, CCN508, GICv3,two 64-bit DDR4 memory controller, 8
> > I2C controllers, 3 dspi, 2 esdhc,2 USB 3.0, mmu 500, 3 SATA, 4 PL011
> > SBSA UARTs etc.
> >
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@nxp.com>
> > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> > Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> > Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 702
> > +++++++++++++++++++++++++
> >  1 file changed, 702 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > new file mode 100644
> > index 0000000..c758268
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -0,0 +1,702 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) // // Device Tree
> > +Include file for Layerscape-LX2160A family SoC.
> > +//
> > +// Copyright 2018 NXP
> > +
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/memreserve/ 0x80000000 0x00010000;
> > +
> > +/ {
> > +	compatible = "fsl,lx2160a";
> > +	interrupt-parent = <&gic>;
> > +	#address-cells = <2>;
> > +	#size-cells = <2>;
> > +
> > +	cpus {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		// 8 clusters having 2 Cortex-A72 cores each
> > +		cpu@0 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x0>;
> > +			clocks = <&clockgen 1 0>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster0_l2>;
> > +		};
> > +
> > +		cpu@1 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x1>;
> > +			clocks = <&clockgen 1 0>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster0_l2>;
> > +		};
> > +
> > +		cpu@100 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x100>;
> > +			clocks = <&clockgen 1 1>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster1_l2>;
> > +		};
> > +
> > +		cpu@101 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x101>;
> > +			clocks = <&clockgen 1 1>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster1_l2>;
> > +		};
> > +
> > +		cpu@200 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x200>;
> > +			clocks = <&clockgen 1 2>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster2_l2>;
> > +		};
> > +
> > +		cpu@201 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x201>;
> > +			clocks = <&clockgen 1 2>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster2_l2>;
> > +		};
> > +
> > +		cpu@300 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x300>;
> > +			clocks = <&clockgen 1 3>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster3_l2>;
> > +		};
> > +
> > +		cpu@301 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x301>;
> > +			clocks = <&clockgen 1 3>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster3_l2>;
> > +		};
> > +
> > +		cpu@400 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x400>;
> > +			clocks = <&clockgen 1 4>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster4_l2>;
> > +		};
> > +
> > +		cpu@401 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x401>;
> > +			clocks = <&clockgen 1 4>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster4_l2>;
> > +		};
> > +
> > +		cpu@500 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x500>;
> > +			clocks = <&clockgen 1 5>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster5_l2>;
> > +		};
> > +
> > +		cpu@501 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x501>;
> > +			clocks = <&clockgen 1 5>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster5_l2>;
> > +		};
> > +
> > +		cpu@600 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x600>;
> > +			clocks = <&clockgen 1 6>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster6_l2>;
> > +		};
> > +
> > +		cpu@601 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x601>;
> > +			clocks = <&clockgen 1 6>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster6_l2>;
> > +		};
> > +
> > +		cpu@700 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x700>;
> > +			clocks = <&clockgen 1 7>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster7_l2>;
> > +		};
> > +
> > +		cpu@701 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			enable-method = "psci";
> > +			reg = <0x701>;
> > +			clocks = <&clockgen 1 7>;
> > +			d-cache-size = <0x8000>;
> > +			d-cache-line-size = <64>;
> > +			d-cache-sets = <128>;
> > +			i-cache-size = <0xC000>;
> > +			i-cache-line-size = <64>;
> > +			i-cache-sets = <192>;
> > +			next-level-cache = <&cluster7_l2>;
> > +		};
> > +
> > +		cluster0_l2: l2-cache0 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster1_l2: l2-cache1 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster2_l2: l2-cache2 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster3_l2: l2-cache3 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster4_l2: l2-cache4 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster5_l2: l2-cache5 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster6_l2: l2-cache6 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +
> > +		cluster7_l2: l2-cache7 {
> > +			compatible = "cache";
> > +			cache-size = <0x100000>;
> > +			cache-line-size = <64>;
> > +			cache-sets = <1024>;
> > +			cache-level = <2>;
> > +		};
> > +	};
> > +
> > +	gic: interrupt-controller@6000000 {
> > +		compatible = "arm,gic-v3";
> > +		reg = <0x0 0x06000000 0 0x10000>, // GIC Dist
> > +			<0x0 0x06200000 0 0x200000>, // GICR (RD_base +
> > +						     // SGI_base)
> > +			<0x0 0x0c0c0000 0 0x2000>, // GICC
> > +			<0x0 0x0c0d0000 0 0x1000>, // GICH
> > +			<0x0 0x0c0e0000 0 0x20000>; // GICV
> > +		#interrupt-cells = <3>;
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +		interrupt-controller;
> > +		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > +		its: gic-its@6020000 {
> > +			compatible = "arm,gic-v3-its";
> > +			msi-controller;
> > +			reg = <0x0 0x6020000 0 0x20000>;
> > +		};
> > +	};
> > +
> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>,
> > +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +
> > +	pmu {
> > +		compatible = "arm,cortex-a72-pmu";
> > +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +
> > +	psci {
> > +		compatible = "arm,psci-0.2";
> > +		method = "smc";
> > +	};
> > +
> > +	memory@80000000 {
> > +		// DRAM space - 1, size : 2 GB DRAM
> > +		device_type = "memory";
> > +		reg = <0x00000000 0x80000000 0 0x80000000>;
> > +	};
> > +
> > +	ddr1: memory-controller@1080000 {
> > +		compatible = "fsl,qoriq-memory-controller";
> > +		reg = <0x0 0x1080000 0x0 0x1000>;
> > +		interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > +		little-endian;
> > +	};
> > +
> > +	ddr2: memory-controller@1090000 {
> > +		compatible = "fsl,qoriq-memory-controller";
> > +		reg = <0x0 0x1090000 0x0 0x1000>;
> > +		interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > +		little-endian;
> > +	};
> > +
> > +	sysclk: sysclk {
> 
> Name the node a bit generic like clock-xxx.
There is only one clock-unit, Bootloader(U-boot) require sysclk node during device tree fix-up as different platform support varied platform frequency as per reset configuration word used.
Referred other ARM based platform with one clock using name as x: x
> 
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <100000000>;
> > +		clock-output-names = "sysclk";
> > +	};
> > +
> > +	soc {
> > +		compatible = "simple-bus";
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +
> > +		clockgen: clocking@1300000 {
> 
> clock-controller for node name.
Ok, I see generic name recommendation section 2.2.2 DT Specification
> 
> > +			compatible = "fsl,lx2160a-clockgen";
> > +			reg = <0 0x1300000 0 0xa0000>;
> > +			#clock-cells = <2>;
> > +			clocks = <&sysclk>;
> > +		};
> > +
> > +		crypto: crypto@8000000 {
> > +			compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
> > +			fsl,sec-era = <10>;
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +			ranges = <0x0 0x00 0x8000000 0x100000>;
> > +			reg = <0x00 0x8000000 0x0 0x100000>;
> > +			interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
> > +			dma-coherent;
> > +			status = "disabled";
> > +
> > +			sec_jr0: jr@10000 {
> > +				compatible = "fsl,sec-v5.0-job-ring",
> > +					     "fsl,sec-v4.0-job-ring";
> > +				reg        = <0x10000 0x10000>;
> > +				interrupts = <GIC_SPI 140
> IRQ_TYPE_LEVEL_HIGH>;
> > +			};
> > +
> > +			sec_jr1: jr@20000 {
> > +				compatible = "fsl,sec-v5.0-job-ring",
> > +					     "fsl,sec-v4.0-job-ring";
> > +				reg        = <0x20000 0x10000>;
> > +				interrupts = <GIC_SPI 141
> IRQ_TYPE_LEVEL_HIGH>;
> > +			};
> > +
> > +			sec_jr2: jr@30000 {
> > +				compatible = "fsl,sec-v5.0-job-ring",
> > +					     "fsl,sec-v4.0-job-ring";
> > +				reg        = <0x30000 0x10000>;
> > +				interrupts = <GIC_SPI 142
> IRQ_TYPE_LEVEL_HIGH>;
> > +			};
> > +
> > +			sec_jr3: jr@40000 {
> > +				compatible = "fsl,sec-v5.0-job-ring",
> > +					     "fsl,sec-v4.0-job-ring";
> > +				reg        = <0x40000 0x10000>;
> > +				interrupts = <GIC_SPI 143
> IRQ_TYPE_LEVEL_HIGH>;
> > +			};
> > +		};
> > +
> > +		dcfg: dcfg@1e00000 {
> 
> As per suggestion from devicetree specification, we can "syscon" as a more
> generic node name?
Sure as per DT spec recommendation, Updating to dcfg: syscon@1e00000
> 
> > +			compatible = "fsl,lx2160a-dcfg", "syscon";
> > +			reg = <0x0 0x1e00000 0x0 0x10000>;
> > +			little-endian;
> > +		};
> > +
> > +		gpio0: gpio@2300000 {
> > +			compatible = "fsl,qoriq-gpio";
> > +			reg = <0x0 0x2300000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			little-endian;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +		};
> > +
> > +		gpio1: gpio@2310000 {
> > +			compatible = "fsl,qoriq-gpio";
> > +			reg = <0x0 0x2310000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			little-endian;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +		};
> > +
> > +		gpio2: gpio@2320000 {
> > +			compatible = "fsl,qoriq-gpio";
> > +			reg = <0x0 0x2320000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			little-endian;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +		};
> > +
> > +		gpio3: gpio@2330000 {
> > +			compatible = "fsl,qoriq-gpio";
> > +			reg = <0x0 0x2330000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> > +			gpio-controller;
> > +			little-endian;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +		};
> > +
> > +		i2c0: i2c@2000000 {
> 
> Sort the nodes under bus in order of unit-address.
Ok, I will update
Is it recommendation or rule? I don't see in DT specification
> 
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2000000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			fsl-scl-gpio = <&gpio2 15 0>;
> 
> I cannot find this property in fsl,vf610-i2c bindings.
Yes this is not present, I will update the property as scl-gpio
> 
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c1: i2c@2010000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2010000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c2: i2c@2020000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2020000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c3: i2c@2030000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2030000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c4: i2c@2040000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2040000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			fsl-scl-gpio = <&gpio2 16 0>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c5: i2c@2050000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2050000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c6: i2c@2060000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2060000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		i2c7: i2c@2070000 {
> > +			compatible = "fsl,vf610-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x2070000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "i2c";
> > +			clocks = <&clockgen 4 7>;
> > +			status = "disabled";
> > +		};
> > +
> > +		uart0: serial@21c0000 {
> > +			device_type = "serial";
> 
> Quote from devicetree specification:
> 
> The device_type property was used in IEEE 1275 to describe the device’s FCode
> programming model. Because DTSpec does not have FCode, new use of the
> property is deprecated, and it should be included only on cpu and memory nodes
> for compatibility with IEEE 1275–derived devicetrees.
Ok, Thanks. I see section 2.3.11  DT specification as you mentioned.
Not required except for memory/cpu node, I will update
> 
> > +			compatible = "arm,sbsa-uart","arm,pl011";
> > +			reg = <0x0 0x21c0000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> > +			current-speed = <115200>;
> > +			status = "disabled";
> > +		};
> > +
> > +		uart1: serial@21d0000 {
> > +			device_type = "serial";
> > +			compatible = "arm,sbsa-uart","arm,pl011";
> > +			reg = <0x0 0x21d0000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> > +			current-speed = <115200>;
> > +			status = "disabled";
> > +		};
> > +
> > +		uart2: serial@21e0000 {
> > +			device_type = "serial";
> > +			compatible = "arm,sbsa-uart","arm,pl011";
> > +			reg = <0x0 0x21e0000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> > +			current-speed = <115200>;
> > +			status = "disabled";
> > +		};
> > +
> > +		uart3: serial@21f0000 {
> > +			device_type = "serial";
> > +			compatible = "arm,sbsa-uart","arm,pl011";
> > +			reg = <0x0 0x21f0000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +			current-speed = <115200>;
> > +			status = "disabled";
> > +		};
> > +
> > +		smmu: iommu@5000000 {
> > +			compatible = "arm,mmu-500";
> > +			reg = <0 0x5000000 0 0x800000>;
> > +			#iommu-cells = <1>;
> > +			#global-interrupts = <14>;
> > +			interrupts = <0 13 4>, // global secure fault
> 
> Can we use defines for interrupt cells just like other device nodes?
Sure
> 
> > +				     <0 14 4>, // combined secure interrupt
> > +				     <0 15 4>, // global non-secure fault
> > +				     <0 16 4>, // combined non-secure interrupt
> > +				// performance counter interrupts 0-9
> > +				     <0 211 4>, <0 212 4>,
> > +				     <0 213 4>, <0 214 4>,
> > +				     <0 215 4>, <0 216 4>,
> > +				     <0 217 4>, <0 218 4>,
> > +				     <0 219 4>, <0 220 4>,
> > +				// per context interrupt, 64 interrupts
> > +				     <0 146 4>, <0 147 4>,
> > +				     <0 148 4>, <0 149 4>,
> > +				     <0 150 4>, <0 151 4>,
> > +				     <0 152 4>, <0 153 4>,
> > +				     <0 154 4>, <0 155 4>,
> > +				     <0 156 4>, <0 157 4>,
> > +				     <0 158 4>, <0 159 4>,
> > +				     <0 160 4>, <0 161 4>,
> > +				     <0 162 4>, <0 163 4>,
> > +				     <0 164 4>, <0 165 4>,
> > +				     <0 166 4>, <0 167 4>,
> > +				     <0 168 4>, <0 169 4>,
> > +				     <0 170 4>, <0 171 4>,
> > +				     <0 172 4>, <0 173 4>,
> > +				     <0 174 4>, <0 175 4>,
> > +				     <0 176 4>, <0 177 4>,
> > +				     <0 178 4>, <0 179 4>,
> > +				     <0 180 4>, <0 181 4>,
> > +				     <0 182 4>, <0 183 4>,
> > +				     <0 184 4>, <0 185 4>,
> > +				     <0 186 4>, <0 187 4>,
> > +				     <0 188 4>, <0 189 4>,
> > +				     <0 190 4>, <0 191 4>,
> > +				     <0 192 4>, <0 193 4>,
> > +				     <0 194 4>, <0 195 4>,
> > +				     <0 196 4>, <0 197 4>,
> > +				     <0 198 4>, <0 199 4>,
> > +				     <0 200 4>, <0 201 4>,
> > +				     <0 202 4>, <0 203 4>,
> > +				     <0 204 4>, <0 205 4>,
> > +				     <0 206 4>, <0 207 4>,
> > +				     <0 208 4>, <0 209 4>;
> > +			dma-coherent;
> > +		};
> > +
> > +		usb0: usb3@3100000 {
> 
> usb for node name.
Ok, I see recommendation for generic name in DT spec
> 
> Shawn
> 
> > +			compatible = "snps,dwc3";
> > +			reg = <0x0 0x3100000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> > +			dr_mode = "host";
> > +			snps,quirk-frame-length-adjustment = <0x20>;
> > +			snps,dis_rxdet_inp3_quirk;
> > +			status = "disabled";
> > +		};
> > +
> > +		usb1: usb3@3110000 {
> > +			compatible = "snps,dwc3";
> > +			reg = <0x0 0x3110000 0x0 0x10000>;
> > +			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > +			dr_mode = "host";
> > +			snps,quirk-frame-length-adjustment = <0x20>;
> > +			snps,dis_rxdet_inp3_quirk;
> > +			status = "disabled";
> > +		};
> > +
> > +		watchdog@23a0000 {
> > +			compatible = "arm,sbsa-gwdt";
> > +			reg = <0x0 0x23a0000 0 0x1000>,
> > +			      <0x0 0x2390000 0 0x1000>;
> > +			interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
> > +			timeout-sec = <30>;
> > +		};
> > +	};
> > +};
> > --
> > 2.7.4
> >