* [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
@ 2020-12-19 22:43 Daniel West
2020-12-20 15:29 ` Kari Argillander
2020-12-28 14:09 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Daniel West @ 2020-12-19 22:43 UTC (permalink / raw)
To: Larry.Finger
Cc: gregkh, insafonov, daniel.west.dev, gustavoars,
andrealmeidap1996, yepeilin.cs, devel, linux-kernel
Fixed a checkpatch warning:
WARNING: Block comments use * on subsequent lines
#4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
+/****************************************************************************
+
The code is full of comments like this. Should the coding style
be inforced here, even when there is a logic to the way the code
was broken up?
Signed-off-by: Daniel West <daniel.west.dev@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 8794907a39f4..adf2788a416f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
@@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
}
}
-/****************************************************************************
-
-Following are the functions for the timer handlers
-
-*****************************************************************************/
+/*
+ *
+ *Following are the functions for the timer handlers
+ */
static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
2020-12-19 22:43 [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue Daniel West
@ 2020-12-20 15:29 ` Kari Argillander
2020-12-28 14:09 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Kari Argillander @ 2020-12-20 15:29 UTC (permalink / raw)
To: Daniel West
Cc: Larry.Finger, gregkh, insafonov, gustavoars, andrealmeidap1996,
yepeilin.cs, devel, linux-kernel
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> Fixed a checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
> #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> +/****************************************************************************
> +
>
> The code is full of comments like this. Should the coding style
> be inforced here, even when there is a logic to the way the code
> was broken up?
You should make one patch which atleast fix one file at ones. It would
be even better if it fixes whole stuff (example one driver) right a way.
Also note that you should not but this kind messages to your patch
message. If you want to note this kind of thing you can use --- and
after that it will not included in patch itself. You can read it online
more.
Also where does this [PATCH 8455/8455] even come from? Good thing is
that you really didn't send so many patches or atleast I won't see them.
And it seems that you are new so welcome a board :)
--
Kari Argillander
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
2020-12-19 22:43 [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue Daniel West
2020-12-20 15:29 ` Kari Argillander
@ 2020-12-28 14:09 ` Greg KH
2020-12-28 19:47 ` Joe Perches
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-12-28 14:09 UTC (permalink / raw)
To: Daniel West
Cc: Larry.Finger, devel, insafonov, gustavoars, andrealmeidap1996,
linux-kernel, yepeilin.cs
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> Fixed a checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
> #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> +/****************************************************************************
> +
>
> The code is full of comments like this. Should the coding style
> be inforced here, even when there is a logic to the way the code
> was broken up?
>
> Signed-off-by: Daniel West <daniel.west.dev@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 8794907a39f4..adf2788a416f 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
> }
> }
>
> -/****************************************************************************
> -
> -Following are the functions for the timer handlers
> -
> -*****************************************************************************/
> +/*
> + *
> + *Following are the functions for the timer handlers
> + */
Does that look correct? Make it all one line please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
2020-12-28 14:09 ` Greg KH
@ 2020-12-28 19:47 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-12-28 19:47 UTC (permalink / raw)
To: Greg KH, Daniel West
Cc: Larry.Finger, devel, insafonov, gustavoars, andrealmeidap1996,
linux-kernel, yepeilin.cs
On Mon, 2020-12-28 at 15:09 +0100, Greg KH wrote:
> On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> > Fixed a checkpatch warning:
> >
> > WARNING: Block comments use * on subsequent lines
> > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> > +/****************************************************************************
> > +
> >
> > The code is full of comments like this. Should the coding style
> > be inforced here, even when there is a logic to the way the code
> > was broken up?
[]
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
[]
> > @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
> > }
> > }
> >
> >
> > -/****************************************************************************
> > -
> > -Following are the functions for the timer handlers
> > -
> > -*****************************************************************************/
> > +/*
> > + *
> > + *Following are the functions for the timer handlers
> > + */
>
> Does that look correct? Make it all one line please.
Just:
/* timer handler functions */
would be simpler.
And the code is mostly a horror to read.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-28 23:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-19 22:43 [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue Daniel West
2020-12-20 15:29 ` Kari Argillander
2020-12-28 14:09 ` Greg KH
2020-12-28 19:47 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).