* [PATCH] staging: rtl8723bs: align comments
@ 2021-03-10 15:37 Fabio Aiuto
2021-03-10 15:51 ` Greg KH
2021-03-10 17:48 ` Dan Carpenter
0 siblings, 2 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-10 15:37 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
fix the following checkpatch warnings:
WARNING: Block comments use * on subsequent lines
+ /*
+ AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
--
WARNING: Block comments use * on subsequent lines
+/*
+op_mode
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index b6f944b37b08..3a0e4f64466a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
/* handle A-MPDU parameter field */
/*
- AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
- AMPDU_para [4:2]:Min MPDU Start Spacing
- */
+ * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
+ * AMPDU_para [4:2]:Min MPDU Start Spacing
+ */
max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
min_MPDU_spacing = (
@@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
}
/*
-op_mode
-Set to 0 (HT pure) under the following conditions
- - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
- - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
-Set to 1 (HT non-member protection) if there may be non-HT STAs
- in both the primary and the secondary channel
-Set to 2 if only HT STAs are associated in BSS,
- however and at least one 20 MHz HT STA is associated
-Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
- (currently non-GF HT station is considered as non-HT STA also)
-*/
+ *op_mode
+ *Set to 0 (HT pure) under the following conditions
+ * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
+ * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
+ *Set to 1 (HT non-member protection) if there may be non-HT STAs
+ * in both the primary and the secondary channel
+ *Set to 2 if only HT STAs are associated in BSS,
+ * however and at least one 20 MHz HT STA is associated
+ *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
+ * (currently non-GF HT station is considered as non-HT STA also)
+ */
static int rtw_ht_operation_update(struct adapter *padapter)
{
u16 cur_op_mode, new_op_mode;
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 15:37 [PATCH] staging: rtl8723bs: align comments Fabio Aiuto
@ 2021-03-10 15:51 ` Greg KH
2021-03-10 21:58 ` Fabio Aiuto
2021-03-10 17:48 ` Dan Carpenter
1 sibling, 1 reply; 11+ messages in thread
From: Greg KH @ 2021-03-10 15:51 UTC (permalink / raw)
To: Fabio Aiuto; +Cc: devel, linux-kernel
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch warnings:
>
> WARNING: Block comments use * on subsequent lines
> + /*
> + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> --
> WARNING: Block comments use * on subsequent lines
> +/*
> +op_mode
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index b6f944b37b08..3a0e4f64466a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
>
> /* handle A-MPDU parameter field */
> /*
> - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> - AMPDU_para [4:2]:Min MPDU Start Spacing
> - */
> + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> + * AMPDU_para [4:2]:Min MPDU Start Spacing
> + */
> max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
>
> min_MPDU_spacing = (
> @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> }
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
> + *Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + *Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + */
Add a space after the ' ' to make it look correct please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 15:51 ` Greg KH
@ 2021-03-10 21:58 ` Fabio Aiuto
2021-03-10 22:13 ` Fabio Aiuto
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-10 21:58 UTC (permalink / raw)
To: Greg KH
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote:
> On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch warnings:
> >
> > WARNING: Block comments use * on subsequent lines
> > + /*
> > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > --
> > WARNING: Block comments use * on subsequent lines
> > +/*
> > +op_mode
> >
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> > 1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > index b6f944b37b08..3a0e4f64466a 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
> >
> > /* handle A-MPDU parameter field */
> > /*
> > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > - AMPDU_para [4:2]:Min MPDU Start Spacing
> > - */
> > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > + * AMPDU_para [4:2]:Min MPDU Start Spacing
> > + */
> > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
> >
> > min_MPDU_spacing = (
> > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> > }
> >
> > /*
> > -op_mode
> > -Set to 0 (HT pure) under the following conditions
> > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > -Set to 1 (HT non-member protection) if there may be non-HT STAs
> > - in both the primary and the secondary channel
> > -Set to 2 if only HT STAs are associated in BSS,
> > - however and at least one 20 MHz HT STA is associated
> > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > - (currently non-GF HT station is considered as non-HT STA also)
> > -*/
> > + *op_mode
> > + *Set to 0 (HT pure) under the following conditions
> > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> > + * in both the primary and the secondary channel
> > + *Set to 2 if only HT STAs are associated in BSS,
> > + * however and at least one 20 MHz HT STA is associated
> > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > + * (currently non-GF HT station is considered as non-HT STA also)
> > + */
>
> Add a space after the ' ' to make it look correct please.
>
> thanks,
>
> greg k-h
I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
Where have I to add a ' ' (a blank?)?
thank you,
fabio
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 21:58 ` Fabio Aiuto
@ 2021-03-10 22:13 ` Fabio Aiuto
2021-03-10 22:27 ` Eric Curtin
[not found] ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
2 siblings, 0 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-10 22:13 UTC (permalink / raw)
To: Greg KH
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote:
> On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch warnings:
> >
> > WARNING: Block comments use * on subsequent lines
> > + /*
> > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > --
> > WARNING: Block comments use * on subsequent lines
> > +/*
> > +op_mode
> >
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> > 1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > index b6f944b37b08..3a0e4f64466a 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
> >
> > /* handle A-MPDU parameter field */
> > /*
> > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > - AMPDU_para [4:2]:Min MPDU Start Spacing
> > - */
> > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > + * AMPDU_para [4:2]:Min MPDU Start Spacing
> > + */
> > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
> >
> > min_MPDU_spacing = (
> > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> > }
> >
> > /*
> > -op_mode
> > -Set to 0 (HT pure) under the following conditions
> > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > -Set to 1 (HT non-member protection) if there may be non-HT STAs
> > - in both the primary and the secondary channel
> > -Set to 2 if only HT STAs are associated in BSS,
> > - however and at least one 20 MHz HT STA is associated
> > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > - (currently non-GF HT station is considered as non-HT STA also)
> > -*/
> > + *op_mode
> > + *Set to 0 (HT pure) under the following conditions
> > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> > + * in both the primary and the secondary channel
> > + *Set to 2 if only HT STAs are associated in BSS,
> > + * however and at least one 20 MHz HT STA is associated
> > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > + * (currently non-GF HT station is considered as non-HT STA also)
> > + */
>
> Add a space after the ' ' to make it look correct please.
>
> thanks,
>
> greg k-h
I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
Where have I to add a ' ' (a blank?)?
thank you,
fabio
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 21:58 ` Fabio Aiuto
2021-03-10 22:13 ` Fabio Aiuto
@ 2021-03-10 22:27 ` Eric Curtin
2021-03-10 22:45 ` Fabio Aiuto
2021-03-12 9:15 ` Fabio Aiuto
[not found] ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
2 siblings, 2 replies; 11+ messages in thread
From: Eric Curtin @ 2021-03-10 22:27 UTC (permalink / raw)
To: Fabio Aiuto; +Cc: Greg KH, Kernel development list
Hi Fabio,
> I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> Where have I to add a ' ' (a blank?)?
>
> thank you,
>
> fabio
>
I'm only responding to this because this email is doing a very good job
of avoiding my filters somehow :) I think what Greg means is:
Change this:
/*
-op_mode
-Set to 0 (HT pure) under the following conditions
- - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
- - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
-Set to 1 (HT non-member protection) if there may be non-HT STAs
- in both the primary and the secondary channel
-Set to 2 if only HT STAs are associated in BSS,
- however and at least one 20 MHz HT STA is associated
-Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
- (currently non-GF HT station is considered as non-HT STA also)
-*/
+ *op_mode
+ *Set to 0 (HT pure) under the following conditions
+ * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
+ * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
+ *Set to 1 (HT non-member protection) if there may be non-HT STAs
+ * in both the primary and the secondary channel
+ *Set to 2 if only HT STAs are associated in BSS,
+ * however and at least one 20 MHz HT STA is associated
+ *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
+ * (currently non-GF HT station is considered as non-HT STA also)
+ */
to this:
/*
-op_mode
-Set to 0 (HT pure) under the following conditions
- - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
- - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
-Set to 1 (HT non-member protection) if there may be non-HT STAs
- in both the primary and the secondary channel
-Set to 2 if only HT STAs are associated in BSS,
- however and at least one 20 MHz HT STA is associated
-Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
- (currently non-GF HT station is considered as non-HT STA also)
-*/
+ * op_mode
+ * Set to 0 (HT pure) under the following conditions
+ * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
+ * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
+ * Set to 1 (HT non-member protection) if there may be non-HT STAs
+ * in both the primary and the secondary channel
+ * Set to 2 if only HT STAs are associated in BSS,
+ * however and at least one 20 MHz HT STA is associated
+ * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
+ * (currently non-GF HT station is considered as non-HT STA also)
+ * /
Like Dan said, you need a space after the '*'/
Is mise le meas/Regards,
Eric Curtin
Check out this charity that's close to my heart:
https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html
https://www.facebook.com/Peak-for-Pat-104470678280309
https://www.instagram.com/peakforpat/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 22:27 ` Eric Curtin
@ 2021-03-10 22:45 ` Fabio Aiuto
2021-03-12 9:15 ` Fabio Aiuto
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-10 22:45 UTC (permalink / raw)
To: Eric Curtin; +Cc: gregkh, linux-kernel
On Wed, Mar 10, 2021 at 10:27:53PM +0000, Eric Curtin wrote:
> Hi Fabio,
>
> > I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> > Where have I to add a ' ' (a blank?)?
> >
> > thank you,
> >
> > fabio
> >
>
> I'm only responding to this because this email is doing a very good job
> of avoiding my filters somehow :) I think what Greg means is:
>
> Change this:
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
> + *Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + *Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + */
>
> to this:
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + * op_mode
> + * Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + * Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + * Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + * /
>
> Like Dan said, you need a space after the '*'/
>
> Is mise le meas/Regards,
>
> Eric Curtin
>
> Check out this charity that's close to my heart:
>
> https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html
> https://www.facebook.com/Peak-for-Pat-104470678280309
> https://www.instagram.com/peakforpat/
thank you, Eric :)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 22:27 ` Eric Curtin
2021-03-10 22:45 ` Fabio Aiuto
@ 2021-03-12 9:15 ` Fabio Aiuto
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-12 9:15 UTC (permalink / raw)
To: Eric Curtin; +Cc: gregkh, linux-kernel
On Wed, Mar 10, 2021 at 10:27:53PM +0000, Eric Curtin wrote:
> Hi Fabio,
>
> > I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> > Where have I to add a ' ' (a blank?)?
> >
> > thank you,
> >
> > fabio
> >
>
> I'm only responding to this because this email is doing a very good job
> of avoiding my filters somehow :) I think what Greg means is:
>
> Change this:
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
> + *Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + *Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + */
>
> to this:
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + * op_mode
> + * Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + * Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + * Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + * /
>
> Like Dan said, you need a space after the '*'/
>
> Is mise le meas/Regards,
>
> Eric Curtin
>
> Check out this charity that's close to my heart:
>
> https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html
> https://www.facebook.com/Peak-for-Pat-104470678280309
> https://www.instagram.com/peakforpat/
Thank you Eric, community is the best resource ever :), hope to contribute
soon
Kind regards,
Fabio
^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>]
* Re: [PATCH] staging: rtl8723bs: align comments
[not found] ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
@ 2021-03-11 13:31 ` Fabio Aiuto
0 siblings, 0 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-11 13:31 UTC (permalink / raw)
To: Miguel Ojeda; +Cc: gregkh, linux-kernel
On Thu, Mar 11, 2021 at 09:03:57AM +0100, Miguel Ojeda wrote:
> On Wed, Mar 10, 2021 at 11:00 PM Fabio Aiuto <fabioaiuto83@gmail.com> wrote:
> >
> > I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
> > Where have I to add a ' ' (a blank?)?
>
> Please take a look at Documentation/process/coding-style.rst (comments
> are also described there).
>
> HTH,
>
> Cheers,
> Miguel
Thank you Miguel,
fabio
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 15:37 [PATCH] staging: rtl8723bs: align comments Fabio Aiuto
2021-03-10 15:51 ` Greg KH
@ 2021-03-10 17:48 ` Dan Carpenter
2021-03-11 9:15 ` Joe Perches
1 sibling, 1 reply; 11+ messages in thread
From: Dan Carpenter @ 2021-03-10 17:48 UTC (permalink / raw)
To: Fabio Aiuto; +Cc: gregkh, devel, linux-kernel
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> fix the following checkpatch warnings:
>
> WARNING: Block comments use * on subsequent lines
> + /*
> + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> --
> WARNING: Block comments use * on subsequent lines
> +/*
> +op_mode
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index b6f944b37b08..3a0e4f64466a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
>
> /* handle A-MPDU parameter field */
> /*
Combine these two comments into one mult-line comment.
> - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> - AMPDU_para [4:2]:Min MPDU Start Spacing
> - */
> + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> + * AMPDU_para [4:2]:Min MPDU Start Spacing
> + */
> max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
>
> min_MPDU_spacing = (
> @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> }
>
> /*
> -op_mode
> -Set to 0 (HT pure) under the following conditions
> - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> -Set to 1 (HT non-member protection) if there may be non-HT STAs
> - in both the primary and the secondary channel
> -Set to 2 if only HT STAs are associated in BSS,
> - however and at least one 20 MHz HT STA is associated
> -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> - (currently non-GF HT station is considered as non-HT STA also)
> -*/
> + *op_mode
You need to have a space character after the '*'.
/*
* op_mode
* Set to ...
> + *Set to 0 (HT pure) under the following conditions
> + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> + * in both the primary and the secondary channel
> + *Set to 2 if only HT STAs are associated in BSS,
> + * however and at least one 20 MHz HT STA is associated
> + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> + * (currently non-GF HT station is considered as non-HT STA also)
> + */
regards,
dan carpenter
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-10 17:48 ` Dan Carpenter
@ 2021-03-11 9:15 ` Joe Perches
2021-03-11 16:38 ` Fabio Aiuto
0 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2021-03-11 9:15 UTC (permalink / raw)
To: Dan Carpenter, Fabio Aiuto; +Cc: gregkh, devel, linux-kernel
On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote:
> You need to have a space character after the '*'.
Perhaps YA checkpatch test...
---
scripts/checkpatch.pl | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f42e5ba16d9b..0de553d52605 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3876,6 +3876,21 @@ sub process {
}
}
+# Independent comment lines should have a space after the comment initiator
+ if ($line =~ /^\+[ \t]*($;+)/) { #leading comment
+ my $comment = trim(substr($rawline, $-[1], $+[1] - $-[1]));
+ if ($comment =~ m{^(/\*|\*/|\*|//)(.*)}) {
+ my $init = $1;
+ my $rest = $2;
+ if ($init =~ m{^(?:/\*|\*|//)$} &&
+ $rest ne '' &&
+ $rest !~ /^[\s\*=\-]/) {
+ WARN("COMMENT_STYLE",
+ "Comments generally use whitespace after the comment initiator\n" . $herecurr);
+ }
+ }
+ }
+
# check for missing blank lines after struct/union declarations
# with exceptions for various attributes and macros
if ($prevline =~ /^[\+ ]};?\s*$/ &&
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] staging: rtl8723bs: align comments
2021-03-11 9:15 ` Joe Perches
@ 2021-03-11 16:38 ` Fabio Aiuto
0 siblings, 0 replies; 11+ messages in thread
From: Fabio Aiuto @ 2021-03-11 16:38 UTC (permalink / raw)
To: Joe Perches; +Cc: gregkh, linux-kernel
On Thu, Mar 11, 2021 at 01:15:34AM -0800, Joe Perches wrote:
> On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote:
> > You need to have a space character after the '*'.
>
> Perhaps YA checkpatch test...
> ---
> scripts/checkpatch.pl | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f42e5ba16d9b..0de553d52605 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3876,6 +3876,21 @@ sub process {
> }
> }
>
> +# Independent comment lines should have a space after the comment initiator
> + if ($line =~ /^\+[ \t]*($;+)/) { #leading comment
> + my $comment = trim(substr($rawline, $-[1], $+[1] - $-[1]));
> + if ($comment =~ m{^(/\*|\*/|\*|//)(.*)}) {
> + my $init = $1;
> + my $rest = $2;
> + if ($init =~ m{^(?:/\*|\*|//)$} &&
> + $rest ne '' &&
> + $rest !~ /^[\s\*=\-]/) {
> + WARN("COMMENT_STYLE",
> + "Comments generally use whitespace after the comment initiator\n" . $herecurr);
> + }
> + }
> + }
> +
> # check for missing blank lines after struct/union declarations
> # with exceptions for various attributes and macros
> if ($prevline =~ /^[\+ ]};?\s*$/ &&
>
Thank you Joe, it works fine. I've just tested it for my particular need but
I hope it's going to be merged in the mainline if other people will find it useful:)
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-12 9:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 15:37 [PATCH] staging: rtl8723bs: align comments Fabio Aiuto
2021-03-10 15:51 ` Greg KH
2021-03-10 21:58 ` Fabio Aiuto
2021-03-10 22:13 ` Fabio Aiuto
2021-03-10 22:27 ` Eric Curtin
2021-03-10 22:45 ` Fabio Aiuto
2021-03-12 9:15 ` Fabio Aiuto
[not found] ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
2021-03-11 13:31 ` Fabio Aiuto
2021-03-10 17:48 ` Dan Carpenter
2021-03-11 9:15 ` Joe Perches
2021-03-11 16:38 ` Fabio Aiuto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).