* [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
@ 2021-04-21 14:36 zhuguangqing83
2021-04-21 16:04 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: zhuguangqing83 @ 2021-04-21 14:36 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Tony Lindgren, linux-pm, linux-kernel, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
Empty list or fully traversed list points to list head, which is not
NULL (and before the first element containing real data).
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
v2:
- Modify commit message and code as suggested by Sebastian.
---
drivers/power/supply/cpcap-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d..a3fc0084cda0 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
break;
}
- if (!d)
+ if (list_entry_is_head(d, &ddata->irq_list, node))
return IRQ_NONE;
latest = cpcap_battery_latest(ddata);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
2021-04-21 14:36 [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor zhuguangqing83
@ 2021-04-21 16:04 ` Tony Lindgren
2021-04-21 17:19 ` Carl Philipp Klemm
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2021-04-21 16:04 UTC (permalink / raw)
To: zhuguangqing83
Cc: Sebastian Reichel, linux-pm, linux-kernel, Carl Philipp Klemm
Hi,
* zhuguangqing83@gmail.com <zhuguangqing83@gmail.com> [210421 14:38]:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
> Empty list or fully traversed list points to list head, which is not
> NULL (and before the first element containing real data).
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> ---
> v2:
> - Modify commit message and code as suggested by Sebastian.
Thanks looks OK to me. Looks like there's no flag we need to set there when
the entry is found, so this should do for the check.
Hmm I wonder if this just might fix the issue where booting with a USB
charger connected can hang..
Reviewed-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/power/supply/cpcap-battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> index 6d5bcdb9f45d..a3fc0084cda0 100644
> --- a/drivers/power/supply/cpcap-battery.c
> +++ b/drivers/power/supply/cpcap-battery.c
> @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
> break;
> }
>
> - if (!d)
> + if (list_entry_is_head(d, &ddata->irq_list, node))
> return IRQ_NONE;
>
> latest = cpcap_battery_latest(ddata);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
2021-04-21 16:04 ` Tony Lindgren
@ 2021-04-21 17:19 ` Carl Philipp Klemm
2021-04-21 21:09 ` Sebastian Reichel
0 siblings, 1 reply; 4+ messages in thread
From: Carl Philipp Klemm @ 2021-04-21 17:19 UTC (permalink / raw)
To: Tony Lindgren; +Cc: zhuguangqing83, Sebastian Reichel, linux-pm, linux-kernel
Looks good to me, but dosent appear to solve the bootup bug.
(this time reply all)
Reviewed-by: Carl Philipp Klemm <philipp@uvos.xyz>
Tested-by: Carl Philipp Klemm <philipp@uvos.xyz>
--
Carl Philipp Klemm <philipp@uvos.xyz> <carl@uvos.xyz>
On Wed, 21 Apr 2021 19:04:30 +0300
Tony Lindgren <tony@atomide.com> wrote:
> Hi,
>
> * zhuguangqing83@gmail.com <zhuguangqing83@gmail.com> [210421 14:38]:
> > From: Guangqing Zhu <zhuguangqing83@gmail.com>
> >
> > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
> > Empty list or fully traversed list points to list head, which is not
> > NULL (and before the first element containing real data).
> >
> > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> > ---
> > v2:
> > - Modify commit message and code as suggested by Sebastian.
>
> Thanks looks OK to me. Looks like there's no flag we need to set there when
> the entry is found, so this should do for the check.
>
> Hmm I wonder if this just might fix the issue where booting with a USB
> charger connected can hang..
>
> Reviewed-by: Tony Lindgren <tony@atomide.com>
>
> > ---
> > drivers/power/supply/cpcap-battery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> > index 6d5bcdb9f45d..a3fc0084cda0 100644
> > --- a/drivers/power/supply/cpcap-battery.c
> > +++ b/drivers/power/supply/cpcap-battery.c
> > @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
> > break;
> > }
> >
> > - if (!d)
> > + if (list_entry_is_head(d, &ddata->irq_list, node))
> > return IRQ_NONE;
> >
> > latest = cpcap_battery_latest(ddata);
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor
2021-04-21 17:19 ` Carl Philipp Klemm
@ 2021-04-21 21:09 ` Sebastian Reichel
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2021-04-21 21:09 UTC (permalink / raw)
To: Carl Philipp Klemm; +Cc: Tony Lindgren, zhuguangqing83, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]
Hi,
On Wed, Apr 21, 2021 at 07:19:33PM +0200, Carl Philipp Klemm wrote:
> Tony Lindgren <tony@atomide.com> wrote:
> > * zhuguangqing83@gmail.com <zhuguangqing83@gmail.com> [210421 14:38]:
> > > From: Guangqing Zhu <zhuguangqing83@gmail.com>
> > >
> > > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
> > > Empty list or fully traversed list points to list head, which is not
> > > NULL (and before the first element containing real data).
> > >
> > > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> > > ---
> > > v2:
> > > - Modify commit message and code as suggested by Sebastian.
> >
> > Thanks looks OK to me. Looks like there's no flag we need to set there when
> > the entry is found, so this should do for the check.
> >
> > Hmm I wonder if this just might fix the issue where booting with a USB
> > charger connected can hang..
> >
> > Reviewed-by: Tony Lindgren <tony@atomide.com>
>
> Looks good to me, but dosent appear to solve the bootup bug.
>
> (this time reply all)
>
> Reviewed-by: Carl Philipp Klemm <philipp@uvos.xyz>
> Tested-by: Carl Philipp Klemm <philipp@uvos.xyz>
Thanks, queued.
-- Sebastian
> > > drivers/power/supply/cpcap-battery.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> > > index 6d5bcdb9f45d..a3fc0084cda0 100644
> > > --- a/drivers/power/supply/cpcap-battery.c
> > > +++ b/drivers/power/supply/cpcap-battery.c
> > > @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
> > > break;
> > > }
> > >
> > > - if (!d)
> > > + if (list_entry_is_head(d, &ddata->irq_list, node))
> > > return IRQ_NONE;
> > >
> > > latest = cpcap_battery_latest(ddata);
> > > --
> > > 2.17.1
> > >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-21 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 14:36 [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor zhuguangqing83
2021-04-21 16:04 ` Tony Lindgren
2021-04-21 17:19 ` Carl Philipp Klemm
2021-04-21 21:09 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).