* [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic
@ 2022-06-10 20:17 Wolfram Sang
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-06-10 20:17 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
When handling the V3U/r8a779a0 exception, avoid using 'not:' because
then its subschemas are far away in the 'else:' branch. Keep them
together using positive logic.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Changes since v2:
* new patch
Tested with:
make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
.../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
index 1368d90da0e8..72dc7eb27f8d 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
@@ -57,31 +57,30 @@ required:
- "#thermal-sensor-cells"
if:
- not:
- properties:
- compatible:
- contains:
- enum:
- - renesas,r8a779a0-thermal
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,r8a779a0-thermal
then:
properties:
reg:
- minItems: 2
items:
+ - description: TSC0 registers
- description: TSC1 registers
- description: TSC2 registers
- description: TSC3 registers
- required:
- - interrupts
+ - description: TSC4 registers
else:
properties:
reg:
+ minItems: 2
items:
- - description: TSC0 registers
- description: TSC1 registers
- description: TSC2 registers
- description: TSC3 registers
- - description: TSC4 registers
+ required:
+ - interrupts
additionalProperties: false
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
@ 2022-06-10 20:17 ` Wolfram Sang
2022-06-12 22:18 ` Niklas Söderlund
` (2 more replies)
2022-06-12 22:16 ` [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Niklas Söderlund
` (2 subsequent siblings)
3 siblings, 3 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-06-10 20:17 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
Add support for R-Car S4. The S4 IP differs a bit from its siblings in
such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
are not routed to the INTC-AP but to the ECM.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Change since V2:
* make interrupts not required for this SoC
Tested with:
make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
.../bindings/thermal/rcar-gen3-thermal.yaml | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
index 72dc7eb27f8d..0f05f5c886c5 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
@@ -8,9 +8,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: Renesas R-Car Gen3 Thermal Sensor
description:
- On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal
- sensors (THS) which are the analog circuits for measuring temperature (Tj)
- inside the LSI.
+ On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC)
+ control the thermal sensors (THS) which are the analog circuits for
+ measuring temperature (Tj) inside the LSI.
maintainers:
- Niklas Söderlund <niklas.soderlund@ragnatech.se>
@@ -27,6 +27,7 @@ properties:
- renesas,r8a77965-thermal # R-Car M3-N
- renesas,r8a77980-thermal # R-Car V3H
- renesas,r8a779a0-thermal # R-Car V3U
+ - renesas,r8a779f0-thermal # R-Car S4-8
reg: true
@@ -79,8 +80,16 @@ else:
- description: TSC1 registers
- description: TSC2 registers
- description: TSC3 registers
- required:
- - interrupts
+ if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,r8a779f0-thermal
+ then:
+ required:
+ - interrupts
additionalProperties: false
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
@ 2022-06-12 22:16 ` Niklas Söderlund
2022-06-14 13:46 ` Geert Uytterhoeven
2022-06-14 19:08 ` Daniel Lezcano
3 siblings, 0 replies; 12+ messages in thread
From: Niklas Söderlund @ 2022-06-12 22:16 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Rob Herring, Krzysztof Kozlowski,
linux-pm, devicetree, linux-kernel
Hi Wolfram,
Thanks for your patch.
On 2022-06-10 22:17:00 +0200, Wolfram Sang wrote:
> When handling the V3U/r8a779a0 exception, avoid using 'not:' because
> then its subschemas are far away in the 'else:' branch. Keep them
> together using positive logic.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> Changes since v2:
> * new patch
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 1368d90da0e8..72dc7eb27f8d 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -57,31 +57,30 @@ required:
> - "#thermal-sensor-cells"
>
> if:
> - not:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,r8a779a0-thermal
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779a0-thermal
> then:
> properties:
> reg:
> - minItems: 2
> items:
> + - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + - description: TSC4 registers
> else:
> properties:
> reg:
> + minItems: 2
> items:
> - - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - - description: TSC4 registers
> + required:
> + - interrupts
>
> additionalProperties: false
>
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
@ 2022-06-12 22:18 ` Niklas Söderlund
2022-06-14 13:54 ` Geert Uytterhoeven
2022-06-14 20:07 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Niklas Söderlund @ 2022-06-12 22:18 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Rob Herring, Krzysztof Kozlowski,
linux-pm, devicetree, linux-kernel
Hi Wolfram,
Thanks for your work.
On 2022-06-10 22:17:01 +0200, Wolfram Sang wrote:
> Add support for R-Car S4. The S4 IP differs a bit from its siblings in
> such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
> are not routed to the INTC-AP but to the ECM.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> Change since V2:
> * make interrupts not required for this SoC
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 72dc7eb27f8d..0f05f5c886c5 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -8,9 +8,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Renesas R-Car Gen3 Thermal Sensor
>
> description:
> - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal
> - sensors (THS) which are the analog circuits for measuring temperature (Tj)
> - inside the LSI.
> + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC)
> + control the thermal sensors (THS) which are the analog circuits for
> + measuring temperature (Tj) inside the LSI.
>
> maintainers:
> - Niklas Söderlund <niklas.soderlund@ragnatech.se>
> @@ -27,6 +27,7 @@ properties:
> - renesas,r8a77965-thermal # R-Car M3-N
> - renesas,r8a77980-thermal # R-Car V3H
> - renesas,r8a779a0-thermal # R-Car V3U
> + - renesas,r8a779f0-thermal # R-Car S4-8
>
> reg: true
>
> @@ -79,8 +80,16 @@ else:
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779f0-thermal
> + then:
> + required:
> + - interrupts
>
> additionalProperties: false
>
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
2022-06-12 22:16 ` [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Niklas Söderlund
@ 2022-06-14 13:46 ` Geert Uytterhoeven
2022-06-14 19:08 ` Daniel Lezcano
3 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-06-14 13:46 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Fri, Jun 10, 2022 at 10:18 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> When handling the V3U/r8a779a0 exception, avoid using 'not:' because
> then its subschemas are far away in the 'else:' branch. Keep them
> together using positive logic.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since v2:
> * new patch
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
And dt_binding_check? Yep, it succeeds ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
2022-06-12 22:18 ` Niklas Söderlund
@ 2022-06-14 13:54 ` Geert Uytterhoeven
2022-06-14 19:12 ` Wolfram Sang
2022-06-14 20:18 ` Wolfram Sang
2022-06-14 20:07 ` Rob Herring
2 siblings, 2 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-06-14 13:54 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Wolfram,
On Fri, Jun 10, 2022 at 10:17 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Add support for R-Car S4. The S4 IP differs a bit from its siblings in
> such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
> are not routed to the INTC-AP but to the ECM.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since V2:
> * make interrupts not required for this SoC
Thanks for the update!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -79,8 +80,16 @@ else:
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779f0-thermal
> + then:
> + required:
> + - interrupts
While correct, IMHO adding this check here loses again the improvement
made by "[PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use
positive logic".
What about splitting this in two separate checks at the top level:
- one for regs (R-Car V3U vs. the world), and
- a second for interrupts (R-Car V3U+S4-8 vs. the world)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
` (2 preceding siblings ...)
2022-06-14 13:46 ` Geert Uytterhoeven
@ 2022-06-14 19:08 ` Daniel Lezcano
3 siblings, 0 replies; 12+ messages in thread
From: Daniel Lezcano @ 2022-06-14 19:08 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc
Cc: Niklas Söderlund, Rafael J. Wysocki, Amit Kucheria,
Zhang Rui, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
On 10/06/2022 22:17, Wolfram Sang wrote:
> When handling the V3U/r8a779a0 exception, avoid using 'not:' because
> then its subschemas are far away in the 'else:' branch. Keep them
> together using positive logic.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since v2:
> * new patch
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 1368d90da0e8..72dc7eb27f8d 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -57,31 +57,30 @@ required:
> - "#thermal-sensor-cells"
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-14 13:54 ` Geert Uytterhoeven
@ 2022-06-14 19:12 ` Wolfram Sang
2022-06-14 20:18 ` Wolfram Sang
1 sibling, 0 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-06-14 19:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
> What about splitting this in two separate checks at the top level:
> - one for regs (R-Car V3U vs. the world), and
> - a second for interrupts (R-Car V3U+S4-8 vs. the world)?
I'll try this and see how it looks, thanks for the suggestion!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
2022-06-12 22:18 ` Niklas Söderlund
2022-06-14 13:54 ` Geert Uytterhoeven
@ 2022-06-14 20:07 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-06-14 20:07 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Rob Herring, Rafael J. Wysocki, devicetree,
Zhang Rui, Krzysztof Kozlowski, linux-pm, Daniel Lezcano,
Amit Kucheria, linux-renesas-soc, Niklas Söderlund
On Fri, 10 Jun 2022 22:17:01 +0200, Wolfram Sang wrote:
> Add support for R-Car S4. The S4 IP differs a bit from its siblings in
> such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
> are not routed to the INTC-AP but to the ECM.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since V2:
> * make interrupts not required for this SoC
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-14 13:54 ` Geert Uytterhoeven
2022-06-14 19:12 ` Wolfram Sang
@ 2022-06-14 20:18 ` Wolfram Sang
2022-06-14 21:31 ` Geert Uytterhoeven
1 sibling, 1 reply; 12+ messages in thread
From: Wolfram Sang @ 2022-06-14 20:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
> What about splitting this in two separate checks at the top level:
> - one for regs (R-Car V3U vs. the world), and
> - a second for interrupts (R-Car V3U+S4-8 vs. the world)?
This task seems too much for my YAML-foo :( I couldn't get it to work.
Can we leave it as-is for now?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-14 20:18 ` Wolfram Sang
@ 2022-06-14 21:31 ` Geert Uytterhoeven
2022-06-15 10:09 ` Wolfram Sang
0 siblings, 1 reply; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-06-14 21:31 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Wolfram,
On Tue, Jun 14, 2022 at 10:18 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > What about splitting this in two separate checks at the top level:
> > - one for regs (R-Car V3U vs. the world), and
> > - a second for interrupts (R-Car V3U+S4-8 vs. the world)?
>
> This task seems too much for my YAML-foo :( I couldn't get it to work.
> Can we leave it as-is for now?
You just need an allOf with two if statements, cfr. e.g.
Documentation/devicetree/bindings/media/renesas,vin.yaml?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support
2022-06-14 21:31 ` Geert Uytterhoeven
@ 2022-06-15 10:09 ` Wolfram Sang
0 siblings, 0 replies; 12+ messages in thread
From: Wolfram Sang @ 2022-06-15 10:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Rob Herring,
Krzysztof Kozlowski, Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
> > > What about splitting this in two separate checks at the top level:
> > > - one for regs (R-Car V3U vs. the world), and
> > > - a second for interrupts (R-Car V3U+S4-8 vs. the world)?
> >
> > This task seems too much for my YAML-foo :( I couldn't get it to work.
> > Can we leave it as-is for now?
>
> You just need an allOf with two if statements, cfr. e.g.
> Documentation/devicetree/bindings/media/renesas,vin.yaml?
First, I don't think the negative logic is as bad here because there is
no 'else' block which is far away. Second, I think we need a 'not'
anyhow because the condition is:
'if not r8a779f0 then required interrupts'
Third, I still think we can fix it incrementally later if we want. The
new board has enough issues to take care of. For now, I'd rather
investigate those than YAML ;)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-06-15 10:09 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 20:17 [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Wolfram Sang
2022-06-10 20:17 ` [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support Wolfram Sang
2022-06-12 22:18 ` Niklas Söderlund
2022-06-14 13:54 ` Geert Uytterhoeven
2022-06-14 19:12 ` Wolfram Sang
2022-06-14 20:18 ` Wolfram Sang
2022-06-14 21:31 ` Geert Uytterhoeven
2022-06-15 10:09 ` Wolfram Sang
2022-06-14 20:07 ` Rob Herring
2022-06-12 22:16 ` [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic Niklas Söderlund
2022-06-14 13:46 ` Geert Uytterhoeven
2022-06-14 19:08 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).