* [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
@ 2022-07-12 16:33 ` Francesco Dolcini
2022-08-08 15:17 ` Lee Jones
2022-07-12 16:33 ` [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
` (4 subsequent siblings)
5 siblings, 1 reply; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-12 16:33 UTC (permalink / raw)
To: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski
Cc: Francesco Dolcini, linux-stm32, linux-arm-kernel, linux-kernel,
devicetree
Remove rotator block from probe, it is not used in any device tree file,
there is no related cell defined, it's just dead non-working code with no
of_compatible for it.
This is a preliminary change to allow probing by of_compatible and not
by a fixed name.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
v2:
- new patch
---
drivers/mfd/stmpe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index aeb9ea55f97d..4aa4ac2ff406 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1372,8 +1372,6 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->blocks |= STMPE_BLOCK_ADC;
} else if (of_node_name_eq(child, "stmpe_pwm")) {
pdata->blocks |= STMPE_BLOCK_PWM;
- } else if (of_node_name_eq(child, "stmpe_rotator")) {
- pdata->blocks |= STMPE_BLOCK_ROTATOR;
}
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe
2022-07-12 16:33 ` [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe Francesco Dolcini
@ 2022-08-08 15:17 ` Lee Jones
0 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2022-08-08 15:17 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-stm32, linux-arm-kernel, linux-kernel,
devicetree, Lee Jones
On Tue, 12 Jul 2022, Francesco Dolcini wrote:
> Remove rotator block from probe, it is not used in any device tree file,
> there is no related cell defined, it's just dead non-working code with no
> of_compatible for it.
>
> This is a preliminary change to allow probing by of_compatible and not
> by a fixed name.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> v2:
> - new patch
> ---
> drivers/mfd/stmpe.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
2022-07-12 16:33 ` [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe Francesco Dolcini
@ 2022-07-12 16:33 ` Francesco Dolcini
2022-07-18 9:20 ` Linus Walleij
2022-08-08 15:18 ` Lee Jones
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
` (3 subsequent siblings)
5 siblings, 2 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-12 16:33 UTC (permalink / raw)
To: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski
Cc: Francesco Dolcini, linux-stm32, linux-arm-kernel, linux-kernel,
devicetree, Ahmad Fatoum
Use sub-function of_compatible during probe, instead of using the node
name. The code should not rely on the node names during probe, in
addition to that the previously hard-coded node names are not compliant
to the latest naming convention (they are not generic and they use
underscores), and it was broken by mistake already once [1].
[1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
v2:
- remove define usage for compatible strings
- moved rotator removal from probe to a separate patch
---
drivers/mfd/stmpe.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 4aa4ac2ff406..987e251d90ae 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -1362,17 +1362,16 @@ static void stmpe_of_probe(struct stmpe_platform_data *pdata,
pdata->autosleep = (pdata->autosleep_timeout) ? true : false;
for_each_available_child_of_node(np, child) {
- if (of_node_name_eq(child, "stmpe_gpio")) {
+ if (of_device_is_compatible(child, stmpe_gpio_cell.of_compatible))
pdata->blocks |= STMPE_BLOCK_GPIO;
- } else if (of_node_name_eq(child, "stmpe_keypad")) {
+ else if (of_device_is_compatible(child, stmpe_keypad_cell.of_compatible))
pdata->blocks |= STMPE_BLOCK_KEYPAD;
- } else if (of_node_name_eq(child, "stmpe_touchscreen")) {
+ else if (of_device_is_compatible(child, stmpe_ts_cell.of_compatible))
pdata->blocks |= STMPE_BLOCK_TOUCHSCREEN;
- } else if (of_node_name_eq(child, "stmpe_adc")) {
+ else if (of_device_is_compatible(child, stmpe_adc_cell.of_compatible))
pdata->blocks |= STMPE_BLOCK_ADC;
- } else if (of_node_name_eq(child, "stmpe_pwm")) {
+ else if (of_device_is_compatible(child, stmpe_pwm_cell.of_compatible))
pdata->blocks |= STMPE_BLOCK_PWM;
- }
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible
2022-07-12 16:33 ` [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
@ 2022-07-18 9:20 ` Linus Walleij
2022-08-08 15:18 ` Lee Jones
1 sibling, 0 replies; 25+ messages in thread
From: Linus Walleij @ 2022-07-18 9:20 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-stm32, linux-arm-kernel, linux-kernel,
devicetree, Ahmad Fatoum
On Tue, Jul 12, 2022 at 6:36 PM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
> Use sub-function of_compatible during probe, instead of using the node
> name. The code should not rely on the node names during probe, in
> addition to that the previously hard-coded node names are not compliant
> to the latest naming convention (they are not generic and they use
> underscores), and it was broken by mistake already once [1].
>
> [1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
>
> Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> v2:
> - remove define usage for compatible strings
> - moved rotator removal from probe to a separate patch
v2 LGTM
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible
2022-07-12 16:33 ` [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
2022-07-18 9:20 ` Linus Walleij
@ 2022-08-08 15:18 ` Lee Jones
1 sibling, 0 replies; 25+ messages in thread
From: Lee Jones @ 2022-08-08 15:18 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-stm32, linux-arm-kernel, linux-kernel,
devicetree, Ahmad Fatoum, Lee Jones
On Tue, 12 Jul 2022, Francesco Dolcini wrote:
> Use sub-function of_compatible during probe, instead of using the node
> name. The code should not rely on the node names during probe, in
> addition to that the previously hard-coded node names are not compliant
> to the latest naming convention (they are not generic and they use
> underscores), and it was broken by mistake already once [1].
>
> [1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
>
> Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> v2:
> - remove define usage for compatible strings
> - moved rotator removal from probe to a separate patch
> ---
> drivers/mfd/stmpe.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Applied, thanks.
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
2022-07-12 16:33 ` [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe Francesco Dolcini
2022-07-12 16:33 ` [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
@ 2022-07-12 16:33 ` Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
` (3 more replies)
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
` (2 subsequent siblings)
5 siblings, 4 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-12 16:33 UTC (permalink / raw)
To: Lee Jones, Linus Walleij, Bartosz Golaszewski, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski
Cc: Francesco Dolcini, linux-iio, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel, linux-gpio, devicetree
STMPE driver does not require a specific node name anymore, only the
compatible is checked, update binding according to this.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Documentation/devicetree/bindings/gpio/gpio-stmpe.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
index a0e4cf885213..b33f8f02c0d7 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
@@ -8,8 +8,7 @@ Optional properties:
- st,norequest-mask: bitmask specifying which GPIOs should _not_ be requestable
due to different usage (e.g. touch, keypad)
-Node name must be stmpe_gpio and should be child node of stmpe node to which it
-belongs.
+Node should be child node of stmpe node to which it belongs.
Example:
stmpe_gpio {
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
@ 2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 7:43 ` Bartosz Golaszewski
` (2 subsequent siblings)
3 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-12 21:23 UTC (permalink / raw)
To: Francesco Dolcini, Lee Jones, Linus Walleij, Bartosz Golaszewski,
Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski
Cc: linux-iio, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree
On 12/07/2022 18:33, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
@ 2022-07-13 7:43 ` Bartosz Golaszewski
2022-07-18 10:43 ` Francesco Dolcini
2022-08-09 13:48 ` Francesco Dolcini
3 siblings, 0 replies; 25+ messages in thread
From: Bartosz Golaszewski @ 2022-07-13 7:43 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Linus Walleij, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski, linux-iio, Linux Input,
linux-stm32, Linux ARM, Linux Kernel Mailing List,
open list:GPIO SUBSYSTEM, devicetree
On Tue, Jul 12, 2022 at 6:33 PM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
>
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-stmpe.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> index a0e4cf885213..b33f8f02c0d7 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> @@ -8,8 +8,7 @@ Optional properties:
> - st,norequest-mask: bitmask specifying which GPIOs should _not_ be requestable
> due to different usage (e.g. touch, keypad)
>
> -Node name must be stmpe_gpio and should be child node of stmpe node to which it
> -belongs.
> +Node should be child node of stmpe node to which it belongs.
>
> Example:
> stmpe_gpio {
> --
> 2.25.1
>
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 7:43 ` Bartosz Golaszewski
@ 2022-07-18 10:43 ` Francesco Dolcini
2022-08-09 13:48 ` Francesco Dolcini
3 siblings, 0 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-18 10:43 UTC (permalink / raw)
To: Lee Jones, Linus Walleij
Cc: Francesco Dolcini, Bartosz Golaszewski, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski, linux-iio,
linux-input, linux-stm32, linux-arm-kernel, linux-kernel,
linux-gpio, devicetree
On Tue, Jul 12, 2022 at 06:33:43PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
from v1 https://lore.kernel.org/all/CACRpkdZDRjadHc4TBHouWPSYhLoCAynXzKejKi+H98C5ioCW6A@mail.gmail.com/
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
` (2 preceding siblings ...)
2022-07-18 10:43 ` Francesco Dolcini
@ 2022-08-09 13:48 ` Francesco Dolcini
2022-08-31 19:57 ` Bartosz Golaszewski
3 siblings, 1 reply; 25+ messages in thread
From: Francesco Dolcini @ 2022-08-09 13:48 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Lee Jones, Linus Walleij, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski, linux-iio, linux-input,
linux-stm32, linux-arm-kernel, linux-kernel, linux-gpio,
devicetree, Francesco Dolcini
Hello Bartosz, can you pick this? Patches 1 and 2 were applied to MFD
tree.
On Tue, Jul 12, 2022 at 06:33:43PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-stmpe.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> index a0e4cf885213..b33f8f02c0d7 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> @@ -8,8 +8,7 @@ Optional properties:
> - st,norequest-mask: bitmask specifying which GPIOs should _not_ be requestable
> due to different usage (e.g. touch, keypad)
>
> -Node name must be stmpe_gpio and should be child node of stmpe node to which it
> -belongs.
> +Node should be child node of stmpe node to which it belongs.
>
> Example:
> stmpe_gpio {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement
2022-08-09 13:48 ` Francesco Dolcini
@ 2022-08-31 19:57 ` Bartosz Golaszewski
0 siblings, 0 replies; 25+ messages in thread
From: Bartosz Golaszewski @ 2022-08-31 19:57 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Linus Walleij, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski, linux-iio, Linux Input,
linux-stm32, Linux ARM, Linux Kernel Mailing List,
open list:GPIO SUBSYSTEM, devicetree
On Tue, Aug 9, 2022 at 3:48 PM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
>
> Hello Bartosz, can you pick this? Patches 1 and 2 were applied to MFD
> tree.
>
> On Tue, Jul 12, 2022 at 06:33:43PM +0200, Francesco Dolcini wrote:
> > STMPE driver does not require a specific node name anymore, only the
> > compatible is checked, update binding according to this.
> >
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> > Documentation/devicetree/bindings/gpio/gpio-stmpe.txt | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> > index a0e4cf885213..b33f8f02c0d7 100644
> > --- a/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> > @@ -8,8 +8,7 @@ Optional properties:
> > - st,norequest-mask: bitmask specifying which GPIOs should _not_ be requestable
> > due to different usage (e.g. touch, keypad)
> >
> > -Node name must be stmpe_gpio and should be child node of stmpe node to which it
> > -belongs.
> > +Node should be child node of stmpe node to which it belongs.
> >
> > Example:
> > stmpe_gpio {
> > --
> > 2.25.1
> >
>
Sorry, I was off most of August and missed this one. Now applied.
Bart
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
` (2 preceding siblings ...)
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
@ 2022-07-12 16:33 ` Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
` (2 more replies)
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
2022-08-09 7:54 ` [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
5 siblings, 3 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-12 16:33 UTC (permalink / raw)
To: Lee Jones, Jonathan Cameron, Lars-Peter Clausen, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski
Cc: Francesco Dolcini, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree, linux-iio
STMPE driver does not require a specific node name anymore, only the
compatible is checked, update binding according to this.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
index 9049c699152f..333744a2159c 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
@@ -13,8 +13,7 @@ description:
This ADC forms part of an ST microelectronics STMPE multifunction device .
The ADC is shared with the STMPE touchscreen. As a result some ADC related
settings are specified in the parent node.
- The node name myst be stmpe_adc and should be a child node of the stmpe node
- to which it belongs.
+ The node should be a child node of the stmpe node to which it belongs.
properties:
compatible:
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
@ 2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 16:24 ` Jonathan Cameron
2022-08-09 13:46 ` Francesco Dolcini
2 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-12 21:23 UTC (permalink / raw)
To: Francesco Dolcini, Lee Jones, Jonathan Cameron,
Lars-Peter Clausen, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski
Cc: linux-input, linux-stm32, linux-arm-kernel, linux-kernel,
linux-gpio, devicetree, linux-iio
On 12/07/2022 18:33, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
@ 2022-07-13 16:24 ` Jonathan Cameron
2022-08-09 13:46 ` Francesco Dolcini
2 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2022-07-13 16:24 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Lars-Peter Clausen, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel, linux-gpio, devicetree,
linux-iio
On Tue, 12 Jul 2022 18:33:44 +0200
Francesco Dolcini <francesco.dolcini@toradex.com> wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
I'm assuming this will go through mfd (or at least some tree that isn't
IIO :) Shout if I should pick this up in the IIO tree.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> index 9049c699152f..333744a2159c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> @@ -13,8 +13,7 @@ description:
> This ADC forms part of an ST microelectronics STMPE multifunction device .
> The ADC is shared with the STMPE touchscreen. As a result some ADC related
> settings are specified in the parent node.
> - The node name myst be stmpe_adc and should be a child node of the stmpe node
> - to which it belongs.
> + The node should be a child node of the stmpe node to which it belongs.
>
> properties:
> compatible:
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 16:24 ` Jonathan Cameron
@ 2022-08-09 13:46 ` Francesco Dolcini
2022-08-09 15:37 ` Lee Jones
2 siblings, 1 reply; 25+ messages in thread
From: Francesco Dolcini @ 2022-08-09 13:46 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lee Jones, Lars-Peter Clausen, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel, linux-gpio, devicetree,
linux-iio, Francesco Dolcini
Hello Jonathan, can you pick this? Patches 1 and 2 were applied to MFD
tree.
Thanks
Francesco
On Tue, Jul 12, 2022 at 06:33:44PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> index 9049c699152f..333744a2159c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> @@ -13,8 +13,7 @@ description:
> This ADC forms part of an ST microelectronics STMPE multifunction device .
> The ADC is shared with the STMPE touchscreen. As a result some ADC related
> settings are specified in the parent node.
> - The node name myst be stmpe_adc and should be a child node of the stmpe node
> - to which it belongs.
> + The node should be a child node of the stmpe node to which it belongs.
>
> properties:
> compatible:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-08-09 13:46 ` Francesco Dolcini
@ 2022-08-09 15:37 ` Lee Jones
2022-08-13 15:05 ` Jonathan Cameron
0 siblings, 1 reply; 25+ messages in thread
From: Lee Jones @ 2022-08-09 15:37 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Jonathan Cameron, Lars-Peter Clausen, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski, linux-input,
linux-stm32, linux-arm-kernel, linux-kernel, linux-gpio,
devicetree, linux-iio, Lee Jones
On Tue, 09 Aug 2022, Francesco Dolcini wrote:
> Hello Jonathan, can you pick this? Patches 1 and 2 were applied to MFD
> tree.
Sending out nags whilst the merge-window is open is seldom helpful.
Also, please refrain from top-posting.
Thanks.
> On Tue, Jul 12, 2022 at 06:33:44PM +0200, Francesco Dolcini wrote:
> > STMPE driver does not require a specific node name anymore, only the
> > compatible is checked, update binding according to this.
> >
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > index 9049c699152f..333744a2159c 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > @@ -13,8 +13,7 @@ description:
> > This ADC forms part of an ST microelectronics STMPE multifunction device .
> > The ADC is shared with the STMPE touchscreen. As a result some ADC related
> > settings are specified in the parent node.
> > - The node name myst be stmpe_adc and should be a child node of the stmpe node
> > - to which it belongs.
> > + The node should be a child node of the stmpe node to which it belongs.
> >
> > properties:
> > compatible:
>
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: iio: adc: stmpe: Remove node name requirement
2022-08-09 15:37 ` Lee Jones
@ 2022-08-13 15:05 ` Jonathan Cameron
0 siblings, 0 replies; 25+ messages in thread
From: Jonathan Cameron @ 2022-08-13 15:05 UTC (permalink / raw)
To: Lee Jones
Cc: Francesco Dolcini, Lars-Peter Clausen, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski, linux-input,
linux-stm32, linux-arm-kernel, linux-kernel, linux-gpio,
devicetree, linux-iio, Lee Jones
On Tue, 9 Aug 2022 16:37:27 +0100
Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 09 Aug 2022, Francesco Dolcini wrote:
>
> > Hello Jonathan, can you pick this? Patches 1 and 2 were applied to MFD
> > tree.
>
> Sending out nags whilst the merge-window is open is seldom helpful.
Agreed, next week would have been better. I happen to be queuing stuff
up ready for a rebase this cycle though so applied this one to what will
be the togreg branch of iio.git after rc1 is available and I've rebased.
Jonathan
>
> Also, please refrain from top-posting.
>
> Thanks.
>
> > On Tue, Jul 12, 2022 at 06:33:44PM +0200, Francesco Dolcini wrote:
> > > STMPE driver does not require a specific node name anymore, only the
> > > compatible is checked, update binding according to this.
> > >
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > ---
> > > Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > > index 9049c699152f..333744a2159c 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/st,stmpe-adc.yaml
> > > @@ -13,8 +13,7 @@ description:
> > > This ADC forms part of an ST microelectronics STMPE multifunction device .
> > > The ADC is shared with the STMPE touchscreen. As a result some ADC related
> > > settings are specified in the parent node.
> > > - The node name myst be stmpe_adc and should be a child node of the stmpe node
> > > - to which it belongs.
> > > + The node should be a child node of the stmpe node to which it belongs.
> > >
> > > properties:
> > > compatible:
> >
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 5/5] dt-bindings: input: touchscreen: stmpe: Remove node name requirement
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
` (3 preceding siblings ...)
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
@ 2022-07-12 16:33 ` Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
` (3 more replies)
2022-08-09 7:54 ` [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
5 siblings, 4 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-07-12 16:33 UTC (permalink / raw)
To: Lee Jones, Dmitry Torokhov, Maxime Coquelin, Alexandre Torgue,
Rob Herring, Krzysztof Kozlowski
Cc: Francesco Dolcini, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree, linux-iio
STMPE driver does not require a specific node name anymore, only the
compatible is checked, update binding according to this.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Documentation/devicetree/bindings/input/touchscreen/stmpe.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
index c549924603d2..238b51555c04 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
@@ -54,8 +54,7 @@ Optional properties common with MFD (deprecated):
1 -> 3.25 MHz
2 || 3 -> 6.5 MHz
-Node name must be stmpe_touchscreen and should be child node of stmpe node to
-which it belongs.
+Node should be child node of stmpe node to which it belongs.
Note that common ADC settings of stmpe_touchscreen (child) will take precedence
over the settings done in MFD.
--
2.25.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 5/5] dt-bindings: input: touchscreen: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
@ 2022-07-12 21:23 ` Krzysztof Kozlowski
2022-08-09 13:50 ` Francesco Dolcini
` (2 subsequent siblings)
3 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-12 21:23 UTC (permalink / raw)
To: Francesco Dolcini, Lee Jones, Dmitry Torokhov, Maxime Coquelin,
Alexandre Torgue, Rob Herring, Krzysztof Kozlowski
Cc: linux-input, linux-stm32, linux-arm-kernel, linux-kernel,
linux-gpio, devicetree, linux-iio
On 12/07/2022 18:33, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/input/touchscreen/stmpe.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 5/5] dt-bindings: input: touchscreen: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
@ 2022-08-09 13:50 ` Francesco Dolcini
2022-09-05 7:22 ` Francesco Dolcini
2022-09-06 3:15 ` Dmitry Torokhov
3 siblings, 0 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-08-09 13:50 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree, linux-iio,
Francesco Dolcini
Hello Dmitry, can you pick this? Patches 1 and 2 were applied to MFD
tree.
Thanks,
Francesco
On Tue, Jul 12, 2022 at 06:33:45PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Documentation/devicetree/bindings/input/touchscreen/stmpe.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> index c549924603d2..238b51555c04 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/stmpe.txt
> @@ -54,8 +54,7 @@ Optional properties common with MFD (deprecated):
> 1 -> 3.25 MHz
> 2 || 3 -> 6.5 MHz
>
> -Node name must be stmpe_touchscreen and should be child node of stmpe node to
> -which it belongs.
> +Node should be child node of stmpe node to which it belongs.
>
> Note that common ADC settings of stmpe_touchscreen (child) will take precedence
> over the settings done in MFD.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 5/5] dt-bindings: input: touchscreen: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-08-09 13:50 ` Francesco Dolcini
@ 2022-09-05 7:22 ` Francesco Dolcini
2022-09-06 3:15 ` Dmitry Torokhov
3 siblings, 0 replies; 25+ messages in thread
From: Francesco Dolcini @ 2022-09-05 7:22 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree, linux-iio,
Francesco Dolcini
Hello Dmitry,
On Tue, Jul 12, 2022 at 06:33:45PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Just a gently ping, this is the last patch of this series not merged, all
the rest was merged through the respective subsystems. Can you merge it?
Thanks,
Francesco
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 5/5] dt-bindings: input: touchscreen: stmpe: Remove node name requirement
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
` (2 preceding siblings ...)
2022-09-05 7:22 ` Francesco Dolcini
@ 2022-09-06 3:15 ` Dmitry Torokhov
3 siblings, 0 replies; 25+ messages in thread
From: Dmitry Torokhov @ 2022-09-06 3:15 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Lee Jones, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, linux-input, linux-stm32, linux-arm-kernel,
linux-kernel, linux-gpio, devicetree, linux-iio
On Tue, Jul 12, 2022 at 06:33:45PM +0200, Francesco Dolcini wrote:
> STMPE driver does not require a specific node name anymore, only the
> compatible is checked, update binding according to this.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible
2022-07-12 16:33 [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
` (4 preceding siblings ...)
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
@ 2022-08-09 7:54 ` Francesco Dolcini
2022-08-09 13:38 ` Lee Jones
5 siblings, 1 reply; 25+ messages in thread
From: Francesco Dolcini @ 2022-08-09 7:54 UTC (permalink / raw)
To: Lee Jones, Dmitry Torokhov
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Linus Walleij, Bartosz Golaszewski,
Jonathan Cameron, Lars-Peter Clausen, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel, linux-gpio, devicetree,
linux-iio, Francesco Dolcini
Hello Lee,
thanks for picking up patches 1 and 2. What about the others, should you
pick also those? 3 and 4 do have all the required acks, I'm not sure
about 5 however that has the ack only from Krzysztof.
Francesco
On Tue, Jul 12, 2022 at 06:33:40PM +0200, Francesco Dolcini wrote:
> Hi all,
> This series update the STMPE MFD driver to use of_compatible to probe for
> sub-functions instead of using hardcoded names. Matching by name does not seems
> in general a good idea, in this specific case it is even worst since the node
> name are not compliant to the current naming convention (they are not generic
> and they do include underscores), and because of that recently
> we had a regression introduced [1].
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible
2022-08-09 7:54 ` [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
@ 2022-08-09 13:38 ` Lee Jones
0 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2022-08-09 13:38 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Dmitry Torokhov, Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Linus Walleij, Bartosz Golaszewski,
Jonathan Cameron, Lars-Peter Clausen, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel, linux-gpio, devicetree,
linux-iio, Lee Jones
On Tue, 09 Aug 2022, Francesco Dolcini wrote:
> Hello Lee,
> thanks for picking up patches 1 and 2. What about the others, should you
> pick also those? 3 and 4 do have all the required acks, I'm not sure
> about 5 however that has the ack only from Krzysztof.
They need to go in via their own subsystems.
We only filter in patches from other areas if there are build deps.
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 25+ messages in thread