* Re: [PATCH] NVMe: Added another device ID with stripe quirk
[not found] <1499379151-32479-1-git-send-email-david.fugate@intel.com>
@ 2017-07-06 22:17 ` Christoph Hellwig
2017-07-06 22:39 ` Keith Busch
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2017-07-06 22:17 UTC (permalink / raw)
To: David Wayne Fugate
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme, linux-kernel
On Thu, Jul 06, 2017 at 04:12:31PM -0600, David Wayne Fugate wrote:
> Adds a fourth Intel controller which has the "stripe" quirk.
NVMe has stadardized a way to communicate this information through
the Namespace Optimal IO Boundary (NOIOB) field in the Identify
Namespace structure, and Keith and Amber at Intel helped to define
this, so please actually implement it in your controllers.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: Added another device ID with stripe quirk
2017-07-06 22:17 ` [PATCH] NVMe: Added another device ID with stripe quirk Christoph Hellwig
@ 2017-07-06 22:39 ` Keith Busch
2017-07-06 23:22 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Keith Busch @ 2017-07-06 22:39 UTC (permalink / raw)
To: Christoph Hellwig
Cc: David Wayne Fugate, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel
On Fri, Jul 07, 2017 at 12:17:54AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 06, 2017 at 04:12:31PM -0600, David Wayne Fugate wrote:
> > Adds a fourth Intel controller which has the "stripe" quirk.
>
> NVMe has stadardized a way to communicate this information through
> the Namespace Optimal IO Boundary (NOIOB) field in the Identify
> Namespace structure, and Keith and Amber at Intel helped to define
> this, so please actually implement it in your controllers.
That's true for all Intel controllers going forward, but this
is actually an older controller that pre-dates NOIOB. It's the exact
same as the 8086:0A54 model, but a particular vendor decided their
rebranded device needs to be made special with a different DID.
We all agree that's a terrible way to go about this for mutliple reasons,
but we can't go back in time to tell the decision makers of this folly. So
I think we need to let this last one go through with the quirk.
Acked-by: Keith Busch <keith.busch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: Added another device ID with stripe quirk
2017-07-06 22:39 ` Keith Busch
@ 2017-07-06 23:22 ` Christoph Hellwig
2017-07-10 5:52 ` Sagi Grimberg
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2017-07-06 23:22 UTC (permalink / raw)
To: Keith Busch
Cc: Christoph Hellwig, David Wayne Fugate, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
On Thu, Jul 06, 2017 at 06:39:56PM -0400, Keith Busch wrote:
> That's true for all Intel controllers going forward, but this
> is actually an older controller that pre-dates NOIOB. It's the exact
> same as the 8086:0A54 model, but a particular vendor decided their
> rebranded device needs to be made special with a different DID.
Meh..
>
> We all agree that's a terrible way to go about this for mutliple reasons,
> but we can't go back in time to tell the decision makers of this folly. So
> I think we need to let this last one go through with the quirk.
>
> Acked-by: Keith Busch <keith.busch@intel.com>
Reluctantly-accepted-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: Added another device ID with stripe quirk
2017-07-06 23:22 ` Christoph Hellwig
@ 2017-07-10 5:52 ` Sagi Grimberg
0 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2017-07-10 5:52 UTC (permalink / raw)
To: Christoph Hellwig, Keith Busch
Cc: David Wayne Fugate, Jens Axboe, linux-nvme, linux-kernel
>> That's true for all Intel controllers going forward, but this
>> is actually an older controller that pre-dates NOIOB. It's the exact
>> same as the 8086:0A54 model, but a particular vendor decided their
>> rebranded device needs to be made special with a different DID.
>
> Meh..
>
>>
>> We all agree that's a terrible way to go about this for mutliple reasons,
>> but we can't go back in time to tell the decision makers of this folly. So
>> I think we need to let this last one go through with the quirk.
>>
>> Acked-by: Keith Busch <keith.busch@intel.com>
>
> Reluctantly-accepted-by: Christoph Hellwig <hch@lst.de>
>
David, can you resend the patch? For some reason I
can't locate it in my mailbox...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-10 5:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1499379151-32479-1-git-send-email-david.fugate@intel.com>
2017-07-06 22:17 ` [PATCH] NVMe: Added another device ID with stripe quirk Christoph Hellwig
2017-07-06 22:39 ` Keith Busch
2017-07-06 23:22 ` Christoph Hellwig
2017-07-10 5:52 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).