* [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array()
@ 2022-05-09 14:04 Yang Yingliang
2022-05-10 1:19 ` Yang Yingliang
2022-05-16 14:43 ` Robert Foss
0 siblings, 2 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-05-09 14:04 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, linux-media
Cc: mchehab, hverkuil-cisco, robert.foss, bryan.odonoghue,
vladimir.zapolskiy
'supplies' is a pointer, the real size of struct regulator_bulk_data
should be pass to devm_kmalloc_array().
Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/qcom/camss/camss-csid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index f993f349b66b..80628801cf09 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
if (csid->num_supplies) {
csid->supplies = devm_kmalloc_array(camss->dev,
csid->num_supplies,
- sizeof(csid->supplies),
+ sizeof(*csid->supplies),
GFP_KERNEL);
if (!csid->supplies)
return -ENOMEM;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array()
2022-05-09 14:04 [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array() Yang Yingliang
@ 2022-05-10 1:19 ` Yang Yingliang
2022-05-16 14:43 ` Robert Foss
1 sibling, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-05-10 1:19 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, linux-media
Cc: mchehab, hverkuil-cisco, robert.foss, bryan.odonoghue,
vladimir.zapolskiy
I made a mistake, this patch was sent twice, please ignore this patch.
Thanks,
Yang
On 2022/5/9 22:04, Yang Yingliang wrote:
> 'supplies' is a pointer, the real size of struct regulator_bulk_data
> should be pass to devm_kmalloc_array().
>
> Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index f993f349b66b..80628801cf09 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
> if (csid->num_supplies) {
> csid->supplies = devm_kmalloc_array(camss->dev,
> csid->num_supplies,
> - sizeof(csid->supplies),
> + sizeof(*csid->supplies),
> GFP_KERNEL);
> if (!csid->supplies)
> return -ENOMEM;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array()
2022-05-09 14:04 [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array() Yang Yingliang
2022-05-10 1:19 ` Yang Yingliang
@ 2022-05-16 14:43 ` Robert Foss
1 sibling, 0 replies; 4+ messages in thread
From: Robert Foss @ 2022-05-16 14:43 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, linux-arm-msm, linux-media, mchehab,
hverkuil-cisco, bryan.odonoghue, vladimir.zapolskiy
On Mon, 9 May 2022 at 15:53, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> 'supplies' is a pointer, the real size of struct regulator_bulk_data
> should be pass to devm_kmalloc_array().
>
> Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index f993f349b66b..80628801cf09 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
> if (csid->num_supplies) {
> csid->supplies = devm_kmalloc_array(camss->dev,
> csid->num_supplies,
> - sizeof(csid->supplies),
> + sizeof(*csid->supplies),
> GFP_KERNEL);
> if (!csid->supplies)
> return -ENOMEM;
> --
> 2.25.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array()
@ 2022-05-09 14:04 Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-05-09 14:04 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, linux-media
Cc: mchehab, hverkuil-cisco, robert.foss, bryan.odonoghue,
vladimir.zapolskiy
'supplies' is a pointer, the real size of struct regulator_bulk_data
should be pass to devm_kmalloc_array().
Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/qcom/camss/camss-csid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index f993f349b66b..80628801cf09 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
if (csid->num_supplies) {
csid->supplies = devm_kmalloc_array(camss->dev,
csid->num_supplies,
- sizeof(csid->supplies),
+ sizeof(*csid->supplies),
GFP_KERNEL);
if (!csid->supplies)
return -ENOMEM;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-16 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 14:04 [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array() Yang Yingliang
2022-05-10 1:19 ` Yang Yingliang
2022-05-16 14:43 ` Robert Foss
2022-05-09 14:04 Yang Yingliang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).