From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional
Date: Fri, 2 Jul 2021 14:23:47 +0200 [thread overview]
Message-ID: <aee1d5a46b75fcaf4c231ddaf221f9ac2538440d.1625227382.git.matthias.schiffer@ew.tq-group.com> (raw)
In-Reply-To: <cover.1625227382.git.matthias.schiffer@ew.tq-group.com>
In-Reply-To: <cover.1625227382.git.matthias.schiffer@ew.tq-group.com>
The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This
causes warnings with newer kernels.
Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a
missing IRQ properly.
Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
v2: add Fixes line
The "irq != -ENXIO" check can be removed again if
platform_get_irq_optional() is modified to return 0 when no IRQ is
found; the current code will work with both -ENXIO and 0 returns.
drivers/gpio/gpio-tqmx86.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
index 5022e0ad0fae..0f5d17f343f1 100644
--- a/drivers/gpio/gpio-tqmx86.c
+++ b/drivers/gpio/gpio-tqmx86.c
@@ -238,8 +238,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
struct resource *res;
int ret, irq;
- irq = platform_get_irq(pdev, 0);
- if (irq < 0)
+ irq = platform_get_irq_optional(pdev, 0);
+ if (irq < 0 && irq != -ENXIO)
return irq;
res = platform_get_resource(pdev, IORESOURCE_IO, 0);
@@ -278,7 +278,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
- if (irq) {
+ if (irq > 0) {
struct irq_chip *irq_chip = &gpio->irq_chip;
u8 irq_status;
--
2.17.1
next prev parent reply other threads:[~2021-07-02 12:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 12:23 [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Matthias Schiffer
2021-07-02 12:23 ` Matthias Schiffer [this message]
2021-07-02 13:45 ` [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Andrew Lunn
2021-07-02 14:14 ` Andy Shevchenko
2021-07-02 12:23 ` [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-07-02 13:52 ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Matthias Schiffer
2021-07-02 13:56 ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 4/7] mfd: tqmx86: fix typo in "platform" Matthias Schiffer
2021-07-02 14:00 ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Matthias Schiffer
2021-07-02 14:01 ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Matthias Schiffer
2021-07-02 14:01 ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Matthias Schiffer
2021-07-02 14:04 ` Andrew Lunn
2021-07-02 13:41 ` [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Andrew Lunn
2021-07-05 7:13 ` Matthias Schiffer
2021-07-16 9:20 ` Lee Jones
2021-07-16 9:23 ` Matthias Schiffer
2021-07-16 9:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee1d5a46b75fcaf4c231ddaf221f9ac2538440d.1625227382.git.matthias.schiffer@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).