* [PATCH v3] Staging: most: use __func__ instead of the function name @ 2017-03-17 19:49 Chandra Annamaneni [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com> 0 siblings, 1 reply; 11+ messages in thread From: Chandra Annamaneni @ 2017-03-17 19:49 UTC (permalink / raw) To: christian.gromm, andrey.shvetsov; +Cc: devel, linux-kernel Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 --- a/drivers/staging/most/aim-v4l2/video.c +++ b/drivers/staging/most/aim-v4l2/video.c @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) struct most_video_dev *mdev = video_drvdata(filp); struct aim_fh *fh; - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); switch (vdev->vfl_type) { case VFL_TYPE_GRABBER: @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp) struct most_video_dev *mdev = fh->mdev; struct mbo *mbo, *tmp; - v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); /* * We need to put MBOs back before we call most_stop_channel() @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm) struct aim_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); *norm = V4L2_STD_UNKNOWN; return 0; @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index) struct aim_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index); + v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index); if (index >= V4L2_AIM_MAX_INPUT) return -EINVAL; @@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev *mdev) { int ret; - v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); init_waitqueue_head(&mdev->wait_data); @@ -471,7 +471,7 @@ static int aim_register_videodev(struct most_video_dev *mdev) static void aim_unregister_videodev(struct most_video_dev *mdev) { - v4l2_info(&mdev->v4l2_dev, "aim_unregister_videodev()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); video_unregister_device(mdev->vdev); } ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>]
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com> @ 2017-04-10 11:21 ` Christian Gromm 2017-04-21 7:40 ` Chandra Annamaneni 1 sibling, 0 replies; 11+ messages in thread From: Christian Gromm @ 2017-04-10 11:21 UTC (permalink / raw) To: chandrasekhar annamaneni, andrey.shvetsov; +Cc: devel, linux-kernel Sorry for the delay... On 04/10/2017 05:24 AM, chandrasekhar annamaneni wrote: > > Second reminder, please review. > > Thanks. > Chandra > > > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni > <chandra627@gmail.com <mailto:chandra627@gmail.com>> wrote: > > > Change video.c to use %s, __func__ instead of function names. > Warnings flagged by checkpatch.pl <http://checkpatch.pl> > > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com > <mailto:chandra627@gmail.com>> Acked-by: Christian Gromm <christian.gromm@microchip.com> > > diff --git a/drivers/staging/most/aim-v4l2/video.c > b/drivers/staging/most/aim-v4l2/video.c > index e074841..59e861e 100644 > --- a/drivers/staging/most/aim-v4l2/video.c > +++ b/drivers/staging/most/aim-v4l2/video.c > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) > struct most_video_dev *mdev = video_drvdata(filp); > struct aim_fh *fh; > > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > switch (vdev->vfl_type) { > case VFL_TYPE_GRABBER: > @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp) > struct most_video_dev *mdev = fh->mdev; > struct mbo *mbo, *tmp; > > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > /* > * We need to put MBOs back before we call most_stop_channel() > @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void > *priv, v4l2_std_id *norm) > struct aim_fh *fh = priv; > struct most_video_dev *mdev = fh->mdev; > > - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > *norm = V4L2_STD_UNKNOWN; > return 0; > @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, > void *priv, unsigned int index) > struct aim_fh *fh = priv; > struct most_video_dev *mdev = fh->mdev; > > - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index); > + v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index); > > if (index >= V4L2_AIM_MAX_INPUT) > return -EINVAL; > @@ -441,7 +441,7 @@ static int aim_register_videodev(struct > most_video_dev *mdev) > { > int ret; > > - v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > init_waitqueue_head(&mdev->wait_data); > > @@ -471,7 +471,7 @@ static int aim_register_videodev(struct > most_video_dev *mdev) > > static void aim_unregister_videodev(struct most_video_dev *mdev) > { > - v4l2_info(&mdev->v4l2_dev, "aim_unregister_videodev()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > video_unregister_device(mdev->vdev); > } > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com> 2017-04-10 11:21 ` Christian Gromm @ 2017-04-21 7:40 ` Chandra Annamaneni 2017-04-21 8:40 ` Greg KH 2017-04-21 10:30 ` Joe Perches 1 sibling, 2 replies; 11+ messages in thread From: Chandra Annamaneni @ 2017-04-21 7:40 UTC (permalink / raw) To: chandrasekhar annamaneni Cc: christian.gromm, andrey.shvetsov, devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 3244 bytes --] Third Reminder. Please review. -- Chandra On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote: > > Second reminder, please review. > > Thanks. > Chandra > > > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com> > wrote: > > Change video.c to use %s, __func__ instead of function names. > Warnings flagged by checkpatch.pl > > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> > > diff --git a/drivers/staging/most/aim-v4l2/video.c > b/drivers/staging/most/aim-v4l2/video.c > index e074841..59e861e 100644 > --- a/drivers/staging/most/aim-v4l2/video.c > +++ b/drivers/staging/most/aim-v4l2/video.c > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) > struct most_video_dev *mdev = video_drvdata(filp); > struct aim_fh *fh; > > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > switch (vdev->vfl_type) { > case VFL_TYPE_GRABBER: > @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp) > struct most_video_dev *mdev = fh->mdev; > struct mbo *mbo, *tmp; > > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > /* > * We need to put MBOs back before we call > most_stop_channel() > @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, > void *priv, v4l2_std_id *norm) > struct aim_fh *fh = priv; > struct most_video_dev *mdev = fh->mdev; > > - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > *norm = V4L2_STD_UNKNOWN; > return 0; > @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, > void *priv, unsigned int index) > struct aim_fh *fh = priv; > struct most_video_dev *mdev = fh->mdev; > > - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", > index); > + v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index); > > if (index >= V4L2_AIM_MAX_INPUT) > return -EINVAL; > @@ -441,7 +441,7 @@ static int aim_register_videodev(struct > most_video_dev *mdev) > { > int ret; > > - v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > init_waitqueue_head(&mdev->wait_data); > > @@ -471,7 +471,7 @@ static int aim_register_videodev(struct > most_video_dev *mdev) > > static void aim_unregister_videodev(struct most_video_dev > *mdev) > { > - v4l2_info(&mdev->v4l2_dev, > "aim_unregister_videodev()\n"); > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > > video_unregister_device(mdev->vdev); > } > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-21 7:40 ` Chandra Annamaneni @ 2017-04-21 8:40 ` Greg KH 2017-04-21 18:06 ` Chandra Annamaneni 2017-04-21 10:30 ` Joe Perches 1 sibling, 1 reply; 11+ messages in thread From: Greg KH @ 2017-04-21 8:40 UTC (permalink / raw) To: Chandra Annamaneni; +Cc: devel, christian.gromm, linux-kernel Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Apr 21, 2017 at 12:40:25AM -0700, Chandra Annamaneni wrote: > > Third Reminder. Please review. 2 days after you asked before? And I don't even see this patch in my queue, are you sure it hasn't already been handled, or merged, or rejected? thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-21 8:40 ` Greg KH @ 2017-04-21 18:06 ` Chandra Annamaneni 2017-04-21 18:19 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Chandra Annamaneni @ 2017-04-21 18:06 UTC (permalink / raw) To: Greg KH; +Cc: Chandra Annamaneni, devel, christian.gromm, linux-kernel Sorry about the top posting. I did ask about it on the 9th of April and the reply was that the email was 'acked'. Since I did not get a further email, I assumed it was lost. Perhaps I misunderstood. Thanks! Chandra On Fri, 21 Apr 2017, Greg KH wrote: > > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Fri, Apr 21, 2017 at 12:40:25AM -0700, Chandra Annamaneni wrote: > > > > Third Reminder. Please review. > > 2 days after you asked before? > > And I don't even see this patch in my queue, are you sure it hasn't > already been handled, or merged, or rejected? > > thanks, > > greg k-h > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-21 18:06 ` Chandra Annamaneni @ 2017-04-21 18:19 ` Greg KH 2017-04-25 6:20 ` Chandra Annamaneni 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2017-04-21 18:19 UTC (permalink / raw) To: Chandra Annamaneni; +Cc: devel, christian.gromm, linux-kernel On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote: > > Sorry about the top posting. > > I did ask about it on the 9th of April and the reply was that the email > was 'acked'. Since I did not get a further email, I assumed it was lost. > Perhaps I misunderstood. I really do not know, sorry. If you didn't get an automated email from my system that it was applied, rebased it against the latest staging-next branch and resend it. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-21 18:19 ` Greg KH @ 2017-04-25 6:20 ` Chandra Annamaneni 2017-04-25 18:36 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Chandra Annamaneni @ 2017-04-25 6:20 UTC (permalink / raw) To: Greg KH; +Cc: Chandra Annamaneni, devel, christian.gromm, linux-kernel Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 --- a/drivers/staging/most/aim-v4l2/video.c +++ b/drivers/staging/most/aim-v4l2/video.c @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) struct most_video_dev *mdev = video_drvdata(filp); struct aim_fh *fh; - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); switch (vdev->vfl_type) { case VFL_TYPE_GRABBER: @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp) struct most_video_dev *mdev = fh->mdev; struct mbo *mbo, *tmp; - v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); /* * We need to put MBOs back before we call most_stop_channel() @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm) struct aim_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); *norm = V4L2_STD_UNKNOWN; return 0; @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index) struct aim_fh *fh = priv; struct most_video_dev *mdev = fh->mdev; - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index); + v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index); if (index >= V4L2_AIM_MAX_INPUT) return -EINVAL; @@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev *mdev) { int ret; - v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n"); + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); On Fri, 21 Apr 2017, Greg KH wrote: > On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote: > > > > Sorry about the top posting. > > > > I did ask about it on the 9th of April and the reply was that the email > > was 'acked'. Since I did not get a further email, I assumed it was lost. > > Perhaps I misunderstood. > > I really do not know, sorry. If you didn't get an automated email from > my system that it was applied, rebased it against the latest > staging-next branch and resend it. > > thanks, > > greg k-h > ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-25 6:20 ` Chandra Annamaneni @ 2017-04-25 18:36 ` Greg KH 2017-04-26 2:28 ` Chandra Annamaneni 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2017-04-25 18:36 UTC (permalink / raw) To: Chandra Annamaneni; +Cc: devel, christian.gromm, linux-kernel On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote: > > Change video.c to use %s, __func__ instead of function names. > Warnings flagged by checkpatch.pl > > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> Why is this indented? Why is your subject a "Re:"? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-25 18:36 ` Greg KH @ 2017-04-26 2:28 ` Chandra Annamaneni 2017-04-26 2:55 ` Joe Perches 0 siblings, 1 reply; 11+ messages in thread From: Chandra Annamaneni @ 2017-04-26 2:28 UTC (permalink / raw) To: Greg KH; +Cc: Chandra Annamaneni, devel, christian.gromm, linux-kernel I assumed the email should be a reply to the previous email so it appears in the thread. As to the leading spaces, it was a problem with my mail client. Ill resend the patch. -- Chandra On Tue, 25 Apr 2017, Greg KH wrote: > On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote: > > > > Change video.c to use %s, __func__ instead of function names. > > Warnings flagged by checkpatch.pl > > > > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> > > Why is this indented? Why is your subject a "Re:"? > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-26 2:28 ` Chandra Annamaneni @ 2017-04-26 2:55 ` Joe Perches 0 siblings, 0 replies; 11+ messages in thread From: Joe Perches @ 2017-04-26 2:55 UTC (permalink / raw) To: Chandra Annamaneni, Greg KH; +Cc: devel, christian.gromm, linux-kernel On Tue, 2017-04-25 at 19:28 -0700, Chandra Annamaneni wrote: > I assumed the email should be a reply to the previous email so it appears > in the thread. As to the leading spaces, it was a problem with my mail > client. > > Ill resend the patch. Did you read my suggestion to just delete these lines instead? > -- > Chandra > > > On Tue, 25 Apr 2017, Greg KH wrote: > > > On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote: > > > > > > Change video.c to use %s, __func__ instead of function names. > > > Warnings flagged by checkpatch.pl > > > > > > Signed-off-by: Chandra Annamaneni <chandra627@gmail.com> > > > > Why is this indented? Why is your subject a "Re:"? > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] Staging: most: use __func__ instead of the function name 2017-04-21 7:40 ` Chandra Annamaneni 2017-04-21 8:40 ` Greg KH @ 2017-04-21 10:30 ` Joe Perches 1 sibling, 0 replies; 11+ messages in thread From: Joe Perches @ 2017-04-21 10:30 UTC (permalink / raw) To: Chandra Annamaneni; +Cc: christian.gromm, andrey.shvetsov, devel, linux-kernel On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote: > Third Reminder. Please review. Patience. > On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote: > > Second reminder, please review. [] > > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com> > > wrote: > > > > Change video.c to use %s, __func__ instead of function names. > > Warnings flagged by checkpatch.pl [] > > diff --git a/drivers/staging/most/aim-v4l2/video.c [] > > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) > > struct most_video_dev *mdev = video_drvdata(filp); > > struct aim_fh *fh; > > > > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); > > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); More likely all of these should be deleted as these seem to be function tracing logging and ftrace works well. see: Documentation/trace/ftrace.txt ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-04-26 2:55 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-17 19:49 [PATCH v3] Staging: most: use __func__ instead of the function name Chandra Annamaneni [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com> 2017-04-10 11:21 ` Christian Gromm 2017-04-21 7:40 ` Chandra Annamaneni 2017-04-21 8:40 ` Greg KH 2017-04-21 18:06 ` Chandra Annamaneni 2017-04-21 18:19 ` Greg KH 2017-04-25 6:20 ` Chandra Annamaneni 2017-04-25 18:36 ` Greg KH 2017-04-26 2:28 ` Chandra Annamaneni 2017-04-26 2:55 ` Joe Perches 2017-04-21 10:30 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).