linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bisected] drm/ksm: fbdev blanking regression in 2.6.33
@ 2010-01-06 17:00 Johan Hovold
  2010-01-06 17:00 ` [PATCH] drm/kms: fix fbdev blanking regression Johan Hovold
  0 siblings, 1 reply; 14+ messages in thread
From: Johan Hovold @ 2010-01-06 17:00 UTC (permalink / raw)
  To: Dave Airlie; +Cc: James Simmons, dri-devel, linux-kernel

Hi,

Console blanking broke on my laptop with GM45 chipset with 2.6.33. Instead of
blanking, the screen was dimmed and the backlight started glowing in the lower
edges of the screen. The glowing then slowly spread upwards. Did not look
healthy at all.

Easily reproduced by issuing "setterm -blank force".

I bisected it down to 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e (drm/kms:
properly handle fbdev blanking). Which instead of going directly to
DPMS_STANDBY now calls the encoder dpms helper with DRM_MODE_DPMS_ON and the
crtc dpms helper with DRM_MODE_DPMS_OFF. I've verified that is this combination
that triggers the bug. 

If I don't call crtc_funcs->dpms(crtc, DRM_MODE_DPMS_OFF) on FB_BLANK_NORMAL
but still encoder_funcs->dpms(encoder, DRM_MODE_DPMS_ON), the bug is not
triggered, but the screen is not cleared either.

For now, I simply reverted to the old behaviour of going directly to
DPMS_STANDBY (see follow-up patch).  

Thanks,
Johan


Johan Hovold (1):
  drm/kms: fix fbdev blanking regression

 drivers/gpu/drm/drm_fb_helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2010-01-16 16:02 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-06 17:00 [bisected] drm/ksm: fbdev blanking regression in 2.6.33 Johan Hovold
2010-01-06 17:00 ` [PATCH] drm/kms: fix fbdev blanking regression Johan Hovold
2010-01-06 17:33   ` James Simmons
2010-01-06 18:09     ` Johan Hovold
2010-01-06 18:18       ` James Simmons
2010-01-06 19:12         ` Johan Hovold
2010-01-07  6:41           ` David John
2010-01-12 17:28             ` James Simmons
2010-01-12 17:34               ` Jesse Barnes
2010-01-13 19:48                 ` James Simmons
2010-01-13 20:01                   ` Alex Deucher
2010-01-15 12:40                     ` James Simmons
2010-01-15 13:10                       ` Alan Cox
2010-01-16 16:02                 ` James Simmons

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).