linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerhard Wiesinger <lists@wiesinger.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26
Date: Thu, 24 May 2018 07:29:42 +0200	[thread overview]
Message-ID: <ba1a6179-48ff-ca2b-bb3c-f99f8376df50@wiesinger.com> (raw)
In-Reply-To: <53c9272a-0e1a-e8fb-a3e4-b4e23e77be10@gmail.com>

After some analysis with Florian (thnx) we found out that the current 
implementation is broken:

https://patchwork.ozlabs.org/patch/836538/
https://github.com/torvalds/linux/commit/c499696e7901bda18385ac723b7bd27c3a4af624#diff-a2b6f8d89e18de600e873ac3ac43fa1d

Florians comment:

c499696e7901bda18385ac723b7bd27c3a4af624 ("net: dsa: b53: Stop using
dev->cpu_port incorrectly") since it would result in no longer setting
the CPU port as tagged for a specific VLAN. Easiest way for you right
now is to just revert it, but this needs some more thoughts for a proper
upstream change. I will think about it some more.

Ciao,
Gerhard

  reply	other threads:[~2018-05-24  5:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 19:11 B53 DSA switch problem on Banana Pi-R1 on Fedora 26 Gerhard Wiesinger
2018-05-22 19:15 ` Florian Fainelli
2018-05-22 20:16 ` Andrew Lunn
2018-05-22 20:42   ` Florian Fainelli
2018-05-22 21:02     ` Andrew Lunn
2018-05-23  4:49     ` Gerhard Wiesinger
2018-05-23 15:28       ` Florian Fainelli
2018-05-23 15:50         ` Florian Fainelli
2018-05-23 17:29           ` Gerhard Wiesinger
2018-05-23 17:47             ` Florian Fainelli
2018-05-23 18:11               ` Gerhard Wiesinger
2018-05-23 18:21                 ` Florian Fainelli
2018-05-23 17:35         ` Gerhard Wiesinger
2018-05-23 17:55           ` Florian Fainelli
2018-05-23 18:27             ` Gerhard Wiesinger
2018-05-23 18:54               ` Florian Fainelli
2018-05-24  5:29                 ` Gerhard Wiesinger [this message]
2018-05-24  6:22                   ` Gerhard Wiesinger
2018-05-27 19:01                     ` B53 DSA switch problem on Banana Pi-R1 on Fedora 26 - systemd-networkd problem Gerhard Wiesinger
2018-05-27 19:18                       ` Gerhard Wiesinger
2018-05-27 20:35                         ` Florian Fainelli
2018-05-28  5:24                           ` Gerhard Wiesinger
2018-05-27 20:31                       ` Florian Fainelli
2018-05-28  5:32                         ` Gerhard Wiesinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1a6179-48ff-ca2b-bb3c-f99f8376df50@wiesinger.com \
    --to=lists@wiesinger.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).