From: Florian Fainelli <f.fainelli@gmail.com>
To: Gerhard Wiesinger <lists@wiesinger.com>, Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26
Date: Wed, 23 May 2018 10:47:52 -0700 [thread overview]
Message-ID: <fb898d25-3e5a-787b-cc4b-f670e4b61f58@gmail.com> (raw)
In-Reply-To: <88af3639-f3f9-ed45-c6bd-b30021347633@wiesinger.com>
On 05/23/2018 10:29 AM, Gerhard Wiesinger wrote:
> On 23.05.2018 17:50, Florian Fainelli wrote:
>>
>> On 05/23/2018 08:28 AM, Florian Fainelli wrote:
>>>
>>> On 05/22/2018 09:49 PM, Gerhard Wiesinger wrote:
>>>> On 22.05.2018 22:42, Florian Fainelli wrote:
>>>>> On 05/22/2018 01:16 PM, Andrew Lunn wrote:
>>>>>>> Planned network structure will be as with 4.7.x kernels:
>>>>>>>
>>>>>>> br0 <=> eth0.101 <=> eth0 (vlan 101 tagged) <=> lan 1-lan4 (vlan 101
>>>>>>> untagged pvid)
>>>>>>>
>>>>>>> br1 <=> eth0.102 <=> eth0 (vlan 102 tagged) <=> wan (vlan 102
>>>>>>> untagged pvid)
>>>>>> Do you even need these vlans?
>>>>> Yes, remember, b53 does not currently turn on Broadcom tags, so the
>>>>> only
>>>>> way to segregate traffic is to have VLANs for that.
>>>>>
>>>>>> Are you doing this for port separation? To keep lan1-4 traffic
>>>>>> separate from wan? DSA does that by default, no vlan needed.
>>>>>>
>>>>>> So you can just do
>>>>>>
>>>>>> ip link add name br0 type bridge
>>>>>> ip link set dev br0 up
>>>>>> ip link set dev lan1 master br0
>>>>>> ip link set dev lan2 master br0
>>>>>> ip link set dev lan3 master br0
>>>>>> ip link set dev lan4 master br0
>>>>>>
>>>>>> and use interface wan directly, no bridge needed.
>>>>> That would work once Broadcom tags are turned on which requires
>>>>> turning
>>>>> on managed mode, which requires work that I have not been able to get
>>>>> done :)
>>>> Setup with swconfig:
>>>>
>>>> #!/usr/bin/bash
>>>>
>>>>
>>>> INTERFACE=eth0
>>>>
>>>> # Delete all IP addresses and get link up
>>>> ip addr flush dev ${INTERFACE}
>>>> ip link set ${INTERFACE} up
>>>>
>>>> # Lamobo R1 aka BPi R1 Routerboard
>>>> #
>>>> # Speaker | LAN1 | LAN2 | LAN3 | LAN4 || LAN5 | HDMI
>>>> # SW-Port | P2 | P1 | P0 | P4 || P3 |
>>>> # VLAN | 11 | 12 | 13 | 14 ||ALL(t)|
>>>> #
>>>> # Switch-Port P8 - ALL(t) boards internal CPU Port
>>>>
>>>> # Setup switch
>>>> swconfig dev ${INTERFACE} set reset 1
>>>> swconfig dev ${INTERFACE} set enable_vlan 1
>>>> swconfig dev ${INTERFACE} vlan 101 set ports '3 8t'
>>>> swconfig dev ${INTERFACE} vlan 102 set ports '4 0 1 2 8t'
>>>> swconfig dev ${INTERFACE} set apply 1
>>>>
>>>> How to achieve this setup CURRENTLY with DSA?
>>> Your first email had the right programming sequence, but you did not
>>> answer whether you have CONFIG_BRIDGE_VLAN_FILTERING enabled or not,
>>> which is likely your problem.
>> Here are some reference configurations that should work:
>>
>> https://github.com/armbian/build/issues/511#issuecomment-320473246
>
> I know, some comments are from me but none of them worked, therefore on
> LKML :-)
I see, maybe you could have started there, that would have saved me a
trip to github to find out the thread.
>
> /boot/config-4.16.7-100.fc26.armv7hl:CONFIG_BRIDGE_VLAN_FILTERING=y
>
> so this can't be the issue, any further ideas?
Yes, remove the "self" from your bridge vlan commands, I don't see that
being necessary.
>
> On my 2nd Banana Pi-R1 still on Fedora 25 with kernel
> 4.12.8-200.fc25.armv7hl the commands still work well, but I wanted to
> test the upgrade on another one.
>
> /boot/config-4.12.8-200.fc25.armv7hl:CONFIG_BRIDGE_VLAN_FILTERING=y
Is using an upstream or compiled by yourself kernel an option at all? I
have no clue what is in a distribution kernel.
--
Florian
next prev parent reply other threads:[~2018-05-23 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:11 B53 DSA switch problem on Banana Pi-R1 on Fedora 26 Gerhard Wiesinger
2018-05-22 19:15 ` Florian Fainelli
2018-05-22 20:16 ` Andrew Lunn
2018-05-22 20:42 ` Florian Fainelli
2018-05-22 21:02 ` Andrew Lunn
2018-05-23 4:49 ` Gerhard Wiesinger
2018-05-23 15:28 ` Florian Fainelli
2018-05-23 15:50 ` Florian Fainelli
2018-05-23 17:29 ` Gerhard Wiesinger
2018-05-23 17:47 ` Florian Fainelli [this message]
2018-05-23 18:11 ` Gerhard Wiesinger
2018-05-23 18:21 ` Florian Fainelli
2018-05-23 17:35 ` Gerhard Wiesinger
2018-05-23 17:55 ` Florian Fainelli
2018-05-23 18:27 ` Gerhard Wiesinger
2018-05-23 18:54 ` Florian Fainelli
2018-05-24 5:29 ` Gerhard Wiesinger
2018-05-24 6:22 ` Gerhard Wiesinger
2018-05-27 19:01 ` B53 DSA switch problem on Banana Pi-R1 on Fedora 26 - systemd-networkd problem Gerhard Wiesinger
2018-05-27 19:18 ` Gerhard Wiesinger
2018-05-27 20:35 ` Florian Fainelli
2018-05-28 5:24 ` Gerhard Wiesinger
2018-05-27 20:31 ` Florian Fainelli
2018-05-28 5:32 ` Gerhard Wiesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb898d25-3e5a-787b-cc4b-f670e4b61f58@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@wiesinger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).