* [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
@ 2020-09-17 17:51 Randy Dunlap
2020-09-21 15:45 ` Randy Dunlap
2020-09-22 14:12 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-09-17 17:51 UTC (permalink / raw)
To: LKML, USB list
Cc: Li Yin, Vadivel Murugan R, Kishon Vijay Abraham I, Vinod Koul
From: Randy Dunlap <rdunlap@infradead.org>
Fix a Kconfig warning that is causing lots of build errors
when USB_SUPPORT is not set.
USB_PHY depends on USB_SUPPORT but "select" doesn't care about
dependencies, so this driver should also depend on USB_SUPPORT.
It should not select USB_SUPPORT.
WARNING: unmet direct dependencies detected for USB_PHY
Depends on [n]: USB_SUPPORT [=n]
Selected by [m]:
- USB_LGM_PHY [=m]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Li Yin <yin1.li@intel.com>
Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200917.orig/drivers/phy/Kconfig
+++ linux-next-20200917/drivers/phy/Kconfig
@@ -51,6 +51,7 @@ config PHY_XGENE
config USB_LGM_PHY
tristate "INTEL Lightning Mountain USB PHY Driver"
+ depends on USB_SUPPORT
select USB_PHY
select REGULATOR
select REGULATOR_FIXED_VOLTAGE
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
2020-09-17 17:51 [PATCH -next] phy: fix USB_LGM_PHY warning & build errors Randy Dunlap
@ 2020-09-21 15:45 ` Randy Dunlap
2020-09-22 4:21 ` Ramuthevar, Vadivel MuruganX
2020-09-22 14:12 ` Vinod Koul
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-09-21 15:45 UTC (permalink / raw)
To: LKML, USB list
Cc: Li Yin, Vadivel Murugan R, Kishon Vijay Abraham I, Vinod Koul,
Greg Kroah-Hartman
Ping. Still seeing this in linux-next.
On 9/17/20 10:51 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a Kconfig warning that is causing lots of build errors
> when USB_SUPPORT is not set.
>
> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
> dependencies, so this driver should also depend on USB_SUPPORT.
> It should not select USB_SUPPORT.
>
> WARNING: unmet direct dependencies detected for USB_PHY
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [m]:
> - USB_LGM_PHY [=m]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Li Yin <yin1.li@intel.com>
> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200917.orig/drivers/phy/Kconfig
> +++ linux-next-20200917/drivers/phy/Kconfig
> @@ -51,6 +51,7 @@ config PHY_XGENE
>
> config USB_LGM_PHY
> tristate "INTEL Lightning Mountain USB PHY Driver"
> + depends on USB_SUPPORT
> select USB_PHY
> select REGULATOR
> select REGULATOR_FIXED_VOLTAGE
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
2020-09-21 15:45 ` Randy Dunlap
@ 2020-09-22 4:21 ` Ramuthevar, Vadivel MuruganX
0 siblings, 0 replies; 4+ messages in thread
From: Ramuthevar, Vadivel MuruganX @ 2020-09-22 4:21 UTC (permalink / raw)
To: Randy Dunlap, LKML, USB list
Cc: Li Yin, Kishon Vijay Abraham I, Vinod Koul, Greg Kroah-Hartman
Hi Randy,
Thank you for the report, surely will fix it.
Regards
Vadivel
On 21/9/2020 11:45 pm, Randy Dunlap wrote:
> Ping. Still seeing this in linux-next.
>
> On 9/17/20 10:51 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix a Kconfig warning that is causing lots of build errors
>> when USB_SUPPORT is not set.
>>
>> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
>> dependencies, so this driver should also depend on USB_SUPPORT.
>> It should not select USB_SUPPORT.
>>
>> WARNING: unmet direct dependencies detected for USB_PHY
>> Depends on [n]: USB_SUPPORT [=n]
>> Selected by [m]:
>> - USB_LGM_PHY [=m]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Li Yin <yin1.li@intel.com>
>> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Vinod Koul <vkoul@kernel.org>
>> ---
>> drivers/phy/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20200917.orig/drivers/phy/Kconfig
>> +++ linux-next-20200917/drivers/phy/Kconfig
>> @@ -51,6 +51,7 @@ config PHY_XGENE
>>
>> config USB_LGM_PHY
>> tristate "INTEL Lightning Mountain USB PHY Driver"
>> + depends on USB_SUPPORT
>> select USB_PHY
>> select REGULATOR
>> select REGULATOR_FIXED_VOLTAGE
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
2020-09-17 17:51 [PATCH -next] phy: fix USB_LGM_PHY warning & build errors Randy Dunlap
2020-09-21 15:45 ` Randy Dunlap
@ 2020-09-22 14:12 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-09-22 14:12 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, USB list, Li Yin, Vadivel Murugan R, Kishon Vijay Abraham I
On 17-09-20, 10:51, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a Kconfig warning that is causing lots of build errors
> when USB_SUPPORT is not set.
>
> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
> dependencies, so this driver should also depend on USB_SUPPORT.
> It should not select USB_SUPPORT.
>
> WARNING: unmet direct dependencies detected for USB_PHY
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [m]:
> - USB_LGM_PHY [=m]
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-22 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 17:51 [PATCH -next] phy: fix USB_LGM_PHY warning & build errors Randy Dunlap
2020-09-21 15:45 ` Randy Dunlap
2020-09-22 4:21 ` Ramuthevar, Vadivel MuruganX
2020-09-22 14:12 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).