From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Josh Don <joshdon@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Paul Turner <pjt@google.com>,
David Rientjes <rientjes@google.com>,
Oleg Rombakh <olegrom@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steve Sistare <steven.sistare@oracle.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: cgroup SCHED_IDLE support
Date: Thu, 10 Jun 2021 14:53:48 +0200 [thread overview]
Message-ID: <e3fc3338-c469-0c0c-ada2-a0bbc9f969fe@arm.com> (raw)
In-Reply-To: <20210608231132.32012-1-joshdon@google.com>
Hi Josh,
On 09/06/2021 01:11, Josh Don wrote:
[...]
> static void __maybe_unused cpu_period_quota_print(struct seq_file *sf,
> @@ -10306,6 +10318,12 @@ static struct cftype cpu_files[] = {
> .read_s64 = cpu_weight_nice_read_s64,
> .write_s64 = cpu_weight_nice_write_s64,
> },
> + {
> + .name = "idle",
> + .flags = CFTYPE_NOT_ON_ROOT,
> + .read_s64 = cpu_idle_read_s64,
> + .write_s64 = cpu_idle_write_s64,
> + },
Any reason why this should only work on cgroup-v2?
struct cftype cpu_legacy_files[] vs. cpu_files[]
[...]
> @@ -11340,10 +11408,14 @@ void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq,
>
> static DEFINE_MUTEX(shares_mutex);
>
> -int sched_group_set_shares(struct task_group *tg, unsigned long shares)
> +#define IDLE_WEIGHT sched_prio_to_weight[ARRAY_SIZE(sched_prio_to_weight) - 1]
Why not 3 ? Like for tasks (WEIGHT_IDLEPRIO)?
[...]
next prev parent reply other threads:[~2021-06-10 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 23:11 [PATCH] sched: cgroup SCHED_IDLE support Josh Don
2021-06-10 12:53 ` Dietmar Eggemann [this message]
2021-06-10 19:14 ` Josh Don
2021-06-11 16:43 ` Dietmar Eggemann
2021-06-11 23:34 ` Josh Don
2021-06-15 10:06 ` Dietmar Eggemann
2021-06-15 23:30 ` Josh Don
2021-06-25 9:24 ` Peter Zijlstra
2021-06-16 15:42 ` Tejun Heo
2021-06-17 1:01 ` Josh Don
2021-06-26 9:57 ` Tejun Heo
2021-06-29 4:57 ` Josh Don
2021-06-25 8:08 ` Peter Zijlstra
2021-06-26 10:06 ` Tejun Heo
2021-06-26 11:42 ` Rik van Riel
2021-06-25 8:14 ` Peter Zijlstra
2021-06-26 0:18 ` Josh Don
2021-06-25 8:20 ` Peter Zijlstra
2021-06-26 0:35 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fc3338-c469-0c0c-ada2-a0bbc9f969fe@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=olegrom@google.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).