From: Michael Walle <michael@walle.cc>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [RFC PATCH 3/3] net: phy: at803x: add device tree binding
Date: Thu, 31 Oct 2019 18:22:52 +0100 [thread overview]
Message-ID: <e867d1a9a1e4b878aa0dafe413e9a6f7@walle.cc> (raw)
In-Reply-To: <B3B13FB8-42D9-42F9-8106-536F574FA35B@walle.cc>
Am 2019-10-31 00:59, schrieb Michael Walle:
>>> +
>>> + if (of_property_read_bool(node, "atheros,keep-pll-enabled"))
>>> + priv->flags |= AT803X_KEEP_PLL_ENABLED;
>>
>> This should probably be a PHY tunable rather than a Device Tree
>> property
>> as this delves more into the policy than the pure hardware
>> description.
>
> To be frank. I'll first need to look into PHY tunables before answering
> ;)
> But keep in mind that this clock output might be used anywhere on the
> board. It must not have something to do with networking. The PHY has a
> crystal and it can generate these couple of frequencies regardless of
> its network operation.
Although it could be used to provide any clock on the board, I don't
know
if that is possible at the moment, because the PHY is configured in
config_init() which is only called when someone brings the interface up,
correct?
Anyway, I don't know if that is worth the hassle because in almost all
cases the use case is to provide a fixed clock to the MAC for an RGMII
interface. I don't know if that really fits a PHY tunable, because in
the worst case the link won't work at all if the SoC expects an
always-on clock.
--
-michael
next prev parent reply other threads:[~2019-10-31 17:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 22:42 [RFC PATCH 0/3] net: phy: at803x device tree binding Michael Walle
2019-10-30 22:42 ` [RFC PATCH 1/3] net: phy: at803x: fix Kconfig description Michael Walle
2019-10-30 23:13 ` Andrew Lunn
2019-10-30 23:16 ` Florian Fainelli
2019-10-30 23:18 ` Andrew Lunn
2019-10-30 23:32 ` Florian Fainelli
2019-10-31 0:05 ` Michael Walle
2019-10-30 22:42 ` [RFC PATCH 2/3] dt-bindings: net: phy: Add support for AT803X Michael Walle
2019-10-30 23:17 ` Andrew Lunn
2019-10-31 0:14 ` Michael Walle
2019-10-31 16:45 ` Florian Fainelli
2019-10-31 17:14 ` Michael Walle
2019-10-30 23:28 ` Florian Fainelli
2019-10-30 23:36 ` Michael Walle
2019-11-01 15:03 ` Simon Horman
2019-11-02 1:19 ` Michael Walle
2019-10-30 22:42 ` [RFC PATCH 3/3] net: phy: at803x: add device tree binding Michael Walle
2019-10-30 23:21 ` Andrew Lunn
2019-10-30 23:28 ` Florian Fainelli
2019-10-30 23:59 ` Michael Walle
2019-10-31 17:22 ` Michael Walle [this message]
2019-10-31 17:35 ` Florian Fainelli
2019-11-02 1:18 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e867d1a9a1e4b878aa0dafe413e9a6f7@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).