* [PATCH] acpi: require CRC32 to build
@ 2022-01-30 22:38 Randy Dunlap
2022-01-30 22:58 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-01-30 22:38 UTC (permalink / raw)
To: linux-kernel, linux-next
Cc: Randy Dunlap, Guenter Roeck, Rafael J . Wysocki, Heikki Krogerus,
Linus Torvalds
ACPI core now requires crc32() but the kernel build can fail when
CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
Fixes this build error:
ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
---
drivers/acpi/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20220128.orig/drivers/acpi/Kconfig
+++ linux-next-20220128/drivers/acpi/Kconfig
@@ -11,6 +11,7 @@ menuconfig ACPI
depends on ARCH_SUPPORTS_ACPI
select PNP
select NLS
+ select CRC32
default y if X86
help
Advanced Configuration and Power Interface (ACPI) support for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi: require CRC32 to build
2022-01-30 22:38 [PATCH] acpi: require CRC32 to build Randy Dunlap
@ 2022-01-30 22:58 ` Guenter Roeck
2022-01-31 19:17 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2022-01-30 22:58 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel, linux-next
Cc: Rafael J . Wysocki, Heikki Krogerus, Linus Torvalds
On 1/30/22 14:38, Randy Dunlap wrote:
> ACPI core now requires crc32() but the kernel build can fail when
> CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
>
> Fixes this build error:
>
> ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
> include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
>
> Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/acpi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20220128.orig/drivers/acpi/Kconfig
> +++ linux-next-20220128/drivers/acpi/Kconfig
> @@ -11,6 +11,7 @@ menuconfig ACPI
> depends on ARCH_SUPPORTS_ACPI
> select PNP
> select NLS
> + select CRC32
> default y if X86
> help
> Advanced Configuration and Power Interface (ACPI) support for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] acpi: require CRC32 to build
2022-01-30 22:58 ` Guenter Roeck
@ 2022-01-31 19:17 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-01-31 19:17 UTC (permalink / raw)
To: Guenter Roeck, Randy Dunlap, linux-kernel, linux-next
Cc: Heikki Krogerus, Linus Torvalds
On 1/30/2022 11:58 PM, Guenter Roeck wrote:
> On 1/30/22 14:38, Randy Dunlap wrote:
>> ACPI core now requires crc32() but the kernel build can fail when
>> CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
>>
>> Fixes this build error:
>>
>> ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
>> include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
>>
>> Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct
>> acpi_device")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
Applied as 5.17-rc material, thanks!
>> ---
>> drivers/acpi/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20220128.orig/drivers/acpi/Kconfig
>> +++ linux-next-20220128/drivers/acpi/Kconfig
>> @@ -11,6 +11,7 @@ menuconfig ACPI
>> depends on ARCH_SUPPORTS_ACPI
>> select PNP
>> select NLS
>> + select CRC32
>> default y if X86
>> help
>> Advanced Configuration and Power Interface (ACPI) support for
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-31 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 22:38 [PATCH] acpi: require CRC32 to build Randy Dunlap
2022-01-30 22:58 ` Guenter Roeck
2022-01-31 19:17 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).