linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@suse.de>, Greg KH <greg@kroah.com>
Cc: Tejun Heo <htejun@gmail.com>,
	Linux Containers <containers@lists.osdl.org>,
	<netdev@vger.kernel.org>,
	cornelia.huck@de.ibm.com, stern@rowland.harvard.edu,
	kay.sievers@vrfy.org, <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>
Subject: [PATCH 06/10] sysfs: sysfs_chmod_file handle multiple superblocks
Date: Sat, 01 Dec 2007 02:25:44 -0700	[thread overview]
Message-ID: <m1fxym7omf.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <m1k5ny7oqb.fsf_-_@ebiederm.dsl.xmission.com> (Eric W. Biederman's message of "Sat, 01 Dec 2007 02:23:24 -0700")


Teach sysfs_chmod_file how to handle multiple sysfs superblocks.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 fs/sysfs/file.c |   51 ++++++++++++++++++++++++++++-----------------------
 1 files changed, 28 insertions(+), 23 deletions(-)

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 8c7bba0..ade6140 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -558,7 +558,8 @@ EXPORT_SYMBOL_GPL(sysfs_add_file_to_group);
 int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)
 {
 	struct sysfs_dirent *victim_sd = NULL;
-	struct dentry *victim = NULL;
+	struct super_block *sb;
+	struct dentry *victim;
 	struct inode * inode;
 	struct iattr newattrs;
 	int rc;
@@ -569,31 +570,35 @@ int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)
 		goto out;
 
 	mutex_lock(&sysfs_rename_mutex);
-	victim = sysfs_get_dentry(sysfs_sb, victim_sd);
-	mutex_unlock(&sysfs_rename_mutex);
-	if (IS_ERR(victim)) {
-		rc = PTR_ERR(victim);
-		victim = NULL;
-		goto out;
-	}
-
-	inode = victim->d_inode;
-
-	mutex_lock(&inode->i_mutex);
+	sysfs_grab_supers();
+	list_for_each_entry(sb, &sysfs_fs_type.fs_supers, s_instances) {
+		victim = sysfs_get_dentry(sb, victim_sd);
+		if (victim == ERR_PTR(-EXDEV))
+			continue;
+		if (IS_ERR(victim)) {
+			rc = PTR_ERR(victim);
+			victim = NULL;
+			goto out_unlock;
+		}
 
-	newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
-	newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
-	rc = notify_change(victim, &newattrs);
+		inode = victim->d_inode;
+		mutex_lock(&inode->i_mutex);
+		newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
+		newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
+		rc = notify_change(victim, &newattrs);
+		if (rc == 0) {
+			mutex_lock(&sysfs_mutex);
+			victim_sd->s_mode = newattrs.ia_mode;
+			mutex_unlock(&sysfs_mutex);
+		}
+		mutex_unlock(&inode->i_mutex);
 
-	if (rc == 0) {
-		mutex_lock(&sysfs_mutex);
-		victim_sd->s_mode = newattrs.ia_mode;
-		mutex_unlock(&sysfs_mutex);
+		dput(victim);
 	}
-
-	mutex_unlock(&inode->i_mutex);
- out:
-	dput(victim);
+out_unlock:
+	sysfs_release_supers();
+	mutex_unlock(&sysfs_rename_mutex);
+out:
 	sysfs_put(victim_sd);
 	return rc;
 }
-- 
1.5.3.rc6.17.g1911


  reply	other threads:[~2007-12-01  9:27 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01  9:06 [PATCH 0/10] sysfs network namespace support Eric W. Biederman
2007-12-01  9:12 ` [PATCH 01/10] sysfs: Make sysfs_mount static again Eric W. Biederman
2007-12-01  9:13   ` [PATCH 02/10] sysfs: Support for preventing unmounts Eric W. Biederman
2007-12-01  9:16     ` [PATCH 03/10] sysfs: sysfs_get_dentry add a sb parameter Eric W. Biederman
2007-12-01  9:18       ` [PATCH 04/10] sysfs: Implement __sysfs_get_dentry Eric W. Biederman
2007-12-01  9:23         ` [PATCH 05/10] sysfs: Rename Support multiple superblocks Eric W. Biederman
2007-12-01  9:25           ` Eric W. Biederman [this message]
2007-12-01  9:28             ` [PATCH 07/10] sysfs: Implement sysfs tagged directory support Eric W. Biederman
2007-12-01  9:30               ` [PATCH 08/10] sysfs: Implement sysfs_delete_link and sysfs_rename_link Eric W. Biederman
2007-12-01  9:33                 ` [PATCH 09/10] driver core: Implement tagged directory support for device classes Eric W. Biederman
2007-12-01  9:35                   ` [PATCH 10/10] net: Enable tagging for net_class directories in sysfs Eric W. Biederman
2007-12-01 13:10 ` namespace support requires network modules to say "GPL" Mark Lord
2007-12-01 13:13   ` Mark Lord
2007-12-01 19:17   ` Stephen Hemminger
2007-12-01 19:23     ` Alan Cox
2007-12-01 19:38       ` Stephen Hemminger
2007-12-01 19:45         ` Alan Cox
2007-12-01 20:13         ` Eric W. Biederman
2007-12-01 20:21           ` Mark Lord
2007-12-01 20:29             ` Arjan van de Ven
2007-12-01 22:12               ` Mark Lord
2007-12-01 23:13                 ` Eric W. Biederman
2007-12-01 23:24                   ` Jiri Slaby
2007-12-02  1:14                     ` Eric W. Biederman
2007-12-01 23:51                   ` Mark Lord
2007-12-02  1:08                     ` Eric W. Biederman
2007-12-01 20:52             ` Eric W. Biederman
2007-12-01 22:13             ` Mark Lord
2007-12-03  0:02       ` David Schwartz
2007-12-03  0:14         ` Alan Cox
2007-12-01 19:54     ` Eric W. Biederman
2007-12-02  0:30     ` Stephen Hemminger
2007-12-02  2:02       ` Eric W. Biederman
2007-12-02  3:34       ` Mark Lord
2007-12-02  4:23         ` Stephen Hemminger
2007-12-02 19:28           ` Ben Greear
2007-12-02 20:03             ` Patrick McHardy
2007-12-02 20:43               ` Adrian Bunk
2007-12-02 21:59                 ` Patrick McHardy
2007-12-03  1:14                   ` Adrian Bunk
2007-12-03  8:33                   ` Denis V. Lunev
2007-12-03 17:35               ` Eric W. Biederman
2007-12-03 18:19                 ` Ben Greear
2007-12-03 18:57                   ` Daniel Lezcano
2007-12-04 15:19                     ` Daniel Lezcano
2007-12-04 18:03                     ` Eric W. Biederman
2007-12-04 18:44                       ` Ben Greear
2007-12-04 19:17                         ` Eric W. Biederman
2007-12-04 19:35                           ` Ben Greear
2007-12-04 20:09                             ` Eric W. Biederman
2007-12-05  6:14                           ` David Miller
2007-12-05  6:01                       ` David Miller
2007-12-04 17:59                   ` Eric W. Biederman
2007-12-04 18:57                     ` Ben Greear
2007-12-04 20:01                       ` Eric W. Biederman
2007-12-05  6:07                       ` David Miller
2007-12-03  8:24         ` Romano Giannetti
2007-12-03 15:34           ` Arjan van de Ven
2007-12-03 18:03           ` Eric W. Biederman
2007-12-03 18:13             ` David Miller
2007-12-02 13:51       ` Alan Cox
2007-12-02 19:56         ` Valdis.Kletnieks
2007-12-21  3:07 ` [PATCH 0/10] sysfs network namespace support Greg KH
2007-12-21 13:04   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1fxym7omf.fsf_-_@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=htejun@gmail.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).