* Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
2018-10-08 13:19 ` Greg Kroah-Hartman
@ 2018-10-08 15:20 ` Alan Stern
2018-10-08 15:55 ` Randy Dunlap
2018-10-08 16:48 ` Adam Borowski
2018-10-09 6:18 ` Ingo Molnar
2 siblings, 1 reply; 8+ messages in thread
From: Alan Stern @ 2018-10-08 15:20 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Adam Borowski, Thomas Gleixner, Ingo Molnar, x86, linux-usb,
linux-kernel
On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote:
> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
> > A spanking new machine I just got has all but one USB ports wired as 3.0.
> > Booting defconfig resulted in no keyboard or mouse, which was pretty
> > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
> > As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
> >
> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> > ---
> > arch/x86/configs/x86_64_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> defconfig for x86 actually still works? That's amazing in itself :)
>
> > diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> > index e32fc1f274d8..ac9ae487cfeb 100644
> > --- a/arch/x86/configs/x86_64_defconfig
> > +++ b/arch/x86/configs/x86_64_defconfig
> > @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
> > CONFIG_USB=y
> > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
> > CONFIG_USB_MON=y
> > +CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_EHCI_HCD=y
> > CONFIG_USB_EHCI_TT_NEWSCHED=y
> > CONFIG_USB_OHCI_HCD=y
>
> You can probably turn ehci and ohci off if you have xhci in the
> "default" system now.
Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI
_only_ for SuperSpeed devices, and only on some of the ports. Not a
combination I have heard of anywhere else. Enabling xHCI without EHCI
on that computer would be a bad idea. :-)
Alan Stern
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
2018-10-08 15:20 ` Alan Stern
@ 2018-10-08 15:55 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2018-10-08 15:55 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: Adam Borowski, Thomas Gleixner, Ingo Molnar, x86, linux-usb,
linux-kernel
On 10/8/18 8:20 AM, Alan Stern wrote:
> On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote:
>
>> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
>>> A spanking new machine I just got has all but one USB ports wired as 3.0.
>>> Booting defconfig resulted in no keyboard or mouse, which was pretty
>>> uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
>>> As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
>>>
>>> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
>>> ---
>>> arch/x86/configs/x86_64_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> defconfig for x86 actually still works? That's amazing in itself :)
>>
>>> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
>>> index e32fc1f274d8..ac9ae487cfeb 100644
>>> --- a/arch/x86/configs/x86_64_defconfig
>>> +++ b/arch/x86/configs/x86_64_defconfig
>>> @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
>>> CONFIG_USB=y
>>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>>> CONFIG_USB_MON=y
>>> +CONFIG_USB_XHCI_HCD=y
>>> CONFIG_USB_EHCI_HCD=y
>>> CONFIG_USB_EHCI_TT_NEWSCHED=y
>>> CONFIG_USB_OHCI_HCD=y
>>
>> You can probably turn ehci and ohci off if you have xhci in the
>> "default" system now.
>
> Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI
> _only_ for SuperSpeed devices, and only on some of the ports. Not a
> combination I have heard of anywhere else. Enabling xHCI without EHCI
> on that computer would be a bad idea. :-)
Yeah, I have some mixed HCD usages as well.
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
2018-10-08 13:19 ` Greg Kroah-Hartman
2018-10-08 15:20 ` Alan Stern
@ 2018-10-08 16:48 ` Adam Borowski
2018-10-09 6:18 ` Ingo Molnar
2 siblings, 0 replies; 8+ messages in thread
From: Adam Borowski @ 2018-10-08 16:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Gleixner, Ingo Molnar, x86, linux-usb, linux-kernel
On Mon, Oct 08, 2018 at 03:19:44PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
> > A spanking new machine I just got has all but one USB ports wired as 3.0.
> > Booting defconfig resulted in no keyboard or mouse, which was pretty
> > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
> > As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
> >
> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> > ---
> > arch/x86/configs/x86_64_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> defconfig for x86 actually still works? That's amazing in itself :)
IIRC Gentoo even suggests it in the install instructions (although I
haven't looked at Gentoo in quite a while). Other distros have handcrafted
approximations of allmodconfig.
> > +CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_EHCI_HCD=y
> > CONFIG_USB_OHCI_HCD=y
>
> You can probably turn ehci and ohci off if you have xhci in the
> "default" system now.
Besides mixed wiring (as Alan and Randy mentioned), some machines without
USB3 are still usable. I haven't upgraded my home machine in ages -- yet
despite it being an ancient Phenom2 x6 it builds defconfig in 6m 13s while
this fresh work box in 3m something. Defconfig is supposed to handle a wide
range of common hardware, so keeping support for 2011 stuff would be wise.
As for !x86, I see that defconfigs for non-fringe archs already enable XHCI.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢰⠒⠀⣿⡁ 10 people enter a bar: 1 who understands binary,
⢿⡄⠘⠷⠚⠋⠀ 1 who doesn't, D who prefer to write it as hex,
⠈⠳⣄⠀⠀⠀⠀ and 1 who narrowly avoided an off-by-one error.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
2018-10-08 13:19 ` Greg Kroah-Hartman
2018-10-08 15:20 ` Alan Stern
2018-10-08 16:48 ` Adam Borowski
@ 2018-10-09 6:18 ` Ingo Molnar
2018-10-09 6:28 ` [PATCH v2] " Adam Borowski
2 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2018-10-09 6:18 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Adam Borowski, Thomas Gleixner, Ingo Molnar, x86, linux-usb,
linux-kernel
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
> > A spanking new machine I just got has all but one USB ports wired as 3.0.
> > Booting defconfig resulted in no keyboard or mouse, which was pretty
> > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
> > As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
> >
> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> > ---
> > arch/x86/configs/x86_64_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> defconfig for x86 actually still works? That's amazing in itself :)
Many of my test machines are able to boot the x86 defconfig bzImage to a shell,
so it's more like an "Ingo's minconfig". ;-)
/me tries to look innocently but fails miserably
> > diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> > index e32fc1f274d8..ac9ae487cfeb 100644
> > --- a/arch/x86/configs/x86_64_defconfig
> > +++ b/arch/x86/configs/x86_64_defconfig
> > @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
> > CONFIG_USB=y
> > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
> > CONFIG_USB_MON=y
> > +CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_EHCI_HCD=y
> > CONFIG_USB_EHCI_TT_NEWSCHED=y
> > CONFIG_USB_OHCI_HCD=y
>
> You can probably turn ehci and ohci off if you have xhci in the
> "default" system now.
Also, could we please refresh this in the 32-bit defconfig as well.
Other than that the patch looks good to me, no objections to adding
convenience options for people who have actually booted the thing
on reasonably common PC hardware.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] x86/defconfig: Enable CONFIG_USB_XHCI_HCD
2018-10-09 6:18 ` Ingo Molnar
@ 2018-10-09 6:28 ` Adam Borowski
2018-10-10 6:33 ` [tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y tip-bot for Adam Borowski
0 siblings, 1 reply; 8+ messages in thread
From: Adam Borowski @ 2018-10-09 6:28 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, x86, linux-usb, linux-kernel,
Greg Kroah-Hartman
Cc: Adam Borowski
A spanking new machine I just got has all but one USB ports wired as 3.0.
Booting defconfig resulted in no keyboard or mouse, which was pretty
uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
v2: also i386
Ingo Molnar said:
> Also, could we please refresh this in the 32-bit defconfig as well.
While real 32-bit machines are ancient, folks tend to test such kernels on
something modern, thus you have a good point. Changed.
arch/x86/configs/i386_defconfig | 1 +
arch/x86/configs/x86_64_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 0eb9f92f3717..6c3ab05c231d 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -247,6 +247,7 @@ CONFIG_USB_HIDDEV=y
CONFIG_USB=y
CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_MON=y
+CONFIG_USB_XHCI_HCD=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_OHCI_HCD=y
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index e32fc1f274d8..ac9ae487cfeb 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
CONFIG_USB=y
CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_MON=y
+CONFIG_USB_XHCI_HCD=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_OHCI_HCD=y
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [tip:x86/build] x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y
2018-10-09 6:28 ` [PATCH v2] " Adam Borowski
@ 2018-10-10 6:33 ` tip-bot for Adam Borowski
0 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Adam Borowski @ 2018-10-10 6:33 UTC (permalink / raw)
To: linux-tip-commits
Cc: torvalds, mingo, linux-kernel, kilobyte, peterz, hpa, tglx, gregkh
Commit-ID: 72a9c673636b779e370983fea08e40f97039b981
Gitweb: https://git.kernel.org/tip/72a9c673636b779e370983fea08e40f97039b981
Author: Adam Borowski <kilobyte@angband.pl>
AuthorDate: Tue, 9 Oct 2018 08:28:03 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 10 Oct 2018 08:29:51 +0200
x86/defconfig: Enable CONFIG_USB_XHCI_HCD=y
A spanking new machine I just got has all but one USB ports wired as 3.0.
Booting defconfig resulted in no keyboard or mouse, which was pretty
uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
Also add it to the 32-bit defconfig.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-usb@vger.kernel.org
Link: http://lkml.kernel.org/r/20181009062803.4332-1-kilobyte@angband.pl
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/configs/i386_defconfig | 1 +
arch/x86/configs/x86_64_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 0eb9f92f3717..6c3ab05c231d 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -247,6 +247,7 @@ CONFIG_USB_HIDDEV=y
CONFIG_USB=y
CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_MON=y
+CONFIG_USB_XHCI_HCD=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_OHCI_HCD=y
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index e32fc1f274d8..ac9ae487cfeb 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
CONFIG_USB=y
CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_MON=y
+CONFIG_USB_XHCI_HCD=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_OHCI_HCD=y
^ permalink raw reply related [flat|nested] 8+ messages in thread