From: Jeff Moyer <jmoyer@redhat.com>
To: "matthew r. wilcox" <matthew.r.wilcox@intel.com>, linda.knippers@hp.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: regression introduced by "block: Add support for DAX reads/writes to block devices"
Date: Wed, 05 Aug 2015 16:19:08 -0400 [thread overview]
Message-ID: <x49k2t9ij43.fsf@segfault.boston.devel.redhat.com> (raw)
Hi, Matthew,
Linda Knippers noticed that commit (bbab37ddc20b) breaks mkfs.xfs:
# mkfs -t xfs -f /dev/pmem0
meta-data=/dev/pmem0 isize=256 agcount=4, agsize=524288 blks
= sectsz=512 attr=2, projid32bit=1
= crc=0 finobt=0
data = bsize=4096 blocks=2097152, imaxpct=25
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0 ftype=0
log =internal log bsize=4096 blocks=2560, version=2
= sectsz=512 sunit=0 blks, lazy-count=1
realtime =none extsz=4096 blocks=0, rtextents=0
mkfs.xfs: read failed: Numerical result out of range
I sat down with Linda to look into it, and the problem is that mkfs.xfs
sets the blocksize of the device to 512 (via BLKBSZSET), and then reads
from the last sector of the device. This results in dax_io trying to do
a page-sized I/O at 512 bytes from the end of the device.
bdev_direct_access, receiving this bogus pos/size combo, returns
-ERANGE:
if ((sector + DIV_ROUND_UP(size, 512)) >
part_nr_sects_read(bdev->bd_part))
return -ERANGE;
Given that file systems supporting dax refuse to mount with a blocksize
!= page size, I'm guessing this is sort of expected behavior. However,
we really shouldn't be breaking direct I/O on pmem devices.
So, what do you want to do? We could make the pmem device's logical
block size fixed at the sytem page size. Or, we could modify the dax
code to work with blocksize < pagesize. Or, we could continue using the
direct I/O codepath for direct block device access. What do you think?
Thaks,
Jeff and Linda
next reply other threads:[~2015-08-05 20:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 20:19 Jeff Moyer [this message]
2015-08-05 22:01 ` regression introduced by "block: Add support for DAX reads/writes to block devices" Dave Chinner
2015-08-06 1:42 ` Linda Knippers
2015-08-06 3:24 ` Dave Chinner
2015-08-06 7:52 ` Boaz Harrosh
2015-08-06 20:34 ` Dave Chinner
2015-08-09 8:52 ` Boaz Harrosh
2015-08-10 16:32 ` Linda Knippers
2015-08-10 21:27 ` Dave Chinner
2015-08-10 23:04 ` Linda Knippers
2015-08-06 14:21 ` Wilcox, Matthew R
2015-08-06 15:33 ` Jeff Moyer
2015-08-06 15:51 ` Wilcox, Matthew R
2015-08-06 21:30 ` Jeff Moyer
2015-08-07 18:11 ` Wilcox, Matthew R
2015-08-07 20:41 ` Jeff Moyer
2015-08-10 7:42 ` Boaz Harrosh
2015-08-12 21:11 ` Jeff Moyer
2015-08-13 5:32 ` Boaz Harrosh
2015-08-13 14:00 ` Jeff Moyer
2015-08-13 16:42 ` Linda Knippers
2015-08-13 17:14 ` Jeff Moyer
2015-08-13 17:52 ` Linda Knippers
2015-08-13 18:19 ` Jeff Moyer
2015-08-13 19:32 ` Wilcox, Matthew R
2015-08-14 16:28 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49k2t9ij43.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=linda.knippers@hp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).