From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, x86@kernel.org,
Dmitrii Bundin <dmitrii.bundin.a@gmail.com>,
Fangrui Song <maskray@google.com>,
Alexey Alexandrov <aalexand@google.com>,
Bill Wendling <morbo@google.com>,
Greg Thelen <gthelen@google.com>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH v3 0/5] fix debug info for asm and DEBUG_INFO_SPLIT
Date: Tue, 6 Sep 2022 21:59:02 -0700 [thread overview]
Message-ID: <20220907045907.484043-1-ndesaulniers@google.com> (raw)
Alexey reported that the fraction of unknown filename instances in
kallsyms grew from ~0.3% to ~10% recently; Bill and Greg tracked it down
to assembler defined symbols, which regressed as a result of:
commit b8a9092330da ("Kbuild: do not emit debug info for assembly with LLVM_IAS=1")
In that commit, I allude to restoring debug info for assembler defined
symbols in a follow up patch, but it seems I forgot to do so in
commit a66049e2cf0e ("Kbuild: make DWARF version a choice")
Do so requires a fixup for as-option, which seems to be failing when
used in scripts/Makefile.debug.
Also includes a fix for DEBUG_INFO_SPLIT while I'm here. Dmitrii
reports that this has been broken since gcc-11+ & clang-12+. I'm
guessing no one uses this .config option...since no one else has
reported it being broken yet...
Changes from v2 -> v3:
* Pick up Nathan's Reviewed-by and Tested-by tags.
* Reword commit message 1/5 and 2/5 as per Nathan.
* Add Masahiro's Suggested-by tag where relevant.
* Use -x assembler-with-cpp -Werror in as-option and as-instr as per Masahiro.
* Fix AMDGPU compiler version check as per Nathan.
* Drop cc-min-version, as per Masahiro.
* Replace patch 4 with a variant of Masahiro's suggestion.
* Reword commit message 4/5.
Changes from v1 -> v2:
* 5 patches now, rather than 3.
* Split change to arch/x86/boot/compressed/Makefile off of first patch,
as per Masahiro.
* Introduce compiler specific macros, as per Bill, and eradicate
cc-ifversion while I'm at it.
* Update commit message of final patch to refer to 866ced950bcd.
v2: https://lore.kernel.org/llvm/20220831184408.2778264-1-ndesaulniers@google.com/
v1: https://lore.kernel.org/llvm/20220826181035.859042-1-ndesaulniers@google.com/
*** BLURB HERE ***
Nick Desaulniers (5):
x86/boot/compressed: prefer cc-option for CFLAGS additions
Makefile.compiler: Use KBUILD_AFLAGS for as-option
Makefile.compiler: replace cc-ifversion with compiler-specific macros
Makefile.debug: re-enable debug info for .S files
Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT
Documentation/kbuild/makefiles.rst | 29 ++++++++++++---------
Makefile | 6 ++---
arch/x86/boot/compressed/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +-
lib/Kconfig.debug | 4 ++-
scripts/Makefile.compiler | 18 ++++++++-----
scripts/Makefile.debug | 25 ++++++++----------
7 files changed, 46 insertions(+), 40 deletions(-)
--
2.37.2.789.g6183377224-goog
next reply other threads:[~2022-09-07 4:59 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 4:59 Nick Desaulniers [this message]
2022-09-07 4:59 ` [PATCH v3 1/5] x86/boot/compressed: prefer cc-option for CFLAGS additions Nick Desaulniers
2022-09-09 21:05 ` Masahiro Yamada
2022-09-07 4:59 ` [PATCH v3 2/5] Makefile.compiler: Use KBUILD_AFLAGS for as-option Nick Desaulniers
2022-09-09 21:06 ` Masahiro Yamada
2022-09-07 4:59 ` [PATCH v3 3/5] Makefile.compiler: replace cc-ifversion with compiler-specific macros Nick Desaulniers
2022-09-09 21:59 ` Masahiro Yamada
2022-09-07 4:59 ` [PATCH v3 4/5] Makefile.debug: re-enable debug info for .S files Nick Desaulniers
2022-09-07 4:59 ` [PATCH v3 5/5] Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT Nick Desaulniers
2022-09-09 20:56 ` Masahiro Yamada
2022-09-09 21:02 ` Masahiro Yamada
2022-09-19 17:08 ` [PATCH v4] Makefile.compiler: replace cc-ifversion with compiler-specific macros Nick Desaulniers
2022-09-23 19:44 ` Masahiro Yamada
2022-09-24 14:28 ` Masahiro Yamada
2022-09-25 1:22 ` Masahiro Yamada
2022-09-26 21:41 ` Nick Desaulniers
2023-04-27 11:53 ` Shreeya Patel
2023-04-28 7:41 ` Thorsten Leemhuis
2023-05-02 9:48 ` Shreeya Patel
2023-05-02 11:58 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-28 17:27 ` Nick Desaulniers
2023-05-03 21:02 ` Shreeya Patel
2023-05-03 21:15 ` Nick Desaulniers
2023-05-03 22:33 ` Shreeya Patel
2023-05-15 23:01 ` Nick Desaulniers
2023-05-17 8:34 ` Shreeya Patel
2023-05-17 15:39 ` Ricardo Cañuelo
2023-05-17 16:27 ` Nick Desaulniers
2023-05-18 14:23 ` Ricardo Cañuelo
2023-05-18 21:12 ` Nick Desaulniers
2023-05-19 8:35 ` Ricardo Cañuelo
2023-05-19 15:57 ` Nick Desaulniers
2023-05-22 10:09 ` Ricardo Cañuelo
2023-05-22 16:52 ` Greg KH
2023-05-22 19:52 ` Nick Desaulniers
2023-05-22 20:01 ` Greg KH
2023-05-22 20:16 ` Nick Desaulniers
2023-05-23 10:27 ` Shreeya Patel
2023-05-23 21:27 ` Nick Desaulniers
2023-06-12 10:10 ` Shreeya Patel
2023-06-20 4:19 ` Masahiro Yamada
2023-07-10 12:09 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-11 11:16 ` Shreeya Patel
2023-08-29 11:28 ` Linux regression tracking (Thorsten Leemhuis)
2023-09-11 10:05 ` Thorsten Leemhuis
2023-09-15 9:33 ` Shreeya Patel
2023-09-30 10:24 ` Masahiro Yamada
2022-09-19 17:30 ` [PATCH v4] Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT Nick Desaulniers
2022-09-24 1:34 ` Masahiro Yamada
2022-09-19 17:45 ` [PATCH v4] Makefile.debug: re-enable debug info for .S files Nick Desaulniers
2022-09-24 2:11 ` Masahiro Yamada
2022-09-24 2:20 ` Nick Desaulniers
2022-09-24 6:43 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907045907.484043-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=aalexand@google.com \
--cc=dmitrii.bundin.a@gmail.com \
--cc=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=michal.lkml@markovi.net \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=trix@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).