* [PATCH] ath: wil6210: Fix build error
@ 2013-07-21 2:46 Larry Finger
2013-07-21 7:06 ` Vladimir Kondratiev
0 siblings, 1 reply; 9+ messages in thread
From: Larry Finger @ 2013-07-21 2:46 UTC (permalink / raw)
To: linville
Cc: linux-wireless, Larry Finger, netdev, Vladimir Kondratiev,
wil6210, Stable, Thomas Fjellstrom
Building driver wil6210 in 3.10 and 3.11 kernels yields the following errors:
CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_print_ring':
drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
false);
^
In file included from include/linux/kernel.h:13:0,
from include/linux/cache.h:4,
from include/linux/time.h:4,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from drivers/net/wireless/ath/wil6210/debugfs.c:17:
include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
extern void hex_dump_to_buffer(const void *buf, size_t len,
^
drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_txdesc_debugfs_show':
drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
sizeof(printbuf), false);
^
In file included from include/linux/kernel.h:13:0,
from include/linux/cache.h:4,
from include/linux/time.h:4,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from drivers/net/wireless/ath/wil6210/debugfs.c:17:
include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
extern void hex_dump_to_buffer(const void *buf, size_t len,
^
cc1: all warnings being treated as errors
make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
These errors are fixed by changing the type of the buffer from "unsigned char *" to "char *".
Reported-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
Tested-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> [3.10]
Cc: Thomas Fjellstrom <thomas@fjellstrom.ca>
---
drivers/net/wireless/ath/wil6210/debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
index e8308ec..ab63676 100644
--- a/drivers/net/wireless/ath/wil6210/debugfs.c
+++ b/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -145,7 +145,7 @@ static void wil_print_ring(struct seq_file *s, const char *prefix,
le16_to_cpu(hdr.type), hdr.flags);
if (len <= MAX_MBOXITEM_SIZE) {
int n = 0;
- unsigned char printbuf[16 * 3 + 2];
+ char printbuf[16 * 3 + 2];
unsigned char databuf[MAX_MBOXITEM_SIZE];
void __iomem *src = wmi_buffer(wil, d.addr) +
sizeof(struct wil6210_mbox_hdr);
@@ -416,7 +416,7 @@ static int wil_txdesc_debugfs_show(struct seq_file *s, void *data)
seq_printf(s, " SKB = %p\n", skb);
if (skb) {
- unsigned char printbuf[16 * 3 + 2];
+ char printbuf[16 * 3 + 2];
int i = 0;
int len = le16_to_cpu(d->dma.length);
void *p = skb->data;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ath: wil6210: Fix build error
2013-07-21 2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
@ 2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
2013-07-22 16:17 ` Luis R. Rodriguez
0 siblings, 2 replies; 9+ messages in thread
From: Vladimir Kondratiev @ 2013-07-21 7:06 UTC (permalink / raw)
To: Larry Finger
Cc: linville, linux-wireless, netdev, wil6210, Stable, Thomas Fjellstrom
On Saturday, July 20, 2013 09:46:48 PM Larry Finger wrote:
> Building driver wil6210 in 3.10 and 3.11 kernels yields the following errors:
>
> CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
> drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_print_ring':
> drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
> false);
> ^
> In file included from include/linux/kernel.h:13:0,
> from include/linux/cache.h:4,
> from include/linux/time.h:4,
> from include/linux/stat.h:18,
> from include/linux/module.h:10,
> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
> extern void hex_dump_to_buffer(const void *buf, size_t len,
> ^
> drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_txdesc_debugfs_show':
> drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
> sizeof(printbuf), false);
> ^
> In file included from include/linux/kernel.h:13:0,
> from include/linux/cache.h:4,
> from include/linux/time.h:4,
> from include/linux/stat.h:18,
> from include/linux/module.h:10,
> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
> include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
> extern void hex_dump_to_buffer(const void *buf, size_t len,
> ^
> cc1: all warnings being treated as errors
> make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
> make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
> make[3]: *** [drivers/net/wireless/ath] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> These errors are fixed by changing the type of the buffer from "unsigned char *" to "char *".
>
> Reported-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
> Tested-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org> [3.10]
> Cc: Thomas Fjellstrom <thomas@fjellstrom.ca>
> ---
> drivers/net/wireless/ath/wil6210/debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
> index e8308ec..ab63676 100644
> --- a/drivers/net/wireless/ath/wil6210/debugfs.c
> +++ b/drivers/net/wireless/ath/wil6210/debugfs.c
> @@ -145,7 +145,7 @@ static void wil_print_ring(struct seq_file *s, const char *prefix,
> le16_to_cpu(hdr.type), hdr.flags);
> if (len <= MAX_MBOXITEM_SIZE) {
> int n = 0;
> - unsigned char printbuf[16 * 3 + 2];
> + char printbuf[16 * 3 + 2];
> unsigned char databuf[MAX_MBOXITEM_SIZE];
> void __iomem *src = wmi_buffer(wil, d.addr) +
> sizeof(struct wil6210_mbox_hdr);
> @@ -416,7 +416,7 @@ static int wil_txdesc_debugfs_show(struct seq_file *s, void *data)
> seq_printf(s, " SKB = %p\n", skb);
>
> if (skb) {
> - unsigned char printbuf[16 * 3 + 2];
> + char printbuf[16 * 3 + 2];
> int i = 0;
> int len = le16_to_cpu(d->dma.length);
> void *p = skb->data;
>
Hmm, I have no warning for this with neither 3.10 nor 3.11 kernel version; but
patch is correct, and here is my
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath: wil6210: Fix build error
2013-07-21 7:06 ` Vladimir Kondratiev
@ 2013-07-21 15:14 ` Larry Finger
[not found] ` <51EBFABB.8080701-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-07-22 16:17 ` Luis R. Rodriguez
1 sibling, 1 reply; 9+ messages in thread
From: Larry Finger @ 2013-07-21 15:14 UTC (permalink / raw)
To: Vladimir Kondratiev
Cc: linville, linux-wireless, netdev, wil6210, Stable, Thomas Fjellstrom
On 07/21/2013 02:06 AM, Vladimir Kondratiev wrote:
> On Saturday, July 20, 2013 09:46:48 PM Larry Finger wrote:
>> Building driver wil6210 in 3.10 and 3.11 kernels yields the following errors:
>>
>> CC [M] drivers/net/wireless/ath/wil6210/debugfs.o
>> drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_print_ring':
>> drivers/net/wireless/ath/wil6210/debugfs.c:163:11: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
>> false);
>> ^
>> In file included from include/linux/kernel.h:13:0,
>> from include/linux/cache.h:4,
>> from include/linux/time.h:4,
>> from include/linux/stat.h:18,
>> from include/linux/module.h:10,
>> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
>> include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
>> extern void hex_dump_to_buffer(const void *buf, size_t len,
>> ^
>> drivers/net/wireless/ath/wil6210/debugfs.c: In function 'wil_txdesc_debugfs_show':
>> drivers/net/wireless/ath/wil6210/debugfs.c:429:10: error: pointer targets in passing argument 5 of 'hex_dump_to_buffer' differ in signedness [-Werror=pointer-sign]
>> sizeof(printbuf), false);
>> ^
>> In file included from include/linux/kernel.h:13:0,
>> from include/linux/cache.h:4,
>> from include/linux/time.h:4,
>> from include/linux/stat.h:18,
>> from include/linux/module.h:10,
>> from drivers/net/wireless/ath/wil6210/debugfs.c:17:
>> include/linux/printk.h:361:13: note: expected 'char *' but argument is of type 'unsigned char *'
>> extern void hex_dump_to_buffer(const void *buf, size_t len,
>> ^
>> cc1: all warnings being treated as errors
>> make[5]: *** [drivers/net/wireless/ath/wil6210/debugfs.o] Error 1
>> make[4]: *** [drivers/net/wireless/ath/wil6210] Error 2
>> make[3]: *** [drivers/net/wireless/ath] Error 2
>> make[2]: *** [drivers/net/wireless] Error 2
>> make[1]: *** [drivers/net] Error 2
>> make: *** [drivers] Error 2
>>
>> These errors are fixed by changing the type of the buffer from "unsigned char *" to "char *".
>>
>> Reported-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
>> Tested-by: Thomas Fjellstrom <thomas@fjellstrom.ca>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org> [3.10]
>> Cc: Thomas Fjellstrom <thomas@fjellstrom.ca>
>> ---
>> drivers/net/wireless/ath/wil6210/debugfs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
>> index e8308ec..ab63676 100644
>> --- a/drivers/net/wireless/ath/wil6210/debugfs.c
>> +++ b/drivers/net/wireless/ath/wil6210/debugfs.c
>> @@ -145,7 +145,7 @@ static void wil_print_ring(struct seq_file *s, const char *prefix,
>> le16_to_cpu(hdr.type), hdr.flags);
>> if (len <= MAX_MBOXITEM_SIZE) {
>> int n = 0;
>> - unsigned char printbuf[16 * 3 + 2];
>> + char printbuf[16 * 3 + 2];
>> unsigned char databuf[MAX_MBOXITEM_SIZE];
>> void __iomem *src = wmi_buffer(wil, d.addr) +
>> sizeof(struct wil6210_mbox_hdr);
>> @@ -416,7 +416,7 @@ static int wil_txdesc_debugfs_show(struct seq_file *s, void *data)
>> seq_printf(s, " SKB = %p\n", skb);
>>
>> if (skb) {
>> - unsigned char printbuf[16 * 3 + 2];
>> + char printbuf[16 * 3 + 2];
>> int i = 0;
>> int len = le16_to_cpu(d->dma.length);
>> void *p = skb->data;
>>
> Hmm, I have no warning for this with neither 3.10 nor 3.11 kernel version; but
> patch is correct, and here is my
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Thanks. I did not see any warning or error either; however, it did happen for
Thomas. I'm not sure what combination of compiler version and/or switches lead
to the problem, but his system apparently uses them.
Larry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath: wil6210: Fix build error
2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
@ 2013-07-22 16:17 ` Luis R. Rodriguez
1 sibling, 0 replies; 9+ messages in thread
From: Luis R. Rodriguez @ 2013-07-22 16:17 UTC (permalink / raw)
To: Vladimir Kondratiev
Cc: Larry Finger, linville, linux-wireless, netdev, wil6210, Stable,
Thomas Fjellstrom
On Sun, Jul 21, 2013 at 10:06:31AM +0300, Vladimir Kondratiev wrote:
> Hmm, I have no warning for this with neither 3.10 nor 3.11 kernel version; but
> patch is correct, and here is my
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
If you agree with a patch you don't say you Sign-off-by it as well,
you say Acked-by. The Signed-off-by tag has a very specific meaning
from development to a maintainer's hands, and its definition is on
the Developer Certificate or Origin.
So in this case Acked-by is better.
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-07-22 16:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-21 2:46 [PATCH] ath: wil6210: Fix build error Larry Finger
2013-07-21 7:06 ` Vladimir Kondratiev
2013-07-21 15:14 ` Larry Finger
[not found] ` <51EBFABB.8080701-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-07-21 15:35 ` Thomas Fjellstrom
2013-07-21 15:52 ` Vladimir Kondratiev
2013-07-21 16:55 ` Kalle Valo
2013-07-22 1:45 ` Ben Hutchings
2013-07-22 9:56 ` Vladimir Kondratiev
2013-07-22 16:17 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).