netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Wu <lekensteyn@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: r8169: remove "PHY reset until link up" log spam
Date: Tue, 23 Jul 2013 22:59:18 +0200	[thread overview]
Message-ID: <1419387.TRpCvQXgeS@al> (raw)
In-Reply-To: <20130723202340.GB31567@electric-eye.fr.zoreil.com>

On Tuesday 23 July 2013 22:23:40 Francois Romieu wrote:
> Peter Wu <lekensteyn@gmail.com> :
> [...]
> 
> > Which user wants to get log spam every ten seconds ?
> 
> In my world users - be they big workstations or runtime pm enabled
> laptops - may not even care about log [1].
So I am not a real user either because I keep journalctl open / tailf log 
files? I see what you are trying to note, but I doubt the usefulness of this 
specific message. This message appears if:
 (1) The device has just been brought up.
 (2) Has not been connected before while being up.
 (3) Is enabled all the time (runtime PM?)
 (4) No reset it pending.

Only the last point cannot easily be determine from a log context, but these 
do not seem to appear on recent devices? (I've never experienced link issues 
with Realtek Ethernet cards, wireless is another thing)

> > This message was added almost ten years ago, Realtek must
> > certainly have improved their hardware not to be so crappy ?
> 
> With due respect to Realtek, git log or Realtek's own Release.txt file
> do not exactly paint the world as a faery of unicorns.
Or even using the file header as revision log... anyway, you cannot make money 
by selling just crap right? There is enough competition on this market.

Regards,
Peter

  reply	other threads:[~2013-07-23 20:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:55 Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38   ` [PATCH v2] " Peter Wu
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:48       ` Peter Wu
2013-07-23 21:50         ` Francois Romieu
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07   ` Peter Wu
2013-07-23 16:17     ` Stephen Hemminger
2013-07-23 21:18       ` Stephen Hemminger
2013-07-23 20:23     ` Francois Romieu
2013-07-23 20:59       ` Peter Wu [this message]
2013-07-23 21:51         ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419387.TRpCvQXgeS@al \
    --to=lekensteyn@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    --cc=stephen@networkplumber.org \
    --subject='Re: r8169: remove "PHY reset until link up" log spam' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).