* [PATCH v2] vxlan: remove the dead codes
@ 2014-10-17 6:04 roy.qing.li
2014-10-17 17:33 ` Cong Wang
0 siblings, 1 reply; 4+ messages in thread
From: roy.qing.li @ 2014-10-17 6:04 UTC (permalink / raw)
To: netdev
From: Li RongQing <roy.qing.li@gmail.com>
remove the dead codes, no user uses vxlan_salt
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
drivers/net/vxlan.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 77ab844..855a81d 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -152,8 +152,6 @@ struct vxlan_dev {
struct hlist_head fdb_head[FDB_HASH_SIZE];
};
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;
static struct workqueue_struct *vxlan_wq;
static void vxlan_sock_work(struct work_struct *work);
@@ -2797,8 +2795,6 @@ static int __init vxlan_init_module(void)
if (!vxlan_wq)
return -ENOMEM;
- get_random_bytes(&vxlan_salt, sizeof(vxlan_salt));
-
rc = register_pernet_subsys(&vxlan_net_ops);
if (rc)
goto out1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] vxlan: remove the dead codes
2014-10-17 6:04 [PATCH v2] vxlan: remove the dead codes roy.qing.li
@ 2014-10-17 17:33 ` Cong Wang
2014-10-17 20:24 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2014-10-17 17:33 UTC (permalink / raw)
To: Li RongQing; +Cc: netdev, Stephen Hemminger
On Thu, Oct 16, 2014 at 11:04 PM, <roy.qing.li@gmail.com> wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> remove the dead codes, no user uses vxlan_salt
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
> drivers/net/vxlan.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 77ab844..855a81d 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -152,8 +152,6 @@ struct vxlan_dev {
> struct hlist_head fdb_head[FDB_HASH_SIZE];
> };
>
> -/* salt for hash table */
> -static u32 vxlan_salt __read_mostly;
Hmm, it has never been used since it was born. Maybe we should
really use for vxlan hash table?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] vxlan: remove the dead codes
2014-10-17 17:33 ` Cong Wang
@ 2014-10-17 20:24 ` David Miller
2014-10-18 9:20 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2014-10-17 20:24 UTC (permalink / raw)
To: cwang; +Cc: roy.qing.li, netdev, stephen
From: Cong Wang <cwang@twopensource.com>
Date: Fri, 17 Oct 2014 10:33:08 -0700
> On Thu, Oct 16, 2014 at 11:04 PM, <roy.qing.li@gmail.com> wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> remove the dead codes, no user uses vxlan_salt
>>
>> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
>> ---
>> drivers/net/vxlan.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index 77ab844..855a81d 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/drivers/net/vxlan.c
>> @@ -152,8 +152,6 @@ struct vxlan_dev {
>> struct hlist_head fdb_head[FDB_HASH_SIZE];
>> };
>>
>> -/* salt for hash table */
>> -static u32 vxlan_salt __read_mostly;
>
> Hmm, it has never been used since it was born. Maybe we should
> really use for vxlan hash table?
Yes, agreed, and I am very sure that this was Stephen Hemminger's
original intention.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] vxlan: remove the dead codes
2014-10-17 20:24 ` David Miller
@ 2014-10-18 9:20 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2014-10-18 9:20 UTC (permalink / raw)
To: David Miller; +Cc: cwang, roy.qing.li, netdev
On Fri, 17 Oct 2014 16:24:49 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Cong Wang <cwang@twopensource.com>
> Date: Fri, 17 Oct 2014 10:33:08 -0700
>
> > On Thu, Oct 16, 2014 at 11:04 PM, <roy.qing.li@gmail.com> wrote:
> >> From: Li RongQing <roy.qing.li@gmail.com>
> >>
> >> remove the dead codes, no user uses vxlan_salt
> >>
> >> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> >> ---
> >> drivers/net/vxlan.c | 4 ----
> >> 1 file changed, 4 deletions(-)
> >>
> >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> >> index 77ab844..855a81d 100644
> >> --- a/drivers/net/vxlan.c
> >> +++ b/drivers/net/vxlan.c
> >> @@ -152,8 +152,6 @@ struct vxlan_dev {
> >> struct hlist_head fdb_head[FDB_HASH_SIZE];
> >> };
> >>
> >> -/* salt for hash table */
> >> -static u32 vxlan_salt __read_mostly;
> >
> > Hmm, it has never been used since it was born. Maybe we should
> > really use for vxlan hash table?
>
> Yes, agreed, and I am very sure that this was Stephen Hemminger's
> original intention.
yes. never did rekeying, and it would have been hard.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-18 9:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-17 6:04 [PATCH v2] vxlan: remove the dead codes roy.qing.li
2014-10-17 17:33 ` Cong Wang
2014-10-17 20:24 ` David Miller
2014-10-18 9:20 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).