From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: jiri@resnulli.us, netdev@vger.kernel.org, j.vosburgh@gmail.com,
vfalico@gmail.com, gospo@cumulusnetworks.com
Subject: Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface
Date: Sun, 17 May 2015 22:44:02 -0400 (EDT) [thread overview]
Message-ID: <20150517.224402.701978872263069371.davem@davemloft.net> (raw)
In-Reply-To: <1431519582-4219-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 13 May 2015 14:19:42 +0200
> Before the patch, the command 'ip link add bond2 type bond mode 802.3ad'
> causes the kernel to send a rtnl message for the bond2 interface, with an
> ifindex 0.
>
> 'ip monitor' shows:
> 0: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 state DOWN group default
> link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
> 9: bond2@NONE: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default
> link/ether ea:3e:1f:53:92:7b brd ff:ff:ff:ff:ff:ff
> [snip]
>
> The patch fixes the spotted bug by checking in bond driver if the interface
> is registered before calling the notifier chain.
> It also adds a check in rtmsg_ifinfo() to prevent this kind of bug in the
> future.
>
> Fixes: d4261e565000 ("bonding: create netlink event when bonding option is changed")
> CC: Jiri Pirko <jiri@resnulli.us>
> Reported-by: Julien Meunier <julien.meunier@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied and queued up for -stable, thanks Nicolas.
next prev parent reply other threads:[~2015-05-18 2:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:25 [PATCH net] rtnl: don't send rtnl msg for unregistered iface Nicolas Dichtel
2015-05-11 15:37 ` Jiri Pirko
2015-05-11 16:04 ` Nicolas Dichtel
2015-05-11 16:15 ` Nicolas Dichtel
2015-05-11 17:53 ` Jiri Pirko
2015-05-11 22:15 ` Andy Gospodarek
2015-05-12 8:43 ` Nicolas Dichtel
2015-05-12 15:03 ` [PATCH net v2] rtnl/bond: " Nicolas Dichtel
2015-05-12 15:06 ` Nicolas Dichtel
2015-05-12 15:17 ` [PATCH net v3] " Nicolas Dichtel
2015-05-12 15:58 ` Jiri Pirko
2015-05-12 16:10 ` Nicolas Dichtel
2015-05-12 16:14 ` Jiri Pirko
2015-05-13 12:19 ` [PATCH net v4] " Nicolas Dichtel
2015-05-13 12:24 ` Jiri Pirko
2015-05-13 12:36 ` Nicolas Dichtel
2015-05-18 2:44 ` David Miller [this message]
2015-07-13 14:11 ` Kristian Evensen
2015-07-15 15:07 ` Nicolas Dichtel
2015-07-16 9:06 ` Nicolas Dichtel
2015-07-16 9:31 ` [PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces Nicolas Dichtel
2015-05-12 17:12 ` [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface Andy Gospodarek
2015-05-13 12:01 ` Nicolas Dichtel
2015-05-13 14:43 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517.224402.701978872263069371.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).