netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: jiri@resnulli.us
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	j.vosburgh@gmail.com, vfalico@gmail.com,
	gospo@cumulusnetworks.com
Subject: Re: [PATCH net v2] rtnl/bond: don't send rtnl msg for unregistered iface
Date: Tue, 12 May 2015 17:06:02 +0200	[thread overview]
Message-ID: <555216DA.3020105@6wind.com> (raw)
In-Reply-To: <1431443035-4265-1-git-send-email-nicolas.dichtel@6wind.com>

Le 12/05/2015 17:03, Nicolas Dichtel a écrit :
[snip]
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -3273,7 +3273,8 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
>   	case NETDEV_BONDING_INFO:
>   		break;
>   	default:
> -		rtmsg_ifinfo(RTM_NEWLINK, dev, 0, GFP_KERNEL);
> +		if (dev->reg_state == NETREG_REGISTERED)
> +			rtmsg_ifinfo(RTM_NEWLINK, dev, 0, GFP_KERNEL);
In fact, it's probably better to put this in rtmsg_ifinfo().
Will send a v3, sorry for the noise.

  reply	other threads:[~2015-05-12 15:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 14:25 [PATCH net] rtnl: don't send rtnl msg for unregistered iface Nicolas Dichtel
2015-05-11 15:37 ` Jiri Pirko
2015-05-11 16:04   ` Nicolas Dichtel
2015-05-11 16:15     ` Nicolas Dichtel
2015-05-11 17:53       ` Jiri Pirko
2015-05-11 22:15         ` Andy Gospodarek
2015-05-12  8:43         ` Nicolas Dichtel
2015-05-12 15:03         ` [PATCH net v2] rtnl/bond: " Nicolas Dichtel
2015-05-12 15:06           ` Nicolas Dichtel [this message]
2015-05-12 15:17             ` [PATCH net v3] " Nicolas Dichtel
2015-05-12 15:58               ` Jiri Pirko
2015-05-12 16:10                 ` Nicolas Dichtel
2015-05-12 16:14                   ` Jiri Pirko
2015-05-13 12:19                     ` [PATCH net v4] " Nicolas Dichtel
2015-05-13 12:24                       ` Jiri Pirko
2015-05-13 12:36                         ` Nicolas Dichtel
2015-05-18  2:44                       ` David Miller
2015-07-13 14:11                       ` Kristian Evensen
2015-07-15 15:07                         ` Nicolas Dichtel
2015-07-16  9:06                         ` Nicolas Dichtel
2015-07-16  9:31                           ` [PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces Nicolas Dichtel
2015-05-12 17:12                 ` [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface Andy Gospodarek
2015-05-13 12:01                   ` Nicolas Dichtel
2015-05-13 14:43                     ` Andy Gospodarek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555216DA.3020105@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=gospo@cumulusnetworks.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).