* [RFC iproute2] ip route: get: allow zero-length subnet mask
@ 2019-02-13 20:09 Luca Boccassi
2019-02-13 20:37 ` Stephen Hemminger
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
0 siblings, 2 replies; 4+ messages in thread
From: Luca Boccassi @ 2019-02-13 20:09 UTC (permalink / raw)
To: netdev; +Cc: stephen, Luca Boccassi, Clément Hertling
A /0 subnet mask is theoretically valid, but ip route get doesn't allow
it:
$ ip route get 1.0.0.0/0
need at least a destination address
Remove the check so that it can go through:
$ ip/ip route get 1.0.0.0/0
1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
cache
Reported-by: Clément Hertling <wxcafe@wxcafe.net>
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
Stephen et al, this was reported by a Debian user:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737
It makes sense to me at a cursory glance, but sending as RFC as I'm
not 100% familiar with the route get function.
ip/iproute.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index 5f58a3b3..d78f43d8 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -2041,11 +2041,6 @@ static int iproute_get(int argc, char **argv)
argc--; argv++;
}
- if (req.r.rtm_dst_len == 0) {
- fprintf(stderr, "need at least a destination address\n");
- return -1;
- }
-
if (idev || odev) {
int idx;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC iproute2] ip route: get: allow zero-length subnet mask
2019-02-13 20:09 [RFC iproute2] ip route: get: allow zero-length subnet mask Luca Boccassi
@ 2019-02-13 20:37 ` Stephen Hemminger
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-02-13 20:37 UTC (permalink / raw)
To: Luca Boccassi; +Cc: netdev, Clément Hertling
On Wed, 13 Feb 2019 20:09:53 +0000
Luca Boccassi <bluca@debian.org> wrote:
> A /0 subnet mask is theoretically valid, but ip route get doesn't allow
> it:
>
> $ ip route get 1.0.0.0/0
> need at least a destination address
>
> Remove the check so that it can go through:
>
> $ ip/ip route get 1.0.0.0/0
> 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
> cache
>
> Reported-by: Clément Hertling <wxcafe@wxcafe.net>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> Stephen et al, this was reported by a Debian user:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737
>
> It makes sense to me at a cursory glance, but sending as RFC as I'm
> not 100% familiar with the route get function.
>
> ip/iproute.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 5f58a3b3..d78f43d8 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -2041,11 +2041,6 @@ static int iproute_get(int argc, char **argv)
> argc--; argv++;
> }
>
> - if (req.r.rtm_dst_len == 0) {
> - fprintf(stderr, "need at least a destination address\n");
> - return -1;
> - }
> -
> if (idev || odev) {
> int idx;
>
You still need a way to report error for:
ip route get
(i.e when no address is present)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC iproute2 v2] ip route: get: allow zero-length subnet mask
2019-02-13 20:09 [RFC iproute2] ip route: get: allow zero-length subnet mask Luca Boccassi
2019-02-13 20:37 ` Stephen Hemminger
@ 2019-02-14 23:29 ` Luca Boccassi
2019-02-19 23:22 ` Stephen Hemminger
1 sibling, 1 reply; 4+ messages in thread
From: Luca Boccassi @ 2019-02-14 23:29 UTC (permalink / raw)
To: netdev; +Cc: stephen, Luca Boccassi, Clément Hertling
A /0 subnet mask is theoretically valid, but ip route get doesn't allow
it:
$ ip route get 1.0.0.0/0
need at least a destination address
Change the check and remember whether we found an address or not, since
according to the documentation it's a mandatory parameter.
$ ip/ip route get 1.0.0.0/0
1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
cache
Reported-by: Clément Hertling <wxcafe@wxcafe.net>
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v2: changed the check instead of removing it, so that "ip route get"
fails since the address is a mandatory parameter according to the
manpage.
ip/iproute.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index 5f58a3b3..cc02a3e1 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -1932,6 +1932,7 @@ static int iproute_get(int argc, char **argv)
int fib_match = 0;
int from_ok = 0;
unsigned int mark = 0;
+ bool address_found = false;
iproute_reset_filter(0);
filter.cloned = 2;
@@ -2037,11 +2038,12 @@ static int iproute_get(int argc, char **argv)
addattr_l(&req.n, sizeof(req),
RTA_DST, &addr.data, addr.bytelen);
req.r.rtm_dst_len = addr.bitlen;
+ address_found = true;
}
argc--; argv++;
}
- if (req.r.rtm_dst_len == 0) {
+ if (!address_found) {
fprintf(stderr, "need at least a destination address\n");
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC iproute2 v2] ip route: get: allow zero-length subnet mask
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
@ 2019-02-19 23:22 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-02-19 23:22 UTC (permalink / raw)
To: Luca Boccassi; +Cc: netdev, Clément Hertling
On Thu, 14 Feb 2019 23:29:18 +0000
Luca Boccassi <bluca@debian.org> wrote:
> A /0 subnet mask is theoretically valid, but ip route get doesn't allow
> it:
>
> $ ip route get 1.0.0.0/0
> need at least a destination address
>
> Change the check and remember whether we found an address or not, since
> according to the documentation it's a mandatory parameter.
>
> $ ip/ip route get 1.0.0.0/0
> 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
> cache
>
> Reported-by: Clément Hertling <wxcafe@wxcafe.net>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-19 23:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 20:09 [RFC iproute2] ip route: get: allow zero-length subnet mask Luca Boccassi
2019-02-13 20:37 ` Stephen Hemminger
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
2019-02-19 23:22 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).