From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, oss-drivers@netronome.com,
netdev@vger.kernel.org, parav@mellanox.com, jgg@mellanox.com
Subject: Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports
Date: Fri, 1 Mar 2019 08:04:01 -0800 [thread overview]
Message-ID: <20190301080401.1b860467@cakuba.netronome.com> (raw)
In-Reply-To: <20190301072557.GG2314@nanopsycho>
On Fri, 1 Mar 2019 08:25:57 +0100, Jiri Pirko wrote:
> >> I think it would be beneficial to have the switchid shown for devlink
> >> ports too. Then it is clean that the devlink ports with the same
> >> switchid belong to the same switch, and other ports under the same
> >> devlink instance (like PF itself) is separate, but still under the same
> >> ASIC.
> >
> >Sure, you mean in terms of UI - user space can do a link dump or get
> >that from sysfs, right?
>
> I thinking about moving it to devlink. I'll work on it more today.
At the kernel level? Are we sure this is appropriate? I'd think
switchid is in essence a forwarding attribute, so it belongs with
netdevs, no?
next prev parent reply other threads:[~2019-03-01 16:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 18:24 [PATCH net-next 0/8] devlink: add PF and VF port flavours Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 1/8] nfp: split devlink port init from registration Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 2/8] devlink: add PF and VF port flavours Jakub Kicinski
2019-02-27 12:16 ` Jiri Pirko
2019-03-04 4:59 ` Parav Pandit
2019-03-04 7:30 ` Jiri Pirko
2019-03-20 17:29 ` Abodunrin, Akeem G
2019-03-21 12:26 ` Jiri Pirko
2019-02-27 12:23 ` Jiri Pirko
2019-02-27 12:41 ` Jiri Pirko
2019-02-27 17:23 ` Jakub Kicinski
2019-02-27 20:17 ` Jiri Pirko
2019-02-27 22:42 ` Jakub Kicinski
2019-02-28 8:44 ` Jiri Pirko
2019-02-28 16:08 ` Jakub Kicinski
2019-02-28 16:24 ` David Ahern
2019-02-26 18:24 ` [PATCH net-next 3/8] nfp: register devlink ports of all reprs Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports Jakub Kicinski
2019-02-27 12:37 ` Jiri Pirko
2019-02-27 18:30 ` Jakub Kicinski
2019-02-28 8:56 ` Jiri Pirko
2019-02-28 13:32 ` Jiri Pirko
2019-02-28 16:24 ` Jakub Kicinski
2019-03-01 7:25 ` Jiri Pirko
2019-03-01 16:04 ` Jakub Kicinski [this message]
2019-03-01 16:20 ` Jiri Pirko
2019-03-04 16:15 ` Jason Gunthorpe
2019-03-05 1:03 ` Jakub Kicinski
2019-03-05 1:30 ` Jason Gunthorpe
2019-03-05 2:11 ` Jakub Kicinski
2019-03-05 22:11 ` Jason Gunthorpe
2019-03-04 5:00 ` Parav Pandit
2019-02-26 18:24 ` [PATCH net-next 5/8] nfp: switch to devlink_port_get_phys_port_name() Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 6/8] devlink: introduce port's peer netdevs Jakub Kicinski
2019-02-27 13:08 ` Jiri Pirko
2019-02-27 18:47 ` Jakub Kicinski
2019-02-28 9:00 ` Jiri Pirko
2019-02-28 16:36 ` Jakub Kicinski
2019-03-01 7:37 ` Jiri Pirko
2019-03-01 16:05 ` Jakub Kicinski
2019-03-04 5:07 ` Parav Pandit
2019-02-26 18:24 ` [PATCH net-next 7/8] nfp: expose PF " Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 8/8] devlink: fix kdoc Jakub Kicinski
2019-02-27 13:13 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301080401.1b860467@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jgg@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).