From: Jiri Pirko <jiri@resnulli.us>
To: "Abodunrin, Akeem G" <akeem.g.abodunrin@intel.com>
Cc: Parav Pandit <parav@mellanox.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"oss-drivers@netronome.com" <oss-drivers@netronome.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/8] devlink: add PF and VF port flavours
Date: Thu, 21 Mar 2019 13:26:39 +0100 [thread overview]
Message-ID: <20190321122639.GE2087@nanopsycho> (raw)
In-Reply-To: <CFEEE81102D91947B9CC368106979EBABC6D684E@ORSMSX105.amr.corp.intel.com>
Wed, Mar 20, 2019 at 06:29:44PM CET, akeem.g.abodunrin@intel.com wrote:
>
>
>> -----Original Message-----
>> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
>> On Behalf Of Jiri Pirko
>> Sent: Sunday, March 03, 2019 11:30 PM
>> To: Parav Pandit <parav@mellanox.com>
>> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>; davem@davemloft.net;
>> oss-drivers@netronome.com; netdev@vger.kernel.org
>> Subject: Re: [PATCH net-next 2/8] devlink: add PF and VF port flavours
>>
>> Mon, Mar 04, 2019 at 05:59:04AM CET, parav@mellanox.com wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
>> >> Behalf Of Jiri Pirko
>> >> Sent: Wednesday, February 27, 2019 6:17 AM
>> >> To: Jakub Kicinski <jakub.kicinski@netronome.com>
>> >> Cc: davem@davemloft.net; oss-drivers@netronome.com;
>> >> netdev@vger.kernel.org
>> >> Subject: Re: [PATCH net-next 2/8] devlink: add PF and VF port
>> >> flavours
>> >>
>> >> Tue, Feb 26, 2019 at 07:24:30PM CET, jakub.kicinski@netronome.com wrote:
>> >> >Current port flavours cover simple switches and DSA. Add PF and VF
>> >> >flavours to cover "switchdev" SR-IOV NICs.
>> >> >
>> >> >Example devlink user space output:
>> >> >
>> >> >$ devlink port
>> >> >pci/0000:82:00.0/0: type eth netdev p4p1 flavour physical
>> >> >pci/0000:82:00.0/10000: type eth netdev eth0 flavour pcie_pf pf 0
>> >> >pci/0000:82:00.0/10001: type eth netdev eth1 flavour pcie_vf pf 0 vf
>> >> >0
>> >> >pci/0000:82:00.0/10002: type eth netdev eth2 flavour pcie_vf pf 0 vf
>> >> >1
>> >>
>> >A given port is of its parent device.
>> >In current scenario, its PF or VF.
>> >Hence it should be device attribute and not a port attribute.
>>
>> I think that this works. You have VF_rep ports, PF_rep ports and PHYSICAL ports.
>> In mlxsw for example, there are only PHYSICAL ports.
>> In sr-iov world, there is also a PHYSICAL port on the eswitch. The others are
>> either facing PF of VF. Looks accurate. I don't see any need for "devlink dev"
>> flavour.
>
>I see what you're trying to do here, with VF_rep ports being independent of PF_rep ports and PHYSICAL ports - however, my question is how do you categorize VF_rep ports of the same parent PF physical ports (say you have multi-port device, with 2 or more PFs), at least for identification purposes per physical port? Do we need to have pci_vf_number appended to physical port number?
Please wrap your messages at 80 cols.
>
>Thanks,
>~Akeem
>>
>>
>> >So devlink dev show command have to show what device flavour is.
>> >Is it well known PCI VF or PF or something else.
>> >It will show subdev device attribute and its parent PCI (PF/VF) devlink device.
>> >So we should have device flovour as PCI_PF or PCI_VF or SUBDEV.
>> >
>> >Again VF number showcasing here is very restrictive model.
>> >Every PF/VF/Subdev represents its own 'port' and it is connected to eswitch
>> 'port'.
>> >Instead of showing VF here, it must be this 'port' or 'link' number that gives
>> right view.
>> >Which netdev represents which VF is already linked in the VF rep-netdev sysfs
>> property.
>>
>> I think you confuse the eswtich ports (in Jakub's output it's them) and the actual
>> VF.
>>
>>
>> >
>> >So flavour should be something like 'hostport' and when port is registered for
>> the eswitch side it should be 'switchport'.
>> >With this there is very clear picture of which hostport is connected to which
>> eswitch port.
>> >Just like how we see in the physical world.
>> >
next prev parent reply other threads:[~2019-03-21 12:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 18:24 [PATCH net-next 0/8] devlink: add PF and VF port flavours Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 1/8] nfp: split devlink port init from registration Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 2/8] devlink: add PF and VF port flavours Jakub Kicinski
2019-02-27 12:16 ` Jiri Pirko
2019-03-04 4:59 ` Parav Pandit
2019-03-04 7:30 ` Jiri Pirko
2019-03-20 17:29 ` Abodunrin, Akeem G
2019-03-21 12:26 ` Jiri Pirko [this message]
2019-02-27 12:23 ` Jiri Pirko
2019-02-27 12:41 ` Jiri Pirko
2019-02-27 17:23 ` Jakub Kicinski
2019-02-27 20:17 ` Jiri Pirko
2019-02-27 22:42 ` Jakub Kicinski
2019-02-28 8:44 ` Jiri Pirko
2019-02-28 16:08 ` Jakub Kicinski
2019-02-28 16:24 ` David Ahern
2019-02-26 18:24 ` [PATCH net-next 3/8] nfp: register devlink ports of all reprs Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports Jakub Kicinski
2019-02-27 12:37 ` Jiri Pirko
2019-02-27 18:30 ` Jakub Kicinski
2019-02-28 8:56 ` Jiri Pirko
2019-02-28 13:32 ` Jiri Pirko
2019-02-28 16:24 ` Jakub Kicinski
2019-03-01 7:25 ` Jiri Pirko
2019-03-01 16:04 ` Jakub Kicinski
2019-03-01 16:20 ` Jiri Pirko
2019-03-04 16:15 ` Jason Gunthorpe
2019-03-05 1:03 ` Jakub Kicinski
2019-03-05 1:30 ` Jason Gunthorpe
2019-03-05 2:11 ` Jakub Kicinski
2019-03-05 22:11 ` Jason Gunthorpe
2019-03-04 5:00 ` Parav Pandit
2019-02-26 18:24 ` [PATCH net-next 5/8] nfp: switch to devlink_port_get_phys_port_name() Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 6/8] devlink: introduce port's peer netdevs Jakub Kicinski
2019-02-27 13:08 ` Jiri Pirko
2019-02-27 18:47 ` Jakub Kicinski
2019-02-28 9:00 ` Jiri Pirko
2019-02-28 16:36 ` Jakub Kicinski
2019-03-01 7:37 ` Jiri Pirko
2019-03-01 16:05 ` Jakub Kicinski
2019-03-04 5:07 ` Parav Pandit
2019-02-26 18:24 ` [PATCH net-next 7/8] nfp: expose PF " Jakub Kicinski
2019-02-26 18:24 ` [PATCH net-next 8/8] devlink: fix kdoc Jakub Kicinski
2019-02-27 13:13 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321122639.GE2087@nanopsycho \
--to=jiri@resnulli.us \
--cc=akeem.g.abodunrin@intel.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).