From: Hangbin Liu <liuhangbin@gmail.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: "David Ahern" <dsahern@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Yaro Slav" <yaro330@gmail.com>,
"Thomas Haller" <thaller@redhat.com>,
"Lorenzo Colitti" <lorenzo@google.com>,
astrachan@google.com, "Greg KH" <greg@kroah.com>,
"Linux NetDev" <netdev@vger.kernel.org>,
mateusz.bajorski@nokia.com,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied
Date: Wed, 5 Jun 2019 12:08:02 +0800 [thread overview]
Message-ID: <20190605040801.GC18865@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <eef3b598-2590-5c62-e79d-76eb46fae5ff@cumulusnetworks.com>
On Tue, Jun 04, 2019 at 09:57:56PM -0600, David Ahern wrote:
> On 6/4/19 7:43 PM, Hangbin Liu wrote:
> > Hi David Ahern,
> >
> > On Fri, May 31, 2019 at 06:43:42PM -0700, Maciej Żenczykowski wrote:
> >> FYI, this userspace visible change in behaviour breaks Android.
> >>
> >> We rely on being able to add a rule and either have a dup be created
> >> (in which case we'll remove it later) or have it fail with EEXIST (in
> >> which case we won't remove it later).
> >>
> >> Returning 0 makes atomically changing a rule difficult.
> >>
> >> Please revert.
> > What do you think? Should I rever this commit?
>
> I think it is crazy to add multiple identical rules given the linear
> effect on performance. But, since it breaks Android, it has to be reverted.
OK.. Since you also agree to revert it.
Thanks
Hangbin
next prev parent reply other threads:[~2019-06-05 4:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 9:11 [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied Hangbin Liu
2019-05-08 16:35 ` David Miller
2019-06-01 1:43 ` Maciej Żenczykowski
2019-06-01 9:32 ` Greg KH
2019-06-05 1:43 ` Hangbin Liu
2019-06-05 1:47 ` Lorenzo Colitti
2019-06-05 2:15 ` Hangbin Liu
2019-06-05 2:25 ` Lorenzo Colitti
2019-06-05 3:29 ` Hangbin Liu
2019-06-05 3:43 ` Lorenzo Colitti
2019-06-05 4:05 ` Hangbin Liu
2019-06-05 3:57 ` David Ahern
2019-06-05 4:08 ` Hangbin Liu [this message]
2019-06-05 4:58 ` Lorenzo Colitti
2019-06-05 15:33 ` David Ahern
2019-06-06 23:01 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605040801.GC18865@dhcp-12-139.nay.redhat.com \
--to=liuhangbin@gmail.com \
--cc=astrachan@google.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=dsahern@gmail.com \
--cc=greg@kroah.com \
--cc=lorenzo@google.com \
--cc=mateusz.bajorski@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
--cc=yaro330@gmail.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).