netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Hangbin Liu <liuhangbin@gmail.com>, David Ahern <dsahern@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
	"Yaro Slav" <yaro330@gmail.com>,
	"Thomas Haller" <thaller@redhat.com>,
	"Lorenzo Colitti" <lorenzo@google.com>,
	astrachan@google.com, "Greg KH" <greg@kroah.com>,
	"Linux NetDev" <netdev@vger.kernel.org>,
	mateusz.bajorski@nokia.com,
	"Maciej Żenczykowski" <zenczykowski@gmail.com>
Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied
Date: Tue, 4 Jun 2019 21:57:56 -0600	[thread overview]
Message-ID: <eef3b598-2590-5c62-e79d-76eb46fae5ff@cumulusnetworks.com> (raw)
In-Reply-To: <20190605014344.GY18865@dhcp-12-139.nay.redhat.com>

On 6/4/19 7:43 PM, Hangbin Liu wrote:
> Hi David Ahern,
> 
> On Fri, May 31, 2019 at 06:43:42PM -0700, Maciej Żenczykowski wrote:
>> FYI, this userspace visible change in behaviour breaks Android.
>>
>> We rely on being able to add a rule and either have a dup be created
>> (in which case we'll remove it later) or have it fail with EEXIST (in
>> which case we won't remove it later).
>>
>> Returning 0 makes atomically changing a rule difficult.
>>
>> Please revert.
> What do you think? Should I rever this commit?

I think it is crazy to add multiple identical rules given the linear
effect on performance. But, since it breaks Android, it has to be reverted.

  parent reply	other threads:[~2019-06-05  3:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  9:11 [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied Hangbin Liu
2019-05-08 16:35 ` David Miller
2019-06-01  1:43   ` Maciej Żenczykowski
2019-06-01  9:32     ` Greg KH
2019-06-05  1:43     ` Hangbin Liu
2019-06-05  1:47       ` Lorenzo Colitti
2019-06-05  2:15         ` Hangbin Liu
2019-06-05  2:25           ` Lorenzo Colitti
2019-06-05  3:29             ` Hangbin Liu
2019-06-05  3:43               ` Lorenzo Colitti
2019-06-05  4:05                 ` Hangbin Liu
2019-06-05  3:57       ` David Ahern [this message]
2019-06-05  4:08         ` Hangbin Liu
2019-06-05  4:58         ` Lorenzo Colitti
2019-06-05 15:33           ` David Ahern
2019-06-06 23:01             ` Maciej Żenczykowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eef3b598-2590-5c62-e79d-76eb46fae5ff@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=astrachan@google.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=greg@kroah.com \
    --cc=liuhangbin@gmail.com \
    --cc=lorenzo@google.com \
    --cc=mateusz.bajorski@nokia.com \
    --cc=netdev@vger.kernel.org \
    --cc=thaller@redhat.com \
    --cc=yaro330@gmail.com \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).