From: Lorenzo Colitti <lorenzo@google.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: "Hangbin Liu" <liuhangbin@gmail.com>,
"David Ahern" <dsahern@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Yaro Slav" <yaro330@gmail.com>,
"Thomas Haller" <thaller@redhat.com>,
"Alistair Strachan" <astrachan@google.com>,
"Greg KH" <greg@kroah.com>,
"Linux NetDev" <netdev@vger.kernel.org>,
"Mateusz Bajorski" <mateusz.bajorski@nokia.com>,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Subject: Re: [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied
Date: Wed, 5 Jun 2019 13:58:18 +0900 [thread overview]
Message-ID: <CAKD1Yr30Wj+Kk-ao2tFLU5apNjAVNYKeYJ+jZsb=5HTtd3+5-Q@mail.gmail.com> (raw)
In-Reply-To: <eef3b598-2590-5c62-e79d-76eb46fae5ff@cumulusnetworks.com>
On Wed, Jun 5, 2019 at 12:58 PM David Ahern <dsa@cumulusnetworks.com> wrote:
> I think it is crazy to add multiple identical rules given the linear
> effect on performance.
Not sure if this is what you were implying or not, but our code
doesn't maintain multiple identical rules in steady state. It only
uses them for make-before-break when something changes.
> But, since it breaks Android, it has to be reverted.
Well... the immediate problem on Android is that we cannot live with
this going to LTS, since it is going to break devices in the field.
As for making this change in 5.3: we might be able to structure the
code differently in a future Android release, assuming the same
userspace code can work on kernels back to 4.4 (not sure it can, since
the semantics changed in 4.8). But even if we can fix this in Android,
this change is still breaking compatibility with existing other
userspace code. Are there concrete performance optimizations that
you'd like to make that can't be made unless you change the semantics
here? Are those optimizations worth breaking the backwards
compatibility guarantees for?
next prev parent reply other threads:[~2019-06-05 4:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 9:11 [PATCH net] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied Hangbin Liu
2019-05-08 16:35 ` David Miller
2019-06-01 1:43 ` Maciej Żenczykowski
2019-06-01 9:32 ` Greg KH
2019-06-05 1:43 ` Hangbin Liu
2019-06-05 1:47 ` Lorenzo Colitti
2019-06-05 2:15 ` Hangbin Liu
2019-06-05 2:25 ` Lorenzo Colitti
2019-06-05 3:29 ` Hangbin Liu
2019-06-05 3:43 ` Lorenzo Colitti
2019-06-05 4:05 ` Hangbin Liu
2019-06-05 3:57 ` David Ahern
2019-06-05 4:08 ` Hangbin Liu
2019-06-05 4:58 ` Lorenzo Colitti [this message]
2019-06-05 15:33 ` David Ahern
2019-06-06 23:01 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKD1Yr30Wj+Kk-ao2tFLU5apNjAVNYKeYJ+jZsb=5HTtd3+5-Q@mail.gmail.com' \
--to=lorenzo@google.com \
--cc=astrachan@google.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=dsahern@gmail.com \
--cc=greg@kroah.com \
--cc=liuhangbin@gmail.com \
--cc=mateusz.bajorski@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
--cc=yaro330@gmail.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).